Re: [PR] Add Wireguard VPN integration [cloudstack]

2025-01-28 Thread via GitHub
rohityadavcloud commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2618660512 Thanks for the update @Dav-11 happy to assist and help as required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Add Wireguard VPN integration [cloudstack]

2025-01-28 Thread via GitHub
Dav-11 commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2618232370 Yes, that is the idea. In the last few months I have been busy but I plan on starting to work on it again in march. I am not very skilled and I am working on it alone atm

Re: [PR] Add Wireguard VPN integration [cloudstack]

2025-01-27 Thread via GitHub
rohityadavcloud commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2618035563 Hi @Dav-11 are you planning to work/rework this as a general purpose VPN framework-plugin implementation (wireguard then becomes on the supported plugin, in addition to the cur

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-28 Thread via GitHub
rohityadavcloud commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2507223580 @Dav-11 to answer your questions, in addition to what Guto has already advised; * Adding new fields is acceptable to existing APIs, you can also make some fields/parameters

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-28 Thread via GitHub
GutoVeronezi commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2505953112 @Dav-11, you can keep this PR and continue improving it, it is better for tracking. > I suppose we can add fields, but can we make these fields required ? (breaking compati

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-28 Thread via GitHub
Dav-11 commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2505528793 @rohityadavcloud Thank you, I am back to the drawing board, we will compare ipsec, wg and openvpn to find which fields are common and which vary. I would like to know how m

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
sureshanaparti commented on code in PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#discussion_r1860601025 ## plugins/vpn/wireguard/src/main/java/org/apache/cloudstack/api/response/CreateWgVpnResponse.java: ## @@ -0,0 +1,139 @@ +package org.apache.cloudstack.api.re

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
sureshanaparti commented on code in PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#discussion_r1860600558 ## plugins/vpn/wireguard/src/main/java/org/apache/cloudstack/api/response/CreateWgVpnResponse.java: ## @@ -0,0 +1,139 @@ +package org.apache.cloudstack.api.re

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
sureshanaparti commented on code in PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#discussion_r1860598927 ## plugins/vpn/wireguard/src/main/java/org/apache/cloudstack/api/response/CreateWgVpnResponse.java: ## @@ -0,0 +1,139 @@ +package org.apache.cloudstack.api.re

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
sureshanaparti commented on code in PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#discussion_r1860599265 ## plugins/vpn/wireguard/src/main/java/org/apache/cloudstack/api/response/CreateWgVpnResponse.java: ## @@ -0,0 +1,139 @@ +package org.apache.cloudstack.api.re

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
sureshanaparti commented on code in PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#discussion_r1860598612 ## plugins/vpn/wireguard/src/main/java/org/apache/cloudstack/api/response/CreateWgVpnResponse.java: ## @@ -0,0 +1,139 @@ +package org.apache.cloudstack.api.re

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
sureshanaparti commented on code in PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#discussion_r1860598164 ## plugins/vpn/wireguard/src/main/java/org/apache/cloudstack/api/response/CreateWgVpnResponse.java: ## @@ -0,0 +1,139 @@ +package org.apache.cloudstack.api.re

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
rohityadavcloud commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2503605314 @Dav-11 thanks for the PR - looks very exciting. I'm yet to review/test/try the PR, can you raise a doc PR? Some questions & suggestions: * Can you advise if this can

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
GutoVeronezi commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2503581002 > We thought that it would have been better to create new APIs, but if it is preferred to change the current one instead we could try to propose a way to do it that way. Ye

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
Dav-11 commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2503457918 @weizhouapache An Idea could be to create a genric API for VPN and then allow different providers like plugins. This way we could allow for other to add also openvpn or future VPN

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
weizhouapache commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2503533716 > ok, I'll think of a way to modify tha proposed new APIs to allow such beaviour. cool, thanks @Dav-11 it is a new feature I expected for several years.. looking fo

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
Dav-11 commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2503508132 ok, I'll think of a way to modify tha proposed new APIs to allow such beaviour. -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
codecov[bot] commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2503501716 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9977?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
weizhouapache commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2503484366 > @weizhouapache An Idea could be to create a genric API for VPN and then allow different providers like plugins. This way we could allow for other to add also openvpn or future

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
weizhouapache commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2503348815 Currently the remote access vpn feature is implemented via strongswan which has lot of limitations. it is a good idea to setup vpn with different software. @Dav-11 c

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-27 Thread via GitHub
Dav-11 commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2503328961 @GutoVeronezi we did check the existing APIs, the wg behaviour is similar to the remote access vpn. But the remote access vpn APIs do not have some field I need: - createRe

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-26 Thread via GitHub
GutoVeronezi commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2501921087 @Dav-11 Thanks for the PR We already have APIs to manage VPN and introducing more APIs would increase the complexity of the system. Have you checked/considered the existe

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-26 Thread via GitHub
Dav-11 commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2501231372 Ok thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-26 Thread via GitHub
weizhouapache commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2501150845 added to 4.21.0 milestone @Dav-11 please let us know when it is ready for review -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Add Wireguard VPN integration [cloudstack]

2024-11-26 Thread via GitHub
boring-cyborg[bot] commented on PR #9977: URL: https://github.com/apache/cloudstack/pull/9977#issuecomment-2501045020 Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribut

[PR] Add Wireguard VPN integration [cloudstack]

2024-11-26 Thread via GitHub
Dav-11 opened a new pull request, #9977: URL: https://github.com/apache/cloudstack/pull/9977 ### Description This PR adds the possibility to create wireguard VPNs as an alternative to the currently available L2TP-IPsec tunnels. Changes in details: - System VM template change