Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-10 Thread via GitHub
shwstppr commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2157860418 In my testing, listing networks is working fine with the changes and smoke tests didn't report any error. Marking it ready for review -- This is an automated message from the Apache

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2157749797 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9836 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-10 Thread via GitHub
blueorangutan commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2157588370 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-10 Thread via GitHub
weizhouapache commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2157585845 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-07 Thread via GitHub
blueorangutan commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2154524890 [SF] Trillian test result (tid-10382) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48773 seconds Marvin logs: https://github.co

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-06 Thread via GitHub
blueorangutan commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2153326687 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-06 Thread via GitHub
shwstppr commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2153325129 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-06 Thread via GitHub
blueorangutan commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2153317636 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9810 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-06 Thread via GitHub
blueorangutan commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2153205024 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-06 Thread via GitHub
shwstppr commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2153195360 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-06 Thread via GitHub
weizhouapache commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2152066570 good idea -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-06 Thread via GitHub
codecov[bot] commented on PR #9184: URL: https://github.com/apache/cloudstack/pull/9184#issuecomment-2152010100 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9184?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] [WIP] server: refactor listNetworks api database retrievals [cloudstack]

2024-06-06 Thread via GitHub
shwstppr opened a new pull request, #9184: URL: https://github.com/apache/cloudstack/pull/9184 ### Description This PR attempts to optimize database queries during listNetworks API call. It should fix pagination-related issues as well while querying desired networks from the database