Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-06-17 Thread via GitHub
DaanHoogland merged PR #8581: URL: https://github.com/apache/cloudstack/pull/8581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-06-17 Thread via GitHub
blueorangutan commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-217554 [SF] Trillian test result (tid-10464) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46019 seconds Marvin logs: https://github.co

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-06-17 Thread via GitHub
blueorangutan commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2172581925 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-06-17 Thread via GitHub
DaanHoogland commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2172578121 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-06-14 Thread via GitHub
blueorangutan commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2168123235 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9959 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-06-14 Thread via GitHub
blueorangutan commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2167990630 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-06-14 Thread via GitHub
BryanMLima commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2167987711 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-06-14 Thread via GitHub
BryanMLima commented on code in PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#discussion_r1639785664 ## usage/src/main/java/com/cloud/usage/UsageManagerImpl.java: ## @@ -405,9 +405,14 @@ protected void runInContextInternal() { cal.add(Calendar.MI

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2167323795 @BryanMLima , if @GutoVeronezi 's concerns are met, we can merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-06-13 Thread via GitHub
BryanMLima commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2166555417 @sureshanaparti, do you think this PR can go to the `4.19.1.0` version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-05-22 Thread via GitHub
BryanMLima commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2125451174 > > @DaanHoogland, as you have more experience with the test matrix, did it ever happen in a scenario when the API had an incorrect signature, such as `errorText:unable to verify us

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-05-18 Thread via GitHub
DaanHoogland commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2118986070 > @DaanHoogland, as you have more experience with the test matrix, did it ever happen in a scenario when the API had an incorrect signature, such as `errorText:unable to verify us

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-05-10 Thread via GitHub
BryanMLima commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-2105251806 @DaanHoogland, as you have more experience with the test matrix, did it ever happen in a scenario when the API had an incorrect signature, such as `errorText:unable to verify user c

[PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-05-10 Thread via GitHub
BryanMLima opened a new pull request, #8581: URL: https://github.com/apache/cloudstack/pull/8581 ### Description This PR aims to improve the overall Quota balance calculation by breaking into separate methods and calculating based on the period dates rather than the Quota usage recor

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-05-10 Thread via GitHub
BryanMLima closed pull request #8581: [Quota] Improve Quota balance calculation flow URL: https://github.com/apache/cloudstack/pull/8581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-29 Thread via GitHub
BryanMLima commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1971615603 > @BryanMLima as you are still working on this, does it make sense to take it out of the milestone? cc @JoaoJandre @DaanHoogland, I will have a look, should be able to fix thi

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-28 Thread via GitHub
DaanHoogland commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1969035446 @BryanMLima as you are still working on this, does it make sense to take it out of the milestone? cc @JoaoJandre -- This is an automated message from the Apache Git Service. To

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-14 Thread via GitHub
GutoVeronezi commented on code in PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#discussion_r1490096703 ## usage/src/main/java/com/cloud/usage/UsageManagerImpl.java: ## @@ -405,9 +405,14 @@ protected void runInContextInternal() { cal.add(Calendar.

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-12 Thread via GitHub
BryanMLima commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1938742140 > @BryanMLima it passed. not sure if we should add more runners, but a runner for plugins in general would make sense. @DaanHoogland, the test should have not passed, as it th

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-09 Thread via GitHub
DaanHoogland commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1936127702 @BryanMLima it passed. not sure if we should add more runners, but a runner for plugins in general would make sense. -- This is an automated message from the Apache Git Service.

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-03 Thread via GitHub
DaanHoogland commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1925301149 @BryanMLima tests from `test/integration/plugins` are not run in the smoke tests. You can try adding it to the test matrix. see [the test matrix](https://github.com/apache/cloudst

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-02 Thread via GitHub
BryanMLima commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1923973602 > [SF] Trillian test result (tid-9039) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41289 seconds Marvin logs: https://github.com/blueora

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-01 Thread via GitHub
blueorangutan commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1922511644 [SF] Trillian test result (tid-9039) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41289 seconds Marvin logs: https://github.com

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-01 Thread via GitHub
JoaoJandre commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1921623052 > @JoaoJandre, do you think this PR can go to the `4.18.2.0` release? @BryanMLima sure -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-01 Thread via GitHub
blueorangutan commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1921172356 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-02-01 Thread via GitHub
DaanHoogland commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1921169223 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-01-31 Thread via GitHub
BryanMLima commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1919774028 @JoaoJandre, do you think this PR can go to the `4.18.2.0` release? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-01-31 Thread via GitHub
blueorangutan commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1919696997 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8483 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-01-31 Thread via GitHub
codecov[bot] commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1919622585 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8581?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-01-31 Thread via GitHub
blueorangutan commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1919570275 @BryanMLima a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-01-31 Thread via GitHub
BryanMLima commented on PR #8581: URL: https://github.com/apache/cloudstack/pull/8581#issuecomment-1919543628 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[PR] [Quota] Improve Quota balance calculation flow [cloudstack]

2024-01-31 Thread via GitHub
BryanMLima opened a new pull request, #8581: URL: https://github.com/apache/cloudstack/pull/8581 ### Description This PR aims to improve the overall Quota balance calculation by breaking into separate methods and calculating based on the period dates rather than the Quota usage recor