Re: [I] Race condition when automatically assigning IPs to VMs [cloudstack]

2024-06-18 Thread via GitHub
rohityadavcloud commented on issue #7907: URL: https://github.com/apache/cloudstack/issues/7907#issuecomment-2175403112 Thanks for checking @weizhouapache @hsato03 @abh1sar -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Race condition when automatically assigning IPs to VMs [cloudstack]

2024-06-13 Thread via GitHub
abh1sar commented on issue #7907: URL: https://github.com/apache/cloudstack/issues/7907#issuecomment-2166457578 +1 to @weizhouapache and @hsato03 . #9234 fixes public IP race by taking lock before making changes to the IPAddressVO table. For guest IPs the approach would be different #9240

Re: [I] Race condition when automatically assigning IPs to VMs [cloudstack]

2024-06-13 Thread via GitHub
hsato03 commented on issue #7907: URL: https://github.com/apache/cloudstack/issues/7907#issuecomment-2165858307 I think Wei is right, they are different situations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [I] Race condition when automatically assigning IPs to VMs [cloudstack]

2024-06-13 Thread via GitHub
weizhouapache commented on issue #7907: URL: https://github.com/apache/cloudstack/issues/7907#issuecomment-2165444838 > You are right @rohityadavcloud, it is the same. I didn't see that link. @abh1sar can you contact @hsato03 on his PR and discuss a (the best) way forward it looks thi

Re: [I] Race condition when automatically assigning IPs to VMs [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland commented on issue #7907: URL: https://github.com/apache/cloudstack/issues/7907#issuecomment-2165410028 You are right @rohityadavcloud, it is the same. I didn't see that link. @abh1sar can you contact @hsato03 on his PR and discuss a (the best) way forward -- This is an autom

Re: [I] Race condition when automatically assigning IPs to VMs [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on issue #7907: URL: https://github.com/apache/cloudstack/issues/7907#issuecomment-2165103406 ^rubs my eyes^ is this same/similar https://github.com/apache/cloudstack/pull/9234 @DaanHoogland ? -- This is an automated message from the Apache Git Service. To respon

Re: [I] Race condition when automatically assigning IPs to VMs [cloudstack]

2024-06-13 Thread via GitHub
DaanHoogland commented on issue #7907: URL: https://github.com/apache/cloudstack/issues/7907#issuecomment-2164996879 > It seems we may have two PRs for this @sureshanaparti @DaanHoogland @weizhouapache @abh1sar and others I see only @abh1sar 's @rohityadavcloud . Can you point out the

Re: [I] Race condition when automatically assigning IPs to VMs [cloudstack]

2024-06-13 Thread via GitHub
rohityadavcloud commented on issue #7907: URL: https://github.com/apache/cloudstack/issues/7907#issuecomment-2164968776 It seems we may have two PRs for this @sureshanaparti @DaanHoogland @weizhouapache @abh1sar and others -- This is an automated message from the Apache Git Service. To r