Re: [PR] kvm: ref-count storage pool usage [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9498: URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2458898890 @rp- a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

Re: [PR] kvm: ref-count storage pool usage [cloudstack]

2024-11-05 Thread via GitHub
rp- commented on PR #9498: URL: https://github.com/apache/cloudstack/pull/9498#issuecomment-2458895618 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] Improvement: management server peer states [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9885: URL: https://github.com/apache/cloudstack/pull/9885#issuecomment-2458868921 [SF] Trillian test result (tid-11747) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 53263 seconds Marvin logs: https://github.com/

Re: [PR] Support for Management Server Maintenance [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9854: URL: https://github.com/apache/cloudstack/pull/9854#issuecomment-2458840936 [SF] Trillian test result (tid-11748) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 51108 seconds Marvin logs: https://github.com/

Re: [PR] Support for Management Server Maintenance [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9854: URL: https://github.com/apache/cloudstack/pull/9854#issuecomment-2458788447 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9844: URL: https://github.com/apache/cloudstack/pull/9844#issuecomment-2458788449 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11515 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[I] Backup offerings of all zones are listed for any instance [cloudstack]

2024-11-05 Thread via GitHub
rajujith opened a new issue, #9895: URL: https://github.com/apache/cloudstack/issues/9895 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ B&R ~~~ # CLOUDSTACK VERSION ~~~ 4.20 - SNAPSHOT , possibly affects 4.19 as well.

Re: [PR] Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9844: URL: https://github.com/apache/cloudstack/pull/9844#issuecomment-2458711921 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering [cloudstack]

2024-11-05 Thread via GitHub
sureshanaparti commented on PR #9844: URL: https://github.com/apache/cloudstack/pull/9844#issuecomment-2458710911 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Support for Management Server Maintenance [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9854: URL: https://github.com/apache/cloudstack/pull/9854#issuecomment-2458710425 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Support for Management Server Maintenance [cloudstack]

2024-11-05 Thread via GitHub
sureshanaparti commented on PR #9854: URL: https://github.com/apache/cloudstack/pull/9854#issuecomment-2458708547 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9817: URL: https://github.com/apache/cloudstack/pull/9817#issuecomment-2458494158 [SF] Trillian test result (tid-11742) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 60494 seconds Marvin logs: https://github.com/

Re: [PR] Linstor: add support for ISO block devices and direct download [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9792: URL: https://github.com/apache/cloudstack/pull/9792#issuecomment-2458216430 [SF] Trillian test result (tid-11744) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 49159 seconds Marvin logs: https://github.com/

Re: [I] Support separate compute offering for kubernetes nodes (Master and Worker nodes) [cloudstack]

2024-11-05 Thread via GitHub
aron-ac commented on issue #7916: URL: https://github.com/apache/cloudstack/issues/7916#issuecomment-2458159173 bumping this up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] enable to create VPC portfowarding rules with source cidr [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #7081: URL: https://github.com/apache/cloudstack/pull/7081#issuecomment-2458140644 [SF] Trillian test result (tid-11741) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 46174 seconds Marvin logs: https://github.com/

Re: [PR] Fix listServiceOfferings regression [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9894: URL: https://github.com/apache/cloudstack/pull/9894#issuecomment-2458090695 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Fix listServiceOfferings regression [cloudstack]

2024-11-05 Thread via GitHub
codecov[bot] commented on PR #9894: URL: https://github.com/apache/cloudstack/pull/9894#issuecomment-2458001404 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9894?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Fix listServiceOfferings regression [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9894: URL: https://github.com/apache/cloudstack/pull/9894#issuecomment-2457992832 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Fix listServiceOfferings regression [cloudstack]

2024-11-05 Thread via GitHub
winterhazel commented on PR #9894: URL: https://github.com/apache/cloudstack/pull/9894#issuecomment-2457989925 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] Fix listServiceOfferings regression [cloudstack]

2024-11-05 Thread via GitHub
winterhazel opened a new pull request, #9894: URL: https://github.com/apache/cloudstack/pull/9894 ### Description This PR fixes a regression introduced in 4.19.1.0 in the `listServiceOfferings` API. The API's query was being built with an AND where there previously was an OR.

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#issuecomment-2457878967 @shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#issuecomment-2457878145 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9844: URL: https://github.com/apache/cloudstack/pull/9844#issuecomment-2457645868 Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 11510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Support for Management Server Maintenance [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9854: URL: https://github.com/apache/cloudstack/pull/9854#issuecomment-2457565614 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Support for Management Server Maintenance [cloudstack]

2024-11-05 Thread via GitHub
sureshanaparti commented on PR #9854: URL: https://github.com/apache/cloudstack/pull/9854#issuecomment-2457560474 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9844: URL: https://github.com/apache/cloudstack/pull/9844#issuecomment-2457550870 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Fix NPE issues during host rolling maintenance, due to host tags and custom constrained/unconstrained service offering [cloudstack]

2024-11-05 Thread via GitHub
sureshanaparti commented on PR #9844: URL: https://github.com/apache/cloudstack/pull/9844#issuecomment-2457548044 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [PR] Improvement: management server peer states [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9885: URL: https://github.com/apache/cloudstack/pull/9885#issuecomment-2457516807 @weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Improvement: management server peer states [cloudstack]

2024-11-05 Thread via GitHub
weizhouapache commented on PR #9885: URL: https://github.com/apache/cloudstack/pull/9885#issuecomment-2457512619 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[I] UI: Opening direct URL to domain causes visual bug/glitch [cloudstack]

2024-11-05 Thread via GitHub
Rubueno opened a new issue, #9893: URL: https://github.com/apache/cloudstack/issues/9893 # ISSUE TYPE * Bug Report # COMPONENT NAME UI ~~~ # CLOUDSTACK VERSION 4.19.1 # CONFIGURATION N/A # OS / ENVIRONMENT N/A #

Re: [PR] Support for Management Server Maintenance [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9854: URL: https://github.com/apache/cloudstack/pull/9854#issuecomment-2457260713 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Improve logging to include more identifiable information [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9873: URL: https://github.com/apache/cloudstack/pull/9873#issuecomment-2457218547 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11508 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[PR] Maintenance mode: Add host to deployment planner avoid list to fix local storage migration [cloudstack]

2024-11-05 Thread via GitHub
BartJM opened a new pull request, #9892: URL: https://github.com/apache/cloudstack/pull/9892 ### Description This PR adds the host preparing for maintenance to the avoid list for the deployment planner. Without adding the host to the avoid list the deployment planner will retur

Re: [PR] Improvement: management server peer states [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9885: URL: https://github.com/apache/cloudstack/pull/9885#issuecomment-2457195929 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11507 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]

2024-11-05 Thread via GitHub
abh1sar commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2456500473 Thanks @tpodowd for your response. If we had to implement the functionality to set Account level Quota in cloudstack, how do you think that could be done? Does the HyperStore plug

Re: [PR] Support for Management Server Maintenance [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9854: URL: https://github.com/apache/cloudstack/pull/9854#issuecomment-2457110056 @sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progre

Re: [PR] Support for Management Server Maintenance [cloudstack]

2024-11-05 Thread via GitHub
sureshanaparti commented on PR #9854: URL: https://github.com/apache/cloudstack/pull/9854#issuecomment-2457107897 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

Re: [I] value of backup.plugin.veeam.password is not decrypted when configured at zone settings [cloudstack]

2024-11-05 Thread via GitHub
weizhouapache commented on issue #9891: URL: https://github.com/apache/cloudstack/issues/9891#issuecomment-2457046490 thanks @rajujith we probably need to consider the settings with encrypted value for zone/cluster (similar as #9088 ) -- This is an automated message from the Apache Gi

Re: [I] Veeam integration [cloudstack]

2024-11-05 Thread via GitHub
weizhouapache commented on issue #9423: URL: https://github.com/apache/cloudstack/issues/9423#issuecomment-2457044871 if users have issue with veeam , it might be caused by #9891 if so, please try options (1) option 1: update the data_center_details table with password in plaintext

Re: [PR] Improve logging to include more identifiable information [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9873: URL: https://github.com/apache/cloudstack/pull/9873#issuecomment-2457025962 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Improve logging to include more identifiable information [cloudstack]

2024-11-05 Thread via GitHub
vishesh92 commented on PR #9873: URL: https://github.com/apache/cloudstack/pull/9873#issuecomment-2457021321 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Improvement: management server peer states [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9885: URL: https://github.com/apache/cloudstack/pull/9885#issuecomment-2457000242 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] Improvement: management server peer states [cloudstack]

2024-11-05 Thread via GitHub
weizhouapache commented on PR #9885: URL: https://github.com/apache/cloudstack/pull/9885#issuecomment-2456999058 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[I] value of backup.plugin.veeam.password is not decrypted when configured at zone settings [cloudstack]

2024-11-05 Thread via GitHub
rajujith opened a new issue, #9891: URL: https://github.com/apache/cloudstack/issues/9891 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Veeam B&R ~~~ # CLOUDSTACK VERSION ~~~ 4.19, 4.20-SNAPSHOT ~~~ #

Re: [PR] Adjust misformatted Quota balance calculation process log [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9889: URL: https://github.com/apache/cloudstack/pull/9889#issuecomment-2456815577 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#issuecomment-2456780795 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11505 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] Can't download volume after recovering from snapshot. [cloudstack]

2024-11-05 Thread via GitHub
boring-cyborg[bot] commented on issue #9890: URL: https://github.com/apache/cloudstack/issues/9890#issuecomment-2456657206 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[I] Can't download volume after recovering from snapshot. [cloudstack]

2024-11-05 Thread via GitHub
SviridoffA opened a new issue, #9890: URL: https://github.com/apache/cloudstack/issues/9890 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ Storage ~~~ # CLOUDSTACK VERSION ~~~ 4.19.1.2 ~~~ # CONFIGURATION Primary storag

Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]

2024-11-05 Thread via GitHub
tpodowd commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2456463569 Hi @abh1sar - Thanks for your comment/question. > I understand Cloudian doesn't support per bucket Quota. Yes, Cloudian HyperStore does not currently support a bucket stora

Re: [PR] Adjust misformatted Quota balance calculation process log [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9889: URL: https://github.com/apache/cloudstack/pull/9889#issuecomment-2456616363 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
blueorangutan commented on PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#issuecomment-2456616284 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828877562 ## plugins/hypervisors/simulator/src/main/java/com/cloud/resource/AgentRoutingResource.java: ## @@ -122,7 +123,8 @@ public PingCommand getCurrentStatus(long id) {

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#issuecomment-2456614204 Thanks @weizhouapache for the review. I've made the changes as per your suggestions and responded to the queries. @blueorangutan package -- This is an automated message from

Re: [PR] Adjust misformatted Quota balance calculation process log [cloudstack]

2024-11-05 Thread via GitHub
DaanHoogland commented on PR #9889: URL: https://github.com/apache/cloudstack/pull/9889#issuecomment-2456612393 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fix inconsistencies that result in Usage generating usage records when it should not [cloudstack]

2024-11-05 Thread via GitHub
DaanHoogland commented on PR #9888: URL: https://github.com/apache/cloudstack/pull/9888#issuecomment-2456608425 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] NAS B&R Plugin enhancements [cloudstack]

2024-11-05 Thread via GitHub
abh1sar commented on code in PR #9666: URL: https://github.com/apache/cloudstack/pull/9666#discussion_r1804399334 ## server/src/main/java/org/apache/cloudstack/backup/BackupManagerImpl.java: ## @@ -470,16 +468,30 @@ public List listBackupSchedule(final Long vmId) { @Over

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828949324 ## api/src/main/java/org/apache/cloudstack/api/command/admin/domain/ListDomainsCmd.java: ## @@ -142,7 +142,10 @@ protected void updateDomainResponse(List response)

Re: [PR] Add Cloudian HyperStore Object Storage [cloudstack]

2024-11-05 Thread via GitHub
tpodowd commented on PR #9748: URL: https://github.com/apache/cloudstack/pull/9748#issuecomment-2456596898 Hi @abh1sar. The current plugin does not have any API support itself for setting Account level QoS (as it only implements the provided plugin APIs). The HyperStore Admin API itself doe

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828947089 ## server/src/main/java/com/cloud/alert/AlertManagerImpl.java: ## @@ -257,6 +259,64 @@ public void sendAlert(AlertType alertType, long dataCenterId, Long podId, St

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828872604 ## engine/orchestration/src/main/java/com/cloud/agent/manager/AgentManagerImpl.java: ## @@ -223,17 +231,20 @@ public boolean configure(final String name, final Map

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828938024 ## framework/db/src/main/java/com/cloud/utils/db/TransactionLegacy.java: ## @@ -1334,7 +1334,7 @@ private static DataSource createDbcpDataSource(String uri, String

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828937318 ## engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java: ## @@ -4988,89 +5016,58 @@ private void scanStalledVMInTransitionStateOnDisconne

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828933844 ## engine/orchestration/src/main/java/com/cloud/vm/VirtualMachineManagerImpl.java: ## @@ -3793,12 +3803,12 @@ public int getTimeout() { public boolean processC

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828876632 ## engine/schema/src/main/java/com/cloud/upgrade/dao/DatabaseAccessObject.java: ## @@ -114,6 +114,17 @@ public void createIndex(Connection conn, String tableName,

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828874110 ## engine/schema/src/main/java/com/cloud/capacity/dao/CapacityDaoImpl.java: ## @@ -671,6 +671,18 @@ public CapacityVO findByHostIdType(Long hostId, short capacityT

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828897340 ## agent/src/main/java/com/cloud/agent/Agent.java: ## @@ -444,59 +466,87 @@ protected void cancelTasks() { * when host is added back */ protected v

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828889255 ## engine/schema/src/main/java/com/cloud/storage/dao/StoragePoolHostDaoImpl.java: ## @@ -169,23 +169,23 @@ public List findHostsConnectedToPools(List poolIds) {

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828899337 ## plugins/hypervisors/simulator/src/main/java/com/cloud/resource/AgentRoutingResource.java: ## @@ -109,7 +109,8 @@ public Type getType() { public PingCommand

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828897057 ## utils/src/main/java/com/cloud/utils/nio/NioConnection.java: ## @@ -190,9 +209,25 @@ public Boolean call() throws NioConnectionException { abstract void un

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828894606 ## tools/marvin/setup.py: ## @@ -27,7 +27,7 @@ raise RuntimeError("python setuptools is required to build Marvin") -VERSION = "4.20.0.0-SNAPSHOT" +VERS

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828890915 ## agent/src/main/java/com/cloud/agent/Agent.java: ## @@ -444,59 +466,87 @@ protected void cancelTasks() { * when host is added back */ protected v

Re: [PR] api,agent,server,engine-schema: scalability improvements [cloudstack]

2024-11-05 Thread via GitHub
shwstppr commented on code in PR #9840: URL: https://github.com/apache/cloudstack/pull/9840#discussion_r1828890475 ## server/src/main/java/com/cloud/storage/StorageManagerImpl.java: ## @@ -1540,6 +1545,77 @@ protected String getStoragePoolNonDestroyedVolumesLog(long storagePool