Re: [PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9610: URL: https://github.com/apache/cloudstack/pull/9610#issuecomment-2322803315 @rohityadavcloud a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respon

Re: [PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
rohityadavcloud commented on PR #9610: URL: https://github.com/apache/cloudstack/pull/9610#issuecomment-2322802973 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2322793651 [SF] Trillian test result (tid-11257) Environment: xcpng82 (x2), Advanced Networking with Mgmt server a9 Total time taken: 68669 seconds Marvin logs: https://github.com/b

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2322763643 [SF] Trillian Build Failed (tid-11269) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2322757944 [SF] Trillian test result (tid-11254) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 59795 seconds Marvin logs: https://github.com/

Re: [PR] framework/db: use HikariCP as default and improvements [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9518: URL: https://github.com/apache/cloudstack/pull/9518#issuecomment-2322749960 [SF] Trillian test result (tid-11250) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 59833 seconds Marvin logs: https://github.com/

Re: [PR] framework/db: use HikariCP as default and improvements [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9518: URL: https://github.com/apache/cloudstack/pull/9518#issuecomment-2322748124 [SF] Trillian test result (tid-11252) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 59468 seconds Marvin logs: https://github.

Re: [PR] Updated listStoragePools response - added new managed parameter [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9588: URL: https://github.com/apache/cloudstack/pull/9588#issuecomment-2322742599 [SF] Trillian test result (tid-11260) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 48865 seconds Marvin logs: https://github.com/

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2322739976 [SF] Trillian test result (tid-11259) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 51481 seconds Marvin logs: https://github

Re: [PR] framework/db: use HikariCP as default and improvements [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9518: URL: https://github.com/apache/cloudstack/pull/9518#issuecomment-2322679667 [SF] Trillian test result (tid-11251) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 53220 seconds Marvin logs: https://github

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2322604835 [SF] Trillian Build Failed (tid-11265) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2322600509 [SF] Trillian Build Failed (tid-11267) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2322517160 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2322378266 @abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-30 Thread via GitHub
abh1sar commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2322375823 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] backup: simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2322373713 [SF] Trillian test result (tid-11248) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 49729 seconds Marvin logs: https://github.com/

Re: [I] Add Domain/Account Assignment at Instance Creation [cloudstack]

2024-08-30 Thread via GitHub
scottsignal commented on issue #9612: URL: https://github.com/apache/cloudstack/issues/9612#issuecomment-2322307519 @BryanMLima Yes, this will work. I didn't think to search for `VM` since they are called `Instances` now. Thanks for the response. -- This is an automated message from the

Re: [PR] Add minimum details parameter to Search View's listDomains [cloudstack]

2024-08-30 Thread via GitHub
codecov[bot] commented on PR #9616: URL: https://github.com/apache/cloudstack/pull/9616#issuecomment-2322292728 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9616?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

[PR] Fixed incorrect label in VRs and SVMs [cloudstack]

2024-08-30 Thread via GitHub
FelipeM525 opened a new pull request, #9617: URL: https://github.com/apache/cloudstack/pull/9617 ### Description This PR Fixes [!9615](https://github.com/apache/cloudstack/issues/9615) ### Types of changes - [ ] Breaking

[PR] Add minimum details parameter to Search View's listDomains [cloudstack]

2024-08-30 Thread via GitHub
gpordeus opened a new pull request, #9616: URL: https://github.com/apache/cloudstack/pull/9616 ### Description This PR adds the `details: min` parameter to `listDomains` API call. Since they are used only for ids and names, more details are unnecessary and `listDomains` ends up taki

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-30 Thread via GitHub
JoaoJandre commented on code in PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#discussion_r1739311322 ## server/src/main/java/org/apache/cloudstack/snapshot/SnapshotHelper.java: ## @@ -264,4 +264,12 @@ protected Set getSnapshotIdsOnlyInPrimaryStorage(long volumeI

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2322201379 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] Add Domain/Account Assignment at Instance Creation [cloudstack]

2024-08-30 Thread via GitHub
BryanMLima commented on issue #9612: URL: https://github.com/apache/cloudstack/issues/9612#issuecomment-2322187800 Hey @scottsignal, can you check if PR #8919 addresses your case? This PR adds an option to specify the account (and its domain) to be considered the owner of resources such as

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-30 Thread via GitHub
JoaoJandre commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2322183187 @slavkap are your concerns? Does it look good to you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [I] Repeated "Network domain" field in "Add Network" form [cloudstack]

2024-08-30 Thread via GitHub
BryanMLima commented on issue #9603: URL: https://github.com/apache/cloudstack/issues/9603#issuecomment-2322164794 Hey @DaanHoogland @msinhore, this was fixed in this PR https://github.com/apache/cloudstack/pull/8919#issuecomment-2072426719, though, it will only be available in version 4.20

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2322096819 @abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-30 Thread via GitHub
abh1sar commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2322094285 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] backup: simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2322030889 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] KVM incremental snapshot feature [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9270: URL: https://github.com/apache/cloudstack/pull/9270#issuecomment-2321944522 [SF] Trillian test result (tid-11243) Environment: xcpng82 (x2), Advanced Networking with Mgmt server a9 Total time taken: 73412 seconds Marvin logs: https://github.com/b

[I] System Offering Label on SVM's is Incorrect [cloudstack]

2024-08-30 Thread via GitHub
scottsignal opened a new issue, #9615: URL: https://github.com/apache/cloudstack/issues/9615 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.19.1.1 ~~~ # CONFIGURATION

Re: [PR] backup: simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2321871750 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9546: URL: https://github.com/apache/cloudstack/pull/9546#issuecomment-2321871649 @Pearl1594 a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tes

Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]

2024-08-30 Thread via GitHub
Pearl1594 commented on PR #9546: URL: https://github.com/apache/cloudstack/pull/9546#issuecomment-2321865394 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] backup: simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-30 Thread via GitHub
Pearl1594 commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2321862820 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[I] Add Global Setting for Start Instance Default [cloudstack]

2024-08-30 Thread via GitHub
scottsignal opened a new issue, #9614: URL: https://github.com/apache/cloudstack/issues/9614 Add Global Setting for Start Instance Default # ISSUE TYPE * Enhancement Request # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION

Re: [I] cloudstack-management error [cloudstack]

2024-08-30 Thread via GitHub
boring-cyborg[bot] commented on issue #9613: URL: https://github.com/apache/cloudstack/issues/9613#issuecomment-2321736320 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[I] cloudstack-management error [cloudstack]

2024-08-30 Thread via GitHub
khalikhu opened a new issue, #9613: URL: https://github.com/apache/cloudstack/issues/9613 # ISSUE TYPE * Bug Report * Improvement Request * Enhancement Request * Feature Idea * Documentation Report * Other # COMPONENT NAME ~~~ ~

Re: [PR] backup: simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-30 Thread via GitHub
Pearl1594 commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2321672568 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[I] Add Domain/Account Assignment at Instance Creation [cloudstack]

2024-08-30 Thread via GitHub
scottsignal opened a new issue, #9612: URL: https://github.com/apache/cloudstack/issues/9612 # ISSUE TYPE * Enhancement Request # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.19.1.1 ~~~ # CONFIGURATION

Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9546: URL: https://github.com/apache/cloudstack/pull/9546#issuecomment-2321643749 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [I] UI sorting of elements not working on some views [cloudstack]

2024-08-30 Thread via GitHub
DaanHoogland commented on issue #9595: URL: https://github.com/apache/cloudstack/issues/9595#issuecomment-2321610119 gotten too the reason in code, need to think of a solution. The fetching is a two step process, first grab the IDs (ordering applied), than use the IDs to fetch the records (

Re: [I] SingleHost CS - SystemVMS cannot reach deafult gw [cloudstack]

2024-08-30 Thread via GitHub
boring-cyborg[bot] commented on issue #9611: URL: https://github.com/apache/cloudstack/issues/9611#issuecomment-2321464081 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[I] SingleHost CS - SystemVMS cannot reach deafult gw [cloudstack]

2024-08-30 Thread via GitHub
Overmorrow1501 opened a new issue, #9611: URL: https://github.com/apache/cloudstack/issues/9611 # ISSUE TYPE * Other # COMPONENT NAME ~~~ Network ~~~ # CLOUDSTACK VERSION ~~~ 4.19.1.1 ~~~ # CLOUDSTACK CONFIGURA

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2321453308 [LL] Trillian Build Failed (tid-6995) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9546: URL: https://github.com/apache/cloudstack/pull/9546#issuecomment-2321450784 @Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Add support for disabling serivce / system and disk offerings [cloudstack]

2024-08-30 Thread via GitHub
Pearl1594 commented on PR #9546: URL: https://github.com/apache/cloudstack/pull/9546#issuecomment-2321447078 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Support of snapshot copy to StorPool primary storage in different zones [cloudstack]

2024-08-30 Thread via GitHub
slavkap commented on code in PR #9478: URL: https://github.com/apache/cloudstack/pull/9478#discussion_r1738760555 ## api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java: ## @@ -84,6 +85,15 @@ public class CopySnapshotCmd extends BaseAsyncCmd im

Re: [PR] Support of snapshot copy to StorPool primary storage in different zones [cloudstack]

2024-08-30 Thread via GitHub
slavkap commented on code in PR #9478: URL: https://github.com/apache/cloudstack/pull/9478#discussion_r1738757949 ## api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CopySnapshotCmd.java: ## @@ -84,6 +85,15 @@ public class CopySnapshotCmd extends BaseAsyncCmd im

Re: [PR] Support of snapshot copy to StorPool primary storage in different zones [cloudstack]

2024-08-30 Thread via GitHub
slavkap commented on code in PR #9478: URL: https://github.com/apache/cloudstack/pull/9478#discussion_r1738757183 ## engine/api/src/main/java/org/apache/cloudstack/engine/subsystem/api/storage/DataStoreCapabilities.java: ## @@ -40,5 +40,14 @@ public enum DataStoreCapabilities {

Re: [I] UI sorting of elements not working on some views [cloudstack]

2024-08-30 Thread via GitHub
DaanHoogland commented on issue #9595: URL: https://github.com/apache/cloudstack/issues/9595#issuecomment-2321304320 this is indeed a regression in comparison to 4.18. It also seems like redundant functionality as (in the UI) sort can be done on several columns. I can see in the simplest ,

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2321214624 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Updated listStoragePools response - added new managed parameter [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9588: URL: https://github.com/apache/cloudstack/pull/9588#issuecomment-2321140192 @sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Updated listStoragePools response - added new managed parameter [cloudstack]

2024-08-30 Thread via GitHub
sureshanaparti commented on PR #9588: URL: https://github.com/apache/cloudstack/pull/9588#issuecomment-2321135594 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9610: URL: https://github.com/apache/cloudstack/pull/9610#issuecomment-2321084214 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] UI: Notify users when upgrades are available or restart is required [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #7610: URL: https://github.com/apache/cloudstack/pull/7610#issuecomment-232105 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10883 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] kvm: fallback to cloud-init aware domain product name [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9608: URL: https://github.com/apache/cloudstack/pull/9608#issuecomment-232104 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10884 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
DaanHoogland commented on PR #9610: URL: https://github.com/apache/cloudstack/pull/9610#issuecomment-2321047533 > > @shwstppr should we still have a fallback in the agent code, like in #9608 ? > > Ideally, it shouldn't be needed but it won't harm. Should that be done for both manufac

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2321019525 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-30 Thread via GitHub
weizhouapache commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2321017339 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2321009168 [SF] Trillian test result (tid-11245) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 54535 seconds Marvin logs: https://github.co

Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2320981669 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10882 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
shwstppr commented on PR #9610: URL: https://github.com/apache/cloudstack/pull/9610#issuecomment-2320978599 > @shwstppr should we still have a fallback in the agent code, like in #9608 ? Ideally, it shouldn't be needed but if so then should that be done for both manufacturer and prod

Re: [PR] Feature: Forgot password [cloudstack]

2024-08-30 Thread via GitHub
harikrishna-patnala commented on code in PR #9509: URL: https://github.com/apache/cloudstack/pull/9509#discussion_r1738485068 ## server/src/main/java/org/apache/cloudstack/user/PasswordReset.java: ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] framework/db: use HikariCP as default and improvements [cloudstack]

2024-08-30 Thread via GitHub
shwstppr commented on PR #9518: URL: https://github.com/apache/cloudstack/pull/9518#issuecomment-2320973464 Created a documentation PR: https://github.com/apache/cloudstack-documentation/pull/431 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] Feature: Forgot password [cloudstack]

2024-08-30 Thread via GitHub
harikrishna-patnala commented on code in PR #9509: URL: https://github.com/apache/cloudstack/pull/9509#discussion_r1738484068 ## server/src/main/java/com/cloud/api/auth/DefaultResetPasswordAPIAuthenticatorCmd.java: ## @@ -0,0 +1,192 @@ +// Licensed to the Apache Software Foundat

Re: [PR] Feature: Forgot password [cloudstack]

2024-08-30 Thread via GitHub
harikrishna-patnala commented on code in PR #9509: URL: https://github.com/apache/cloudstack/pull/9509#discussion_r1738480485 ## server/src/main/java/org/apache/cloudstack/user/PasswordResetManager.java: ## @@ -0,0 +1,55 @@ +// Licensed to the Apache Software Foundation (ASF) un

Re: [PR] backup: simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-30 Thread via GitHub
DaanHoogland commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2320968034 > Thanks @shwstppr @DaanHoogland for the review, let me try & address as much as I could. > > @DaanHoogland to answer your comments; > > 1. yes, this is mostly fo

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2320961870 [SF] Trillian test result (tid-11244) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 53593 seconds Marvin logs: https://github

Re: [PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
codecov[bot] commented on PR #9610: URL: https://github.com/apache/cloudstack/pull/9610#issuecomment-2320943417 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9610?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
rohityadavcloud commented on PR #9610: URL: https://github.com/apache/cloudstack/pull/9610#issuecomment-2320933304 @shwstppr should we still have a fallback in the agent code, like in https://github.com/apache/cloudstack/pull/9608 ? -- This is an automated message from the Apache Git Serv

Re: [PR] kvm: fallback to cloud-init aware domain product name [cloudstack]

2024-08-30 Thread via GitHub
rohityadavcloud commented on PR #9608: URL: https://github.com/apache/cloudstack/pull/9608#issuecomment-2320932041 Closing in favour of https://github.com/apache/cloudstack/pull/9610#pullrequestreview-2272012279 -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] kvm: fallback to cloud-init aware domain product name [cloudstack]

2024-08-30 Thread via GitHub
rohityadavcloud closed pull request #9608: kvm: fallback to cloud-init aware domain product name URL: https://github.com/apache/cloudstack/pull/9608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] kvm: fallback to cloud-init aware domain product name [cloudstack]

2024-08-30 Thread via GitHub
shwstppr commented on PR #9608: URL: https://github.com/apache/cloudstack/pull/9608#issuecomment-2320925524 @rohityadavcloud sorry I missed this and created #9610. You pick changes from there -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9610: URL: https://github.com/apache/cloudstack/pull/9610#issuecomment-2320925077 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
shwstppr commented on PR #9610: URL: https://github.com/apache/cloudstack/pull/9610#issuecomment-2320923057 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
shwstppr commented on PR #9610: URL: https://github.com/apache/cloudstack/pull/9610#issuecomment-2320918753 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[PR] engine-orchestration: fix issue for empty product in vm metadata [cloudstack]

2024-08-30 Thread via GitHub
shwstppr opened a new pull request, #9610: URL: https://github.com/apache/cloudstack/pull/9610 ### Description Fixes #9607 ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking cha

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2320907978 [SF] Trillian Build Failed (tid-11255) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] kvm: fallback to cloud-init aware domain product name [cloudstack]

2024-08-30 Thread via GitHub
codecov[bot] commented on PR #9608: URL: https://github.com/apache/cloudstack/pull/9608#issuecomment-2320867599 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/9608?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] Bump com.mysql:mysql-connector-j from 8.0.33 to 8.2.0 [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9604: URL: https://github.com/apache/cloudstack/pull/9604#issuecomment-2320859363 @DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Bump com.mysql:mysql-connector-j from 8.0.33 to 8.2.0 [cloudstack]

2024-08-30 Thread via GitHub
DaanHoogland commented on PR #9604: URL: https://github.com/apache/cloudstack/pull/9604#issuecomment-2320853446 @blueorangutan LLtest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump com.mysql:mysql-connector-j from 8.0.33 to 8.2.0 [cloudstack]

2024-08-30 Thread via GitHub
DaanHoogland commented on PR #9604: URL: https://github.com/apache/cloudstack/pull/9604#issuecomment-2320853125 > It wouldn't work, simply like that I think. We'll have to change deps like: > > ``` > > com.mysql > mysql-connector-j > > > ``` well the s

Re: [PR] kvm: fallback to cloud-init aware domain product name [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9608: URL: https://github.com/apache/cloudstack/pull/9608#issuecomment-2320849939 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] kvm: fallback to cloud-init aware domain product name [cloudstack]

2024-08-30 Thread via GitHub
rohityadavcloud commented on PR #9608: URL: https://github.com/apache/cloudstack/pull/9608#issuecomment-2320848913 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [I] cloud-init template broken on KVM [cloudstack]

2024-08-30 Thread via GitHub
rohityadavcloud commented on issue #9607: URL: https://github.com/apache/cloudstack/issues/9607#issuecomment-2320848004 May not be ideal but I've proposed for a band-aid fix here https://github.com/apache/cloudstack/pull/9608 cc @shwstppr @DaanHoogland @JoaoJandre -- This is an automate

[PR] kvm: fallback to cloud-init aware domain product name [cloudstack]

2024-08-30 Thread via GitHub
rohityadavcloud opened a new pull request, #9608: URL: https://github.com/apache/cloudstack/pull/9608 This uses the previously used KVM domain product name when the provided value is null or empty. This ensure backward compatibilty and allow cloud-init to work on KVM+CloudStack setup.

[I] Integrate Cloudstack SSO with Generic OpenID Connect on-premise solution [cloudstack]

2024-08-30 Thread via GitHub
steven3579 opened a new issue, #9609: URL: https://github.com/apache/cloudstack/issues/9609 # ISSUE TYPE * Feature Idea # COMPONENT NAME ~~~ Integrate Cloudstack SSO with Generic OpenID Connect on-premise solution, example: Authentik ~~~

Re: [PR] UI: Notify users when upgrades are available or restart is required [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #7610: URL: https://github.com/apache/cloudstack/pull/7610#issuecomment-2320846173 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] UI: Notify users when upgrades are available or restart is required [cloudstack]

2024-08-30 Thread via GitHub
vishesh92 commented on PR #7610: URL: https://github.com/apache/cloudstack/pull/7610#issuecomment-2320843026 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[I] cloud-init template broken on KVM [cloudstack]

2024-08-30 Thread via GitHub
rohityadavcloud opened a new issue, #9607: URL: https://github.com/apache/cloudstack/issues/9607 Due to https://github.com/apache/cloudstack/pull/9163/files the product name is set to blank. This causes an issue for KVM, where in cloud-init enabled template VMs don't get product name for so

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2320825762 @DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke

Re: [PR] [HEALTH] 4.20/main Health Check, please don't merge this! [cloudstack]

2024-08-30 Thread via GitHub
DaanHoogland commented on PR #9316: URL: https://github.com/apache/cloudstack/pull/9316#issuecomment-2320822302 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2320785610 @shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] server: allow migration of vm with snapshots for vmware [cloudstack]

2024-08-30 Thread via GitHub
shwstppr commented on PR #9305: URL: https://github.com/apache/cloudstack/pull/9305#issuecomment-2320784794 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] UI: Notify users when upgrades are available or restart is required [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #7610: URL: https://github.com/apache/cloudstack/pull/7610#issuecomment-2320777523 Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 10881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Bump com.mysql:mysql-connector-j from 8.0.33 to 8.2.0 [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #9604: URL: https://github.com/apache/cloudstack/pull/9604#issuecomment-2320777493 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #8683: URL: https://github.com/apache/cloudstack/pull/8683#issuecomment-2320776092 [SF] Trillian test result (tid-11227) Environment: xcpng82 (x2), Advanced Networking with Mgmt server a9 Total time taken: 95028 seconds Marvin logs: https://github.com/b

Re: [PR] backup: simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-30 Thread via GitHub
rohityadavcloud commented on code in PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#discussion_r1738378610 ## plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtRestoreBackupCommandWrapper.java: ## @@ -0,0 +1,181 @@ +// +// Lice

Re: [PR] UI: Notify users when upgrades are available or restart is required [cloudstack]

2024-08-30 Thread via GitHub
blueorangutan commented on PR #7610: URL: https://github.com/apache/cloudstack/pull/7610#issuecomment-2320768212 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] UI: Notify users when upgrades are available or restart is required [cloudstack]

2024-08-30 Thread via GitHub
vishesh92 commented on PR #7610: URL: https://github.com/apache/cloudstack/pull/7610#issuecomment-2320765400 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

  1   2   >