Re: [PR] Build: drop EL7 support, support JRE17 for packages, building and sonar check [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2266523716 [SF] Trillian test result (tid-11016) Environment: xcpng82 (x2), Advanced Networking with Mgmt server a9 Total time taken: 70098 seconds Marvin logs: https://github.com/b

Re: [PR] Build: drop EL7 support, support JRE17 for packages, building and sonar check [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2266367469 [SF] Trillian test result (tid-11014) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 62049 seconds Marvin logs: https://github

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2266315233 [SF] Trillian test result (tid-11012) Environment: xcpng82 (x2), Advanced Networking with Mgmt server a9 Total time taken: 68473 seconds Marvin logs: https://github.com/b

svn commit: r70670 - in /dev/cloudstack/4.19.1.1: ./ apache-cloudstack-4.19.1.1-src.tar.bz2 apache-cloudstack-4.19.1.1-src.tar.bz2.asc apache-cloudstack-4.19.1.1-src.tar.bz2.sha512

2024-08-02 Thread nvazquez
Author: nvazquez Date: Fri Aug 2 20:31:35 2024 New Revision: 70670 Log: Committing release candidate artifacts for 4.19.1.1 to dist/dev/cloudstack in preparation for release vote Added: dev/cloudstack/4.19.1.1/ dev/cloudstack/4.19.1.1/apache-cloudstack-4.19.1.1-src.tar.bz2 (with prop

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2266103041 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

svn commit: r70669 - in /dev/cloudstack/4.18.2.3: ./ apache-cloudstack-4.18.2.3-src.tar.bz2 apache-cloudstack-4.18.2.3-src.tar.bz2.asc apache-cloudstack-4.18.2.3-src.tar.bz2.sha512

2024-08-02 Thread nvazquez
Author: nvazquez Date: Fri Aug 2 20:25:38 2024 New Revision: 70669 Log: Committing release candidate artifacts for 4.18.2.3 to dist/dev/cloudstack in preparation for release vote Added: dev/cloudstack/4.18.2.3/ dev/cloudstack/4.18.2.3/apache-cloudstack-4.18.2.3-src.tar.bz2 (with prop

Re: [PR] [HEALTH] 4.19 LTS Health Check, please don't merge this! [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9315: URL: https://github.com/apache/cloudstack/pull/9315#issuecomment-2266058013 [SF] Trillian test result (tid-11010) Environment: kvm-ubuntu22 (x2), Advanced Networking with Mgmt server u22 Total time taken: 49187 seconds Marvin logs: https://github

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2266007999 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#issuecomment-2266007293 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] Unable to Migrate VM from admin to user Account [cloudstack]

2024-08-02 Thread via GitHub
shwstppr commented on issue #9476: URL: https://github.com/apache/cloudstack/issues/9476#issuecomment-2265926703 @anjanahkarthic that is expected behaviour. If you want to assign a VM to a particular account then associated entities such as template, network, etc must also be accessible to

Re: [I] Cannot start GPU instances - Exception on: com.mysql.cj.jdbc.ClientPreparedStatement [cloudstack]

2024-08-02 Thread via GitHub
boring-cyborg[bot] commented on issue #9483: URL: https://github.com/apache/cloudstack/issues/9483#issuecomment-2265920060 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[I] Cannot start GPU instances - Exception on: com.mysql.cj.jdbc.ClientPreparedStatement [cloudstack]

2024-08-02 Thread via GitHub
Revellski opened a new issue, #9483: URL: https://github.com/apache/cloudstack/issues/9483 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ CS core - GPU ~~~ # CLOUDSTACK VERSION ~~~ 4.19.1.0 ~~~ # CONFIGURATION

Re: [I] Menu sub-section VNF and "create kubernetes" showed also if list permission not present [cloudstack]

2024-08-02 Thread via GitHub
shwstppr commented on issue #9481: URL: https://github.com/apache/cloudstack/issues/9481#issuecomment-2265909971 @tanganellilore adding to what @adietrich-ussignal mentioned, if your new role is based on the Default User/DomainAdmin role you may have to set deny for the APIs for which you

Re: [I] Menu sub-section VNF and "create kubernetes" showed also if list permission not present [cloudstack]

2024-08-02 Thread via GitHub
tanganellilore commented on issue #9481: URL: https://github.com/apache/cloudstack/issues/9481#issuecomment-2265890854 Thanks for fast answer, I will check better my release because I'm started from new role without any permission. I notice that there are a lot permission but this allow u

Re: [I] Unable to Migrate VM from admin to user Account [cloudstack]

2024-08-02 Thread via GitHub
adietrich-ussignal commented on issue #9476: URL: https://github.com/apache/cloudstack/issues/9476#issuecomment-2265815152 @anjanahkarthic I have also run across this issue if the template/ISO that the instance was created with is not accessible to the target account. If the template/ISO wa

Re: [I] Menu sub-section VNF and "create kubernetes" showed also if list permission not present [cloudstack]

2024-08-02 Thread via GitHub
adietrich-ussignal commented on issue #9481: URL: https://github.com/apache/cloudstack/issues/9481#issuecomment-2265811507 Here is an example of what I see on a specifically configured role with VNF and Kubernetes permissions removed. https://github.com/user-attachments/assets/fbbf509f-98

Re: [I] Menu sub-section VNF and "create kubernetes" showed also if list permission not present [cloudstack]

2024-08-02 Thread via GitHub
adietrich-ussignal commented on issue #9481: URL: https://github.com/apache/cloudstack/issues/9481#issuecomment-2265808054 @tanganellilore I believe PR #9237 actually fixed this, which was released in 4.19.1.0. I don't see either option in our roles configured to align to what end users wi

[I] Unable to assign ISO permissions to Account in sub-Domain [cloudstack]

2024-08-02 Thread via GitHub
adietrich-ussignal opened a new issue, #9482: URL: https://github.com/apache/cloudstack/issues/9482 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI, ISOs/Templates ~~~ # CLOUDSTACK VERSION ~~~ 4.19.0.2 ~~~ #

Re: [I] Menu sub-section showed also if list permission not present [cloudstack]

2024-08-02 Thread via GitHub
tanganellilore closed issue #9481: Menu sub-section showed also if list permission not present URL: https://github.com/apache/cloudstack/issues/9481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [I] Menu sub-section showed also if list permission not present [cloudstack]

2024-08-02 Thread via GitHub
boring-cyborg[bot] commented on issue #9481: URL: https://github.com/apache/cloudstack/issues/9481#issuecomment-2265746643 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the mes

[I] Menu sub-section showed also if list permission not present [cloudstack]

2024-08-02 Thread via GitHub
tanganellilore opened a new issue, #9481: URL: https://github.com/apache/cloudstack/issues/9481 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.19.1.0 ~~~ # CONFIGURATION

[I] Improve "Delete Account" pop-up verbiage [cloudstack]

2024-08-02 Thread via GitHub
adietrich-ussignal opened a new issue, #9480: URL: https://github.com/apache/cloudstack/issues/9480 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.19.0.2 ~~~ # CONFIGU

Re: [PR] Updated invalid parameter/value error with proper exception, to com.cloud.exception.InvalidParameterValueException (from java.security.InvalidParameterException) [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9455: URL: https://github.com/apache/cloudstack/pull/9455#issuecomment-2265710334 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1702025156 ## server/src/main/java/org/apache/cloudstack/network/RoutedIpv4ManagerImpl.java: ## @@ -0,0 +1,1563 @@ +// Licensed to the Apache Software Foundation (ASF) un

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1702024836 ## server/src/main/java/org/apache/cloudstack/network/router/deployment/RouterDeploymentDefinition.java: ## @@ -353,7 +353,8 @@ protected boolean prepareDeploy

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1702023562 ## api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateIpv4GuestSubnetCmd.java: ## @@ -0,0 +1,125 @@ +// Licensed to the Apache Software Fo

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701998747 ## ui/src/views/AutogenView.vue: ## @@ -211,6 +211,11 @@ :pagination="true" style="overflow-y: auto" > +

Re: [PR] Updated invalid parameter/value error with proper exception, to com.cloud.exception.InvalidParameterValueException (from java.security.InvalidParameterException) [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9455: URL: https://github.com/apache/cloudstack/pull/9455#issuecomment-2265588252 @weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progres

Re: [PR] Updated invalid parameter/value error with proper exception, to com.cloud.exception.InvalidParameterValueException (from java.security.InvalidParameterException) [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on PR #9455: URL: https://github.com/apache/cloudstack/pull/9455#issuecomment-2265584811 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701951047 ## api/src/main/java/org/apache/cloudstack/api/command/user/network/routing/CreateRoutingFirewallRuleCmd.java: ## @@ -0,0 +1,270 @@ +// Licensed to the Apache

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701924010 ## api/src/main/java/org/apache/cloudstack/api/command/admin/network/bgp/ChangeBgpPeersForVpcCmd.java: ## @@ -0,0 +1,109 @@ +// Licensed to the Apache Software

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
Pearl1594 commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701912642 ## ui/src/views/AutogenView.vue: ## @@ -211,6 +211,11 @@ :pagination="true" style="overflow-y: auto" > +

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701906083 ## tools/marvin/setup.py: ## @@ -27,7 +27,7 @@ raise RuntimeError("python setuptools is required to build Marvin") -VERSION = "4.20.0.0-SNAPSHOT"

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701889651 ## test/integration/smoke/test_network_ipv6.py: ## @@ -394,7 +394,7 @@ def getRouterProcessStatus(self, router, cmd): cmd, hypervisor

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701882118 ## server/src/main/java/org/apache/cloudstack/network/router/deployment/RouterDeploymentDefinition.java: ## @@ -353,7 +353,8 @@ protected boolean prepareDeploy

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701879136 ## ui/src/views/AutogenView.vue: ## @@ -211,6 +211,11 @@ :pagination="true" style="overflow-y: auto" > +

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701879527 ## api/src/main/java/org/apache/cloudstack/api/command/user/network/routing/CreateRoutingFirewallRuleCmd.java: ## @@ -0,0 +1,270 @@ +// Licensed to the Apache

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701876065 ## api/src/main/java/org/apache/cloudstack/api/command/admin/network/ListIpv4SubnetsForGuestNetworkCmd.java: ## @@ -0,0 +1,123 @@ +// Licensed to the Apache So

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701874957 ## api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateIpv4GuestSubnetCmd.java: ## @@ -0,0 +1,125 @@ +// Licensed to the Apache Software Fo

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701873038 ## api/src/main/java/com/cloud/network/Network.java: ## @@ -412,12 +412,16 @@ public void setIp6Address(String ip6Address) { String getGateway(); +

Re: [PR] Fix grammar, spelling, word casing, whitespace [cloudstack]

2024-08-02 Thread via GitHub
FelipeM525 commented on code in PR #9132: URL: https://github.com/apache/cloudstack/pull/9132#discussion_r1701861805 ## server/src/test/java/com/cloud/vm/UserVmManagerTest.java: ## @@ -292,7 +292,7 @@ public void testScaleVMF1() throws Exception { lenient().when(_vmI

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701862174 ## server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java: ## @@ -6582,11 +6605,64 @@ public NetworkOfferingVO createNetworkOffering(final

Re: [PR] Restore listNetworks behavior & clean up the code [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9461: URL: https://github.com/apache/cloudstack/pull/9461#issuecomment-2265414491 @shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respond to th

Re: [PR] Restore listNetworks behavior & clean up the code [cloudstack]

2024-08-02 Thread via GitHub
shwstppr commented on PR #9461: URL: https://github.com/apache/cloudstack/pull/9461#issuecomment-2265410730 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701850773 ## server/src/main/java/com/cloud/bgp/BGPServiceImpl.java: ## @@ -0,0 +1,406 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] Restore listNetworks behavior & clean up the code [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9461: URL: https://github.com/apache/cloudstack/pull/9461#issuecomment-2265407650 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701848658 ## server/src/main/java/com/cloud/bgp/BGPServiceImpl.java: ## @@ -0,0 +1,406 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more cont

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701845161 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -5281,4 +5365,57 @@ public BucketResponse createBucketResponse(Bucket bucket) { p

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701838400 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -2719,6 +2750,29 @@ public NetworkResponse createNetworkResponse(ResponseView view, Networ

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701838400 ## server/src/main/java/com/cloud/api/ApiResponseHelper.java: ## @@ -2719,6 +2750,29 @@ public NetworkResponse createNetworkResponse(ResponseView view, Networ

Re: [PR] Restore listNetworks behavior & clean up the code [cloudstack]

2024-08-02 Thread via GitHub
shwstppr commented on PR #9461: URL: https://github.com/apache/cloudstack/pull/9461#issuecomment-2265369423 @winterhazel sure, will do that once we have the new packages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Restore listNetworks behavior & clean up the code [cloudstack]

2024-08-02 Thread via GitHub
winterhazel commented on PR #9461: URL: https://github.com/apache/cloudstack/pull/9461#issuecomment-2265247873 @shwstppr could we run the CI again? There seems to have been a problem with the last run -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Restore listNetworks behavior & clean up the code [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9461: URL: https://github.com/apache/cloudstack/pull/9461#issuecomment-2265247855 @winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Restore listNetworks behavior & clean up the code [cloudstack]

2024-08-02 Thread via GitHub
winterhazel commented on PR #9461: URL: https://github.com/apache/cloudstack/pull/9461#issuecomment-2265245973 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [WIP] backup: Simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-02 Thread via GitHub
rohityadavcloud commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2265218556 Tested NFS, CephFS & samba, works when configuration is correctly configured; for example; ``` mysql> select * from backup_repository\G; ***

Re: [PR] [WIP] backup: Simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2265138232 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Build: drop EL7 support, support JRE17 for packages, building and sonar check [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2265090650 @rohityadavcloud a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smo

Re: [PR] Build: drop EL7 support, support JRE17 for packages, building and sonar check [cloudstack]

2024-08-02 Thread via GitHub
rohityadavcloud commented on PR #8609: URL: https://github.com/apache/cloudstack/pull/8609#issuecomment-2265089038 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [WIP] backup: Simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2265033088 @rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progr

Re: [PR] [WIP] backup: Simple NAS backup plugin for KVM (experimental) [cloudstack]

2024-08-02 Thread via GitHub
rohityadavcloud commented on PR #9451: URL: https://github.com/apache/cloudstack/pull/9451#issuecomment-2265030665 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2264962220 Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-02 Thread via GitHub
abh1sar commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2264874354 > Hey @abh1sar > > Good to see you actually have a specification for such a big feature. Sadly we have too many PRs that change 2k+ lines with little to none specification. >

Re: [PR] [WIP] Dynamic and Static Routing [cloudstack]

2024-08-02 Thread via GitHub
shwstppr commented on code in PR #9470: URL: https://github.com/apache/cloudstack/pull/9470#discussion_r1701361117 ## server/src/main/java/com/cloud/bgp/BGPServiceImpl.java: ## @@ -0,0 +1,406 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contribut

Re: [PR] [WIP] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-02 Thread via GitHub
abh1sar commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2264844754 @weizhouapache PR is ready for review. Documentation PR is pending which I will link in a few days. Also working on UT and integrations tests. -- This is an automated message from th

Re: [PR] [WIP] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-02 Thread via GitHub
blueorangutan commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2264843809 @abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

Re: [PR] [WIP] Storage Filesystem as a First Class Feature [cloudstack]

2024-08-02 Thread via GitHub
abh1sar commented on PR #9208: URL: https://github.com/apache/cloudstack/pull/9208#issuecomment-2264840731 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Add access modifier to `VolumeVO` [cloudstack]

2024-08-02 Thread via GitHub
weizhouapache commented on PR #9394: URL: https://github.com/apache/cloudstack/pull/9394#issuecomment-2264816580 @FelipeM525 - `hostip` should be renamed to `hostIp` - `getHostip` and `setHostip` are not needed. there are already `getHostIp` and `setHostIp` -- This is an automa