Re: [PR] feature: webhooks [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2005592013 [SF] Trillian test result (tid-9511) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 52275 seconds Marvin logs: https://github.com

Re: [PR] Add UI to view and download usage records [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8615: URL: https://github.com/apache/cloudstack/pull/8615#issuecomment-2004962606 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8966 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004936825 @vishesh92 a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is a

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
vishesh92 commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004933632 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004854118 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8965 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow [cloudstack]

2024-03-18 Thread via GitHub
gpordeus commented on code in PR #8689: URL: https://github.com/apache/cloudstack/pull/8689#discussion_r1529192893 ## test/integration/smoke/test_vm_life_cycle.py: ## @@ -955,6 +956,92 @@ def test_12_start_vm_multiple_volumes_allocated(self): "Check virtual machine

Re: [PR] Add UI to view and download usage records [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8615: URL: https://github.com/apache/cloudstack/pull/8615#issuecomment-2004781225 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Add UI to view and download usage records [cloudstack]

2024-03-18 Thread via GitHub
vishesh92 commented on PR #8615: URL: https://github.com/apache/cloudstack/pull/8615#issuecomment-2004778758 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004711998 Packaging result [SF]: ✖️ el7 ✖️ debian. SL-JID 8964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004711712 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
vishesh92 commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004709709 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-2004614548 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 8963 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004584472 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
vishesh92 commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004582378 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Restart VPC with clean-up not applying all LB rules [cloudstack]

2024-03-18 Thread via GitHub
weizhouapache commented on code in PR #8765: URL: https://github.com/apache/cloudstack/pull/8765#discussion_r1528966859 ## server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java: ## @@ -2578,7 +2579,13 @@ protected void finalizeNetworkRulesForNetwo

Re: [PR] VPC VR: fix empty iptables if there is no vpc tier [cloudstack]

2024-03-18 Thread via GitHub
JoaoJandre commented on PR #8787: URL: https://github.com/apache/cloudstack/pull/8787#issuecomment-2004503876 @KlausDornsbach could you test this and share your test steps/results? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-2004484407 @JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] Restart VPC with clean-up not applying all LB rules [cloudstack]

2024-03-18 Thread via GitHub
SadiJr commented on code in PR #8765: URL: https://github.com/apache/cloudstack/pull/8765#discussion_r1528951434 ## server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java: ## @@ -2578,7 +2579,13 @@ protected void finalizeNetworkRulesForNetwork(fina

Re: [PR] Use join instead of views [cloudstack]

2024-03-18 Thread via GitHub
weizhouapache merged PR #8321: URL: https://github.com/apache/cloudstack/pull/8321 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@c

Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2024-03-18 Thread via GitHub
JoaoJandre commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-2004480003 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Use join instead of views [cloudstack]

2024-03-18 Thread via GitHub
weizhouapache commented on PR #8321: URL: https://github.com/apache/cloudstack/pull/8321#issuecomment-2004479089 Merging based on approvals and CI/manual test results Thanks @vishesh92 @vladimirpetrov -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] [Usage] Create network billing [cloudstack]

2024-03-18 Thread via GitHub
sureshanaparti commented on PR #7236: URL: https://github.com/apache/cloudstack/pull/7236#issuecomment-2004294260 > @DaanHoogland @sureshanaparti, do you guys think this PR can go to the `4.19.1.0` release? @BryanMLima Good to have this PR on `4.19.1.0` release, code/test lgtms are a

Re: [PR] Use join instead of views [cloudstack]

2024-03-18 Thread via GitHub
vladimirpetrov commented on PR #8321: URL: https://github.com/apache/cloudstack/pull/8321#issuecomment-2004220279 Tested on a simulator hypervisor, with a separate MS (4 CPUs, 8 GB RAM) and DB VM (8 CPUs, 16 GB RAM), using Apache Benchmark tool (ab), measuring mean response time from 100 ex

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004206237 Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 8962 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] linstor: cleanup diskless nodes on disconnect [cloudstack]

2024-03-18 Thread via GitHub
sureshanaparti commented on code in PR #8790: URL: https://github.com/apache/cloudstack/pull/8790#discussion_r1528761276 ## plugins/storage/volume/linstor/src/main/java/com/cloud/hypervisor/kvm/storage/LinstorStorageAdaptor.java: ## @@ -302,26 +308,89 @@ public boolean connectPh

Re: [PR] linstor: Support VM-Instance Disk snapshots [cloudstack]

2024-03-18 Thread via GitHub
sureshanaparti commented on code in PR #8796: URL: https://github.com/apache/cloudstack/pull/8796#discussion_r1528758764 ## plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/snapshot/LinstorVMSnapshotStrategy.java: ## @@ -0,0 +1,347 @@ +// +//Licensed to

Re: [PR] linstor: Support VM-Instance Disk snapshots [cloudstack]

2024-03-18 Thread via GitHub
codecov[bot] commented on PR #8796: URL: https://github.com/apache/cloudstack/pull/8796#issuecomment-2004178378 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8796?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] linstor: Support VM-Instance Disk snapshots [cloudstack]

2024-03-18 Thread via GitHub
sureshanaparti commented on code in PR #8796: URL: https://github.com/apache/cloudstack/pull/8796#discussion_r1528743512 ## plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/snapshot/LinstorVMSnapshotStrategy.java: ## @@ -0,0 +1,347 @@ +// +//Licensed to

Re: [PR] linstor: Support VM-Instance Disk snapshots [cloudstack]

2024-03-18 Thread via GitHub
sureshanaparti commented on code in PR #8796: URL: https://github.com/apache/cloudstack/pull/8796#discussion_r1528743512 ## plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/snapshot/LinstorVMSnapshotStrategy.java: ## @@ -0,0 +1,347 @@ +// +//Licensed to

Re: [PR] linstor: Support VM-Instance Disk snapshots [cloudstack]

2024-03-18 Thread via GitHub
sureshanaparti commented on code in PR #8796: URL: https://github.com/apache/cloudstack/pull/8796#discussion_r1528743512 ## plugins/storage/volume/linstor/src/main/java/org/apache/cloudstack/storage/snapshot/LinstorVMSnapshotStrategy.java: ## @@ -0,0 +1,347 @@ +// +//Licensed to

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
codecov[bot] commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004093344 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8798?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments

Re: [PR] [Usage] Create VPC billing [cloudstack]

2024-03-18 Thread via GitHub
BryanMLima commented on PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#issuecomment-2004074831 @DaanHoogland @sureshanaparti, do you guys think this PR can go to the `4.19.1.0` release? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004073610 @vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] [Usage] Create network billing [cloudstack]

2024-03-18 Thread via GitHub
BryanMLima commented on PR #7236: URL: https://github.com/apache/cloudstack/pull/7236#issuecomment-2004071990 @DaanHoogland @sureshanaparti, do you guys think this PR can go to the `4.19.1.0` release? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
vishesh92 commented on PR #8798: URL: https://github.com/apache/cloudstack/pull/8798#issuecomment-2004070132 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[PR] Hypervisor as class [cloudstack]

2024-03-18 Thread via GitHub
vishesh92 opened a new pull request, #8798: URL: https://github.com/apache/cloudstack/pull/8798 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionali

Re: [PR] UI: Fix missing locale strings for Status widget [cloudstack]

2024-03-18 Thread via GitHub
vishesh92 commented on code in PR #8792: URL: https://github.com/apache/cloudstack/pull/8792#discussion_r1528671141 ## ui/src/components/widgets/Status.vue: ## @@ -166,23 +166,24 @@ export default { if (!(state && this.displayText)) { return '' } Review C

Re: [PR] Fix spelling in docs and code comments only [cloudstack]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #8774: URL: https://github.com/apache/cloudstack/pull/8774#issuecomment-2004010394 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] Fix spelling in docs and code comments only [cloudstack]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #8774: URL: https://github.com/apache/cloudstack/pull/8774#issuecomment-2003896134 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] plugins/pom.xml: build nsx only if noredist is passed [cloudstack]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #8772: URL: https://github.com/apache/cloudstack/pull/8772#issuecomment-2003896097 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] feature: webhooks [cloudstack]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2003896031 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] [VMware] apply IOPS in resize/migrate [cloudstack]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #7226: URL: https://github.com/apache/cloudstack/pull/7226#issuecomment-2003895944 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] [Quota] Add API to list preset variables [cloudstack]

2024-03-18 Thread via GitHub
github-actions[bot] commented on PR #8372: URL: https://github.com/apache/cloudstack/pull/8372#issuecomment-2003895988 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] Add indexes for vm_stats [cloudstack]

2024-03-18 Thread via GitHub
JoaoJandre commented on PR #8737: URL: https://github.com/apache/cloudstack/pull/8737#issuecomment-2003875216 Sure @vishesh92 , here are the results: No index: ``` MariaDB [teste]> ANALYZE SELECT vm_stats.id, vm_stats.vm_id, vm_stats.mgmt_server_id, vm_stats.timestamp, vm_st

[I] UI: Job is cancelled as it has been blocking others for too long [cloudstack]

2024-03-18 Thread via GitHub
levindecaro opened a new issue, #8797: URL: https://github.com/apache/cloudstack/issues/8797 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ UI ~~~ # CLOUDSTACK VERSION ~~~ 4.19 ~~~ # CONFIGURATION Advanc

Re: [PR] snapshot: don't schedule next snapshot job for a removed volume [cloudstack]

2024-03-18 Thread via GitHub
JoaoJandre commented on PR #8735: URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-2003796954 I tried to test this manually but was not able to reproduce the issue, @rohityadavcloud could you share the steps to reproduce this? -- This is an automated message from the

Re: [PR] snapshot: don't schedule next snapshot job for a removed volume [cloudstack]

2024-03-18 Thread via GitHub
rohityadavcloud commented on PR #8735: URL: https://github.com/apache/cloudstack/pull/8735#issuecomment-2003788044 @JoaoJandre since you're the RM who has called off a freeze, could you merge this? -- This is an automated message from the Apache Git Service. To respond to the message, ple

(cloudstack) branch 4.19 updated (9acba904237 -> ffd59720dd8)

2024-03-18 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch 4.19 in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 9acba904237 Fix 404 when moving a VM to out of a project (#8650) add ffd59720dd8 storage,plugins: delegate allow

Re: [PR] storage,plugins: delegate allow zone-wide volume migration check and access grant check to storage drivers [cloudstack]

2024-03-18 Thread via GitHub
rohityadavcloud merged PR #8762: URL: https://github.com/apache/cloudstack/pull/8762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...

Re: [PR] storage,plugins: delegate allow zone-wide volume migration check and access grant check to storage drivers [cloudstack]

2024-03-18 Thread via GitHub
rohityadavcloud commented on PR #8762: URL: https://github.com/apache/cloudstack/pull/8762#issuecomment-2003721662 LGTM, merging based on review, manual tests and smoketests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

(cloudstack) branch main updated: Quota email configuration (#8307)

2024-03-18 Thread joao
This is an automated email from the ASF dual-hosted git repository. joao pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new f76c6f3ea97 Quota email configuration (#8307) f76c

Re: [PR] Quota email configuration [cloudstack]

2024-03-18 Thread via GitHub
JoaoJandre merged PR #8307: URL: https://github.com/apache/cloudstack/pull/8307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clou

Re: [PR] Quota email configuration [cloudstack]

2024-03-18 Thread via GitHub
JoaoJandre commented on PR #8307: URL: https://github.com/apache/cloudstack/pull/8307#issuecomment-2003657468 Merging based on approvals, manual test results and CI results. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] feature: webhooks [cloudstack]

2024-03-18 Thread via GitHub
blueorangutan commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2003584194 @shwstppr a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

Re: [PR] feature: webhooks [cloudstack]

2024-03-18 Thread via GitHub
shwstppr commented on PR #8674: URL: https://github.com/apache/cloudstack/pull/8674#issuecomment-2003576954 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen