Re: [PR] FiberChannel Multipath for KVM + Pure Flash Array and HPE-Primera Support [cloudstack]

2023-10-31 Thread via GitHub
shwstppr commented on code in PR #7889: URL: https://github.com/apache/cloudstack/pull/7889#discussion_r1378452547 ## engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java: ## @@ -511,11 +517,16 @@ public void copyAsync(DataO

Re: [PR] FiberChannel Multipath for KVM + Pure Flash Array and HPE-Primera Support [cloudstack]

2023-10-31 Thread via GitHub
shwstppr commented on code in PR #7889: URL: https://github.com/apache/cloudstack/pull/7889#discussion_r1378451503 ## api/src/main/java/org/apache/cloudstack/api/command/admin/storage/UpdateStoragePoolCmd.java: ## @@ -61,6 +63,20 @@ public class UpdateStoragePoolCmd extends Base

Re: [PR] Linstor backup snaphots [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #8067: URL: https://github.com/apache/cloudstack/pull/8067#issuecomment-1788423781 [SF] Trillian test result (tid-8185) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8 Total time taken: 47566 seconds Marvin logs: https://github.co

Re: [PR] Linstor backup snaphots [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #8067: URL: https://github.com/apache/cloudstack/pull/8067#issuecomment-1788420337 [SF] Trillian test result (tid-8184) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47362 seconds Marvin logs: https://github.co

Re: [PR] NSX integration [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1788402067 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7595 -- This is an auto

Re: [PR] Database VIEW management via separated files [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7417: URL: https://github.com/apache/cloudstack/pull/7417#issuecomment-1788400356 @GutoVeronezi a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Database VIEW management via separated files [cloudstack]

2023-10-31 Thread via GitHub
GutoVeronezi commented on PR #7417: URL: https://github.com/apache/cloudstack/pull/7417#issuecomment-1788394434 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Fixes:#7837: Add isolationMethods and vlan to TrafficTypeResponse [cloudstack]

2023-10-31 Thread via GitHub
madhukar93 commented on code in PR #8151: URL: https://github.com/apache/cloudstack/pull/8151#discussion_r1378379019 ## api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListTrafficTypesCmd.java: ## @@ -27,14 +27,13 @@ import org.apache.cloudstack.api.Parameter;

Re: [PR] Fixes:#7837: Add isolationMethods and vlan to TrafficTypeResponse [cloudstack]

2023-10-31 Thread via GitHub
madhukar93 commented on code in PR #8151: URL: https://github.com/apache/cloudstack/pull/8151#discussion_r1378379019 ## api/src/main/java/org/apache/cloudstack/api/command/admin/usage/ListTrafficTypesCmd.java: ## @@ -27,14 +27,13 @@ import org.apache.cloudstack.api.Parameter;

Re: [PR] Storage Management [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1788380244 [SF] Trillian test result (tid-8182) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43931 seconds Marvin logs: https://github.com

Re: [I] Can not add a Baremetal Template when using cloudstack to manager the Baremetal Server ? [cloudstack]

2023-10-31 Thread via GitHub
xuanyuanaosheng commented on issue #8162: URL: https://github.com/apache/cloudstack/issues/8162#issuecomment-1788372724 Only add a Baremetal Template in the Baremetal zone and it works. I think it need to check related code to do someting to avoid this or add some comments on te web

Re: [I] Can not add a Baremetal Template when using cloudstack to manager the Baremetal Server ? [cloudstack]

2023-10-31 Thread via GitHub
xuanyuanaosheng closed issue #8162: Can not add a Baremetal Template when using cloudstack to manager the Baremetal Server ? URL: https://github.com/apache/cloudstack/issues/8162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] NSX integration [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1788359817 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] NSX integration [cloudstack]

2023-10-31 Thread via GitHub
nvazquez commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1788359413 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] NSX integration [cloudstack]

2023-10-31 Thread via GitHub
nvazquez commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1788355749 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

(cloudstack) branch nsx-integration updated (dc90d0b9dd1 -> e3a27622357)

2023-10-31 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a change to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git from dc90d0b9dd1 NSX: fix LB member addition and deletion and add defensive checks (#8167) add e3a2762

Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7752: URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1788347297 [SF] Trillian test result (tid-8183) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40954 seconds Marvin logs: https://github.com

Re: [PR] Database VIEW management via separated files [cloudstack]

2023-10-31 Thread via GitHub
github-actions[bot] commented on PR #7417: URL: https://github.com/apache/cloudstack/pull/7417#issuecomment-1788305141 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

Re: [PR] Standardize StringUtils usages in NetworkModelImpl [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7980: URL: https://github.com/apache/cloudstack/pull/7980#issuecomment-1788276412 [SF] Trillian test result (tid-8178) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47704 seconds Marvin logs: https://github.com

Re: [I] The Problem about using cloudstack to manager the Baremetal Server [cloudstack]

2023-10-31 Thread via GitHub
hooklee2000 commented on issue #8124: URL: https://github.com/apache/cloudstack/issues/8124#issuecomment-1788268257 check #8162, you select "all zone'. listStoresByZoneId can'nt find secondary storage in the right "all zone". Maybe create a secondary storage in your zone csbm , and c

Re: [PR] NSX integration [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1788267871 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7592 -- This is an auto

Re: [PR] NSX integration [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1788224980 @nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Re: [PR] NSX integration [cloudstack]

2023-10-31 Thread via GitHub
nvazquez commented on PR #7919: URL: https://github.com/apache/cloudstack/pull/7919#issuecomment-1788221534 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

(cloudstack) branch nsx-integration updated (d0fe7b269f9 -> dc90d0b9dd1)

2023-10-31 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a change to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git from d0fe7b269f9 NSX: Fix VR public NIC allocation (#8166) add dc90d0b9dd1 NSX: fix LB member addition

Re: [PR] NSX: fix LB member addition and deletion and add defensive checks [cloudstack]

2023-10-31 Thread via GitHub
nvazquez merged PR #8167: URL: https://github.com/apache/cloudstack/pull/8167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

Re: [PR] FiberChannel Multipath for KVM + Pure Flash Array and HPE-Primera Support [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7889: URL: https://github.com/apache/cloudstack/pull/7889#issuecomment-1788201709 [SF] Trillian test result (tid-8179) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 41586 seconds Marvin logs: https://github.com

(cloudstack) branch nsx-integration updated: NSX: Fix VR public NIC allocation (#8166)

2023-10-31 Thread nvazquez
This is an automated email from the ASF dual-hosted git repository. nvazquez pushed a commit to branch nsx-integration in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/nsx-integration by this push: new d0fe7b269f9 NSX: Fix VR

Re: [PR] [NSX] Fix for VR public NIC [cloudstack]

2023-10-31 Thread via GitHub
nvazquez merged PR #8166: URL: https://github.com/apache/cloudstack/pull/8166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@clouds

Re: [PR] NSX: fix LB member addition and deletion and add defensive checks [cloudstack]

2023-10-31 Thread via GitHub
nvazquez closed pull request #8167: NSX: fix LB member addition and deletion and add defensive checks URL: https://github.com/apache/cloudstack/pull/8167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Inject hypervisor type and volume format on Quota tariffs [cloudstack]

2023-10-31 Thread via GitHub
GutoVeronezi commented on PR #8138: URL: https://github.com/apache/cloudstack/pull/8138#issuecomment-1788038545 > > > the gha failure is codecov upload. I don't think the ssvm errors are related. @shwstppr @GutoVeronezi Are we requiring 3rd party testing on this? > > > > > > It wo

Re: [PR] Add logs to the listLoadBalancerRuleInstances API [cloudstack]

2023-10-31 Thread via GitHub
GutoVeronezi commented on PR #6357: URL: https://github.com/apache/cloudstack/pull/6357#issuecomment-1788010674 @DaanHoogland @shwstppr I talked with @joseflauzino offline and I'll handle this PR later; not necessary for 4.19. -- This is an automated message from the Apache Git Service. T

Re: [PR] Database VIEW management via separated files [cloudstack]

2023-10-31 Thread via GitHub
GutoVeronezi commented on PR #7417: URL: https://github.com/apache/cloudstack/pull/7417#issuecomment-1788001498 > @GutoVeronezi do you think we can make this work before 4.19? @DaanHoogland yes, I'm working on the fix for the tests RN. -- This is an automated message from the Apache

Re: [PR] NSX: fix LB member addition and deletion and add defensive checks [cloudstack]

2023-10-31 Thread via GitHub
codecov[bot] commented on PR #8167: URL: https://github.com/apache/cloudstack/pull/8167#issuecomment-1787928368 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8167?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

Re: [PR] [NSX] Fix for VR public NIC [cloudstack]

2023-10-31 Thread via GitHub
codecov[bot] commented on PR #8166: URL: https://github.com/apache/cloudstack/pull/8166#issuecomment-1787904664 ## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8166?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)

[PR] NSX: fix LB member addition and deletion and add defensive checks [cloudstack]

2023-10-31 Thread via GitHub
Pearl1594 opened a new pull request, #8167: URL: https://github.com/apache/cloudstack/pull/8167 ### Description This PR... ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionali

[PR] [NSX] Fix for VR public NIC [cloudstack]

2023-10-31 Thread via GitHub
nvazquez opened a new pull request, #8166: URL: https://github.com/apache/cloudstack/pull/8166 ### Description This PR fixes VR public NIC allocation and remove tier 1 only when it exists ### Types of changes - [ ] Breaking change (fix or feature that would cause existing

Re: [PR] cks: Refactor to externalize scripts [cloudstack]

2023-10-31 Thread via GitHub
davidjumani commented on PR #6458: URL: https://github.com/apache/cloudstack/pull/6458#issuecomment-1787618740 @DaanHoogland I'm not sure if this will still work and I don't have access to a cluster to test. Feel free to close this -- This is an automated message from the Apache Git Servi

Re: [PR] Update requirements file and fix minimum pre-commit version [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7901: URL: https://github.com/apache/cloudstack/pull/7901#issuecomment-1787616264 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7588 -- This is an auto

Re: [PR] ui: extend role isPublic parameter [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7973: URL: https://github.com/apache/cloudstack/pull/7973#issuecomment-1787616262 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7587 -- This is an auto

Re: [PR] Add MGMT IP in management.network.cidr as alternate name in their self-signed certificate [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7728: URL: https://github.com/apache/cloudstack/pull/7728#issuecomment-1787598751 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7586 -- This is an auto

Re: [PR] add metadata to KVM domain (Issue 6695 fix) [cloudstack]

2023-10-31 Thread via GitHub
Jehan-h20220012 commented on PR #6908: URL: https://github.com/apache/cloudstack/pull/6908#issuecomment-1787519584 > @Jehan-h20220012 is this still relevant? are you still looking at this? (cc @slavkap ) I have no updates on it and this issue might have been resolved by some other PR

Re: [PR] misc: fix spelling [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7549: URL: https://github.com/apache/cloudstack/pull/7549#issuecomment-1787514241 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7585 -- This is an auto

Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7486: URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1787514243 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7584 -- This is an auto

Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1787506415 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Move subdomains between domains [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7446: URL: https://github.com/apache/cloudstack/pull/7446#issuecomment-1787505587 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7583 -- This is an auto

Re: [PR] [HEALTH] 4.19/main Health Check, please don't merge this! [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7344: URL: https://github.com/apache/cloudstack/pull/7344#issuecomment-1787504494 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1787502536 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

(cloudstack) branch dummy updated (bc4054940b0 -> 0b3389c2d3b)

2023-10-31 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch dummy in repository https://gitbox.apache.org/repos/asf/cloudstack.git omit bc4054940b0 do not merge add 67eddd7c0e1 Fix allignment on layout on right panel (#8060) add 235e4fe1907 Oa

Re: [PR] [HEALTH] 4.18 LTS Health Check, please don't merge this! [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7345: URL: https://github.com/apache/cloudstack/pull/7345#issuecomment-1787500152 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Cannot add Centos Stream 9 KVM host [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on issue #8160: URL: https://github.com/apache/cloudstack/issues/8160#issuecomment-1787497886 centos 9 is not supported @rongage . I know not of anybody working on adding it. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Add a retry mechanism for VM migration [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7383: URL: https://github.com/apache/cloudstack/pull/7383#issuecomment-1787491023 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7582 -- This is an auto

Re: [I] listTemplate response error on ACS 4.17.2 [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on issue #8111: URL: https://github.com/apache/cloudstack/issues/8111#issuecomment-1787484260 > Finally we solved the problem by changing VM template id in vm_instance table. We replace the removed template id with a template id that it was Active nice that it i

Re: [PR] [Veeam] Check for failures in the restore process [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7224: URL: https://github.com/apache/cloudstack/pull/7224#issuecomment-1787477902 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7581 -- This is an auto

Re: [PR] Linstor backup snaphots [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #8067: URL: https://github.com/apache/cloudstack/pull/8067#issuecomment-1787472643 @DaanHoogland a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This i

Re: [PR] Inject hypervisor type and volume format on Quota tariffs [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #8138: URL: https://github.com/apache/cloudstack/pull/8138#issuecomment-1787471693 > > the gha failure is codecov upload. I don't think the ssvm errors are related. @shwstppr @GutoVeronezi Are we requiring 3rd party testing on this? > > It would be interes

Re: [PR] Linstor backup snaphots [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #8067: URL: https://github.com/apache/cloudstack/pull/8067#issuecomment-1787468494 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] KVM Host HA enhancement for StorPool storage [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #8045: URL: https://github.com/apache/cloudstack/pull/8045#issuecomment-1787467434 @kiranchavala see test_hostha_kvm.py and test_outofbandmanagement.py. ipmitool is used in those. -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7752: URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1787465090 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Flexible URI for connection with DB and new MariaDB driver [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7895: URL: https://github.com/apache/cloudstack/pull/7895#issuecomment-1787465015 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] ui: extend role isPublic parameter [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7973: URL: https://github.com/apache/cloudstack/pull/7973#issuecomment-1787464787 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Storage Management [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1787464877 @DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To r

Re: [PR] Update requirements file and fix minimum pre-commit version [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7901: URL: https://github.com/apache/cloudstack/pull/7901#issuecomment-1787464950 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] ui: extend role isPublic parameter [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7973: URL: https://github.com/apache/cloudstack/pull/7973#issuecomment-1787450907 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Create global configuration to allow changing the default nic adapter for user VMs in VMware [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7954: URL: https://github.com/apache/cloudstack/pull/7954#issuecomment-1787448395 @harikrishna-patnala is this lgty now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Storage Management [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7949: URL: https://github.com/apache/cloudstack/pull/7949#issuecomment-1787445183 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Update requirements file and fix minimum pre-commit version [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7901: URL: https://github.com/apache/cloudstack/pull/7901#issuecomment-1787443229 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Flexible URI for connection with DB and new MariaDB driver [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7895: URL: https://github.com/apache/cloudstack/pull/7895#issuecomment-1787441051 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Flexible URI for connection with DB and new MariaDB driver [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7895: URL: https://github.com/apache/cloudstack/pull/7895#issuecomment-1787440637 @GutoVeronezi @weizhouapache @JoaoJandre , is this ready? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] New Feature: Import VMware VMs into KVM [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7881: URL: https://github.com/apache/cloudstack/pull/7881#issuecomment-1787436692 @nvazquez can you handle the conflicts, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] ObjectStore Framework with MinIO and Simulator plugins [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7752: URL: https://github.com/apache/cloudstack/pull/7752#issuecomment-1787433821 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add MGMT IP in management.network.cidr as alternate name in their self-signed certificate [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7728: URL: https://github.com/apache/cloudstack/pull/7728#issuecomment-1787432033 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Add MGMT IP in management.network.cidr as alternate name in their self-signed certificate [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7728: URL: https://github.com/apache/cloudstack/pull/7728#issuecomment-1787427842 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on code in PR #7486: URL: https://github.com/apache/cloudstack/pull/7486#discussion_r1377753495 ## agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java: ## @@ -92,11 +92,11 @@ public synchronized boolean configure(String name, Map params) {

Re: [PR] Refactor testCRUDAcl to Separated Case to Improve the Test Experience [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7705: URL: https://github.com/apache/cloudstack/pull/7705#issuecomment-1787413567 @Pearl1594 @nvazquez , Can you assess if still is usefull in further development? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] misc: fix spelling [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7549: URL: https://github.com/apache/cloudstack/pull/7549#issuecomment-1787395267 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Add dynamic secondary storage selection [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7659: URL: https://github.com/apache/cloudstack/pull/7659#issuecomment-1787410589 @BryanMLima , can you answer @vishesh92 's comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Externalize KVM HA heartbeat frequency [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #6892: URL: https://github.com/apache/cloudstack/pull/6892#issuecomment-1787407479 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7580 -- This is an auto

Re: [PR] Do not list Quota API's to accounts with Quota disabled [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7599: URL: https://github.com/apache/cloudstack/pull/7599#issuecomment-1787401122 @JoaoJandre , can you look at @GutoVeronezi 's comments/suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] misc: fix spelling [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7549: URL: https://github.com/apache/cloudstack/pull/7549#issuecomment-1787397292 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Add basic `.editorconfig` file to help maintain consistent coding styles [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7562: URL: https://github.com/apache/cloudstack/pull/7562#issuecomment-1787397651 let's move to 4.20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7486: URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1787390130 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7486: URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1787393535 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7486: URL: https://github.com/apache/cloudstack/pull/7486#issuecomment-1787389585 @nikam14 @GutoVeronezi , I've applied the rather trivial changes to move this forward, please publicaly shame me here or on email if that was just to brutal of me. -- This is a

Re: [PR] cks: Refactor to externalize scripts [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #6458: URL: https://github.com/apache/cloudstack/pull/6458#issuecomment-1787386869 Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7579 -- This is an auto

Re: [PR] HAproxy based load balancer Customisation [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7484: URL: https://github.com/apache/cloudstack/pull/7484#issuecomment-1787384760 @CharlesQueiroz (cc @weizhouapache ) will this be done in time for 4.19 or should we postpone? -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Move subdomains between domains [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7446: URL: https://github.com/apache/cloudstack/pull/7446#issuecomment-1787381824 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Move subdomains between domains [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7446: URL: https://github.com/apache/cloudstack/pull/7446#issuecomment-1787378693 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Database VIEW management via separated files [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7417: URL: https://github.com/apache/cloudstack/pull/7417#issuecomment-1787374385 @GutoVeronezi do you think we can make this work before 4.19? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add a retry mechanism for VM migration [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7383: URL: https://github.com/apache/cloudstack/pull/7383#issuecomment-1787370324 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] Enable defining a network as redundant during restart through the UI [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7405: URL: https://github.com/apache/cloudstack/pull/7405#issuecomment-1787370340 @GaOrtiga how do you want to move forward with this? (moving it to 4.20 for now) -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] Add a retry mechanism for VM migration [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7383: URL: https://github.com/apache/cloudstack/pull/7383#issuecomment-1787366487 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Usage] Create VPC billing [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on code in PR #7235: URL: https://github.com/apache/cloudstack/pull/7235#discussion_r1377702673 ## engine/schema/src/main/resources/META-INF/db/schema-41800to41810.sql: ## @@ -47,3 +47,17 @@ WHERE so.default_use = 1 AND so.vm_type IN ('domainrouter', 'sec

Re: [PR] [Usage] Create network billing [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7236: URL: https://github.com/apache/cloudstack/pull/7236#issuecomment-1787358753 @SadiJr can you address the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [VMware] apply IOPS in resize/migrate [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7226: URL: https://github.com/apache/cloudstack/pull/7226#issuecomment-1787355234 @SadiJr can you answer any questions/address any comments, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [Veeam] Check for failures in the restore process [cloudstack]

2023-10-31 Thread via GitHub
blueorangutan commented on PR #7224: URL: https://github.com/apache/cloudstack/pull/7224#issuecomment-1787354858 @DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress

Re: [PR] [Veeam] Check for failures in the restore process [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7224: URL: https://github.com/apache/cloudstack/pull/7224#issuecomment-1787351810 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] [Veeam] Check for failures in the restore process [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on code in PR #7224: URL: https://github.com/apache/cloudstack/pull/7224#discussion_r1377696340 ## plugins/backup/veeam/src/main/java/org/apache/cloudstack/backup/veeam/VeeamClient.java: ## @@ -317,17 +317,29 @@ private boolean checkTaskStatus(final HttpRe

[I] restoreTimeout in VeeamClient is being used as a counter [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland opened a new issue, #8165: URL: https://github.com/apache/cloudstack/issues/8165 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ ~~~ # CLOUDSTACK VERSION ~~~ ~~~ # CONFIGURATION

Re: [PR] [Veeam] Restore only a specified volume [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7221: URL: https://github.com/apache/cloudstack/pull/7221#issuecomment-1787336791 @SadiJr are you still looking to get this merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Tungsten: Support multiple physical networks [cloudstack]

2023-10-31 Thread via GitHub
DaanHoogland commented on PR #7220: URL: https://github.com/apache/cloudstack/pull/7220#issuecomment-1787333417 given the EOL for the tungsten project, maybe close this (for now postpone) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

  1   2   >