[GitHub] [cloudstack] blueorangutan commented on pull request #6918: Override vr service offering

2022-12-20 Thread GitBox
blueorangutan commented on PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-1360969311 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] DaanHoogland commented on pull request #6918: Override vr service offering

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#issuecomment-1360969085 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1360967947 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] DaanHoogland commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1360967458 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[cloudstack] branch 4.17 updated: checksums for new macchinina ova template (#7001)

2022-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.17 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.17 by this push: new 08881d69c78 checksums for new macchinina ova templ

[GitHub] [cloudstack] DaanHoogland merged pull request #7001: checksums for new macchinina ova template

2022-12-20 Thread GitBox
DaanHoogland merged PR #7001: URL: https://github.com/apache/cloudstack/pull/7001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] slavkap commented on a diff in pull request #6661: Enable live volume migration for StorPool and small fixes

2022-12-20 Thread GitBox
slavkap commented on code in PR #6661: URL: https://github.com/apache/cloudstack/pull/6661#discussion_r1054059289 ## test/integration/plugins/storpool/MigrateVolumeToStorPool.py: ## @@ -194,9 +194,12 @@ def setUpCloudStack(cls): securitygroup = SecurityGroup.list(cls.ap

[GitHub] [cloudstack] slavkap commented on a diff in pull request #6661: Enable live volume migration for StorPool and small fixes

2022-12-20 Thread GitBox
slavkap commented on code in PR #6661: URL: https://github.com/apache/cloudstack/pull/6661#discussion_r1054055512 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/provider/StorPoolHostListener.java: ## @@ -164,10 +163,25 @@ public boolean

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1360865281 Trillian test result (tid-5595) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48180 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] shwstppr commented on issue #6987: Project User kubeadmin is not working with project k8s clusters

2022-12-20 Thread GitBox
shwstppr commented on issue #6987: URL: https://github.com/apache/cloudstack/issues/6987#issuecomment-1360858870 @davidjumani can you please comment on this? For ACS to provision resources based on k8s deployments won't we need kubernetes-provider being setup or is being done by default n

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1360846217 Trillian test result (tid-5594) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45971 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-20 Thread GitBox
blueorangutan commented on PR #6803: URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1360802963 Trillian test result (tid-5592) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 47209 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #7001: checksums for new macchinina ova template

2022-12-20 Thread GitBox
blueorangutan commented on PR #7001: URL: https://github.com/apache/cloudstack/pull/7001#issuecomment-1360787214 Trillian test result (tid-5590) Environment: vmware-70u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48154 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1360744159 Trillian test result (tid-5593) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39068 seconds Marvin logs: https://github.com/blu

[GitHub] [cloudstack] blueorangutan commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2022-12-20 Thread GitBox
blueorangutan commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1360682999 Trillian test result (tid-5591) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 43323 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6995: Packages consolidation: merge suse15 to el8

2022-12-20 Thread GitBox
blueorangutan commented on PR #6995: URL: https://github.com/apache/cloudstack/pull/6995#issuecomment-1360651462 Trillian test result (tid-5585) Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8 Total time taken: 49371 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6946: server: add Host Control Plane Status to uservm and systemvm response

2022-12-20 Thread GitBox
blueorangutan commented on PR #6946: URL: https://github.com/apache/cloudstack/pull/6946#issuecomment-1360615464 Trillian test result (tid-5588) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 46746 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6808: Allow privateips on console proxy

2022-12-20 Thread GitBox
blueorangutan commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1360501328 Trillian test result (tid-5589) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 40424 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6946: server: add Host Control Plane Status to uservm and systemvm response

2022-12-20 Thread GitBox
blueorangutan commented on PR #6946: URL: https://github.com/apache/cloudstack/pull/6946#issuecomment-1360426291 Trillian test result (tid-5587) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 3 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6845: new plugins: Add non-strict affinity groups

2022-12-20 Thread GitBox
blueorangutan commented on PR #6845: URL: https://github.com/apache/cloudstack/pull/6845#issuecomment-1360420903 Trillian test result (tid-5584) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42612 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6946: server: add Host Control Plane Status to uservm and systemvm response

2022-12-20 Thread GitBox
blueorangutan commented on PR #6946: URL: https://github.com/apache/cloudstack/pull/6946#issuecomment-1360414756 Trillian test result (tid-5586) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 39300 seconds Marvin logs: https://github.com/blu

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled

2022-12-20 Thread GitBox
sonarcloud[bot] commented on PR #7007: URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1360412404 Kudos, SonarCloud Quality Gate passed!    [![Quality Gate passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/passed-16px.png 'Q

[GitHub] [cloudstack] stephankruggg commented on a diff in pull request #7002: Fix spelling

2022-12-20 Thread GitBox
stephankruggg commented on code in PR #7002: URL: https://github.com/apache/cloudstack/pull/7002#discussion_r1053814015 ## tools/marvin/marvin/sandbox/demo/simulator/testcase/libs/common.py: ## @@ -110,7 +110,7 @@ def download_systemplates_sec_storage(server, services):

[GitHub] [cloudstack] blueorangutan commented on pull request #6977: AutoScaling: update smoke test and consider db upgrade from a fork

2022-12-20 Thread GitBox
blueorangutan commented on PR #6977: URL: https://github.com/apache/cloudstack/pull/6977#issuecomment-1360394037 Trillian test result (tid-5583) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 42346 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] BryanMLima commented on pull request #6812: Normalize encryption on global configurations values

2022-12-20 Thread GitBox
BryanMLima commented on PR #6812: URL: https://github.com/apache/cloudstack/pull/6812#issuecomment-1360369008 @weizhouapache Below are the output from the cases you mentioned: Global configuration: 1. Hidden/Secure config (Hidden are not displayed in the API) ~~~ list configur

[GitHub] [cloudstack] boring-cyborg[bot] commented on pull request #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled

2022-12-20 Thread GitBox
boring-cyborg[bot] commented on PR #7007: URL: https://github.com/apache/cloudstack/pull/7007#issuecomment-1360367940 Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribut

[GitHub] [cloudstack] benj-n opened a new pull request, #7007: Ensure Prometheus doesn't return values when the capacity_state is disabled

2022-12-20 Thread GitBox
benj-n opened a new pull request, #7007: URL: https://github.com/apache/cloudstack/pull/7007 ### Description This PR... Fixes: #7000 It makes prometheus integration returns the same value ("0") when a capacity is explicitly "Disabled" or non-existent.

[GitHub] [cloudstack] aron-ac commented on issue #6987: Project User kubeadmin is not working with project k8s clusters

2022-12-20 Thread GitBox
aron-ac commented on issue #6987: URL: https://github.com/apache/cloudstack/issues/6987#issuecomment-1360320133 @shwstppr have you been able to check back in on this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [cloudstack] benj-n commented on issue #7000: Prometheus integration ignores capacity_state

2022-12-20 Thread GitBox
benj-n commented on issue #7000: URL: https://github.com/apache/cloudstack/issues/7000#issuecomment-1360251496 I am under the impression that https://github.com/apache/cloudstack/pull/4438/ has superseded https://github.com/apache/cloudstack/pull/5773 And that none of them adds anything

[GitHub] [cloudstack] codecov[bot] commented on pull request #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2

2022-12-20 Thread GitBox
codecov[bot] commented on PR #7006: URL: https://github.com/apache/cloudstack/pull/7006#issuecomment-1360072810 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+So

[GitHub] [cloudstack] weizhouapache closed pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2022-12-20 Thread GitBox
weizhouapache closed pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce URL: https://github.com/apache/cloudstack/pull/7003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] jbampton opened a new pull request, #7006: Use lowercase HTTP header field names so we are compatible with HTTP/2

2022-12-20 Thread GitBox
jbampton opened a new pull request, #7006: URL: https://github.com/apache/cloudstack/pull/7006 "Just as in HTTP/1.x, header field names are strings of ASCII characters that are compared in a case-insensitive fashion. However, header field names MUST be converted to lowercase prior to their

[GitHub] [cloudstack] codecov[bot] commented on pull request #7005: gha(linters): enable 7 more Python `flake8` checks

2022-12-20 Thread GitBox
codecov[bot] commented on PR #7005: URL: https://github.com/apache/cloudstack/pull/7005#issuecomment-1359713432 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7005?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+So

[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6809: Reserve memory for host

2022-12-20 Thread GitBox
weizhouapache commented on code in PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1053517021 ## server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java: ## @@ -472,6 +472,8 @@ public class ConfigurationManagerImpl extends ManagerBase

[GitHub] [cloudstack] wido commented on a diff in pull request #6809: Reserve memory for host

2022-12-20 Thread GitBox
wido commented on code in PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1053509434 ## server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java: ## @@ -472,6 +472,8 @@ public class ConfigurationManagerImpl extends ManagerBase impleme

[GitHub] [cloudstack] jbampton opened a new pull request, #7005: gha(linters): enable 7 more Python `flake8` checks

2022-12-20 Thread GitBox
jbampton opened a new pull request, #7005: URL: https://github.com/apache/cloudstack/pull/7005 Can be run locally with: ``` cloudstack % flake8 --select=E223,E224,E242,E273,E274,E901,E902,W291,W292,W293,W391 . ``` https://www.flake8rules.com/ ### Description

[cloudstack] branch 4.18-new-cipher-aead updated (1f05d1b1165 -> 534c7114a04)

2022-12-20 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.18-new-cipher-aead in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 1f05d1b1165 utils,framework/db: Introduce new database encryption cipher based on AesGcmJce a

[GitHub] [cloudstack] soreana commented on a diff in pull request #6918: Override vr service offering

2022-12-20 Thread GitBox
soreana commented on code in PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#discussion_r1053447723 ## framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java: ## @@ -34,7 +34,7 @@ public static final String CATEGORY_ALERT = "Alert

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1359560968 @DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an automated

[cloudstack] branch main updated (889045fba5 -> 34e4376c16)

2022-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 889045fba5 new plugins: Add non-strict affinity groups (#6845) add 34e4376c16 ui: fix persist networks config in

[GitHub] [cloudstack] DaanHoogland closed issue #6974: UI Bug: IP assignment in deploying a VM

2022-12-20 Thread GitBox
DaanHoogland closed issue #6974: UI Bug: IP assignment in deploying a VM URL: https://github.com/apache/cloudstack/issues/6974 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [cloudstack] DaanHoogland merged pull request #6994: ui: persist networks config in deploy vm form

2022-12-20 Thread GitBox
DaanHoogland merged PR #6994: URL: https://github.com/apache/cloudstack/pull/6994 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] DaanHoogland commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1359559217 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [cloudstack] codecov[bot] commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2022-12-20 Thread GitBox
codecov[bot] commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1359547397 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7003?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+So

[GitHub] [cloudstack] soreana commented on pull request #6994: ui: persist networks config in deploy vm form

2022-12-20 Thread GitBox
soreana commented on PR #6994: URL: https://github.com/apache/cloudstack/pull/6994#issuecomment-1359522072 @DaanHoogland We've checked the PR. It works as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1359503062 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5038 -- This is an automated message from the Apache

[GitHub] [cloudstack] DaanHoogland merged pull request #6845: new plugins: Add non-strict affinity groups

2022-12-20 Thread GitBox
DaanHoogland merged PR #6845: URL: https://github.com/apache/cloudstack/pull/6845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[cloudstack] branch main updated (440d7805cb -> 889045fba5)

2022-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git from 440d7805cb Support for parameter `cidrlist` added to the UI (#6869) add 889045fba5 new plugins: Add non-strict af

[GitHub] [cloudstack] DaanHoogland commented on issue #7004: The 'LSI Logic Parallel' controller is not supported on Windows 10

2022-12-20 Thread GitBox
DaanHoogland commented on issue #7004: URL: https://github.com/apache/cloudstack/issues/7004#issuecomment-1359419528 @rohityadavcloud can you describe a scenario in which this poses a problem, please? Also I see three lsilogic adapters in our code: ``` public interface ScsiDiskContr

[GitHub] [cloudstack] blueorangutan commented on pull request #7002: Fix spelling

2022-12-20 Thread GitBox
blueorangutan commented on PR #7002: URL: https://github.com/apache/cloudstack/pull/7002#issuecomment-1359404864 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7002 (QA-JID-20) -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1359402541 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] DaanHoogland commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1359400953 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #7002: Fix spelling

2022-12-20 Thread GitBox
DaanHoogland commented on PR #7002: URL: https://github.com/apache/cloudstack/pull/7002#issuecomment-1359396797 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] blueorangutan commented on pull request #7002: Fix spelling

2022-12-20 Thread GitBox
blueorangutan commented on PR #7002: URL: https://github.com/apache/cloudstack/pull/7002#issuecomment-1359393643 @DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To respond

[cloudstack] branch main updated: Support for parameter `cidrlist` added to the UI (#6869)

2022-12-20 Thread gutoveronezi
This is an automated email from the ASF dual-hosted git repository. gutoveronezi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 440d7805cb Support for parameter `cidrlist

[GitHub] [cloudstack] GutoVeronezi merged pull request #6869: Support for parameter `cidrlist` added to the UI

2022-12-20 Thread GitBox
GutoVeronezi merged PR #6869: URL: https://github.com/apache/cloudstack/pull/6869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] GutoVeronezi commented on pull request #6869: Support for parameter `cidrlist` added to the UI

2022-12-20 Thread GitBox
GutoVeronezi commented on PR #6869: URL: https://github.com/apache/cloudstack/pull/6869#issuecomment-1359392952 Merging this one based on the approvals and build result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] DaanHoogland commented on pull request #7002: Fix spelling

2022-12-20 Thread GitBox
DaanHoogland commented on PR #7002: URL: https://github.com/apache/cloudstack/pull/7002#issuecomment-1359392493 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [cloudstack] DaanHoogland commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6803: URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1359383170 the test failures for vmware are related to the fix in #7001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] blueorangutan commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-20 Thread GitBox
blueorangutan commented on PR #6803: URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1359383062 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack] DaanHoogland commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6803: URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1359382690 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] DaanHoogland commented on pull request #6661: Enable live volume migration for StorPool and small fixes

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6661: URL: https://github.com/apache/cloudstack/pull/6661#issuecomment-1359381953 @slavkap will you apply @GutoVeronezi's sugestions? I will give it one more run afterwards. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6661: Enable live volume migration for StorPool and small fixes

2022-12-20 Thread GitBox
DaanHoogland commented on code in PR #6661: URL: https://github.com/apache/cloudstack/pull/6661#discussion_r1053334394 ## test/integration/plugins/storpool/MigrateVolumeToStorPool.py: ## @@ -194,9 +194,12 @@ def setUpCloudStack(cls): securitygroup = SecurityGroup.list(c

[GitHub] [cloudstack] blueorangutan commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2022-12-20 Thread GitBox
blueorangutan commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1359369861 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + vmware-67u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack] DaanHoogland commented on pull request #6273: Add `pre-commit` workflow with 3 Git hooks

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6273: URL: https://github.com/apache/cloudstack/pull/6273#issuecomment-1359368535 @blueorangutan test centos7 vmware-67u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [cloudstack] rohityadavcloud opened a new issue, #7004: The 'LSI Logic Parallel' controller is not supported on Windows 10

2022-12-20 Thread GitBox
rohityadavcloud opened a new issue, #7004: URL: https://github.com/apache/cloudstack/issues/7004 The 'LSI Logic Parallel' controller' not supported on Windows 10 and may causes problems if we use it. https://kb.vmware.com/s/article/2004740 Please check if that's the case and should we

[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2022-12-20 Thread GitBox
sonarcloud[bot] commented on PR #7003: URL: https://github.com/apache/cloudstack/pull/7003#issuecomment-1359342858 SonarCloud Quality Gate failed.    [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality

[GitHub] [cloudstack] blueorangutan commented on pull request #6426: Configurable MTU for VR

2022-12-20 Thread GitBox
blueorangutan commented on PR #6426: URL: https://github.com/apache/cloudstack/pull/6426#issuecomment-1359329950 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5037 -- This is an automated message from the Apache

[GitHub] [cloudstack] JoaoJandre commented on a diff in pull request #6918: Override vr service offering

2022-12-20 Thread GitBox
JoaoJandre commented on code in PR #6918: URL: https://github.com/apache/cloudstack/pull/6918#discussion_r1053300957 ## framework/config/src/main/java/org/apache/cloudstack/framework/config/ConfigKey.java: ## @@ -34,7 +34,7 @@ public static final String CATEGORY_ALERT = "Al

[GitHub] [cloudstack] blueorangutan commented on pull request #7001: checksums for new macchinina ova template

2022-12-20 Thread GitBox
blueorangutan commented on PR #7001: URL: https://github.com/apache/cloudstack/pull/7001#issuecomment-1359328358 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + vmware-70u3) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] weizhouapache commented on pull request #7001: checksums for new macchinina ova template

2022-12-20 Thread GitBox
weizhouapache commented on PR #7001: URL: https://github.com/apache/cloudstack/pull/7001#issuecomment-1359327897 @blueorangutan test centos7 vmware-70u3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] blueorangutan commented on pull request #7001: checksums for new macchinina ova template

2022-12-20 Thread GitBox
blueorangutan commented on PR #7001: URL: https://github.com/apache/cloudstack/pull/7001#issuecomment-1359319408 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5036 -- This is an automated message from the Apache

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1359317973 Trillian test result (tid-5581) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 49035 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] blueorangutan commented on pull request #6991: [HEALTH] 4.18/main Health Check, please don't merge this!

2022-12-20 Thread GitBox
blueorangutan commented on PR #6991: URL: https://github.com/apache/cloudstack/pull/6991#issuecomment-1359315112 Trillian test result (tid-5582) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 48984 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] codecov[bot] commented on pull request #7002: Fix spelling

2022-12-20 Thread GitBox
codecov[bot] commented on PR #7002: URL: https://github.com/apache/cloudstack/pull/7002#issuecomment-1359305120 # [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7002?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+So

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6808: Allow privateips on console proxy

2022-12-20 Thread GitBox
DaanHoogland commented on code in PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#discussion_r1053258194 ## server/src/test/java/com/cloud/configuration/ConfigurationManagerImplTest.java: ## @@ -0,0 +1,178 @@ +package com.cloud.configuration; Review Comment: li

[GitHub] [cloudstack] weizhouapache opened a new pull request, #7003: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2022-12-20 Thread GitBox
weizhouapache opened a new pull request, #7003: URL: https://github.com/apache/cloudstack/pull/7003 ### Description CloudStack has used StandardPBEStringEncryptor from jasypt for more than 10 years. The encryptor use algorithm "PBEWithMD5AndDes", which is considered as Insecu

[cloudstack] 01/01: utils,framework/db: Introduce new database encryption cipher based on AesGcmJce

2022-12-20 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.18-new-cipher-aead in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 1f05d1b1165d66978ea870f04464b6d3a0b1951e Author: Wei Zhou AuthorDate: Tue Dec 20 13:15:41 2022 +0100

[cloudstack] branch 4.18-new-cipher-aead created (now 1f05d1b116)

2022-12-20 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.18-new-cipher-aead in repository https://gitbox.apache.org/repos/asf/cloudstack.git at 1f05d1b116 utils,framework/db: Introduce new database encryption cipher based on AesGcmJce This b

[GitHub] [cloudstack] blueorangutan commented on pull request #6808: Allow privateips on console proxy

2022-12-20 Thread GitBox
blueorangutan commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1359272401 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack] alexandremattioli commented on issue #6998: There is no secondary storage VM for system VM, start ssvm failed.

2022-12-20 Thread GitBox
alexandremattioli commented on issue #6998: URL: https://github.com/apache/cloudstack/issues/6998#issuecomment-1359271515 Also, I'd suggest you setup ACS with a trial version of ESX, get your zone up and running, make sure you understand all the requirements for an ACS Zone and then create

[GitHub] [cloudstack] DaanHoogland commented on pull request #6808: Allow privateips on console proxy

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6808: URL: https://github.com/apache/cloudstack/pull/6808#issuecomment-1359271505 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [cloudstack] alexandremattioli commented on issue #6998: There is no secondary storage VM for system VM, start ssvm failed.

2022-12-20 Thread GitBox
alexandremattioli commented on issue #6998: URL: https://github.com/apache/cloudstack/issues/6998#issuecomment-1359270448 Did you setup your physical networks for Public, Guest and Managemeng traffic? Did you assign an IP range for public traffic? -- This is an automated messag

[GitHub] [cloudstack] DaanHoogland commented on issue #6998: There is no secondary storage VM for system VM, start ssvm failed.

2022-12-20 Thread GitBox
DaanHoogland commented on issue #6998: URL: https://github.com/apache/cloudstack/issues/6998#issuecomment-1359267720 if all logical networks are on the same physical network you should only need one nic. I have no experience with hyperv, so I am not sure if there are extra requirements o

[GitHub] [cloudstack] blueorangutan commented on pull request #6426: Configurable MTU for VR

2022-12-20 Thread GitBox
blueorangutan commented on PR #6426: URL: https://github.com/apache/cloudstack/pull/6426#issuecomment-1359266821 @shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -- T

[GitHub] [cloudstack] shwstppr commented on pull request #6426: Configurable MTU for VR

2022-12-20 Thread GitBox
shwstppr commented on PR #6426: URL: https://github.com/apache/cloudstack/pull/6426#issuecomment-1359266443 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [cloudstack] github-actions[bot] commented on pull request #6755: Feature: Safely shutdown cloudstack

2022-12-20 Thread GitBox
github-actions[bot] commented on PR #6755: URL: https://github.com/apache/cloudstack/pull/6755#issuecomment-1359265669 This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. -- This is an automated message from the Apache Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #6803: ui,server,api: resource metrics improvements

2022-12-20 Thread GitBox
blueorangutan commented on PR #6803: URL: https://github.com/apache/cloudstack/pull/6803#issuecomment-1359262704 Trillian test result (tid-5579) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 53238 seconds Marvin logs: https://github.com/blue

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6661: Enable live volume migration for StorPool and small fixes

2022-12-20 Thread GitBox
GutoVeronezi commented on code in PR #6661: URL: https://github.com/apache/cloudstack/pull/6661#discussion_r1053233971 ## plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/provider/StorPoolHostListener.java: ## @@ -164,10 +163,25 @@ public boo

[GitHub] [cloudstack] blueorangutan commented on pull request #7001: checksums for new macchinina ova template

2022-12-20 Thread GitBox
blueorangutan commented on PR #7001: URL: https://github.com/apache/cloudstack/pull/7001#issuecomment-1359252916 @DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] DaanHoogland commented on pull request #7001: checksums for new macchinina ova template

2022-12-20 Thread GitBox
DaanHoogland commented on PR #7001: URL: https://github.com/apache/cloudstack/pull/7001#issuecomment-1359252674 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [cloudstack] DaanHoogland commented on pull request #6348: Improving code related to the Agent properties

2022-12-20 Thread GitBox
DaanHoogland commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1359251776 > @DaanHoogland @GutoVeronezi I couldn't finish my review yet but it looks good so far! I would like to double check the agent.properties refactor so we don't miss any existing pr

[GitHub] [cloudstack] DaanHoogland commented on issue #7000: Prometheus integration ignores capacity_state

2022-12-20 Thread GitBox
DaanHoogland commented on issue #7000: URL: https://github.com/apache/cloudstack/issues/7000#issuecomment-1359250620 @benj-n can you look at #5773 it might do what you need (for 4.18 hopefully) -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack] nvazquez commented on pull request #6348: Improving code related to the Agent properties

2022-12-20 Thread GitBox
nvazquez commented on PR #6348: URL: https://github.com/apache/cloudstack/pull/6348#issuecomment-1359248970 @DaanHoogland @GutoVeronezi I couldn't finish my review yet but it looks good so far! I would like to double check the agent.properties refactor so we don't miss any existing property

[GitHub] [cloudstack] jbampton opened a new pull request, #7002: Fix spelling

2022-12-20 Thread GitBox
jbampton opened a new pull request, #7002: URL: https://github.com/apache/cloudstack/pull/7002 ### Description This PR fixes spelling ### Types of changes - [ ] Breaking change (fix or feature that would cause existing

[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6809: Reserve memory for host

2022-12-20 Thread GitBox
GutoVeronezi commented on code in PR #6809: URL: https://github.com/apache/cloudstack/pull/6809#discussion_r1053229339 ## server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java: ## @@ -472,6 +472,8 @@ public class ConfigurationManagerImpl extends ManagerBase

[cloudstack] branch main updated: Metrics plugin: expose full domain path instead of name (#6959)

2022-12-20 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new cc676cbc83 Metrics plugin: expose full domain path

[GitHub] [cloudstack] boring-cyborg[bot] commented on pull request #6959: Metrics plugin: expose full domain path instead of name

2022-12-20 Thread GitBox
boring-cyborg[bot] commented on PR #6959: URL: https://github.com/apache/cloudstack/pull/6959#issuecomment-1359240156 Awesome work, congrats on your first merged pull request! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [cloudstack] DaanHoogland merged pull request #6959: Metrics plugin: expose full domain path instead of name

2022-12-20 Thread GitBox
DaanHoogland merged PR #6959: URL: https://github.com/apache/cloudstack/pull/6959 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cl

[GitHub] [cloudstack] DaanHoogland closed issue #6859: Exported metrics have a domain instead of the full path

2022-12-20 Thread GitBox
DaanHoogland closed issue #6859: Exported metrics have a domain instead of the full path URL: https://github.com/apache/cloudstack/issues/6859 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

  1   2   >