[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.

2022-02-28 Thread GitBox
blueorangutan commented on pull request #6050: URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055121293 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2734 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.

2022-02-28 Thread GitBox
blueorangutan commented on pull request #6050: URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055099525 @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack] sureshanaparti commented on pull request #6050: Check the network access when deploying VM in Advanced Security Group.

2022-02-28 Thread GitBox
sureshanaparti commented on pull request #6050: URL: https://github.com/apache/cloudstack/pull/6050#issuecomment-1055099103 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] sureshanaparti opened a new pull request #6050: Check the network access when deploying VM in Advanced Security Group.

2022-02-28 Thread GitBox
sureshanaparti opened a new pull request #6050: URL: https://github.com/apache/cloudstack/pull/6050 ### Description This PR checks the network access when deploying VM in Advanced Security Group. ### Types of changes

[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055030759 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2733 -- This is an automated message from

[GitHub] [cloudstack] sureshanaparti commented on issue #6030: GSoC 2022 Idea: Report / Manage the VM jobs in CloudStack.

2022-02-28 Thread GitBox
sureshanaparti commented on issue #6030: URL: https://github.com/apache/cloudstack/issues/6030#issuecomment-1055027526 Hi @damanBirSingh Thanks for your interest in this idea. You can reach out to us, for any guidance on CloudStack, the idea or the draft proposal. -- This is

[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055008659 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
davidjumani commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055007906 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055005111 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1199) -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055000836 @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
davidjumani commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1055000281 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [cloudstack] Damans227 edited a comment on issue #6016: GSoC 2022: CloudStack Terraform Provider - Add datasources for the existing resources

2022-02-28 Thread GitBox
Damans227 edited a comment on issue #6016: URL: https://github.com/apache/cloudstack/issues/6016#issuecomment-1054904064 Hi @Pearl1594 @harikrishna-patnala I have revised the draft of my design document based on the feedback I've received earlier, and it now looks pretty close to what I am

[GitHub] [cloudstack] Damans227 edited a comment on issue #6016: GSoC 2022: CloudStack Terraform Provider - Add datasources for the existing resources

2022-02-28 Thread GitBox
Damans227 edited a comment on issue #6016: URL: https://github.com/apache/cloudstack/issues/6016#issuecomment-1054904064 Hi @Pearl1594 @harikrishna-patnala I have revised the draft of my design document based on the feedback I've received earlier, and it now looks pretty close to what I am

[GitHub] [cloudstack] Damans227 commented on issue #6016: GSoC 2022: CloudStack Terraform Provider - Add datasources for the existing resources

2022-02-28 Thread GitBox
Damans227 commented on issue #6016: URL: https://github.com/apache/cloudstack/issues/6016#issuecomment-1054904064 Hi @Pearl1594 @harikrishna-patnala I have revised the draft of my design document based on the feedback I've received earlier, and it now looks pretty close to what I am planni

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1054834985 Trillian test result (tid-3450) Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7 Total time taken: 34065 seconds Marvin logs: https://gith

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1054811424 Trillian test result (tid-3449) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31415 seconds Marvin logs: https://gith

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1054803011 Trillian test result (tid-3448) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31055 seconds Marvin logs: https://git

[GitHub] [cloudstack] weizhouapache commented on issue #6049: CloudStack allows deploying VMs on Networks that should not be accessed by VM's owner

2022-02-28 Thread GitBox
weizhouapache commented on issue #6049: URL: https://github.com/apache/cloudstack/issues/6049#issuecomment-1054542890 > Thanks for raising that PR, @weizhouapache. > > I have not dug deeper into your PR, so I might be missing another context beyond the lines you presented here. Pleas

[GitHub] [cloudstack] neogismm edited a comment on issue #4834: GSoC 2022 Idea: CloudStack OAuth2 Plugin

2022-02-28 Thread GitBox
neogismm edited a comment on issue #4834: URL: https://github.com/apache/cloudstack/issues/4834#issuecomment-1050907031 I also have a few questions: 1. What if someone tries to sign in who is not yet authorized from the admin (new user). Should the new user be granted access at all or se

[GitHub] [cloudstack] rohityadavcloud commented on issue #5770: Choose storage location for Snapshots

2022-02-28 Thread GitBox
rohityadavcloud commented on issue #5770: URL: https://github.com/apache/cloudstack/issues/5770#issuecomment-1054530160 > we have the problem that in 1 secondary storage there isn't enough space and ACS tries to save snapshots there. @soptecsn this is no longer an issue after the new

[GitHub] [cloudstack] slavkap commented on a change in pull request #6007: StorPool storage plugin

2022-02-28 Thread GitBox
slavkap commented on a change in pull request #6007: URL: https://github.com/apache/cloudstack/pull/6007#discussion_r816128986 ## File path: plugins/storage/volume/storpool/src/main/java/org/apache/cloudstack/storage/datastore/util/StorpoolUtil.java ## @@ -0,0 +1,610 @@ +/* +

[cloudstack-www] 01/01: Merge remote-tracking branch 'apache-github/main' into asf-site

2022-02-28 Thread gutoveronezi
This is an automated email from the ASF dual-hosted git repository. gutoveronezi pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit 62cb2d8e74b405ba950e897eb852ef808afdb150 Merge: 30cd0dc 3f54d85 Author: GutoVeronezi AuthorDate: Mon Feb

[cloudstack-www] branch asf-site updated (30cd0dc -> 62cb2d8)

2022-02-28 Thread gutoveronezi
This is an automated email from the ASF dual-hosted git repository. gutoveronezi pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git. from 30cd0dc Merge remote-tracking branch 'origin/main' into asf-site add 708da84 Fix commiters not

[cloudstack-www] branch main updated: updated PR #89 to include compiled content

2022-02-28 Thread gutoveronezi
This is an automated email from the ASF dual-hosted git repository. gutoveronezi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/main by this push: new 3f54d85 updated PR #89 to include com

[cloudstack-www] branch main updated: Fix commiters not being shown on page who (#89)

2022-02-28 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/main by this push: new 708da84 Fix commiters not being shown on pag

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5909: Quota custom tariffs

2022-02-28 Thread GitBox
DaanHoogland commented on a change in pull request #5909: URL: https://github.com/apache/cloudstack/pull/5909#discussion_r816026617 ## File path: framework/quota/src/test/java/org/apache/cloudstack/quota/constant/QuotaTypesTest.java ## @@ -43,6 +43,6 @@ public void testQuotaTy

[GitHub] [cloudstack] GabrielBrascher commented on issue #6049: CloudStack allows deploying VMs on Networks that should not be accessed by VM's owner

2022-02-28 Thread GitBox
GabrielBrascher commented on issue #6049: URL: https://github.com/apache/cloudstack/issues/6049#issuecomment-1054456499 Thanks for raising that PR, @weizhouapache. I have not dug deeper into your PR, so I might be missing another context beyond the lines you presented here. Please

[GitHub] [cloudstack] weizhouapache commented on issue #6049: CloudStack allows deploying VMs on Networks that should not be accessed by VM's owner

2022-02-28 Thread GitBox
weizhouapache commented on issue #6049: URL: https://github.com/apache/cloudstack/issues/6049#issuecomment-1054422439 @GabrielBrascher oh, I have found the issue and fixed in #5769 , but never created PR for it [server/src/main/java/com/cloud/vm/UserVmManagerImpl.java](https

[GitHub] [cloudstack] weizhouapache commented on issue #6049: CloudStack allows deploying VMs on Networks that should not be accessed by VM's owner

2022-02-28 Thread GitBox
weizhouapache commented on issue #6049: URL: https://github.com/apache/cloudstack/issues/6049#issuecomment-1054413218 @GabrielBrascher I have fixed a similar issue but with L2 network in #5784 what type of network do you use ? -- This is an automated message from the Apach

[GitHub] [cloudstack] GabrielBrascher commented on issue #6049: CloudStack allows deploying VMs on Networks that should not be accessed by VM's owner

2022-02-28 Thread GitBox
GabrielBrascher commented on issue #6049: URL: https://github.com/apache/cloudstack/issues/6049#issuecomment-1054382323 @PaulAngus yes, it can be a normal User calling the API and the VM will be deployed on any network, regardless of the owner/domain of the network. Normal users are

[GitHub] [cloudstack] PaulAngus commented on issue #6049: CloudStack allows deploying VMs on Networks that should not be accessed by VM's owner

2022-02-28 Thread GitBox
PaulAngus commented on issue #6049: URL: https://github.com/apache/cloudstack/issues/6049#issuecomment-1054372430 Can you do this by using the UUID as a normal user from an account that should not be able to see this network? -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] JoaoJandre commented on a change in pull request #6048: Refactor account type

2022-02-28 Thread GitBox
JoaoJandre commented on a change in pull request #6048: URL: https://github.com/apache/cloudstack/pull/6048#discussion_r815981665 ## File path: api/src/main/java/com/cloud/user/Account.java ## @@ -16,35 +16,55 @@ // under the License. package com.cloud.user; -import java.ut

[GitHub] [cloudstack] BryanMLima commented on pull request #6031: Update VM priority (cpu_shares) when live scaling it

2022-02-28 Thread GitBox
BryanMLima commented on pull request #6031: URL: https://github.com/apache/cloudstack/pull/6031#issuecomment-1054358545 The error was caused while trying to download a Template, so it had no relation to the code itself. ![image](https://user-images.githubusercontent.com/42067040/1560076

[GitHub] [cloudstack] GabrielBrascher opened a new issue #6049: CloudStack allows deploying VMs on Networks that should not be accessed by VM's owner

2022-02-28 Thread GitBox
GabrielBrascher opened a new issue #6049: URL: https://github.com/apache/cloudstack/issues/6049 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ (probably affects also versions before 4.15, bu

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #6048: Refactor account type

2022-02-28 Thread GitBox
DaanHoogland commented on a change in pull request #6048: URL: https://github.com/apache/cloudstack/pull/6048#discussion_r815956513 ## File path: api/src/test/java/com/cloud/user/AccountTypeTest.java ## @@ -0,0 +1,36 @@ +package com.cloud.user; Review comment: license

[GitHub] [cloudstack] blueorangutan commented on pull request #6031: Update VM priority (cpu_shares) when live scaling it

2022-02-28 Thread GitBox
blueorangutan commented on pull request #6031: URL: https://github.com/apache/cloudstack/pull/6031#issuecomment-1054324455 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2730 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1054303851 @nvazquez a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is an au

[GitHub] [cloudstack] nvazquez commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-02-28 Thread GitBox
nvazquez commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1054303041 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] JoaoJandre opened a new pull request #6048: Refactor account type

2022-02-28 Thread GitBox
JoaoJandre opened a new pull request #6048: URL: https://github.com/apache/cloudstack/pull/6048 ### Description This PR aims to refactor the Account class by changing both the account type and the account state to de facto enums to facilitate future ACS development. Moreover, the us

[GitHub] [cloudstack] blueorangutan commented on pull request #6031: Update VM priority (cpu_shares) when live scaling it

2022-02-28 Thread GitBox
blueorangutan commented on pull request #6031: URL: https://github.com/apache/cloudstack/pull/6031#issuecomment-1054282850 @BryanMLima a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To

[GitHub] [cloudstack] BryanMLima commented on pull request #6031: Update VM priority (cpu_shares) when live scaling it

2022-02-28 Thread GitBox
BryanMLima commented on pull request #6031: URL: https://github.com/apache/cloudstack/pull/6031#issuecomment-1054282102 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #5965: Multiple SSH Keys support

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5965: URL: https://github.com/apache/cloudstack/pull/5965#issuecomment-1054273985 Trillian test result (tid-3446) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31716 seconds Marvin logs: https://gith

[GitHub] [cloudstack] damanBirSingh commented on issue #6030: GSoC 2022 Idea: Report / Manage the VM jobs in CloudStack.

2022-02-28 Thread GitBox
damanBirSingh commented on issue #6030: URL: https://github.com/apache/cloudstack/issues/6030#issuecomment-1054232901 Hello Everyone, I am Daman Bir Singh, an gradute student and I would like to put forth a proposal for this particular issue and work on building a solution. I ha

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1054222482 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2729 -- This is an automated message from

[GitHub] [cloudstack] nvazquez commented on pull request #5297: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2022-02-28 Thread GitBox
nvazquez commented on pull request #5297: URL: https://github.com/apache/cloudstack/pull/5297#issuecomment-1054209611 Yes @GutoVeronezi we are working on updating it on Trillian for KVM tests -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [cloudstack] blueorangutan commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1054193317 @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack] sureshanaparti commented on pull request #5811: [HEALTH] 4.17 Health Check please don't merge this

2022-02-28 Thread GitBox
sureshanaparti commented on pull request #5811: URL: https://github.com/apache/cloudstack/pull/5811#issuecomment-1054192649 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] davidjumani closed issue #6036: GSoC 2022 Idea: Make CloudStack aware of Unmanaged Kubernetes Clusters

2022-02-28 Thread GitBox
davidjumani closed issue #6036: URL: https://github.com/apache/cloudstack/issues/6036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsu

[GitHub] [cloudstack] GutoVeronezi commented on pull request #5297: KVM disk-only based snapshot of volumes instead of taking VM's full snapshot and extracting disks

2022-02-28 Thread GitBox
GutoVeronezi commented on pull request #5297: URL: https://github.com/apache/cloudstack/pull/5297#issuecomment-1054190355 @nvazquez CI errors are related to the QEMU binary (see https://github.com/apache/cloudstack/pull/5297#issuecomment-940007442). -- This is an automated message from t

[GitHub] [cloudstack] harikrishna-patnala commented on issue #4825: GSoC 2022 Idea: Mapping existing configuration parameters to the APIs

2022-02-28 Thread GitBox
harikrishna-patnala commented on issue #4825: URL: https://github.com/apache/cloudstack/issues/4825#issuecomment-1054128840 Okay @rohityadavcloud makes sense. I'll take it out from GSoC. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [cloudstack] NuxRo opened a new issue #6047: GSoC 2022 Idea: Autodetect IPs used inside the VM

2022-02-28 Thread GitBox
NuxRo opened a new issue #6047: URL: https://github.com/apache/cloudstack/issues/6047 With regards to IP info reporting, Cloudstack relies entirely on it's DHCP data bases and so on. When this is not available (L2 networks etc) no IP information is shown for a given VM. I propose we

[GitHub] [cloudstack] weizhouapache commented on pull request #6046: New feature: Reserve and release Public IPs

2022-02-28 Thread GitBox
weizhouapache commented on pull request #6046: URL: https://github.com/apache/cloudstack/pull/6046#issuecomment-1054080965 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] weizhouapache opened a new pull request #6046: New feature: Reserve and release Public IPs

2022-02-28 Thread GitBox
weizhouapache opened a new pull request #6046: URL: https://github.com/apache/cloudstack/pull/6046 ### Description This PR provides a new feature to reserve public IPs and release them. (1) new Public IP state: Reserved (2) new API: reserveipaddress and releaseipaddress (3) R

[GitHub] [cloudstack] Yashikaone commented on issue #6021: GSoC 2022 Idea: Add the ability to Safely Shutdown / restart CloudStack

2022-02-28 Thread GitBox
Yashikaone commented on issue #6021: URL: https://github.com/apache/cloudstack/issues/6021#issuecomment-1054073787 Thank you @davidjumani -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
rohityadavcloud commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054059132 Few nits, @utchoang @davidjumani cc @nvazquez pl also test as normal user account and domain accounts. Notes: - Worth hiding removing the blue gear/button for a

[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054046481 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1196) -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054041718 @rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Servi

[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
rohityadavcloud commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054041476 @blueorangutan ui -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054040437 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2728 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054011884 @davidjumani a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
davidjumani commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1054009697 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] davidjumani removed a comment on pull request #6045: Honour isrecursive above listall

2022-02-28 Thread GitBox
davidjumani removed a comment on pull request #6045: URL: https://github.com/apache/cloudstack/pull/6045#issuecomment-1054006809 @DaanHoogland Good point! I'll make the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] davidjumani commented on pull request #6045: Honour isrecursive above listall

2022-02-28 Thread GitBox
davidjumani commented on pull request #6045: URL: https://github.com/apache/cloudstack/pull/6045#issuecomment-1054006809 @DaanHoogland Good point! I'll make the changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cloudstack] davidjumani removed a comment on pull request #6045: Honour isrecursive above listall

2022-02-28 Thread GitBox
davidjumani removed a comment on pull request #6045: URL: https://github.com/apache/cloudstack/pull/6045#issuecomment-1054005921 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [cloudstack] davidjumani commented on pull request #6045: Honour isrecursive above listall

2022-02-28 Thread GitBox
davidjumani commented on pull request #6045: URL: https://github.com/apache/cloudstack/pull/6045#issuecomment-1054005921 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [cloudstack] DaanHoogland commented on pull request #6045: Honour isrecursive above listall

2022-02-28 Thread GitBox
DaanHoogland commented on pull request #6045: URL: https://github.com/apache/cloudstack/pull/6045#issuecomment-1054001247 @davidjumani , would it make sense to let `isRecursive()` return a different default value, depending on whether `listall` is given? this seems like a very elaborate wa

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5848: Feat/add vdisk UUID to list volume

2022-02-28 Thread GitBox
DaanHoogland commented on a change in pull request #5848: URL: https://github.com/apache/cloudstack/pull/5848#discussion_r815655866 ## File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql ## @@ -220,6 +220,10 @@ CREATE VIEW `cloud`.`service_offering_v

[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053994759 UI build: :heavy_check_mark: Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5151 (SL-JID-1195) -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] blueorangutan commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
blueorangutan commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053990586 @davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] davidjumani commented on pull request #5151: UI: Upgrade to Vue3 library

2022-02-28 Thread GitBox
davidjumani commented on pull request #5151: URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1053990261 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To