[GitHub] [cloudstack] blueorangutan commented on pull request #5721: Fix NPE on scale VM operation after the corresponding template is del…

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5721: URL: https://github.com/apache/cloudstack/pull/5721#issuecomment-979754154 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1791 -- This is an automated message from

[GitHub] [cloudstack] sureshanaparti closed pull request #5720: Removed redundant call for VM snapshot chain size, in VMware.

2021-11-25 Thread GitBox
sureshanaparti closed pull request #5720: URL: https://github.com/apache/cloudstack/pull/5720 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: comm

[GitHub] [cloudstack] blueorangutan commented on pull request #5680: [Veeam] Fix full backup VM restore exception

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5680: URL: https://github.com/apache/cloudstack/pull/5680#issuecomment-979741362 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1790 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5720: Removed redundant call for VM snapshot chain size, in VMware.

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5720: URL: https://github.com/apache/cloudstack/pull/5720#issuecomment-979735702 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1789 -- This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on pull request #5721: Fix NPE on scale VM operation after the corresponding template is del…

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5721: URL: https://github.com/apache/cloudstack/pull/5721#issuecomment-979735166 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. To re

[GitHub] [cloudstack] shwstppr commented on pull request #5721: Fix NPE on scale VM operation after the corresponding template is del…

2021-11-25 Thread GitBox
shwstppr commented on pull request #5721: URL: https://github.com/apache/cloudstack/pull/5721#issuecomment-979734897 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [cloudstack] harikrishna-patnala opened a new pull request #5721: Fix NPE on scale VM operation after the corresponding template is del…

2021-11-25 Thread GitBox
harikrishna-patnala opened a new pull request #5721: URL: https://github.com/apache/cloudstack/pull/5721 ### Description This PR fixes issue #5719 NPE during scale VM operation on a VM for which the corresponding template is already deleted.

[cloudstack] branch FixScaleVMNPE created (now 7b73863)

2021-11-25 Thread harikrishna
This is an automated email from the ASF dual-hosted git repository. harikrishna pushed a change to branch FixScaleVMNPE in repository https://gitbox.apache.org/repos/asf/cloudstack.git. at 7b73863 Fix NPE on scale VM operation after the corresponding template is deleted This branch incl

[cloudstack] 01/01: Fix NPE on scale VM operation after the corresponding template is deleted

2021-11-25 Thread harikrishna
This is an automated email from the ASF dual-hosted git repository. harikrishna pushed a commit to branch FixScaleVMNPE in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit 7b73863312b643b3482202b8a053cb7b6e62bc8a Author: Harikrishna Patnala AuthorDate: Fri Nov 26 11:59:36 202

[GitHub] [cloudstack] harikrishna-patnala commented on issue #5719: Cannot scale VM with deleted template

2021-11-25 Thread GitBox
harikrishna-patnala commented on issue #5719: URL: https://github.com/apache/cloudstack/issues/5719#issuecomment-979719200 There is force delete option for templates @sureshanaparti. This looks like a genuine issue I could reproduce it. -- This is an automated message from the Apache Git

[GitHub] [cloudstack] blueorangutan commented on pull request #5008: Decouple service (compute) offering and disk offering

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-979717869 @sureshanaparti a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests -- This is

[GitHub] [cloudstack] blueorangutan commented on pull request #5680: [Veeam] Fix full backup VM restore exception

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5680: URL: https://github.com/apache/cloudstack/pull/5680#issuecomment-979717476 @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] sureshanaparti commented on pull request #5008: Decouple service (compute) offering and disk offering

2021-11-25 Thread GitBox
sureshanaparti commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-979717459 @blueorangutan test matrix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] sureshanaparti commented on pull request #5680: [Veeam] Fix full backup VM restore exception

2021-11-25 Thread GitBox
sureshanaparti commented on pull request #5680: URL: https://github.com/apache/cloudstack/pull/5680#issuecomment-979717141 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] blueorangutan commented on pull request #5720: Removed redundant call for VM snapshot chain size, in VMware.

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5720: URL: https://github.com/apache/cloudstack/pull/5720#issuecomment-979713627 @sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] sureshanaparti commented on pull request #5720: Removed redundant call for VM snapshot chain size, in VMware.

2021-11-25 Thread GitBox
sureshanaparti commented on pull request #5720: URL: https://github.com/apache/cloudstack/pull/5720#issuecomment-979713343 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] sureshanaparti opened a new pull request #5720: Removed redundant call for VM snapshot chain size, in VMware.

2021-11-25 Thread GitBox
sureshanaparti opened a new pull request #5720: URL: https://github.com/apache/cloudstack/pull/5720 ### Description This PR removes redundant call for VM snapshot chain size, in VMware. ### Types of changes - [ ] Br

[GitHub] [cloudstack] sureshanaparti commented on issue #5719: Cannot scale VM with deleted template

2021-11-25 Thread GitBox
sureshanaparti commented on issue #5719: URL: https://github.com/apache/cloudstack/issues/5719#issuecomment-979708731 Hi @alexandru-bagu Are you able to delete the template when a VM exists / using that template? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] alexandru-bagu opened a new issue #5719: Cannot scale VM with deleted template

2021-11-25 Thread GitBox
alexandru-bagu opened a new issue #5719: URL: https://github.com/apache/cloudstack/issues/5719 CS version 4.16.0 Error occurs here: ``` java.lang.NullPointerException at com.cloud.vm.UserVmManagerImpl.checkIfDynamicScalingCanBeEnabled(UserVmManagerImpl.java:4138)

[cloudstack] branch 4.16 updated: server bug fix: remove network details when network is removed (#5675)

2021-11-25 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a commit to branch 4.16 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.16 by this push: new 965316b server bug fix: remove network details

[GitHub] [cloudstack] weizhouapache merged pull request #5675: server bug fix: remove network details when network is removed

2021-11-25 Thread GitBox
weizhouapache merged pull request #5675: URL: https://github.com/apache/cloudstack/pull/5675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [cloudstack] weizhouapache commented on pull request #5675: server bug fix: remove network details when network is removed

2021-11-25 Thread GitBox
weizhouapache commented on pull request #5675: URL: https://github.com/apache/cloudstack/pull/5675#issuecomment-979452254 Merged based on 3 approvals and trillian test result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [cloudstack] blueorangutan commented on pull request #5701: server: update capacity_state of host cpu core after disable/enable a host

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5701: URL: https://github.com/apache/cloudstack/pull/5701#issuecomment-979452203 @weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service

[GitHub] [cloudstack] weizhouapache commented on pull request #5701: server: update capacity_state of host cpu core after disable/enable a host

2021-11-25 Thread GitBox
weizhouapache commented on pull request #5701: URL: https://github.com/apache/cloudstack/pull/5701#issuecomment-979451733 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] blueorangutan commented on pull request #5588: Mshost stats

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5588: URL: https://github.com/apache/cloudstack/pull/5588#issuecomment-979358819 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1788 -- This is an automated message from

[cloudstack] branch main updated: Fix HostMetricsResponse unit test (#5713)

2021-11-25 Thread gutoveronezi
This is an automated email from the ASF dual-hosted git repository. gutoveronezi pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/main by this push: new 6e04f87 Fix HostMetricsResponse unit test

[GitHub] [cloudstack] GutoVeronezi merged pull request #5713: Fix HostMetricsResponse unit test

2021-11-25 Thread GitBox
GutoVeronezi merged pull request #5713: URL: https://github.com/apache/cloudstack/pull/5713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

[GitHub] [cloudstack] GutoVeronezi commented on pull request #5713: Fix HostMetricsResponse unit test

2021-11-25 Thread GitBox
GutoVeronezi commented on pull request #5713: URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-979225718 Merging based on 2x LGTM (https://github.com/apache/cloudstack/pull/5713#pullrequestreview-815700415 and https://github.com/apache/cloudstack/pull/5713#pullrequestreview

[GitHub] [cloudstack] joseflauzino commented on pull request #5713: Fix HostMetricsResponse unit test

2021-11-25 Thread GitBox
joseflauzino commented on pull request #5713: URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-979225118 @DaanHoogland we can keep in main (4.17). Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cloudstack] rhtyd commented on pull request #5602: Create profiles to download systemvm-templates

2021-11-25 Thread GitBox
rhtyd commented on pull request #5602: URL: https://github.com/apache/cloudstack/pull/5602#issuecomment-979157737 We're coming with a new design doc that will reduce the cloudstack-management pkg by more than 1GB in size and introduce a single mvn flag that will bundle a template for only

[GitHub] [cloudstack] rhtyd commented on pull request #4276: ListAll including VMs in projects for ADMIN

2021-11-25 Thread GitBox
rhtyd commented on pull request #4276: URL: https://github.com/apache/cloudstack/pull/4276#issuecomment-979153747 @GabrielBrascher changed the milestone based on base `main` branch, if this is 4.16 pl fix PR base branch and advise. -- This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] blueorangutan commented on pull request #5701: server: update capacity_state of host cpu core after disable/enable a host

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5701: URL: https://github.com/apache/cloudstack/pull/5701#issuecomment-979146771 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1787 -- This is an automated message from

[cloudstack] branch 4.16 updated (a85a00b -> 2b54b58)

2021-11-25 Thread weizhou
This is an automated email from the ASF dual-hosted git repository. weizhou pushed a change to branch 4.16 in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from a85a00b kvm: Fixes UEFI XML Definition Error (#5692) add 2b54b58 engine/schema: fix findActiveAccountById i

[GitHub] [cloudstack] blueorangutan commented on pull request #5701: server: update capacity_state of host cpu core after disable/enable a host

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5701: URL: https://github.com/apache/cloudstack/pull/5701#issuecomment-979112093 @weizhouapache a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] weizhouapache commented on pull request #5701: server: update capacity_state of host cpu core after disable/enable a host

2021-11-25 Thread GitBox
weizhouapache commented on pull request #5701: URL: https://github.com/apache/cloudstack/pull/5701#issuecomment-979111451 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] weizhouapache merged pull request #5704: engine/schema: fix findActiveAccountById in AccountDaoImpl.java

2021-11-25 Thread GitBox
weizhouapache merged pull request #5704: URL: https://github.com/apache/cloudstack/pull/5704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commi

[GitHub] [cloudstack] weizhouapache commented on pull request #5704: engine/schema: fix findActiveAccountById in AccountDaoImpl.java

2021-11-25 Thread GitBox
weizhouapache commented on pull request #5704: URL: https://github.com/apache/cloudstack/pull/5704#issuecomment-979110661 Merged based on 2 approvals and trillian test result -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [cloudstack] DaanHoogland commented on pull request #5704: engine/schema: fix findActiveAccountById in AccountDaoImpl.java

2021-11-25 Thread GitBox
DaanHoogland commented on pull request #5704: URL: https://github.com/apache/cloudstack/pull/5704#issuecomment-979065175 > > @weizhouapache code looks ok, but what is the sense of searching for a bunch of fields _and_ the id. The id is unique so this search makes no sense to me. Do you kno

[GitHub] [cloudstack] blueorangutan commented on pull request #5008: Decouple service (compute) offering and disk offering

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-979063878 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1786 -- This is an automated message from

[GitHub] [cloudstack] DaanHoogland commented on pull request #5713: Fix HostMetricsResponse unit test

2021-11-25 Thread GitBox
DaanHoogland commented on pull request #5713: URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-979058995 @joseflauzino if you want this in 4.16.1 please rebase. otherwise just wait for a second review and we are good to merge. -- This is an automated message from the Apac

[GitHub] [cloudstack] blueorangutan commented on pull request #5008: Decouple service (compute) offering and disk offering

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-979031170 @harikrishna-patnala a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Ser

[GitHub] [cloudstack] harikrishna-patnala commented on pull request #5008: Decouple service (compute) offering and disk offering

2021-11-25 Thread GitBox
harikrishna-patnala commented on pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#issuecomment-979030809 @blueorangutan package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #5008: Decouple service (compute) offering and disk offering

2021-11-25 Thread GitBox
harikrishna-patnala commented on a change in pull request #5008: URL: https://github.com/apache/cloudstack/pull/5008#discussion_r756720190 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@ -2857,7 +2857,7 @@ private DiskOfferingVO c

[GitHub] [cloudstack] weizhouapache commented on pull request #5704: engine/schema: fix findActiveAccountById in AccountDaoImpl.java

2021-11-25 Thread GitBox
weizhouapache commented on pull request #5704: URL: https://github.com/apache/cloudstack/pull/5704#issuecomment-979020367 > @weizhouapache code looks ok, but what is the sense of searching for a bunch of fields _and_ the id. The id is unique so this search makes no sense to me. Do you know

[GitHub] [cloudstack] blueorangutan commented on pull request #5713: Fix HostMetricsResponse unit test

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5713: URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-979016151 Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 1785 -- This is an automated message from

[GitHub] [cloudstack] DaanHoogland commented on pull request #5704: engine/schema: fix findActiveAccountById in AccountDaoImpl.java

2021-11-25 Thread GitBox
DaanHoogland commented on pull request #5704: URL: https://github.com/apache/cloudstack/pull/5704#issuecomment-978983296 @weizhouapache code looks ok, but what is the sense of searching for a bunch of fields *and* the id. The id is unique so this search makes no sense to me. Do you know ho

[GitHub] [cloudstack] ravening closed pull request #5687: db: Avoid db locks if account resource limit is -1

2021-11-25 Thread GitBox
ravening closed pull request #5687: URL: https://github.com/apache/cloudstack/pull/5687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-un

[GitHub] [cloudstack] ravening commented on a change in pull request #5687: db: Avoid db locks if account resource limit is -1

2021-11-25 Thread GitBox
ravening commented on a change in pull request #5687: URL: https://github.com/apache/cloudstack/pull/5687#discussion_r756681894 ## File path: server/src/main/java/com/cloud/resourcelimit/ResourceLimitManagerImpl.java ## @@ -521,13 +520,21 @@ public void checkResourceLimit(fina

[GitHub] [cloudstack] blueorangutan commented on pull request #5713: Fix HostMetricsResponse unit test

2021-11-25 Thread GitBox
blueorangutan commented on pull request #5713: URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-978964718 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -- This is an automated message from the Apache Git Service. T

[GitHub] [cloudstack] DaanHoogland commented on pull request #5713: Fix HostMetricsResponse unit test

2021-11-25 Thread GitBox
DaanHoogland commented on pull request #5713: URL: https://github.com/apache/cloudstack/pull/5713#issuecomment-978964354 If packaging succeeds it compiles and the test is good. No testing needed as it is a unit test only. @blueorangutan package -- This is an automated message from the