[GitHub] [cloudstack] Spaceman1984 commented on issue #4310: SystemVMs Publics IPs offered to accounts despite global settings

2020-10-13 Thread GitBox
Spaceman1984 commented on issue #4310: URL: https://github.com/apache/cloudstack/issues/4310#issuecomment-708202487 Seems like IP addresses are presented but you cannot actually select it. I have set up a few ranges and dedicated 2 ranges to system VMs and 1 range to an account.

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4389: Fixed vm-templates not being removed from primary storage with storag…

2020-10-13 Thread GitBox
Spaceman1984 commented on pull request #4389: URL: https://github.com/apache/cloudstack/pull/4389#issuecomment-708161496 @andrijapanicsb, I agree with @nvazquez. This is an automated message from the Apache Git Service. To r

[GitHub] [cloudstack] nvazquez commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-13 Thread GitBox
nvazquez commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-708102858 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] hstan77 opened a new issue #4403: Support for Linstore

2020-10-13 Thread GitBox
hstan77 opened a new issue #4403: URL: https://github.com/apache/cloudstack/issues/4403 # ISSUE TYPE * Feature Idea # COMPONENT NAME ~~~ Storage Support for Linstor ~~~ # CLOUDSTACK VERSION ~~~ All Version ~~~

[GitHub] [cloudstack] nvazquez commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-13 Thread GitBox
nvazquez commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-708032733 @blueorangutan test centos7 vmware-67u3 This is an automated message from the Apache Git Service. To respond

[GitHub] [cloudstack] blueorangutan commented on pull request #4397: List VMs by Security Group & HA

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#issuecomment-708000962 Trillian test result (tid-2932) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37369 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707995506 Trillian test result (tid-2930) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38742 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-707974074 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2170 This is an automated message from the Apache Git

[GitHub] [cloudstack] sourpatchkidz8484 closed issue #4394: My server

2020-10-13 Thread GitBox
sourpatchkidz8484 closed issue #4394: URL: https://github.com/apache/cloudstack/issues/4394 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [cloudstack] sourpatchkidz8484 commented on issue #4394: My server

2020-10-13 Thread GitBox
sourpatchkidz8484 commented on issue #4394: URL: https://github.com/apache/cloudstack/issues/4394#issuecomment-707959671 Who is that hey man I need some help I was just trying to learn how to code and they went into my private stuff ---

[GitHub] [cloudstack] blueorangutan commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-707958167 @nvazquez a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. Th

[GitHub] [cloudstack] nvazquez commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-13 Thread GitBox
nvazquez commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-707957513 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4348: vmware: use hotPlugMemoryIncrementSize only for valid value

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4348: URL: https://github.com/apache/cloudstack/pull/4348#issuecomment-707950058 Trillian test result (tid-2931) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 33178 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4401: Preventing port 53 being added as lb rule when dns service is availab…

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4401: URL: https://github.com/apache/cloudstack/pull/4401#issuecomment-707944059 Trillian test result (tid-2928) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 36946 seconds Marvin logs: https://githu

[GitHub] [cloudstack] nvazquez commented on pull request #4389: Fixed vm-templates not being removed from primary storage with storag…

2020-10-13 Thread GitBox
nvazquez commented on pull request #4389: URL: https://github.com/apache/cloudstack/pull/4389#issuecomment-707896101 In my opinion, if the record has been already removed from the table `template_spool_ref` by the GC then CloudStack loses track of the template (need manual delete). However

[GitHub] [cloudstack] andrijapanicsb commented on pull request #4389: Fixed vm-templates not being removed from primary storage with storag…

2020-10-13 Thread GitBox
andrijapanicsb commented on pull request #4389: URL: https://github.com/apache/cloudstack/pull/4389#issuecomment-707884603 @Spaceman1984 do you want to advise, in form of the official documentation AND here - how one can fix his env, by marking the existing "template VMs" (which are just V

[GitHub] [cloudstack] DaanHoogland commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-10-13 Thread GitBox
DaanHoogland commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-707808239 @blueorangutan test kvm-centos7 centos7 keepEnv This is an automated message from the Apache Git Service

[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-707804396 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2169 This is an automated message from the Apache Git

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4399: PR multi tags in host offering [#4398]

2020-10-13 Thread GitBox
DaanHoogland commented on a change in pull request #4399: URL: https://github.com/apache/cloudstack/pull/4399#discussion_r503977398 ## File path: engine/schema/src/main/java/com/cloud/host/dao/HostDaoImpl.java ## @@ -1147,27 +1155,68 @@ public HostVO findByIp(final String ipAdd

[GitHub] [cloudstack] blueorangutan commented on pull request #4399: PR multi tags in host offering [#4398]

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4399: URL: https://github.com/apache/cloudstack/pull/4399#issuecomment-707750956 Packaging result: ✖centos7 ✖centos8 ✖debian. JID-2168 This is an automated message from the Apache Git

[GitHub] [cloudstack] blueorangutan commented on pull request #4399: PR multi tags in host offering [#4398]

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4399: URL: https://github.com/apache/cloudstack/pull/4399#issuecomment-707746090 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] DaanHoogland commented on pull request #4399: PR multi tags in host offering [#4398]

2020-10-13 Thread GitBox
DaanHoogland commented on pull request #4399: URL: https://github.com/apache/cloudstack/pull/4399#issuecomment-707745105 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack] nvazquez commented on issue #4299: Can't unmanage VMware instance

2020-10-13 Thread GitBox
nvazquez commented on issue #4299: URL: https://github.com/apache/cloudstack/issues/4299#issuecomment-707737186 Thanks @Spaceman1984, closing it This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] nvazquez closed issue #4299: Can't unmanage VMware instance

2020-10-13 Thread GitBox
nvazquez closed issue #4299: URL: https://github.com/apache/cloudstack/issues/4299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [cloudstack] nvazquez commented on a change in pull request #4251: Handle with VM snapshot events

2020-10-13 Thread GitBox
nvazquez commented on a change in pull request #4251: URL: https://github.com/apache/cloudstack/pull/4251#discussion_r503940063 ## File path: usage/src/main/java/com/cloud/usage/UsageManagerImpl.java ## @@ -1889,29 +1889,93 @@ private void createSecurityGroupEvent(UsageEventVO

[GitHub] [cloudstack] ravening commented on a change in pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
ravening commented on a change in pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#discussion_r503920494 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -3938,7 +3938,12 @@ public void doInTransactionWithoutResult(final

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
sureshanaparti commented on a change in pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#discussion_r503918601 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -3938,7 +3938,12 @@ public void doInTransactionWithoutResult

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
sureshanaparti commented on a change in pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#discussion_r503918601 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -3938,7 +3938,12 @@ public void doInTransactionWithoutResult

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4375: Fixing count for findHostsForMigration

2020-10-13 Thread GitBox
sureshanaparti commented on a change in pull request #4375: URL: https://github.com/apache/cloudstack/pull/4375#discussion_r503916203 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -1278,33 +1277,24 @@ private HypervisorType getHypervisorTyp

[cloudstack-www] 01/01: Merge branch 'master' into asf-site

2020-10-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit 9ac2d5d812831c755cb225ffb7bf38e469539b8c Merge: d96e95d 1b7943e Author: Daan Hoogland AuthorDate: Tue Oct 13 14:

[cloudstack-www] branch asf-site updated (d96e95d -> 9ac2d5d)

2020-10-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git. from d96e95d contents update add 1b7943e double check for content new 9ac2d5d Merge branch 'master' i

[cloudstack-www] branch master updated: double check for content

2020-10-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git The following commit(s) were added to refs/heads/master by this push: new 1b7943e double check for content 1b7943e

[GitHub] [cloudstack] ravening commented on a change in pull request #4396: Show network name in exception message

2020-10-13 Thread GitBox
ravening commented on a change in pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503886888 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(String

[GitHub] [cloudstack] wido commented on pull request #4397: List VMs by Security Group & HA

2020-10-13 Thread GitBox
wido commented on pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#issuecomment-707658423 LGTM based on code This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4396: Show network name in exception message

2020-10-13 Thread GitBox
Pearl1594 commented on a change in pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503852917 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(String

[GitHub] [cloudstack] slavkap commented on a change in pull request #4388: fix NPE in volumes statistics

2020-10-13 Thread GitBox
slavkap commented on a change in pull request #4388: URL: https://github.com/apache/cloudstack/pull/4388#discussion_r503850235 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -1930,18 +1931,13 @@ private boolean upgradeRunningVirtualMachine(Long vmI

[GitHub] [cloudstack] Spaceman1984 commented on a change in pull request #4401: Preventing port 53 being added as lb rule when dns service is availab…

2020-10-13 Thread GitBox
Spaceman1984 commented on a change in pull request #4401: URL: https://github.com/apache/cloudstack/pull/4401#discussion_r503838412 ## File path: server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java ## @@ -1598,65 +1602,73 @@ public LoadBalancer createP

[GitHub] [cloudstack] blueorangutan commented on pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-707641742 Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2167 This is an automated message from the Apache Git

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4396: Show network name in exception message

2020-10-13 Thread GitBox
DaanHoogland commented on a change in pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503831503 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(Str

[GitHub] [cloudstack] DaanHoogland commented on issue #4394: My server

2020-10-13 Thread GitBox
DaanHoogland commented on issue #4394: URL: https://github.com/apache/cloudstack/issues/4394#issuecomment-707636111 Mr. S.C.Laus is your prime suspect This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack] blueorangutan commented on pull request #4397: List VMs by Security Group & HA

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#issuecomment-707630876 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] DaanHoogland commented on pull request #4397: List VMs by Security Group & HA

2020-10-13 Thread GitBox
DaanHoogland commented on pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#issuecomment-707630473 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4401: Preventing port 53 being added as lb rule when dns service is availab…

2020-10-13 Thread GitBox
DaanHoogland commented on a change in pull request #4401: URL: https://github.com/apache/cloudstack/pull/4401#discussion_r503819956 ## File path: server/src/main/java/com/cloud/network/lb/LoadBalancingRulesManagerImpl.java ## @@ -1598,65 +1602,73 @@ public LoadBalancer createP

[GitHub] [cloudstack] blueorangutan commented on pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-707627588 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] DaanHoogland commented on pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
DaanHoogland commented on pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-707626994 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
blueorangutan removed a comment on pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-707160355 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
DaanHoogland removed a comment on pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-707159514 @blueorangutan package This is an automated message from the Apache Git Service. To respond to t

[GitHub] [cloudstack] DaanHoogland commented on pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
DaanHoogland commented on pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-707626409 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
DaanHoogland removed a comment on pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-707626409 @blueorangutan package This is an automated message from the Apache Git Service. To respond to t

[GitHub] [cloudstack] ravening commented on a change in pull request #4396: Show network name in exception message

2020-10-13 Thread GitBox
ravening commented on a change in pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503812081 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(String

[cloudstack-documentation] branch master updated: Fix create k8s binaries script name (#163)

2020-10-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git The following commit(s) were added to refs/heads/master by this push: new 0192a30 Fix create k8s binaries

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-13 Thread GitBox
blueorangutan removed a comment on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707112843 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-13 Thread GitBox
DaanHoogland removed a comment on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707112130 @blueorangutan test ubuntu kvm-ubuntu This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-13 Thread GitBox
DaanHoogland removed a comment on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707096930 @blueorangutan test ubuntu kvm-ubuntu keepEnv This is an automated message from the Apache Git S

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4396: Show network name in exception message

2020-10-13 Thread GitBox
Pearl1594 commented on a change in pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503810344 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(String

[GitHub] [cloudstack] Spaceman1984 commented on issue #4299: Can't unmanage VMware instance

2020-10-13 Thread GitBox
Spaceman1984 commented on issue #4299: URL: https://github.com/apache/cloudstack/issues/4299#issuecomment-707618609 Tested on master, no issue. This is an automated message from the Apache Git Service. To respond to the messa

[cloudstack] branch 4.14 updated: server: Fix some cpuspeed issues while create service offering (#4376)

2020-10-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch 4.14 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.14 by this push: new 94f9f89 server: Fix some cpuspeed issues while cr

[GitHub] [cloudstack] DaanHoogland merged pull request #4376: server: Fix some cpuspeed issues while create service offering

2020-10-13 Thread GitBox
DaanHoogland merged pull request #4376: URL: https://github.com/apache/cloudstack/pull/4376 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [cloudstack] DaanHoogland merged pull request #4374: Fixing searchAndCount searchAndDistinctCount when sc is null

2020-10-13 Thread GitBox
DaanHoogland merged pull request #4374: URL: https://github.com/apache/cloudstack/pull/4374 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[cloudstack] branch master updated: Fixing searchAndCount searchAndDistinctCount when sc is null (#4374)

2020-10-13 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new aab8df0 Fixing searchAndCount searchAndDistin

[GitHub] [cloudstack] DaanHoogland closed issue #4372: list roles API returns a wrong count

2020-10-13 Thread GitBox
DaanHoogland closed issue #4372: URL: https://github.com/apache/cloudstack/issues/4372 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-13 Thread GitBox
sureshanaparti commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503804331 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForMa

[GitHub] [cloudstack] blueorangutan commented on pull request #4348: vmware: use hotPlugMemoryIncrementSize only for valid value

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4348: URL: https://github.com/apache/cloudstack/pull/4348#issuecomment-707614189 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4348: vmware: use hotPlugMemoryIncrementSize only for valid value

2020-10-13 Thread GitBox
DaanHoogland removed a comment on pull request #4348: URL: https://github.com/apache/cloudstack/pull/4348#issuecomment-707160368 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] DaanHoogland commented on pull request #4348: vmware: use hotPlugMemoryIncrementSize only for valid value

2020-10-13 Thread GitBox
DaanHoogland commented on pull request #4348: URL: https://github.com/apache/cloudstack/pull/4348#issuecomment-707613902 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4348: vmware: use hotPlugMemoryIncrementSize only for valid value

2020-10-13 Thread GitBox
blueorangutan removed a comment on pull request #4348: URL: https://github.com/apache/cloudstack/pull/4348#issuecomment-707178438 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] blueorangutan commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707613639 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] ravening commented on a change in pull request #4396: Show network name in exception message

2020-10-13 Thread GitBox
ravening commented on a change in pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503800086 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(String

[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-13 Thread GitBox
DaanHoogland removed a comment on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707158283 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [cloudstack] DaanHoogland commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-13 Thread GitBox
DaanHoogland commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707613367 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-13 Thread GitBox
blueorangutan removed a comment on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707178254 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [cloudstack] blueorangutan removed a comment on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-13 Thread GitBox
blueorangutan removed a comment on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707159076 @DaanHoogland unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, k

[GitHub] [cloudstack] rvalle edited a comment on issue #4402: Egress Broken in VPC Tiers

2020-10-13 Thread GitBox
rvalle edited a comment on issue #4402: URL: https://github.com/apache/cloudstack/issues/4402#issuecomment-707596192 Further testing: seems like can be mitigated by adding an specific Egress 0.0.0.0/0 deny all rule.

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4396: Show network name in exception message

2020-10-13 Thread GitBox
DaanHoogland commented on a change in pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503796696 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(Str

[GitHub] [cloudstack] blueorangutan commented on pull request #4375: Fixing count for findHostsForMigration

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4375: URL: https://github.com/apache/cloudstack/pull/4375#issuecomment-707609074 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] rvalle edited a comment on issue #4402: Egress Broken in VPC Tiers

2020-10-13 Thread GitBox
rvalle edited a comment on issue #4402: URL: https://github.com/apache/cloudstack/issues/4402#issuecomment-707596192 Further testing: Traffic is going out from the VPC tiers despite adding an Egress 0.0.0.0/0 deny all rule. Something here seems fundamentally broken. --

[GitHub] [cloudstack] DaanHoogland commented on pull request #4375: Fixing count for findHostsForMigration

2020-10-13 Thread GitBox
DaanHoogland commented on pull request #4375: URL: https://github.com/apache/cloudstack/pull/4375#issuecomment-707608503 @blueorangutan test centos7 kvm-centos7 This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] sourpatchkidz8484 commented on issue #4394: My server

2020-10-13 Thread GitBox
sourpatchkidz8484 commented on issue #4394: URL: https://github.com/apache/cloudstack/issues/4394#issuecomment-707606483 My discord server was open in my computer and you guys where going through a bunch of my shit. At least who else could it have been. --

[GitHub] [cloudstack] DaanHoogland commented on issue #4394: My server

2020-10-13 Thread GitBox
DaanHoogland commented on issue #4394: URL: https://github.com/apache/cloudstack/issues/4394#issuecomment-707597118 @sourpatchkidz8484 better use us...@cloudstack.apache.org than. This is an automated message from the Apache

[GitHub] [cloudstack] rvalle commented on issue #4402: Egress Broken in VPC Tiers

2020-10-13 Thread GitBox
rvalle commented on issue #4402: URL: https://github.com/apache/cloudstack/issues/4402#issuecomment-707596192 Further testing: Traffic is going out from the VPC tiers despite the deny all rule. Something here seems fundamentally broken.

[GitHub] [cloudstack] blueorangutan commented on pull request #4397: List VMs by Security Group & HA

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#issuecomment-707591590 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2166 This is an automated message from the Apache Git

[GitHub] [cloudstack] blueorangutan commented on pull request #4397: List VMs by Security Group & HA

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#issuecomment-707572936 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4397: List VMs by Security Group & HA

2020-10-13 Thread GitBox
GabrielBrascher commented on pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#issuecomment-707572623 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4397: List VMs by Security Group & HA

2020-10-13 Thread GitBox
GabrielBrascher commented on a change in pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#discussion_r503752859 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -1016,10 +1024,18 @@ sc.setParameters("serviceO

[GitHub] [cloudstack] blueorangutan commented on pull request #4401: Preventing port 53 being added as lb rule when dns service is availab…

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4401: URL: https://github.com/apache/cloudstack/pull/4401#issuecomment-707570671 @Spaceman1984 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] ravening commented on a change in pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-13 Thread GitBox
ravening commented on a change in pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#discussion_r503750115 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -3938,7 +3938,12 @@ public void doInTransactionWithoutResult(final

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4401: Preventing port 53 being added as lb rule when dns service is availab…

2020-10-13 Thread GitBox
Spaceman1984 commented on pull request #4401: URL: https://github.com/apache/cloudstack/pull/4401#issuecomment-707570067 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] blueorangutan commented on pull request #4401: Preventing port 53 being added as lb rule when dns service is availab…

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4401: URL: https://github.com/apache/cloudstack/pull/4401#issuecomment-707567752 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2165 This is an automated message from the Apache Git

[GitHub] [cloudstack] rvalle opened a new issue #4402: ACL default behaviour not honoured in VPC tiers

2020-10-13 Thread GitBox
rvalle opened a new issue #4402: URL: https://github.com/apache/cloudstack/issues/4402 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VPC ~~~ # CLOUDSTACK VERSION ~~~ 4.14 ~~~ # CONFIGURATION ##

[GitHub] [cloudstack] ravening commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-13 Thread GitBox
ravening commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503737321 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForMaintena

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4401: Preventing port 53 being added as lb rule when dns service is availab…

2020-10-13 Thread GitBox
Spaceman1984 commented on pull request #4401: URL: https://github.com/apache/cloudstack/pull/4401#issuecomment-707550408 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack] blueorangutan commented on pull request #4401: Preventing port 53 being added as lb rule when dns service is availab…

2020-10-13 Thread GitBox
blueorangutan commented on pull request #4401: URL: https://github.com/apache/cloudstack/pull/4401#issuecomment-707550657 @Spaceman1984 a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] Spaceman1984 opened a new pull request #4401: Preventing port 53 being added as lb rule when dns service is availab…

2020-10-13 Thread GitBox
Spaceman1984 opened a new pull request #4401: URL: https://github.com/apache/cloudstack/pull/4401 …le in network offering ## Description Throwing an error when port 53 is added to a load balancer when DNS is available on the network service offering.

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-13 Thread GitBox
sureshanaparti commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503716591 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForMa

[GitHub] [cloudstack] sureshanaparti edited a comment on issue #4400: Find suitable storage for migration regression

2020-10-13 Thread GitBox
sureshanaparti edited a comment on issue #4400: URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-707540591 @borisstoyanov the check in the Zone wide pool allocator `if (dskCh.useLocalStorage()) { return null;}` should be ok, as the local storage can never be a zone wide p

[GitHub] [cloudstack] sureshanaparti commented on issue #4400: Find suitable storage for migration regression

2020-10-13 Thread GitBox
sureshanaparti commented on issue #4400: URL: https://github.com/apache/cloudstack/issues/4400#issuecomment-707540591 @borisstoyanov the check in the Zone wide pool allocator `if (dskCh.useLocalStorage()) { return null;}` should be ok, as the local storage can never be a zone wide pool and

[GitHub] [cloudstack] ravening commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-13 Thread GitBox
ravening commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503712301 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForMaintena

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-13 Thread GitBox
sureshanaparti commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503710867 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForMa