[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-12 Thread GitBox
sureshanaparti commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503709089 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForMa

[GitHub] [cloudstack] borisstoyanov opened a new issue #4400: Find suitable storage for migration regression

2020-10-12 Thread GitBox
borisstoyanov opened a new issue #4400: URL: https://github.com/apache/cloudstack/issues/4400 # ISSUE TYPE * Bug Report # COMPONENT NAME ~~~ VMware migration, API ~~~ # CLOUDSTACK VERSION ~~~ 4.14 ~~~ # CONFIG

[GitHub] [cloudstack] DK101010 opened a new pull request #4399: PR multi tags in host offering [#4398]

2020-10-12 Thread GitBox
DK101010 opened a new pull request #4399: URL: https://github.com/apache/cloudstack/pull/4399 ## Description - only changed HostDaoImpl.java to handle with comma separated multi host string - old behavior with one tag works like the old implementation ## Types of changes

[GitHub] [cloudstack] ravening commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-12 Thread GitBox
ravening commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503699026 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForMaintena

[GitHub] [cloudstack] blueorangutan commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-707523028 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2164 This is an automated message from the Apache Git

[GitHub] [cloudstack] ravening commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-12 Thread GitBox
ravening commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503698395 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForMaintena

[GitHub] [cloudstack] DK101010 opened a new issue #4398: Use multiple host tags in compute offerings

2020-10-12 Thread GitBox
DK101010 opened a new issue #4398: URL: https://github.com/apache/cloudstack/issues/4398 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ Engine/Schema ~~~ # CLOUDSTACK VERSION ~~~ all versions ~~~ # CONFIGURATION N

[GitHub] [cloudstack] blueorangutan commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-707509594 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] borisstoyanov commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-12 Thread GitBox
borisstoyanov commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-707509018 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4397: List VMs by Security Group & HA

2020-10-12 Thread GitBox
sureshanaparti commented on a change in pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#discussion_r503673587 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -1016,10 +1024,18 @@ sc.setParameters("serviceOf

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4397: List VMs by Security Group & HA

2020-10-12 Thread GitBox
sureshanaparti commented on a change in pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#discussion_r503673331 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -1016,10 +1024,18 @@ sc.setParameters("serviceOf

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-12 Thread GitBox
sureshanaparti commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503661983 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForMa

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-12 Thread GitBox
sureshanaparti commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503659931 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForMa

[GitHub] [cloudstack] Pearl1594 commented on a change in pull request #4397: List VMs by Security Group & HA

2020-10-12 Thread GitBox
Pearl1594 commented on a change in pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#discussion_r503659531 ## File path: server/src/main/java/com/cloud/api/query/QueryManagerImpl.java ## @@ -1016,10 +1024,18 @@ sc.setParameters("serviceOfferin

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4363: Ability to put a server in Down state to maintenance

2020-10-12 Thread GitBox
GabrielBrascher commented on a change in pull request #4363: URL: https://github.com/apache/cloudstack/pull/4363#discussion_r503480390 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ## @@ -1302,6 +1305,17 @@ public Host maintain(final PrepareForM

[GitHub] [cloudstack] blueorangutan commented on pull request #4397: List VMs by Security Group & HA

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#issuecomment-707290697 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2163 This is an automated message from the Apache Git

[GitHub] [cloudstack] blueorangutan commented on pull request #4397: List VMs by Security Group & HA

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#issuecomment-707276844 @GabrielBrascher a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack] GabrielBrascher opened a new pull request #4397: List VMs by Security Group & HA

2020-10-12 Thread GitBox
GabrielBrascher opened a new pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397 ## Description List VMs by "security group ID" and/or "ha enabled" Improve List VMs command allowing to list VMs filtering by security group or HA enabled.

[GitHub] [cloudstack] GabrielBrascher commented on pull request #4397: List VMs by Security Group & HA

2020-10-12 Thread GitBox
GabrielBrascher commented on pull request #4397: URL: https://github.com/apache/cloudstack/pull/4397#issuecomment-707276251 @blueorangutan package This is an automated message from the Apache Git Service. To respond to th

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4376: server: Fix some cpuspeed issues while create service offering

2020-10-12 Thread GitBox
sureshanaparti commented on a change in pull request #4376: URL: https://github.com/apache/cloudstack/pull/4376#discussion_r503437058 ## File path: server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java ## @@ -2343,7 +2343,7 @@ public ServiceOffering create

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-12 Thread GitBox
sureshanaparti commented on a change in pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#discussion_r503423570 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -3994,7 +3999,12 @@ public void doInTransactionWithoutResult

[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-12 Thread GitBox
sureshanaparti commented on a change in pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#discussion_r503423069 ## File path: server/src/main/java/com/cloud/server/ManagementServerImpl.java ## @@ -3938,7 +3938,12 @@ public void doInTransactionWithoutResult

[GitHub] [cloudstack] blueorangutan commented on pull request #4374: Fixing searchAndCount searchAndDistinctCount when sc is null

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4374: URL: https://github.com/apache/cloudstack/pull/4374#issuecomment-707231124 Trillian test result (tid-2926) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 31223 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4395: support for data migration of incremental snaps on xen

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4395: URL: https://github.com/apache/cloudstack/pull/4395#issuecomment-707211245 Trillian test result (tid-2923) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 38523 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4395: support for data migration of incremental snaps on xen

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4395: URL: https://github.com/apache/cloudstack/pull/4395#issuecomment-707200659 Trillian test result (tid-2922) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 37494 seconds Marvin logs: https://gith

[GitHub] [cloudstack] blueorangutan commented on pull request #4395: support for data migration of incremental snaps on xen

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4395: URL: https://github.com/apache/cloudstack/pull/4395#issuecomment-707178666 Trillian test result (tid-2924) Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server 7 Total time taken: 35291 seconds Marvin logs: https://githu

[GitHub] [cloudstack] blueorangutan commented on pull request #4348: vmware: use hotPlugMemoryIncrementSize only for valid value

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4348: URL: https://github.com/apache/cloudstack/pull/4348#issuecomment-707178438 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] blueorangutan commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707178252 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [cloudstack] DaanHoogland commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-12 Thread GitBox
DaanHoogland commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707174978 using this PR for some testing seems not fair :( @blueorangutan test This is an automated message fro

[GitHub] [cloudstack] blueorangutan commented on pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-707160355 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] DaanHoogland commented on pull request #4348: vmware: use hotPlugMemoryIncrementSize only for valid value

2020-10-12 Thread GitBox
DaanHoogland commented on pull request #4348: URL: https://github.com/apache/cloudstack/pull/4348#issuecomment-707160368 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] DaanHoogland commented on pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-12 Thread GitBox
DaanHoogland commented on pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-707159514 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [cloudstack] blueorangutan commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707159076 @DaanHoogland unsupported parameters provided. Supported mgmt server os are: `centos6, centos7, ubuntu`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-ubunt

[GitHub] [cloudstack] DaanHoogland commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-12 Thread GitBox
DaanHoogland commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707158283 @blueorangutan test keepEnv This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack] Spaceman1984 commented on issue #4285: Set 53/111 LoadBalancer rule may kill haproxy and cause loadbalancer down completely.

2020-10-12 Thread GitBox
Spaceman1984 commented on issue #4285: URL: https://github.com/apache/cloudstack/issues/4285#issuecomment-707142343 I'll check which ports actually prevent haproxy from starting, I think most of them are not breaking the startup. ---

[GitHub] [cloudstack] Spaceman1984 commented on issue #4285: Set 53/111 LoadBalancer rule may kill haproxy and cause loadbalancer down completely.

2020-10-12 Thread GitBox
Spaceman1984 commented on issue #4285: URL: https://github.com/apache/cloudstack/issues/4285#issuecomment-707133517 This is the output running DefaultIsolatedNetworkOffering, ``` tcp0 0 10.1.1.1:80 0.0.0.0:* LISTEN 1080/apache2

[GitHub] [cloudstack] ravening commented on a change in pull request #4396: Show network name in exception message

2020-10-12 Thread GitBox
ravening commented on a change in pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503298089 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(String

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #4396: Show network name in exception message

2020-10-12 Thread GitBox
GabrielBrascher commented on a change in pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503293633 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(

[GitHub] [cloudstack] blueorangutan commented on pull request #4375: Fixing count for findHostsForMigration

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4375: URL: https://github.com/apache/cloudstack/pull/4375#issuecomment-707113955 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] DaanHoogland commented on pull request #4375: Fixing count for findHostsForMigration

2020-10-12 Thread GitBox
DaanHoogland commented on pull request #4375: URL: https://github.com/apache/cloudstack/pull/4375#issuecomment-707113403 @blueorangutan test centos7 kvm-centos7 keepEnv This is an automated message from the Apache Git Service

[GitHub] [cloudstack] blueorangutan commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707112843 @DaanHoogland a Trillian-Jenkins test job (ubuntu mgmt + kvm-ubuntu) has been kicked to run smoke tests ---

[GitHub] [cloudstack] DaanHoogland commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-12 Thread GitBox
DaanHoogland commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707112130 @blueorangutan test ubuntu kvm-ubuntu This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] blueorangutan commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707108041 @DaanHoogland a Trillian-Jenkins test job (ubuntu mgmt + kvm-ubuntu) has been kicked to run smoke tests ---

[GitHub] [cloudstack] DaanHoogland commented on pull request #4367: Remove cpu core from op_host_capacity when host is deleted

2020-10-12 Thread GitBox
DaanHoogland commented on pull request #4367: URL: https://github.com/apache/cloudstack/pull/4367#issuecomment-707100270 @blueorangutn package This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4396: Show network name in exception message

2020-10-12 Thread GitBox
DaanHoogland commented on a change in pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396#discussion_r503271152 ## File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java ## @@ -3821,7 +3821,7 @@ private void checkIfHostNameUniqueInNtwkDomain(Str

[GitHub] [cloudstack] DaanHoogland commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-12 Thread GitBox
DaanHoogland commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-707096930 @blueorangutan test ubuntu kvm-ubuntu keepEnv This is an automated message from the Apache Git Service.

[GitHub] [cloudstack] sourpatchkidz8484 commented on issue #4394: My server

2020-10-12 Thread GitBox
sourpatchkidz8484 commented on issue #4394: URL: https://github.com/apache/cloudstack/issues/4394#issuecomment-707064881 Sorry was an accidental. But I need help with everything This is an automated message from the Apache G

[GitHub] [cloudstack] blueorangutan commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-707065059 Packaging result: ✖centos7 ✖centos8 ✔debian. JID-2159 This is an automated message from the Apache Git

[GitHub] [cloudstack] wido commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run

2020-10-12 Thread GitBox
wido commented on pull request #4373: URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-707069804 @rhtyd /var/run is a tmpfs on many systems nowadays, so the package can't fix this. I just wonder why we (PCextreme) never run into this. ---

[GitHub] [cloudstack] blueorangutan commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4373: URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-707068190 Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2161 This is an automated message from the Apache Git

[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-707068189 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2162 This is an automated message from the Apache Git

[GitHub] [cloudstack] blueorangutan commented on pull request #4375: Fixing count for findHostsForMigration

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4375: URL: https://github.com/apache/cloudstack/pull/4375#issuecomment-707068187 Packaging result: ✔centos7 ✖centos8 ✔debian. JID-2160 This is an automated message from the Apache Git

[GitHub] [cloudstack] Spaceman1984 commented on issue #4285: Set 53/111 LoadBalancer rule may kill haproxy and cause loadbalancer down completely.

2020-10-12 Thread GitBox
Spaceman1984 commented on issue #4285: URL: https://github.com/apache/cloudstack/issues/4285#issuecomment-707050673 I checked on the VR, nothing was listening on port 111. This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] Spaceman1984 edited a comment on pull request #4392: Fixed double slash in secret breaking db insert

2020-10-12 Thread GitBox
Spaceman1984 edited a comment on pull request #4392: URL: https://github.com/apache/cloudstack/pull/4392#issuecomment-707038715 @rhtyd I don't see RBD as an option on Primate for primary storage, my fix was for the UI, but I can't be sure if this works as expected, we need a working back e

[GitHub] [cloudstack] Spaceman1984 edited a comment on pull request #4392: Fixed double slash in secret breaking db insert

2020-10-12 Thread GitBox
Spaceman1984 edited a comment on pull request #4392: URL: https://github.com/apache/cloudstack/pull/4392#issuecomment-707038715 @rhtyd I don't see RBD as an option on Primate for primary storage, my fix was for the UI, but I can't be sure if this works as expected, we need a working back e

[GitHub] [cloudstack] Spaceman1984 edited a comment on pull request #4392: Fixed double slash in secret breaking db insert

2020-10-12 Thread GitBox
Spaceman1984 edited a comment on pull request #4392: URL: https://github.com/apache/cloudstack/pull/4392#issuecomment-707038715 @rhtyd I don't see RBD as an option on Primate for primary storage. This is an automated message

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4392: Fixed double slash in secret breaking db insert

2020-10-12 Thread GitBox
Spaceman1984 commented on pull request #4392: URL: https://github.com/apache/cloudstack/pull/4392#issuecomment-707038715 @rhtyd I don't see the RBD as an option on Primate for primary storage. This is an automated message fro

[GitHub] [cloudstack] blueorangutan commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-707036038 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4131: [HEALTH] Master/4.15 Health Check please don't merge this

2020-10-12 Thread GitBox
rhtyd commented on pull request #4131: URL: https://github.com/apache/cloudstack/pull/4131#issuecomment-707035481 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] Spaceman1984 commented on pull request #4392: Fixed double slash in secret breaking db insert

2020-10-12 Thread GitBox
Spaceman1984 commented on pull request #4392: URL: https://github.com/apache/cloudstack/pull/4392#issuecomment-707035209 I'll check primate. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] Spaceman1984 edited a comment on pull request #4392: Fixed double slash in secret breaking db insert

2020-10-12 Thread GitBox
Spaceman1984 edited a comment on pull request #4392: URL: https://github.com/apache/cloudstack/pull/4392#issuecomment-707035209 I'll check Primate. This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack] rhtyd commented on pull request #4395: support for data migration of incremental snaps on xen

2020-10-12 Thread GitBox
rhtyd commented on pull request #4395: URL: https://github.com/apache/cloudstack/pull/4395#issuecomment-707034824 cc @vladimirpetrov @PaulAngus This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] rhtyd edited a comment on pull request #4392: Fixed double slash in secret breaking db insert

2020-10-12 Thread GitBox
rhtyd edited a comment on pull request #4392: URL: https://github.com/apache/cloudstack/pull/4392#issuecomment-707034228 Does this happen on Primate too @Spaceman1984 or just a UI issue, than backend issue? (related to secret input for adding ceph/rbd pool) --

[GitHub] [cloudstack] rhtyd commented on pull request #4392: Fixed double slash in secret breaking db insert

2020-10-12 Thread GitBox
rhtyd commented on pull request #4392: URL: https://github.com/apache/cloudstack/pull/4392#issuecomment-707034228 Does this happen on Primate too @Spaceman1984 or just a UI issue, than backend issue? (related to secret input for adding ceph/rbd pool) @blueorangutan test --

[GitHub] [cloudstack] rhtyd removed a comment on pull request #4392: Fixed double slash in secret breaking db insert

2020-10-12 Thread GitBox
rhtyd removed a comment on pull request #4392: URL: https://github.com/apache/cloudstack/pull/4392#issuecomment-707033624 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [cloudstack] rhtyd commented on pull request #4392: Fixed double slash in secret breaking db insert

2020-10-12 Thread GitBox
rhtyd commented on pull request #4392: URL: https://github.com/apache/cloudstack/pull/4392#issuecomment-707033624 @blueorangutan test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [cloudstack] blueorangutan commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4373: URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-707032599 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[cloudstack] branch master updated (d3be14d -> 1bbb29d)

2020-10-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from d3be14d hypervisor: Add Citrix Hypervisor 8x product name support (#4271) add 1bbb29d Fixed vm-templates n

[GitHub] [cloudstack] blueorangutan commented on pull request #4375: Fixing count for findHostsForMigration

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4375: URL: https://github.com/apache/cloudstack/pull/4375#issuecomment-707032434 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd merged pull request #4389: Fixed vm-templates not being removed from primary storage with storag…

2020-10-12 Thread GitBox
rhtyd merged pull request #4389: URL: https://github.com/apache/cloudstack/pull/4389 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] ravening commented on pull request #4228: Dont add host back after agent service restart

2020-10-12 Thread GitBox
ravening commented on pull request #4228: URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-707032091 > ping @ravening any update? thanks. @rhtyd apart from logs what else can I share? Manual testing involves Add a host to cloudstack Put it in maintenance mode

[GitHub] [cloudstack] rhtyd closed issue #4292: VMware: template VMs not removed during storage GC/cleanup

2020-10-12 Thread GitBox
rhtyd closed issue #4292: URL: https://github.com/apache/cloudstack/issues/4292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [cloudstack] rhtyd commented on pull request #4375: Fixing count for findHostsForMigration

2020-10-12 Thread GitBox
rhtyd commented on pull request #4375: URL: https://github.com/apache/cloudstack/pull/4375#issuecomment-707031956 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] blueorangutan commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-707031926 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. This

[GitHub] [cloudstack] rhtyd commented on pull request #4373: Handles creation /var/run/cloud folder for creation of lock file while modifyvxlan.sh script is run

2020-10-12 Thread GitBox
rhtyd commented on pull request #4373: URL: https://github.com/apache/cloudstack/pull/4373#issuecomment-707031679 Ideally this must be created on pkg installation. @blueorangutan package This is an automated messag

[GitHub] [cloudstack] rhtyd commented on pull request #4307: [VMware] vSphere advanced capabilities and Full OVF properties support

2020-10-12 Thread GitBox
rhtyd commented on pull request #4307: URL: https://github.com/apache/cloudstack/pull/4307#issuecomment-707031245 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] rhtyd commented on pull request #4348: vmware: use hotPlugMemoryIncrementSize only for valid value

2020-10-12 Thread GitBox
rhtyd commented on pull request #4348: URL: https://github.com/apache/cloudstack/pull/4348#issuecomment-707031436 Is this ready for testing/review @shwstppr ? This is an automated message from the Apache Git Service. To respo

[GitHub] [cloudstack] rhtyd merged pull request #4271: hypervisor: Add Citrix Hypervisor 8x product name support

2020-10-12 Thread GitBox
rhtyd merged pull request #4271: URL: https://github.com/apache/cloudstack/pull/4271 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [cloudstack] rhtyd commented on pull request #4228: Dont add host back after agent service restart

2020-10-12 Thread GitBox
rhtyd commented on pull request #4228: URL: https://github.com/apache/cloudstack/pull/4228#issuecomment-707030955 ping @ravening any update? thanks. This is an automated message from the Apache Git Service. To respond to the

[cloudstack] branch master updated (479ef8a -> d3be14d)

2020-10-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 479ef8a VMware: match hardware version for worker VM when taking a snapshot (#4321) add d3be14d hypervisor

[GitHub] [cloudstack] rhtyd commented on pull request #4251: Handle with VM snapshot events

2020-10-12 Thread GitBox
rhtyd commented on pull request #4251: URL: https://github.com/apache/cloudstack/pull/4251#issuecomment-707030826 @nvazquez can you review this? thanks. This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack] rhtyd commented on pull request #4271: hypervisor: Add Citrix Hypervisor 8x product name support

2020-10-12 Thread GitBox
rhtyd commented on pull request #4271: URL: https://github.com/apache/cloudstack/pull/4271#issuecomment-707030397 Thanks for test results @shwstppr, merging this based on regression tests and code LGTM from Daan and I. This

[GitHub] [cloudstack] andrijapanicsb commented on issue #4285: Set 53/111 LoadBalancer rule may kill haproxy and cause loadbalancer down completely.

2020-10-12 Thread GitBox
andrijapanicsb commented on issue #4285: URL: https://github.com/apache/cloudstack/issues/4285#issuecomment-707028754 I think that's true @rhtyd , but only valid for Shared networks, or something - I recall the issue we fix for 4.13.1/4.14 In general, the design around those should b

[GitHub] [cloudstack] rhtyd commented on issue #4285: Set 53/111 LoadBalancer rule may kill haproxy and cause loadbalancer down completely.

2020-10-12 Thread GitBox
rhtyd commented on issue #4285: URL: https://github.com/apache/cloudstack/issues/4285#issuecomment-707024810 Agree @andrijapanicsb however there may be a case for port 53 (allow DNS externally, there is a setting for that I think?) -

[GitHub] [cloudstack] andrijapanicsb commented on issue #4285: Set 53/111 LoadBalancer rule may kill haproxy and cause loadbalancer down completely.

2020-10-12 Thread GitBox
andrijapanicsb commented on issue #4285: URL: https://github.com/apache/cloudstack/issues/4285#issuecomment-707023892 More proper solution would be to NOT bind those ports on public interfaces (dumb idea anyway) - so that haproxy will not fail to bind those ports later on public interfaces

[GitHub] [cloudstack] rhtyd commented on issue #4285: Set 53/111 LoadBalancer rule may kill haproxy and cause loadbalancer down completely.

2020-10-12 Thread GitBox
rhtyd commented on issue #4285: URL: https://github.com/apache/cloudstack/issues/4285#issuecomment-707024197 @echoidcf I checked port 111 is for rpcbind/NFS, do you think there is any internal use for port 111 at all for VRs? ---

[cloudstack-primate] branch master updated: Close form after submission (#797)

2020-10-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new e414511 Close form after submission

[cloudstack-primate] branch master updated: Add storage policy details in the detail view (#796)

2020-10-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new 22dde36 Add storage policy details i

[cloudstack-primate] branch master updated: Set deploy-as-is to default on VMware (#777)

2020-10-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new 16e06c4 Set deploy-as-is to default

[GitHub] [cloudstack] Spaceman1984 commented on issue #4285: Set 53/111 LoadBalancer rule may kill haproxy and cause loadbalancer down completely.

2020-10-12 Thread GitBox
Spaceman1984 commented on issue #4285: URL: https://github.com/apache/cloudstack/issues/4285#issuecomment-707019155 Should adding port 111 on the load balancer always throw an error? Is there a check that needs to be done or should it be hardcoded? ---

[cloudstack-primate] branch master updated: Adding label for isolationmethod (#795)

2020-10-12 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new aa287a4 Adding label for isolationme

[cloudstack-www] branch asf-site updated (7155814 -> fcde3cf)

2020-10-12 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a change to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git. from 7155814 update build add 61fa869 Updating to reflect ACS now using the ASF security team add 100a

[cloudstack-www] 01/01: Merge branch 'master' into asf-site (#77)

2020-10-12 Thread dahn
This is an automated email from the ASF dual-hosted git repository. dahn pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/cloudstack-www.git commit fcde3cfc29c320f98bc0d1a60f78785c7d549587 Merge: 7155814 366c345 Author: Daan Hoogland AuthorDate: Mon Oct 12 11:

[GitHub] [cloudstack] ravening commented on pull request #4359: Failed to update host password if username/password is not saved in db

2020-10-12 Thread GitBox
ravening commented on pull request #4359: URL: https://github.com/apache/cloudstack/pull/4359#issuecomment-706969355 > @ravening this is a bug fix, which should be merged into 4.14 as well rebased to 4.14 This is an au

[GitHub] [cloudstack] ravening opened a new pull request #4396: Show network name in exception message

2020-10-12 Thread GitBox
ravening opened a new pull request #4396: URL: https://github.com/apache/cloudstack/pull/4396 ## Description Display network name in exception message instead of network object ## Types of changes - [ ] Breaking change (fix or feature that wou

[GitHub] [cloudstack] blueorangutan commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-706954882 Packaging result: ✔centos7 ✔centos8 ✔debian. JID-2158 This is an automated message from the Apache Git

[GitHub] [cloudstack] DaanHoogland commented on issue #4394: My server

2020-10-12 Thread GitBox
DaanHoogland commented on issue #4394: URL: https://github.com/apache/cloudstack/issues/4394#issuecomment-706939678 @sourpatchkidz8484 are you going to add a description to this issue? This is an automated message from the Ap

[GitHub] [cloudstack] blueorangutan commented on pull request #4374: Fixing searchAndCount searchAndDistinctCount when sc is null

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4374: URL: https://github.com/apache/cloudstack/pull/4374#issuecomment-706937468 @DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] DaanHoogland commented on pull request #4374: Fixing searchAndCount searchAndDistinctCount when sc is null

2020-10-12 Thread GitBox
DaanHoogland commented on pull request #4374: URL: https://github.com/apache/cloudstack/pull/4374#issuecomment-706937211 @blueorangutan test centos7 kvm-centos7 This is an automated message from the Apache Git Service. To res

[GitHub] [cloudstack] blueorangutan commented on pull request #4386: systemvm: fix keepalived is always restarted when update config for monitor service

2020-10-12 Thread GitBox
blueorangutan commented on pull request #4386: URL: https://github.com/apache/cloudstack/pull/4386#issuecomment-706935726 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

  1   2   >