[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3649: Garbage snapshots are left on Primary and Secondary

2019-11-22 Thread GitBox
andrijapanicsb edited a comment on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-557715680 Alright - so far tested only KVM (centos 7) with NFS: **While backup to secondary = true**, results as follow

[GitHub] [cloudstack] andrijapanicsb commented on issue #3649: Garbage snapshots are left on Primary and Secondary

2019-11-22 Thread GitBox
andrijapanicsb commented on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-557736437 Well, things are a bit complicated on XenServer (7.1.0), need some more fix (nothing major I hope) **While backup t

[GitHub] [cloudstack] weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface

2019-11-22 Thread GitBox
weizhouapache commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-557720278 @DennisKonrad it is still in progress. The issue you mentioned should be caused by the last commit. It is difficult to

[GitHub] [cloudstack] andrijapanicsb commented on issue #3649: Garbage snapshots are left on Primary and Secondary

2019-11-22 Thread GitBox
andrijapanicsb commented on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-557718232 /CC @rhtyd This is an automated message from the Apache

[GitHub] [cloudstack] andrijapanicsb commented on issue #3649: Garbage snapshots are left on Primary and Secondary

2019-11-22 Thread GitBox
andrijapanicsb commented on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-557718173 I would say that you just fix, if possible, that deletion from Primary (when backup to Sec Store = false) and we are mostl

[GitHub] [cloudstack] rhtyd commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
rhtyd commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557717851 @blueorangutan test This is an automated message from the Apache G

[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3649: Garbage snapshots are left on Primary and Secondary

2019-11-22 Thread GitBox
andrijapanicsb edited a comment on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-557715680 Alright - so far tested only KVM (centos 7) with NFS: **While backup to secondary = true**, results as follow

[GitHub] [cloudstack] blueorangutan commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
blueorangutan commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557717936 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests ---

[GitHub] [cloudstack] andrijapanicsb commented on issue #3649: Garbage snapshots are left on Primary and Secondary

2019-11-22 Thread GitBox
andrijapanicsb commented on issue #3649: Garbage snapshots are left on Primary and Secondary URL: https://github.com/apache/cloudstack/pull/3649#issuecomment-557715680 Alright - so far tested only KVM (centos 7) with NFS: **While backup to secondary = true**, results as follows: -

[cloudstack-primate] branch master updated: autogenview: implement recursive action polling

2019-11-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new 401e797 autogenview: implement recur

[cloudstack-primate] 01/02: config: add resource filter and view buttons

2019-11-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git commit 76c8ed8f5f2a15a67a459f9913c880af173d073d Author: Rohit Yadav AuthorDate: Sat Nov 23 02:37:26 2019 +0530

[cloudstack-primate] 02/02: infocard: group network related blocks together

2019-11-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git commit bf7b55b5c510c737d0e7d3112a6ee87e91461769 Author: Rohit Yadav AuthorDate: Sat Nov 23 02:45:21 2019 +0530

[cloudstack-primate] branch master updated (4a6a266 -> bf7b55b)

2019-11-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git. from 4a6a266 update packages and package-lock, fix infocard new 76c8ed8 config: add resource filter and

[GitHub] [cloudstack] blueorangutan commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
blueorangutan commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557679205 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-378 This

[GitHub] [cloudstack] blueorangutan commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
blueorangutan commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557673039 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] rhtyd commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
rhtyd commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557672893 @blueorangutan package This is an automated message from the Apach

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
rhtyd commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349767341 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7 @@ publ

[GitHub] [cloudstack] rhtyd merged pull request #3696: env config for dual zone simulator

2019-11-22 Thread GitBox
rhtyd merged pull request #3696: env config for dual zone simulator URL: https://github.com/apache/cloudstack/pull/3696 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[cloudstack] branch master updated (24db4d8 -> e1ccbfb)

2019-11-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 24db4d8 security_group.py: check cidr unstrictly to accept cidrs like 1.1.1.1/24 (#3701) add e1ccbfb debia

[cloudstack] branch master updated (e1ccbfb -> 3220705)

2019-11-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from e1ccbfb debian: fix symlink issue post install/upgrade (#3695) add 3220705 setup: env config for dual zone

[GitHub] [cloudstack] rhtyd merged pull request #3695: debian: fix symlink issue post install/upgrade

2019-11-22 Thread GitBox
rhtyd merged pull request #3695: debian: fix symlink issue post install/upgrade URL: https://github.com/apache/cloudstack/pull/3695 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack] andrijapanicsb commented on issue #3695: debian: fix symlink issue post install/upgrade

2019-11-22 Thread GitBox
andrijapanicsb commented on issue #3695: debian: fix symlink issue post install/upgrade URL: https://github.com/apache/cloudstack/pull/3695#issuecomment-557649941 I've manually tested this one, and it works fine as long as we respect the expectation that the usage server is installed once

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-22 Thread GitBox
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r349743170 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ###

[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #3695: debian: fix symlink issue post install/upgrade

2019-11-22 Thread GitBox
andrijapanicsb commented on a change in pull request #3695: debian: fix symlink issue post install/upgrade URL: https://github.com/apache/cloudstack/pull/3695#discussion_r349742946 ## File path: debian/cloudstack-usage.postinst ## @@ -40,7 +35,7 @@ case "$1" in

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-22 Thread GitBox
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r349742144 ## File path: server/src/main/java/com/cloud/resource/ResourceManagerImpl.java ###

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-22 Thread GitBox
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r349741387 ## File path: server/src/main/java/com/cloud/ha/HighAvailabilityManagerImpl.java #

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-22 Thread GitBox
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r349740123 ## File path: engine/components-api/src/main/java/com/cloud/resource/ResourceManag

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-22 Thread GitBox
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r349740002 ## File path: api/src/main/java/com/cloud/resource/ResourceState.java ##

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3695: debian: fix symlink issue post install/upgrade

2019-11-22 Thread GitBox
rhtyd commented on a change in pull request #3695: debian: fix symlink issue post install/upgrade URL: https://github.com/apache/cloudstack/pull/3695#discussion_r349738596 ## File path: debian/cloudstack-usage.postinst ## @@ -40,7 +35,7 @@ case "$1" in # Replaci

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3695: debian: fix symlink issue post install/upgrade

2019-11-22 Thread GitBox
DaanHoogland commented on a change in pull request #3695: debian: fix symlink issue post install/upgrade URL: https://github.com/apache/cloudstack/pull/3695#discussion_r349737651 ## File path: debian/cloudstack-usage.postinst ## @@ -40,7 +35,7 @@ case "$1" in #

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3695: debian: fix symlink issue post install/upgrade

2019-11-22 Thread GitBox
DaanHoogland commented on a change in pull request #3695: debian: fix symlink issue post install/upgrade URL: https://github.com/apache/cloudstack/pull/3695#discussion_r349737315 ## File path: debian/cloudstack-usage.postinst ## @@ -21,15 +21,10 @@ set -e case "$1" in

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

2019-11-22 Thread GitBox
DaanHoogland commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r349690207 ## File path: server/src/main/java/org/apache/cloudstack/vm/VmImportManagerImpl.java ## @@ -233,10 +233,10 @

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

2019-11-22 Thread GitBox
DaanHoogland commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r349688425 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java #

[GitHub] [cloudstack] DaanHoogland commented on issue #3689: Add LDAP account button is not being shown when ldap configuration is added at domain level

2019-11-22 Thread GitBox
DaanHoogland commented on issue #3689: Add LDAP account button is not being shown when ldap configuration is added at domain level URL: https://github.com/apache/cloudstack/issues/3689#issuecomment-557600439 Add ldap account is meant for manual ldap accounts only and not for automatic impo

[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
andrijapanicsb commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349684041 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,

[GitHub] [cloudstack] DaanHoogland commented on issue #3688: New feature: Add support to destroy/recover volumes

2019-11-22 Thread GitBox
DaanHoogland commented on issue #3688: New feature: Add support to destroy/recover volumes URL: https://github.com/apache/cloudstack/pull/3688#issuecomment-557599151 seems like a useful feature @ustcweizhou . I had a global look and saw some style issues but no real ones. I'll do a thourou

[GitHub] [cloudstack] wido commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
wido commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349682738 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7 @@ publi

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3688: New feature: Add support to destroy/recover volumes

2019-11-22 Thread GitBox
DaanHoogland commented on a change in pull request #3688: New feature: Add support to destroy/recover volumes URL: https://github.com/apache/cloudstack/pull/3688#discussion_r349682196 ## File path: ui/l10n/zh_CN.js ## @@ -180,6 +180,7 @@ var dictionary = { "label.acti

[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
andrijapanicsb commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349681345 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,

[GitHub] [cloudstack] andrijapanicsb edited a comment on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
andrijapanicsb edited a comment on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557596702 All good, and both mgmt servers fine, single KVM agent also fine: grep -i "certificate ownership verification

[GitHub] [cloudstack] andrijapanicsb commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
andrijapanicsb commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557596702 All good, and both mgmt servers fine, single KMV agent also fine: grep -i "certificate ownership verification failed

[GitHub] [cloudstack] DaanHoogland commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
DaanHoogland commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557593631 @andrijapanicsb, > What does it mean "ssl enabled"? the default (self signed) rootCA is relying on this code.

[GitHub] [cloudstack] DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface

2019-11-22 Thread GitBox
DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-557593215 @weizhouapache After a first look into the router I can say the APIPA is not the problem. There's something else wrong. I w

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
DaanHoogland commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349674282 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7

[GitHub] [cloudstack] andrijapanicsb commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
andrijapanicsb commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557586920 > code looks good, needs testing on a two ms instance with ssl enabled to see if it solves the cert issue. Analytically I'

[GitHub] [cloudstack] andrijapanicsb commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
andrijapanicsb commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349665261 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,

[GitHub] [cloudstack] DennisKonrad edited a comment on issue #3179: Redundant VRouter guest network on wrong interface

2019-11-22 Thread GitBox
DennisKonrad edited a comment on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-557580409 @weizhouapache Just writing a short feedback so you know where I'm at. At the moment it seems the redundant VPC does

[GitHub] [cloudstack] DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface

2019-11-22 Thread GitBox
DennisKonrad commented on issue #3179: Redundant VRouter guest network on wrong interface URL: https://github.com/apache/cloudstack/issues/3179#issuecomment-557580409 @weizhouapache Just writing a short feedback so you know where I'm at. At the moment it seems the redundant VPC does not de

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
DaanHoogland commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349653874 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
DaanHoogland commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349648997 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7

[cloudstack-primate] branch master updated: update packages and package-lock, fix infocard

2019-11-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new 4a6a266 update packages and package-

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
DaanHoogland commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349648997 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7

[GitHub] [cloudstack] DaanHoogland commented on issue #3696: env config for dual zone simulator

2019-11-22 Thread GitBox
DaanHoogland commented on issue #3696: env config for dual zone simulator URL: https://github.com/apache/cloudstack/pull/3696#issuecomment-557571120 makes sense @rhtyd , will do This is an automated message from the Apache Git

[GitHub] [cloudstack] anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure

2019-11-22 Thread GitBox
anuragaw commented on a change in pull request #3425: [WIP DO NOT MERGE] Better tracking host maintanence success and failure URL: https://github.com/apache/cloudstack/pull/3425#discussion_r349645191 ## File path: server/src/main/java/com/cloud/ha/HighAvailabilityManagerImpl.java #

[cloudstack-primate] branch master updated: eslint: fix missing eslint dependencies and lint errors (#19)

2019-11-22 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack-primate.git The following commit(s) were added to refs/heads/master by this push: new a8b86ae eslint: fix missing eslint d

[GitHub] [cloudstack] onitake opened a new issue #3708: Virtual router timezone always set to UTC instead of local timezone

2019-11-22 Thread GitBox
onitake opened a new issue #3708: Virtual router timezone always set to UTC instead of local timezone URL: https://github.com/apache/cloudstack/issues/3708 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ VR ~~~ # CLOUDSTACK VERS

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
weizhouapache commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349585728 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7

[GitHub] [cloudstack] anuragaw opened a new issue #3707: When only one host is available and it is put in maintenance, all VMs on it are Stopped.

2019-11-22 Thread GitBox
anuragaw opened a new issue #3707: When only one host is available and it is put in maintenance, all VMs on it are Stopped. URL: https://github.com/apache/cloudstack/issues/3707 When host is put in maintenance, and it is the only host available, all VMs on it are shutdown. This seems i

[GitHub] [cloudstack] rhtyd commented on issue #3625: ui allows disabled API call and then ends session

2019-11-22 Thread GitBox
rhtyd commented on issue #3625: ui allows disabled API call and then ends session URL: https://github.com/apache/cloudstack/issues/3625#issuecomment-557507993 @DaanHoogland okay here are my thoughts: 1 - looks valid, the handler of the call shoud check the API response for errors and on

[GitHub] [cloudstack] wido commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
wido commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349554523 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7 @@ publi

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
weizhouapache commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349527295 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7

[GitHub] [cloudstack] andrijapanicsb commented on issue #3627: server: Do NOT cleanup dhcp and dns when stop a vm

2019-11-22 Thread GitBox
andrijapanicsb commented on issue #3627: server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627#issuecomment-557476922 To be continued via: https://github.com/apache/cloudstack/issues/3706 thx both! ---

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
rhtyd commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349525909 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7 @@ publ

[GitHub] [cloudstack] andrijapanicsb opened a new issue #3706: Remove dhcp/dns configuration from VR, when VM is being DETACHED from a network

2019-11-22 Thread GitBox
andrijapanicsb opened a new issue #3706: Remove dhcp/dns configuration from VR, when VM is being DETACHED from a network URL: https://github.com/apache/cloudstack/issues/3706 As part of the additional cleanup discussed in https://github.com/apache/cloudstack/pull/3627, we also need to r

[GitHub] [cloudstack] weizhouapache commented on a change in pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
weizhouapache commented on a change in pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#discussion_r349523845 ## File path: utils/src/main/java/com/cloud/utils/net/NetUtils.java ## @@ -268,19 +268,7

[GitHub] [cloudstack] blueorangutan commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
blueorangutan commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557475318 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-377 This

[GitHub] [cloudstack] rhtyd commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
rhtyd commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557468865 @blueorangutan package This is an automated message from the Apach

[GitHub] [cloudstack] blueorangutan commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
blueorangutan commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557469080 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] rhtyd removed a comment on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
rhtyd removed a comment on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557466671 @blueorangutan package This is an automated message from t

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
blueorangutan removed a comment on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557466785 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] blueorangutan removed a comment on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
blueorangutan removed a comment on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557468734 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-376 --

[GitHub] [cloudstack] blueorangutan commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
blueorangutan commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557468734 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-376 This

[GitHub] [cloudstack] blueorangutan commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
blueorangutan commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557466785 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] rhtyd commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
rhtyd commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557466671 @blueorangutan package This is an automated message from the Apach

[GitHub] [cloudstack] rhtyd commented on issue #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
rhtyd commented on issue #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704#issuecomment-557466284 @andrijapanicsb no, we don't need net-tools (that's for older tools like ifconfig, route etc.) My PR switches to iproute (uses ip r

[GitHub] [cloudstack] andrijapanicsb commented on issue #3700: update default user vm template to later version

2019-11-22 Thread GitBox
andrijapanicsb commented on issue #3700: update default user vm template to later version URL: https://github.com/apache/cloudstack/issues/3700#issuecomment-557460324 Not sure we have CentOS8 mapping/guest OS for all hypervisors - but sounds like a very valid proposition (that I had in my

[GitHub] [cloudstack] DaanHoogland commented on issue #3625: ui allows disabled API call and then ends session

2019-11-22 Thread GitBox
DaanHoogland commented on issue #3625: ui allows disabled API call and then ends session URL: https://github.com/apache/cloudstack/issues/3625#issuecomment-557459252 @wido @rhtyd after analysing I think the session is invalidated to rigorously in the mentioned commits. Please consider:

[GitHub] [cloudstack] cl-k-takahashi opened a new issue #3705: ecdsa and ed25519 support for sshkeys

2019-11-22 Thread GitBox
cl-k-takahashi opened a new issue #3705: ecdsa and ed25519 support for sshkeys URL: https://github.com/apache/cloudstack/issues/3705 # ISSUE TYPE * Improvement Request # COMPONENT NAME ~~~ API ~~~ # CLOUDSTACK VERSION ~~~ m

[GitHub] [cloudstack] rhtyd opened a new pull request #3704: utils: use iproute to get default network interface

2019-11-22 Thread GitBox
rhtyd opened a new pull request #3704: utils: use iproute to get default network interface URL: https://github.com/apache/cloudstack/pull/3704 This uses `ip route` than `route` without an explicit path (/bin, /sbin etc.) to query the default network interface on the system. ## Typ

[GitHub] [cloudstack] weizhouapache commented on issue #3627: server: Do NOT cleanup dhcp and dns when stop a vm

2019-11-22 Thread GitBox
weizhouapache commented on issue #3627: server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627#issuecomment-557442289 @andrijapanicsb make sense. we need to remove dhcp/dns entries in VR when remove a nic from vm. ---

[GitHub] [cloudstack] rhtyd commented on issue #3627: server: Do NOT cleanup dhcp and dns when stop a vm

2019-11-22 Thread GitBox
rhtyd commented on issue #3627: server: Do NOT cleanup dhcp and dns when stop a vm URL: https://github.com/apache/cloudstack/pull/3627#issuecomment-557437870 This PR is closed, we might lose the discussion @andrijapanicsb - can you create a ticket with your concerns? (i.e. to cleanup on vm