[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343512269 ## File path: api/src/main/java/org/apache/cloudstack/api/command/admin/vm/ListUnmanagedInstancesCmd.java ## @@

[GitHub] [cloudstack] shwstppr edited a comment on issue #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr edited a comment on issue #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#issuecomment-550959874 @DaanHoogland will address logging related and remaining review comments soon. --

[GitHub] [cloudstack] shwstppr commented on issue #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on issue #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#issuecomment-550959874 @DaanHoogland will address logging related and remaing review comments soon. This is

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343507896 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java #

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343507916 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java #

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343506628 ## File path: engine/api/src/main/java/org/apache/cloudstack/engine/orchestration/service/VolumeOrchestrationService.java

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343506078 ## File path: server/src/test/java/org/apache/cloudstack/vm/VmImportManagerImplTest.java ## @@ -0,0 +1,334 @@ +p

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343506010 ## File path: api/src/main/java/com/cloud/vm/UserVmService.java ## @@ -513,4 +513,8 @@ UserVm upgradeVirtualMachi

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343505137 ## File path: api/src/main/java/org/apache/cloudstack/vm/UnmanagedInstance.java ## @@ -0,0 +1,333 @@ +// Licensed

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343503453 ## File path: core/src/main/java/com/cloud/agent/api/GetUnmanagedInstancesCommand.java ## @@ -0,0 +1,67 @@ +// L

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343492139 ## File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343491413 ## File path: engine/schema/src/main/java/com/cloud/storage/VMTemplateVO.java ## @@ -230,6 +230,13 @@ public stat

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343487813 ## File path: plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java #

[GitHub] [cloudstack] shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion

shwstppr commented on a change in pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#discussion_r343487634 ## File path: scripts/vm/hypervisor/vmware/discover_networks.py ## @@ -0,0 +1,272 @@ +#!/usr/bin/env python3 R

[GitHub] [cloudstack] msinhore commented on issue #3281: Block storage addition issues on XCP-ng

msinhore commented on issue #3281: Block storage addition issues on XCP-ng URL: https://github.com/apache/cloudstack/issues/3281#issuecomment-550536263 The same issue happen with HBA LUNs. This is an automated message from the

[GitHub] [cloudstack] rhtyd commented on a change in pull request #3659: Fix typo: the past tense of shutdown is shutdown, not shutdowned

rhtyd commented on a change in pull request #3659: Fix typo: the past tense of shutdown is shutdown, not shutdowned URL: https://github.com/apache/cloudstack/pull/3659#discussion_r343247947 ## File path: api/src/main/java/com/cloud/vm/VirtualMachine.java ## @@ -52,7 +52,7

[GitHub] [cloudstack] marcaurele commented on issue #3658: client: fix for jetty session timeout

marcaurele commented on issue #3658: client: fix for jetty session timeout URL: https://github.com/apache/cloudstack/pull/3658#issuecomment-550406033 For the record, this is the small embedded app to validate: https://github.com/marcaurele/embedded-jetty-uber-jar/tree/session-test

[cloudstack] branch master updated (3b82aba -> afab9fb)

This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 3b82aba .gitignore: ignore patches and unzipped logs (#3665) add afab9fb client: jetty session timeo

[GitHub] [cloudstack] andrijapanicsb merged pull request #3658: client: fix for jetty session timeout

andrijapanicsb merged pull request #3658: client: fix for jetty session timeout URL: https://github.com/apache/cloudstack/pull/3658 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [cloudstack] andrijapanicsb commented on issue #3658: client: fix for jetty session timeout

andrijapanicsb commented on issue #3658: client: fix for jetty session timeout URL: https://github.com/apache/cloudstack/pull/3658#issuecomment-550403358 merging based on 2 LGTM, manual testing and automated test results. thx @marcaurele !

[GitHub] [cloudstack] andrijapanicsb commented on issue #3658: client: fix for jetty session timeout

andrijapanicsb commented on issue #3658: client: fix for jetty session timeout URL: https://github.com/apache/cloudstack/pull/3658#issuecomment-550401114 all good @marcaurele. LGTM from my side (manual testing). This is

[GitHub] [cloudstack] andrijapanicsb commented on issue #3658: client: fix for jetty session timeout

andrijapanicsb commented on issue #3658: client: fix for jetty session timeout URL: https://github.com/apache/cloudstack/pull/3658#issuecomment-550397659 my bad, give me 2 minutes... This is an automated message from the Apach

[GitHub] [cloudstack] marcaurele commented on issue #3658: client: fix for jetty session timeout

marcaurele commented on issue #3658: client: fix for jetty session timeout URL: https://github.com/apache/cloudstack/pull/3658#issuecomment-550394926 @andrijapanicsb weird as I don't see any difference so far from the previous 2 commits. Can you double check you're using the right branch an

[GitHub] [cloudstack] rhtyd commented on issue #3658: client: fix for jetty session timeout

rhtyd commented on issue #3658: client: fix for jetty session timeout URL: https://github.com/apache/cloudstack/pull/3658#issuecomment-550394026 @marcaurele can you try https://stackoverflow.com/a/56091476 This is an automated

[GitHub] [cloudstack] andrijapanicsb commented on issue #3658: client: fix for jetty session timeout

andrijapanicsb commented on issue #3658: client: fix for jetty session timeout URL: https://github.com/apache/cloudstack/pull/3658#issuecomment-550391309 the latest code is NOT ok. I've set timeout to 2 minutes and I don't get logged out on 2m30sec (nor on 3m30sec nor on 4m15sec - tested

[GitHub] [cloudstack] GabrielBrascher commented on issue #3533: KVM local migration issue #3521

GabrielBrascher commented on issue #3533: KVM local migration issue #3521 URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-550293330 @andrijapanicsb I will run some tests and check this out, thanks for the heads-up. --

[GitHub] [cloudstack] GabrielBrascher commented on issue #3667: Update SystemVM Template for 4.14+

GabrielBrascher commented on issue #3667: Update SystemVM Template for 4.14+ URL: https://github.com/apache/cloudstack/issues/3667#issuecomment-550283293 @rhtyd considering that Python 2.7 will not be maintained past 2020 (will be retired on 1st January, 2020) next template should also have

[GitHub] [cloudstack] GabrielBrascher commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

GabrielBrascher commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-550280260 Cool, @andrijapanicsb! If you clone/checkout branch https://github.com/PCextreme/cloudstack/tree/fix_revert_rbd_snapshot_on_mas

[GitHub] [cloudstack] andrijapanicsb commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

andrijapanicsb commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-550278674 OK, I get it now – makes sense. I’m fine with either packages or simply a PR in the master, against which I can build packages.

[GitHub] [cloudstack] GabrielBrascher commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

GabrielBrascher commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-550278074 I kept this PR aiming the branch 4.13 as it is a simple fix and it would be nice to have it released in 4.13.1.0. @andrijap

[GitHub] [cloudstack] andrijapanicsb commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

andrijapanicsb commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-550272575 I can’t test upgrade since I already run “master” on this test env… I can test clean install, which requires a manually deployed

[GitHub] [cloudstack] rhtyd commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

rhtyd commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-550263506 Targeting 4.13 branch is fine as ultimately we forward merge the change to master @andrijapanicsb -

[GitHub] [cloudstack] andrijapanicsb commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

andrijapanicsb commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-550262933 @GabrielBrascher this seems to be a wrong branch to merge to (4.13) - please choose the master branch and ping me when done.

[GitHub] [cloudstack] andrijapanicsb commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

andrijapanicsb commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-550260423 I can test this at some point, have an env, which I can upgrade...

[cloudstack] branch master updated (d3f199f -> 3b82aba)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from d3f199f Increase DHCP lease time to infinite (#3662) add 3b82aba .gitignore: ignore patches and unzipped lo

[GitHub] [cloudstack] rhtyd merged pull request #3665: ignore patches and unzipped logs

rhtyd merged pull request #3665: ignore patches and unzipped logs URL: https://github.com/apache/cloudstack/pull/3665 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [cloudstack] rhtyd commented on issue #3665: ignore patches and unzipped logs

rhtyd commented on issue #3665: ignore patches and unzipped logs URL: https://github.com/apache/cloudstack/pull/3665#issuecomment-550195693 Changes are only in gitignore, no tests needed. This is an automated message from the