[GitHub] [cloudstack] blueorangutan commented on issue #3604: Fix Policy Based Routing for private gateway static routes

2019-09-24 Thread GitBox
blueorangutan commented on issue #3604: Fix Policy Based Routing for private gateway static routes URL: https://github.com/apache/cloudstack/pull/3604#issuecomment-534870299 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-292 ---

[GitHub] [cloudstack] blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

2019-09-24 Thread GitBox
blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-534870267 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-291 This is an aut

[GitHub] [cloudstack] GabrielBrascher commented on a change in pull request #3600: Allow deploy Admin/System VMs in disabled zones/pods/clusters

2019-09-24 Thread GitBox
GabrielBrascher commented on a change in pull request #3600: Allow deploy Admin/System VMs in disabled zones/pods/clusters URL: https://github.com/apache/cloudstack/pull/3600#discussion_r327940429 ## File path: engine/components-api/src/main/java/com/cloud/deploy/DeploymentPlanning

[GitHub] [cloudstack] blueorangutan commented on issue #3604: Fix Policy Based Routing for private gateway static routes

2019-09-24 Thread GitBox
blueorangutan commented on issue #3604: Fix Policy Based Routing for private gateway static routes URL: https://github.com/apache/cloudstack/pull/3604#issuecomment-534861741 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] rhtyd commented on issue #3604: Fix Policy Based Routing for private gateway static routes

2019-09-24 Thread GitBox
rhtyd commented on issue #3604: Fix Policy Based Routing for private gateway static routes URL: https://github.com/apache/cloudstack/pull/3604#issuecomment-534861537 @blueorangutan package This is an automated message from th

[GitHub] [cloudstack] blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

2019-09-24 Thread GitBox
blueorangutan commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-534861500 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM

2019-09-24 Thread GitBox
blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608#issuecomment-534861272 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] rhtyd commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

2019-09-24 Thread GitBox
rhtyd commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-534861278 @blueorangutan package This is an automated message from the Apache Git Serv

[GitHub] [cloudstack] rhtyd commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM

2019-09-24 Thread GitBox
rhtyd commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608#issuecomment-534861188 @blueorangutan test This is an automated message from the Ap

[GitHub] [cloudstack] blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM

2019-09-24 Thread GitBox
blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608#issuecomment-534858902 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-290

[GitHub] [cloudstack] blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely

2019-09-24 Thread GitBox
blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607#issuecomment-534856488 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-289 -

[GitHub] [cloudstack] blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely

2019-09-24 Thread GitBox
blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607#issuecomment-534856634 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests --

[GitHub] [cloudstack] rhtyd commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely

2019-09-24 Thread GitBox
rhtyd commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607#issuecomment-534856569 @blueorangutan test This is an automated mes

[GitHub] [cloudstack] blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM

2019-09-24 Thread GitBox
blueorangutan commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608#issuecomment-534853226 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] rhtyd commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM

2019-09-24 Thread GitBox
rhtyd commented on issue #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608#issuecomment-534853117 @blueorangutan package This is an automated message from the

[GitHub] [cloudstack] rhtyd opened a new pull request #3608: server: Cleanup dhcp and dns entries only on expunging VM

2019-09-24 Thread GitBox
rhtyd opened a new pull request #3608: server: Cleanup dhcp and dns entries only on expunging VM URL: https://github.com/apache/cloudstack/pull/3608 This fixes a behaviour to not cleanup DHCP and DNS rules for NICs of a VM in the VR when it is stopped, but instead when VM is expunged bec

[GitHub] [cloudstack] blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely

2019-09-24 Thread GitBox
blueorangutan commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607#issuecomment-534851003 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[cloudstack] branch master updated (8170ec5 -> 7f91964)

2019-09-24 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 8170ec5 kvm: Logrotate should not touch agent.log (#3597) add 7f91964 refactoring: Remove duplicate code (b

[GitHub] [cloudstack] rhtyd commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely

2019-09-24 Thread GitBox
rhtyd commented on issue #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607#issuecomment-534850739 @blueorangutan package This is an automated m

[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)

2019-09-24 Thread GitBox
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-534850580 LGTM, tests LGTM as well. Using lgtms from the original PR, merging this. ---

[GitHub] [cloudstack] rhtyd merged pull request #3538: Refactoring to remove duplicate code (by Frank/Nuage)

2019-09-24 Thread GitBox
rhtyd merged pull request #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cloudstack] rhtyd opened a new pull request #3607: allocator: in case of null guest OS don't fail prioritisation completely

2019-09-24 Thread GitBox
rhtyd opened a new pull request #3607: allocator: in case of null guest OS don't fail prioritisation completely URL: https://github.com/apache/cloudstack/pull/3607 In case of null guest OS found for a template, don't fail prioritisation completely (could still work based on HVM etc).

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-09-24 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-534796714 @anuragaw a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-09-24 Thread GitBox
anuragaw commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-534796593 @blueorangutan test This is an automated message from th

[GitHub] [cloudstack] GabrielBrascher commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot'

2019-09-24 Thread GitBox
GabrielBrascher commented on issue #3605: fix issue #3590 'Revert Ceph/RBD Snapshot' URL: https://github.com/apache/cloudstack/pull/3605#issuecomment-534715094 @andrijapanicsb Can you please check if RBD snapshot rollback will work for you with this fix? Thanks! --

[GitHub] [cloudstack] blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)

2019-09-24 Thread GitBox
blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-534639970 Trillian test result (tid-377) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time take

[GitHub] [cloudstack] blueorangutan commented on issue #3606: [WIP DO NOT MERGE] VM ingestion

2019-09-24 Thread GitBox
blueorangutan commented on issue #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606#issuecomment-534624431 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-288 This is an automated messa

[GitHub] [cloudstack] shwstppr closed pull request #3540: [WIP DO NOT MERGE] VM ingestion

2019-09-24 Thread GitBox
shwstppr closed pull request #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540 This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [cloudstack] shwstppr commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-09-24 Thread GitBox
shwstppr commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-534614423 Moved here, https://github.com/apache/cloudstack/pull/3606 This is an automated mess

[GitHub] [cloudstack] shwstppr opened a new pull request #3606: [WIP DO NOT MERGE] VM ingestion

2019-09-24 Thread GitBox
shwstppr opened a new pull request #3606: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3606 ## Description VM ingestion feature allows CloudStack to discover, on-board, import existing VMs in an infra. The feature currently works only for VMware, with a

[GitHub] [cloudstack] rhtyd commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-09-24 Thread GitBox
rhtyd commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-534520453 @shwstppr a lot of conflicts here, can you rebase or fix conflict? This is an automate

[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-09-24 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-534512448 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-287 This is an automated messa

[GitHub] [cloudstack] blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router

2019-09-24 Thread GitBox
blueorangutan commented on issue #3575: [WIP DO NOT MERGE] Health check feature for virtual router URL: https://github.com/apache/cloudstack/pull/3575#issuecomment-534423671 Packaging result: ✖centos6 ✔centos7 ✔debian. JID-286 ---

[GitHub] [cloudstack] blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)

2019-09-24 Thread GitBox
blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-534421555 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -

[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)

2019-09-24 Thread GitBox
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-534421461 CentOS7 job failed, rekicking @blueorangutan test This is an