[GitHub] [cloudstack] rhtyd commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception

2019-08-07 Thread GitBox
rhtyd commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519392436 The only thing I would check is if throwing an exception would cause any snapshot/item in the db to be set in incorrect state, i.e. any cleanup

[GitHub] [cloudstack] onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception

2019-08-07 Thread GitBox
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519389917 What do you think, @rhtyd ? Would a null value check in `VMSnapshotManagerImpl.orchestrateCreateVMSnapshot(VmWorkCreateVMSnapshot work)` be

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519389112 @rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-ce

[GitHub] [cloudstack] rhtyd commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
rhtyd commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519388839 VMware Tests LGTM @blueorangutan test

[GitHub] [cloudstack] rhtyd opened a new pull request #3547: [WIP] 4.13/master stabilisation PR

2019-08-07 Thread GitBox
rhtyd opened a new pull request #3547: [WIP] 4.13/master stabilisation PR URL: https://github.com/apache/cloudstack/pull/3547 Smoketests fixes. ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (no

[GitHub] [cloudstack] blueorangutan commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception

2019-08-07 Thread GitBox
blueorangutan commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519388264 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack] rhtyd commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception

2019-08-07 Thread GitBox
rhtyd commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519388146 @blueorangutan package This is an automated message from the Apache Git Servic

[GitHub] [cloudstack] kioie commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange

2019-08-07 Thread GitBox
kioie commented on a change in pull request #3522: New API endpoint: UpdateVlanIpRange URL: https://github.com/apache/cloudstack/pull/3522#discussion_r311844222 ## File path: api/src/org/apache/cloudstack/api/command/admin/vlan/UpdateVlanIpRangeCmd.java ## @@ -0,0 +1,137

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519334950 Trillian test result (tid-285) Environment: vmware-65u

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519315633 Trillian test result (tid-283) Environment: xenserver-

[GitHub] [cloudstack] kioie commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly

2019-08-07 Thread GitBox
kioie commented on a change in pull request #3532: Add new "Add volume" button, to add volume to VM instance directly URL: https://github.com/apache/cloudstack/pull/3532#discussion_r311722997 ## File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java ##

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519176163 @nvazquez a Trillian-Jenkins matrix job (centos6 mgmt + x

[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519176099 @blueorangutan test matrix --

[GitHub] [cloudstack] onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception

2019-08-07 Thread GitBox
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519174665 Sorry, scratch that last remark. These function only get a boolean return value. No risk of an NPE there. --

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519172743 Trillian test result (tid-277) Environment: xenserver-

[GitHub] [cloudstack] onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception

2019-08-07 Thread GitBox
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519171822 I suspect that `orchestrateDeleteVMSnapshot(VmWorkDeleteVMSnapshot work)` and `orchestrateDeleteAllVMSnapshots(VmWorkDeleteAllVMSnapshots wor

[GitHub] [cloudstack] onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception

2019-08-07 Thread GitBox
onitake commented on issue #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546#issuecomment-519170384 `VMSnapshotManagerImpl.orchestrateCreateVMSnapshot(Long vmId, Long vmSnapshotId, Boolean quiescevm)` is used in two places: - `VMSnapshotM

[cloudstack-documentation] branch service-offerings-linked-to-zones-doc-update updated (c3aa1b4 -> c923762)

2019-08-07 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch service-offerings-linked-to-zones-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. from c3aa1b4 service-offerings-linked-to-zones-doc-update

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519158261 Trillian test result (tid-278) Environment: kvm-centos

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519156564 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-234 ---

[cloudstack-documentation] branch service-offerings-linked-to-zones-doc-update created (now c3aa1b4)

2019-08-07 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a change to branch service-offerings-linked-to-zones-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git. at c3aa1b4 service-offerings-linked-to-zones-doc-update

[cloudstack-documentation] 01/01: service-offerings-linked-to-zones-doc-update

2019-08-07 Thread andrijapanic
This is an automated email from the ASF dual-hosted git repository. andrijapanic pushed a commit to branch service-offerings-linked-to-zones-doc-update in repository https://gitbox.apache.org/repos/asf/cloudstack-documentation.git commit c3aa1b43ab7b2e0c1a8a09128e147dbedabdd033 Author: Andrija P

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519148516 @nvazquez a Jenkins job has been kicked to build packages

[GitHub] [cloudstack] nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
nvazquez commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519148327 @blueorangutan package --

[GitHub] [cloudstack] onitake opened a new pull request #3546: [FIX] Rethrow takeVMSnapshot() exception

2019-08-07 Thread GitBox
onitake opened a new pull request #3546: [FIX] Rethrow takeVMSnapshot() exception URL: https://github.com/apache/cloudstack/pull/3546 ## Description This patch changes the behaviour of `VMSnapshotManagerImpl.VMSnapshot orchestrateCreateVMSnapshot(Long vmId, Long vmSnapshotId, Boolea

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519106539 Trillian test result (tid-279) Environment: vmware-65u

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519106417 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-233 ---

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519097638 @borisstoyanov a Jenkins job has been kicked to build pac

[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-519097274 @blueorangutan package -

[cloudstack] branch master updated: ui: fix for custom constrained offering params range check (#3545)

2019-08-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new a10e539 ui: fix for custom constrained offer

[GitHub] [cloudstack] rhtyd merged pull request #3545: ui: fix for custom constrained offering params range check

2019-08-07 Thread GitBox
rhtyd merged pull request #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545 This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [cloudstack] blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests

2019-08-07 Thread GitBox
blueorangutan commented on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-519082420 Trillian test result (tid-276) Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7 Total time taken: 27134 se

[GitHub] [cloudstack] shwstppr commented on issue #3517: 4.13.0.0/master: health checks smoketests

2019-08-07 Thread GitBox
shwstppr commented on issue #3517: 4.13.0.0/master: health checks smoketests URL: https://github.com/apache/cloudstack/pull/3517#issuecomment-519079962 VMware router start failure is with, ``` 2019-08-05 15:41:04,252 ERROR [c.c.u.s.SshHelper] (DirectAgent-177:ctx-8fff0c25 10.2.2.141,

[GitHub] [cloudstack] blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check

2019-08-07 Thread GitBox
blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519077001 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-232 ---

[GitHub] [cloudstack] blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check

2019-08-07 Thread GitBox
blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519069969 @shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] shwstppr commented on issue #3545: ui: fix for custom constrained offering params range check

2019-08-07 Thread GitBox
shwstppr commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519069781 @blueorangutan package This is an automated message from

[GitHub] [cloudstack] blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check

2019-08-07 Thread GitBox
blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519057931 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-231 ---

[GitHub] [cloudstack] blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)

2019-08-07 Thread GitBox
blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-519057125 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-230 Thi

[GitHub] [cloudstack] blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion

2019-08-07 Thread GitBox
blueorangutan commented on issue #3540: [WIP DO NOT MERGE] VM ingestion URL: https://github.com/apache/cloudstack/pull/3540#issuecomment-519041693 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-229 This is an automated messa

[GitHub] [cloudstack] blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check

2019-08-07 Thread GitBox
blueorangutan commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519039901 @borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] [cloudstack] borisstoyanov commented on issue #3545: ui: fix for custom constrained offering params range check

2019-08-07 Thread GitBox
borisstoyanov commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519039728 @blueorangutan package This is an automated message

[GitHub] [cloudstack] blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)

2019-08-07 Thread GitBox
blueorangutan commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-519038071 @rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack] rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage)

2019-08-07 Thread GitBox
rhtyd commented on issue #3538: Refactoring to remove duplicate code (by Frank/Nuage) URL: https://github.com/apache/cloudstack/pull/3538#issuecomment-519037899 @blueorangutan package This is an automated message from the Apa

[GitHub] [cloudstack] shwstppr commented on issue #3545: ui: fix for custom constrained offering params range check

2019-08-07 Thread GitBox
shwstppr commented on issue #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545#issuecomment-519037374 @borisstoyanov @andrijapanicsb @anuragaw @rhtyd @svenvogel kindly consider this for 4.13 milestone and please review c

[GitHub] [cloudstack] shwstppr opened a new pull request #3545: ui: fix for custom constrained offering params range check

2019-08-07 Thread GitBox
shwstppr opened a new pull request #3545: ui: fix for custom constrained offering params range check URL: https://github.com/apache/cloudstack/pull/3545 ## Description This PR fixes range check in VM deployment wizard while using custom constrained offering. Existing code was failing

[cloudstack] branch master updated: KVM local migration issue #3521 (#3533)

2019-08-07 Thread rohit
This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/master by this push: new 5dc982d KVM local migration issue #3521 (#35

[GitHub] [cloudstack] rhtyd merged pull request #3533: KVM local migration issue #3521

2019-08-07 Thread GitBox
rhtyd merged pull request #3533: KVM local migration issue #3521 URL: https://github.com/apache/cloudstack/pull/3533 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [cloudstack] rhtyd closed issue #3521: Regression bug in 4.13.0.0-SNAPSHOT that affects KVM local storage migration

2019-08-07 Thread GitBox
rhtyd closed issue #3521: Regression bug in 4.13.0.0-SNAPSHOT that affects KVM local storage migration URL: https://github.com/apache/cloudstack/issues/3521 This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack] rhtyd commented on issue #3533: KVM local migration issue #3521

2019-08-07 Thread GitBox
rhtyd commented on issue #3533: KVM local migration issue #3521 URL: https://github.com/apache/cloudstack/pull/3533#issuecomment-519033783 I think for EL6, storage migration (live) would be limiting. The feature should largely be encouraged on newer distros with newer libvirt.

[GitHub] [cloudstack] blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
blueorangutan commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518974000 @borisstoyanov a Trillian-Jenkins matrix job (centos6 mgm

[GitHub] [cloudstack] borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available

2019-08-07 Thread GitBox
borisstoyanov commented on issue #3271: [WIP: DO NOT MERGE] [Vmware] Allow configuring appliances on the VM instance wizard when OVF properties are available URL: https://github.com/apache/cloudstack/pull/3271#issuecomment-518973810 @blueorangutan test matrix -