stariy95 commented on code in PR #559:
URL: https://github.com/apache/cayenne/pull/559#discussion_r1085304861
##
modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/dialog/db/load/DbImportTreeNode.java:
##
@@ -207,4 +210,45 @@ public boolean isLoaded() {
public
stariy95 merged PR #558:
URL: https://github.com/apache/cayenne/pull/558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
Ivan-nikitko commented on code in PR #559:
URL: https://github.com/apache/cayenne/pull/559#discussion_r1087700992
##
modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/dialog/db/load/DbImportTreeNode.java:
##
@@ -207,4 +210,45 @@ public boolean isLoaded() {
pu
Ivan-nikitko commented on code in PR #559:
URL: https://github.com/apache/cayenne/pull/559#discussion_r1087701254
##
modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/editor/dbimport/DbImportSorter.java:
##
@@ -0,0 +1,110 @@
+/*
Ivan-nikitko commented on code in PR #559:
URL: https://github.com/apache/cayenne/pull/559#discussion_r1087712343
##
modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/editor/dbimport/DbImportSorter.java:
##
@@ -0,0 +1,110 @@
+/*
Ivan-nikitko commented on code in PR #559:
URL: https://github.com/apache/cayenne/pull/559#discussion_r1087700992
##
modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/dialog/db/load/DbImportTreeNode.java:
##
@@ -207,4 +210,45 @@ public boolean isLoaded() {
pu
Ivan-nikitko commented on code in PR #559:
URL: https://github.com/apache/cayenne/pull/559#discussion_r1087714682
##
modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/editor/dbimport/DbImportSorter.java:
##
@@ -0,0 +1,110 @@
+/*
Ivan-nikitko commented on code in PR #559:
URL: https://github.com/apache/cayenne/pull/559#discussion_r1087700992
##
modeler/cayenne-modeler/src/main/java/org/apache/cayenne/modeler/dialog/db/load/DbImportTreeNode.java:
##
@@ -207,4 +210,45 @@ public boolean isLoaded() {
pu
stariy95 commented on code in PR #559:
URL: https://github.com/apache/cayenne/pull/559#discussion_r1088860541
##
cayenne-server/src/main/resources/org/apache/cayenne/schema/11/dbimport.xsd:
##
@@ -73,6 +71,8 @@
+
Review Comment:
This change woul
Ivan-nikitko opened a new pull request, #560:
URL: https://github.com/apache/cayenne/pull/560
Since we have sorting in dbImport, it will be a good idea to have a
possibilty to mark or "pin" some of the patternshttps://user-images.githubusercontent.com/70625960/215539196-83b7643e-354b-47b0-bb
stariy95 merged PR #559:
URL: https://github.com/apache/cayenne/pull/559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
Ivan-nikitko closed pull request #560: Pinned feature in dBImport
URL: https://github.com/apache/cayenne/pull/560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
mattraydub opened a new pull request, #563:
URL: https://github.com/apache/cayenne/pull/563
This has the breaking test for CAY-2792.
The solution still needs to be investigated and implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, p
stariy95 merged PR #563:
URL: https://github.com/apache/cayenne/pull/563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
mattraydub opened a new pull request, #565:
URL: https://github.com/apache/cayenne/pull/565
Breaking test for [CAY-2794](https://issues.apache.org/jira/browse/CAY-2794)
All I had to do was add a Date attribute to `IvImpl`, and one of the
existing tests failed. But I did go ahead and s
stariy95 merged PR #565:
URL: https://github.com/apache/cayenne/pull/565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
Ivan-nikitko opened a new pull request, #568:
URL: https://github.com/apache/cayenne/pull/568
Auto sorting rules by types. Sorting by names by pressing button
--
m-dzianishchyts closed pull request #564: Oracle DB fixes
URL: https://github.com/apache/cayenne/pull/564
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
m-dzianishchyts opened a new pull request, #570:
URL: https://github.com/apache/cayenne/pull/570
I want to update these files so that they don't show up in ```git status```.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
m-dzianishchyts closed pull request #566: Integrate JSON type
URL: https://github.com/apache/cayenne/pull/566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
stariy95 merged PR #572:
URL: https://github.com/apache/cayenne/pull/572
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #570:
URL: https://github.com/apache/cayenne/pull/570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #569:
URL: https://github.com/apache/cayenne/pull/569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #571:
URL: https://github.com/apache/cayenne/pull/571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #574:
URL: https://github.com/apache/cayenne/pull/574
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
m-dzianishchyts opened a new pull request, #575:
URL: https://github.com/apache/cayenne/pull/575
Running tests for DB2 fails with [DB2 -542
error](https://www.sqlerror.de/db2_sql_error_-542_sqlstate_42831.html). The
reason is nullable db-attributes which are included in unique index because
stariy95 merged PR #562:
URL: https://github.com/apache/cayenne/pull/562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #561:
URL: https://github.com/apache/cayenne/pull/561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #575:
URL: https://github.com/apache/cayenne/pull/575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
m-dzianishchyts commented on PR #577:
URL: https://github.com/apache/cayenne/pull/577#issuecomment-1463677600
More changes from #571 are needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
m-dzianishchyts closed pull request #577: CAY-2795 Add unit tests for the Json
type [STABLE-4.2]
URL: https://github.com/apache/cayenne/pull/577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
stariy95 merged PR #576:
URL: https://github.com/apache/cayenne/pull/576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #567:
URL: https://github.com/apache/cayenne/pull/567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 merged PR #578:
URL: https://github.com/apache/cayenne/pull/578
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
dependabot[bot] opened a new pull request, #579:
URL: https://github.com/apache/cayenne/pull/579
Bumps [spring-core](https://github.com/spring-projects/spring-framework)
from 5.2.22.RELEASE to 5.2.23.RELEASE.
Release notes
Sourced from https://github.com/spring-projects/spring-fram
Ivan-nikitko opened a new pull request, #580:
URL: https://github.com/apache/cayenne/pull/580
Replacing toDepPk with fk to avoid confusion about understanding this
property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
stariy95 merged PR #579:
URL: https://github.com/apache/cayenne/pull/579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
dependabot[bot] opened a new pull request, #581:
URL: https://github.com/apache/cayenne/pull/581
Bumps [spring-core](https://github.com/spring-projects/spring-framework)
from 5.2.23.RELEASE to 5.2.24.RELEASE.
Release notes
Sourced from https://github.com/spring-projects/spring-fram
dependabot[bot] opened a new pull request, #585:
URL: https://github.com/apache/cayenne/pull/585
Bumps [sqlite-jdbc](https://github.com/xerial/sqlite-jdbc) from 3.36.0.3 to
3.41.2.2.
Release notes
Sourced from https://github.com/xerial/sqlite-jdbc/releases";>sqlite-jdbc's
releases
Ivan-nikitko opened a new pull request, #586:
URL: https://github.com/apache/cayenne/pull/586
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
Ivan-nikitko opened a new pull request, #587:
URL: https://github.com/apache/cayenne/pull/587
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
Ivan-nikitko opened a new pull request, #588:
URL: https://github.com/apache/cayenne/pull/588
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
stariy95 merged PR #588:
URL: https://github.com/apache/cayenne/pull/588
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
andrus commented on PR #588:
URL: https://github.com/apache/cayenne/pull/588#issuecomment-1625617497
@stariy95 , @Ivan-nikitko Hey guys, I don't see any references to Jira
numbers or entries in the RELEASE-NOTES. How are we going to track all the new
features if we do not link them to Jiras
stariy95 commented on PR #588:
URL: https://github.com/apache/cayenne/pull/588#issuecomment-1625639311
This is part of the
[CAY-2597](https://issues.apache.org/jira/browse/CAY-2597) but this PR doesn't
bring any public changes.
--
This is an automated message from the Apache Git Service.
andrus commented on PR #588:
URL: https://github.com/apache/cayenne/pull/588#issuecomment-1625650290
Oh, maybe also in CAY-2597 we can give a short description / examples of the
future user-facing API? I am very curious how the new `when` will look from the
user POV
--
This is an automat
dependabot[bot] opened a new pull request, #589:
URL: https://github.com/apache/cayenne/pull/589
Bumps [h2](https://github.com/h2database/h2database) from 2.1.214 to 2.2.220.
Release notes
Sourced from https://github.com/h2database/h2database/releases";>h2's
releases.
Versio
kaganem opened a new pull request, #590:
URL: https://github.com/apache/cayenne/pull/590
Hi there. I've found that there is a stuck progress on
https://github.com/apache/cayenne-website/pull/21 - @cottage14 did a
proof-reading on some docs, but published fixes in website repository. I've
t
Ivan-nikitko opened a new pull request, #591:
URL: https://github.com/apache/cayenne/pull/591
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
Ivan-nikitko opened a new pull request, #592:
URL: https://github.com/apache/cayenne/pull/592
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
Ivan-nikitko closed pull request #592: Cay 2811 incorrect sql building using
column querry with ast scalar no test
URL: https://github.com/apache/cayenne/pull/592
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
stariy95 merged PR #591:
URL: https://github.com/apache/cayenne/pull/591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
Ivan-nikitko opened a new pull request, #593:
URL: https://github.com/apache/cayenne/pull/593
**SQLBulder API example**
```
SelectBuilder builder = new SelectBuilder(column("OrderID"),
column("Quantity"),
caseWhen()
.when(column("Qu
asfgit merged PR #590:
URL: https://github.com/apache/cayenne/pull/590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apach
Ivan-nikitko opened a new pull request, #594:
URL: https://github.com/apache/cayenne/pull/594
[see ](https://issues.apache.org/jira/browse/CAY-2814) issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
Ivan-nikitko opened a new pull request, #595:
URL: https://github.com/apache/cayenne/pull/595
API redesign in EntityProperty, CollectionProperty, MapProperty
**Deprecated this methods:**
Expression inId(Collection ids)
Expression inId(Object firstId, Object... moreIds)
stariy95 opened a new pull request, #596:
URL: https://github.com/apache/cayenne/pull/596
This PR is supersedes #594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
stariy95 closed pull request #594: CAY-2814 select query iterator() and batch
iterator() methods return incorrect results
URL: https://github.com/apache/cayenne/pull/594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
stariy95 merged PR #596:
URL: https://github.com/apache/cayenne/pull/596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 opened a new pull request, #597:
URL: https://github.com/apache/cayenne/pull/597
This PR introduces `CayennePath` and `CayennePathSegment` classes (that
should be value objects, but that's still not a thing in Java).
It allows to make any path-related logic more transparent and
stariy95 merged PR #589:
URL: https://github.com/apache/cayenne/pull/589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
dependabot[bot] opened a new pull request, #598:
URL: https://github.com/apache/cayenne/pull/598
Bumps org.apache.derby:derby from 10.14.2.0 to 10.17.1.0.
[ from
3.5.0 to 3.8.1.
Commits
https://github.com/apache/maven/commit/05c21c65bdfed0f71a2f2ada8b84da59348c4c5d";>0
dependabot[bot] opened a new pull request, #600:
URL: https://github.com/apache/cayenne/pull/600
Bumps [org.apache.maven:maven-compat](https://github.com/apache/maven) from
3.5.0 to 3.8.1.
Commits
https://github.com/apache/maven/commit/05c21c65bdfed0f71a2f2ada8b84da59348c4c5d";
dependabot[bot] commented on PR #581:
URL: https://github.com/apache/cayenne/pull/581#issuecomment-1906430472
Superseded by #601.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
dependabot[bot] closed pull request #581: Bump spring-core from 5.2.23.RELEASE
to 5.2.24.RELEASE
URL: https://github.com/apache/cayenne/pull/581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
dependabot[bot] opened a new pull request, #601:
URL: https://github.com/apache/cayenne/pull/601
Bumps
[org.springframework:spring-core](https://github.com/spring-projects/spring-framework)
from 5.2.23.RELEASE to 6.0.15.
Release notes
Sourced from https://github.com/spring-project
stariy95 opened a new pull request, #603:
URL: https://github.com/apache/cayenne/pull/603
See `QualifierTranslatorExistExpressionIT.java` for examples of the
generated queries.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
jghansell opened a new pull request, #604:
URL: https://github.com/apache/cayenne/pull/604
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
stariy95 merged PR #604:
URL: https://github.com/apache/cayenne/pull/604
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
Jugen opened a new pull request, #605:
URL: https://github.com/apache/cayenne/pull/605
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
stariy95 opened a new pull request, #607:
URL: https://github.com/apache/cayenne/pull/607
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
stariy95 commented on PR #606:
URL: https://github.com/apache/cayenne/pull/606#issuecomment-1935495852
@Jugen Thanks for the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
stariy95 merged PR #606:
URL: https://github.com/apache/cayenne/pull/606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cayenne.apa
stariy95 commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1935525475
Hi @Jugen Thanks for another PR! It seems there are some problems with the
tests, please see
https://github.com/apache/cayenne/actions/runs/7830706412/job/21367291178?pr=605
--
This is
Jugen commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1935535384
Am looking into it, it's just trickier than I thought :-)
Have solved most so far, just one more to test to resolve.
--
This is an automated message from the Apache Git Service.
To respon
stariy95 commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1485816260
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/GroupByStage.java:
##
@@ -41,7 +41,7 @@ public void perform(TranslatorContext context) {
}
stariy95 commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1938319464
@Jugen Thanks for keeping it up. I did my review, but it seems a bit early
:) There are mostly minor things with the exception of the translation stages
rearrangement.
--
This is an aut
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1485952787
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/DistinctStage.java:
##
@@ -70,7 +70,7 @@ public void perform(TranslatorContext context) {
cont
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1485959529
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingStage.java:
##
@@ -71,4 +85,26 @@ private void processOrdering(QualifierTranslator
qualifierTr
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1485966341
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/GroupByStage.java:
##
@@ -41,7 +41,7 @@ public void perform(TranslatorContext context) {
}
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1485996375
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/DefaultSelectTranslator.java:
##
@@ -40,11 +40,11 @@ public class DefaultSelectTranslator implements
S
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1486012235
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/DefaultSelectTranslator.java:
##
@@ -40,11 +40,11 @@ public class DefaultSelectTranslator implements
S
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1486015595
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/DefaultSelectTranslator.java:
##
@@ -40,11 +40,11 @@ public class DefaultSelectTranslator implements
S
stariy95 commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1486041480
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/DefaultSelectTranslator.java:
##
@@ -40,11 +40,11 @@ public class DefaultSelectTranslator implements
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1486306763
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/DefaultSelectTranslator.java:
##
@@ -40,11 +40,11 @@ public class DefaultSelectTranslator implements
S
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1486308984
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/GroupByStage.java:
##
@@ -41,7 +41,7 @@ public void perform(TranslatorContext context) {
}
Jugen commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1940518358
@stariy95 Have now split OrderingStage into two as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
stariy95 commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1487338797
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingStage.java:
##
@@ -54,13 +60,15 @@ private void processOrdering(QualifierTranslator
qualifi
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1487416426
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingStage.java:
##
@@ -54,13 +60,15 @@ private void processOrdering(QualifierTranslator
qualifierT
Jugen commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1943106918
@stariy95 have added OrderingGroupByStage as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
stariy95 commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1943371860
@Jugen Great! I like how it's turned out overall. The last think that seems
off is performance of the duplicate check. But I don't have a better idea how
to optimize that. If you got neith
Jugen commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1944099714
I like how it's turned out as well, thanks so much for your guidance.
I can filter using DbAttribute, before doing the SQL compare, to save a
millisecond or two ([Graph](https://www.desmos.
stariy95 commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1944189731
Yep, filtering by `DbAttribute` should make sense. It should filter out
almost everything in most cases.
--
This is an automated message from the Apache Git Service.
To respond to the me
Jugen commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1945847402
@stariy95 Have added the DbAttribute filter.
(If I measured right then we're saving about 1ms per 100 columns)
--
This is an automated message from the Apache Git Service.
To respond to t
Jugen commented on PR #605:
URL: https://github.com/apache/cayenne/pull/605#issuecomment-1947853798
@stariy95 I don't have any further changes in mind, so we can proceed with a
final review when convenient
--
This is an automated message from the Apache Git Service.
To respond to the
stariy95 commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1492412472
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java:
##
@@ -0,0 +1,107 @@
+/*
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1492478211
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java:
##
@@ -0,0 +1,107 @@
+/
stariy95 commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1492495670
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java:
##
@@ -0,0 +1,107 @@
+/*
Jugen commented on code in PR #605:
URL: https://github.com/apache/cayenne/pull/605#discussion_r1492595875
##
cayenne/src/main/java/org/apache/cayenne/access/translator/select/OrderingAbstractStage.java:
##
@@ -0,0 +1,107 @@
+/
1 - 100 of 227 matches
Mail list logo
