[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523983#comment-17523983
]
Ekaterina Dimitrova commented on CASSANDRA-17332:
-
Manual inspection
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523976#comment-17523976
]
Ekaterina Dimitrova commented on CASSANDRA-17332:
-
As I think the c
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520714#comment-17520714
]
David Capwell commented on CASSANDRA-17332:
---
Starting commit
CI Results (
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520636#comment-17520636
]
Alex Petrov commented on CASSANDRA-17332:
-
+1, the only thing I'd do is eith
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519646#comment-17519646
]
Josh McKenzie commented on CASSANDRA-17332:
---
+1. Great work David!
> Add
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519258#comment-17519258
]
David Capwell commented on CASSANDRA-17332:
---
all feedback is address, [~if
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516160#comment-17516160
]
David Capwell commented on CASSANDRA-17332:
---
sent patch for 3.0+ with CI.
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17516149#comment-17516149
]
David Capwell commented on CASSANDRA-17332:
---
Tested using 3.0 upgrade test
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17515482#comment-17515482
]
David Capwell commented on CASSANDRA-17332:
---
Alex just sent out the vote f
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513634#comment-17513634
]
David Capwell commented on CASSANDRA-17332:
---
merged api changes:
https://
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513555#comment-17513555
]
David Capwell commented on CASSANDRA-17332:
---
confirmed with [~ifesdjeen],
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512450#comment-17512450
]
Josh McKenzie commented on CASSANDRA-17332:
---
+1
> Add support for vnodes
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512082#comment-17512082
]
David Capwell commented on CASSANDRA-17332:
---
all feedback is addressed, le
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512079#comment-17512079
]
David Capwell commented on CASSANDRA-17332:
---
Here is dtest api PR based of
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17512047#comment-17512047
]
David Capwell commented on CASSANDRA-17332:
---
added the test case, and by d
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511947#comment-17511947
]
David Capwell commented on CASSANDRA-17332:
---
bq. in theory, there should b
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511338#comment-17511338
]
Josh McKenzie commented on CASSANDRA-17332:
---
One tiny nit left on review;
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511210#comment-17511210
]
Alex Petrov commented on CASSANDRA-17332:
-
bq. I feel like for testing if th
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511205#comment-17511205
]
Brandon Williams commented on CASSANDRA-17332:
--
bq. Should we have vnod
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17511120#comment-17511120
]
Alex Petrov commented on CASSANDRA-17332:
-
Some minor comments:
* I would
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510977#comment-17510977
]
David Capwell commented on CASSANDRA-17332:
---
[~ifesdjeen] [~jmckenzie] tru
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510045#comment-17510045
]
David Capwell commented on CASSANDRA-17332:
---
pushed dtest-api-0.0.13-20220
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510012#comment-17510012
]
David Capwell commented on CASSANDRA-17332:
---
back, so will start looking i
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17499088#comment-17499088
]
David Capwell commented on CASSANDRA-17332:
---
will pick this up in trunk ar
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17497766#comment-17497766
]
David Capwell commented on CASSANDRA-17332:
---
I see we don't publish snapsh
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17496387#comment-17496387
]
David Capwell commented on CASSANDRA-17332:
---
sorry for dropping this, had
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488485#comment-17488485
]
David Capwell commented on CASSANDRA-17332:
---
Merged jvm-dtest api changes
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488227#comment-17488227
]
Josh McKenzie commented on CASSANDRA-17332:
---
+1
> Add support for vnodes
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17488207#comment-17488207
]
Alex Petrov commented on CASSANDRA-17332:
-
+1 ; the only thing I'd theoretic
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486079#comment-17486079
]
Josh McKenzie commented on CASSANDRA-17332:
---
Left a few comments between t
[
https://issues.apache.org/jira/browse/CASSANDRA-17332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485414#comment-17485414
]
David Capwell commented on CASSANDRA-17332:
---
sent patch out for jvm-dtest,
31 matches
Mail list logo