Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-22 Thread via GitHub
liucao-dd commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3105274241 Sure, created https://issues.apache.org/jira/projects/CASSANALYTICS/issues/CASSANALYTICS-79 -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-22 Thread via GitHub
yifan-c commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3105082962 @liucao-dd , I see what you mean. You are right. The calculation is not rack-aware. The problem to solve here is not limited to vnode, but to make the range calculation r

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-22 Thread via GitHub
liucao-dd commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3101520448 @yifan-c Thanks for checking again. Apology that my earlier example is not correct / complete. Allow me to correct it: Referring to the same github gist, 1-indexed en

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-21 Thread via GitHub
yifan-c commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-315898 @liucao-dd, I will need more help on understanding the issue. Btw, thanks for sharing the example. In the instances list shared, the vnode that owns token `-9095340097586

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-21 Thread via GitHub
liucao-dd commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3099771451 Hi @anderoo and @yifan-c thx for getting back. I was looking into this more closely today. > For example, a cluster of 12 C* nodes with vnode=4 should produce the list of

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-21 Thread via GitHub
yifan-c commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3097726389 @liucao-dd, thanks for paying attention to the details! Just to clarify that in the vnode setup, the `List instances` for `calculateTokenRanges` is a list of vnodes sorted

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-21 Thread via GitHub
anderoo commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3096693774 Started a draft here: https://github.com/apache/cassandra-analytics/pull/133 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-20 Thread via GitHub
anderoo commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3094406641 @liucao-dd I see the concern here, especially with the disjointReplica assumption. I'll get a PR together and ensure test coverage for multiple vnodes. I'm not entirely sur

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-19 Thread via GitHub
anderoo commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3092410956 @liucao-dd Actually I think I see the concern with calculateTokenRanges, isn't this is the case if the instance list is not ordered by tokens regardless? -- This is an automate

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-19 Thread via GitHub
anderoo commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3092167684 @liucao-dd Could you provide an example just so I make sure I'm understanding the problem correctly -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-07-18 Thread via GitHub
liucao-dd commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3091351749 > TokenPartitioner > > Just following up on this one @anderoo, does this patch alone work for you? I would have thought there would be changes required to the `C

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-05-08 Thread via GitHub
frankgh merged PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ca

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-05-08 Thread via GitHub
anderoo commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-2864353430 https://github.com/user-attachments/assets/73d1de71-fed3-4e22-b9dd-47743bdf5e04"; /> -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] CASSANALYTICS-50: Add support for vnodes [cassandra-analytics]

2025-05-08 Thread via GitHub
anderoo commented on code in PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#discussion_r2080284587 ## cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/ClientConfig.java: ## @@ -53,6 +53,11 @@ public class ClientConfig public static