Re: wordRangeForRange implememtation

2008-05-11 Thread Adam R. Maxwell
On May 11, 2008, at 2:45 PM, Jérome Laurens wrote: Le 11 mai 08 à 04:42, Ali Ozer a écrit : To extract a word range from a string, it may be easier to use something like NSScanner: // Defining the words NSCharacterSet *validWordSet = [NSCharacterSet alphanumericCharacterSet]; // Or howe

Re: wordRangeForRange implememtation

2008-05-11 Thread Kyle Sluder
On Sun, May 11, 2008 at 5:45 PM, Jérome Laurens <[EMAIL PROTECTED]> wrote: > So I reimplemented my own NSScanner and it was way faster. Did you profile the application first to make sure that NSScanner was indeed the source of your slowdown? --Kyle Sluder

Re: wordRangeForRange implememtation

2008-05-11 Thread Jérome Laurens
Le 11 mai 08 à 04:42, Ali Ozer a écrit : To extract a word range from a string, it may be easier to use something like NSScanner: // Defining the words NSCharacterSet *validWordSet = [NSCharacterSet alphanumericCharacterSet]; // Or however you want to define words NSCharacterSet *wordBre

Re: wordRangeForRange implememtation

2008-05-10 Thread Ali Ozer
> Date: May 10, 2008 7:42:11 PDT To: Lincoln Green <[EMAIL PROTECTED]> Cc: Ali Ozer <[EMAIL PROTECTED]>, cocoa-dev@lists.apple.com Subject: Re: wordRangeForRange implememtation There are a number of problems in this code... - (NSRange)wordRangeForRange:(NSRange)range{ NSString *s

Re: wordRangeForRange implememtation

2008-05-10 Thread Ali Ozer
There are a number of problems in this code... - (NSRange)wordRangeForRange:(NSRange)range{ NSString *string = [NSString stringWithString:[[self string] substringWithRange:range]]; Why do you make yet another copy of the string; you already have the substring? Maybe you meant to make a m

Re: wordRangeForRange implememtation

2008-05-10 Thread Nathan Kinsinger
On May 10, 2008, at 2:26 PM, Lincoln Green wrote: - (NSRange)wordRangeForRange:(NSRange)range{ NSString *string = [NSString stringWithString:[[self string] substringWithRange:range]]; if([string hasPrefix:@" "]){ [string stringByReplacingCharactersInRange:NSMakeRange(0, 1) withS

wordRangeForRange implememtation

2008-05-10 Thread Lincoln Green
- (NSRange)wordRangeForRange:(NSRange)range{ NSString *string = [NSString stringWithString:[[self string] substringWithRange:range]]; if([string hasPrefix:@" "]){ [string stringByReplacingCharactersInRange:NSMakeRange(0, 1) withString:@""]; range.location++;