Re: Proper switching and casing.

2015-04-09 Thread Steve Mills
On Apr 9, 2015, at 16:05:57, Alex Zavatone wrote: > > Is there any reasonable case where you'd want a case condition to not have a > break statement after it? Sure, and it happens a lot: switch(justification) { case kLeft: case kCenter: case kRight: DoRe

Re: Proper switching and casing.

2015-04-09 Thread Alex Zavatone
On Apr 9, 2015, at 5:10 PM, Sean McBride wrote: > On Thu, 9 Apr 2015 17:05:57 -0400, Alex Zavatone said: > >> Sorry that I sent this before the main observation. >> >> Considering the implications of this, should Xcode's compiler flag these >> "unbreak-ed case statements" with a warning? Curr

Re: Proper switching and casing.

2015-04-09 Thread Sean McBride
On Thu, 9 Apr 2015 17:05:57 -0400, Alex Zavatone said: >Sorry that I sent this before the main observation. > >Considering the implications of this, should Xcode's compiler flag these >"unbreak-ed case statements" with a warning? Currently, it doesn't do that. -Wimplict-fallthrough >Is there a

Re: Proper switching and casing.

2015-04-09 Thread Alex Zavatone
Sorry that I sent this before the main observation. Considering the implications of this, should Xcode's compiler flag these "unbreak-ed case statements" with a warning? Currently, it doesn't do that. Is there any reasonable case where you'd want a case condition to not have a break statement

Proper switching and casing.

2015-04-09 Thread Alex Zavatone
I'm looking through the new code that I've inherited and getting to know and love it and I'm running across a few new circumstances I've never seen before. With that said, I just noticed a switch statement with empty case conditions where the variable being checked will be 0, and the execution p