Re: Code Comments

2012-09-10 Thread James Montgomerie
On 9 Sep 2012, at 17:57, koko wrote: > On Sep 9, 2012, at 7:35 AM, Mike Abdullah wrote: > >> NSXMLParser supports NSInputStream directly these days; consider moving to >> that > > That is excellent but for now I must run on 10.5.8 … Aside from the memory management issues already pointed out,

Re: Code Comments

2012-09-09 Thread koko
On Sep 9, 2012, at 7:35 AM, Mike Abdullah wrote: > NSXMLParser supports NSInputStream directly these days; consider moving to > that That is excellent but for now I must run on 10.5.8 … ___ Cocoa-dev mailing list (Cocoa-dev@lists.apple.com) Please

Re: Code Comments

2012-09-09 Thread Mike Abdullah
Further to existing comments: * NSXMLParser supports NSInputStream directly these days; consider moving to that * When releasing the parser because you're finished with it, might as well set the delegate to nil so you can't accidentally end up with a dangling pointer there On 9 Sep 2012, at 04

Re: Code Comments

2012-09-08 Thread Seth Willits
On Sep 8, 2012, at 8:00 PM, koko wrote: > the m_xmlParserDelegate object is instanced in IB Not a fan of instantiating objects in IB. Way too easy to get gigantic nibs going which ain't right. > - (void)startMessageParse:(void*)msgStart end:(void*)msgEnd > { >NSInteger length = msgEnd-msgS

Code Comments

2012-09-08 Thread koko
Does this code look correct in terms of memory management? It is called when a complete XML document is recognized (received via NSStream of a telnet host port) msgStart and msgEnd point to the beginning and ending the length check is arbitrary as I found without it I could get lengths that c