Hey Olaf,
I just wanted to thank you for taking the time out to code review what Ted had
done.
Feel free to continue doing code reviews--reviewing is one practice that I hope
we can all get into more.
As we evolve the project and actually get stuff written, I'd like to also make
sure that we
ge-
From: Andrew Fenn [mailto:andrewf...@gmail.com]
Sent: Thursday, August 05, 2010 8:20 PM
To: Garrett Serack
Cc: Rivera, Rafael; Elizabeth M Smith; coapp-developers@lists.launchpad.net
Subject: Re: [Coapp-developers] Engine - Teds initial take
I have no idea when it comes to unicode in C/C++ howe
---
> From: coapp-developers-bounces+garretts=microsoft@lists.launchpad.net
> [mailto:coapp-developers-bounces+garretts=microsoft@lists.launchpad.net]
> On Behalf Of Rivera, Rafael
> Sent: Wednesday, August 04, 2010 6:06 PM
> To: Elizabeth M Smith
> Cc: coapp-developers@li
The godfather has spoken.
On Thu, Aug 5, 2010 at 3:05 PM, Garrett Serack wrote:
>
> (still on vacation... just poking my nose in).
>
> I had no particular opinion [ _T("") vs L"" ] but I do like the idea that
> perhaps we should explicitly NOT support ANSI. I can't see a really good
> reason to s
To: Elizabeth M Smith
Cc: coapp-developers@lists.launchpad.net
Subject: Re: [Coapp-developers] Engine - Teds initial take
That's a pretty poor reason to not type a few extra characters... but I can't
offer a concrete reason why we should support ANSI.
/rafael
On 8/4/2010 11:25 AM, Elizabeth
That's a pretty poor reason to not type a few extra characters... but I
can't offer a concrete reason why we should support ANSI.
/rafael
On 8/4/2010 11:25 AM, Elizabeth M Smith wrote:
> On 8/4/2010 11:13 AM, Rivera, Rafael wrote:
>> Looks nice, love the chip name.
>>
>> Just one note -- I see wi
On Wed, Aug 4, 2010 at 6:24 PM, Ted Bullock wrote:
>>> '\\ No newline at end of file'
>>
>> Might be a good idea to add this newline to every file. A shame VS
>> doesn't do this by default...
>
> Is this really important? Why would we need a new line at the end of the file?
No, but
http://bazaar
On Wed, Aug 4, 2010 at 8:30 AM, Olaf van der Spek wrote:
> chip/chip.c:
>> if(err = coapp_core_new(&chip_core))
>
> What does the style guide say about a space between if and (?
> My preference is a space.
We haven't specified it. This is how I have coded in the past.
Personally I don't really c
On 8/4/2010 11:25 AM, Elizabeth M Smith wrote:
On 8/4/2010 11:13 AM, Rivera, Rafael wrote:
Looks nice, love the chip name.
Just one note -- I see wide-character strings in use. I suggest
replacing them, and their print functions, with T equivalents, leaving
the choice
On 8/4/2010 11:13 AM, Rivera, Rafael wrote:
Looks nice, love the chip name.
Just one note -- I see wide-character strings in use. I suggest
replacing them, and their print functions, with T equivalents, leaving
the choice of ANSI or UNICODE to the magical defines in the headers and
ultimately th
On Wed, Aug 4, 2010 at 5:16 PM, Rivera, Rafael wrote:
> And waste two bytes?! Silly ANSI and ISO C standards.
Only one if you use Linux EOLs. ;)
Olaf
___
Mailing list: https://launchpad.net/~coapp-developers
Post to : coapp-developers@lists.launch
And waste two bytes?! Silly ANSI and ISO C standards.
/rafael
On 8/4/2010 10:30 AM, Olaf van der Spek wrote:
>
>> '\\ No newline at end of file'
>>
> Might be a good idea to add this newline to every file. A shame VS
> doesn't do this by default...
>
_
Looks nice, love the chip name.
Just one note -- I see wide-character strings in use. I suggest
replacing them, and their print functions, with T equivalents, leaving
the choice of ANSI or UNICODE to the magical defines in the headers and
ultimately the human compiling this stuff.
So, from initia
On Wed, Aug 4, 2010 at 7:32 AM, Ted Bullock wrote:
> Hi Folks,
>
> I just committed a couple hours of thought towards the coapp-engine to:
>
> http://bazaar.launchpad.net/~tbullock/coapp-engine/experiment/changes
Hi Ted,
Just a few quick comments from a scan of the code. Haven't compiled it yet:
Hi Folks,
I just committed a couple hours of thought towards the coapp-engine to:
http://bazaar.launchpad.net/~tbullock/coapp-engine/experiment/changes
This does profoundly little at the moment but does specify the
beginnings of the coapp engine event loop that I have envisioned. I
would have li
15 matches
Mail list logo
