Re: patch for `ant build-apidocs` target on OSX

2012-08-23 Thread Wido den Hollander
On 08/22/2012 05:44 PM, Greg Burd wrote: Wildo, I've signed and filed the Apache ICLA (http://www.apache.org/licenses/icla.txt) not the Citrix one. I've checked, but for submitting small patches like these the Apache ICLA isn't mandatory. I thought you found the old Citrix agreement somewh

Re: patch for `ant build-apidocs` target on OSX

2012-08-22 Thread Greg Burd
Wildo, I've signed and filed the Apache ICLA (http://www.apache.org/licenses/icla.txt) not the Citrix one. @gregburd, Basho Technologies | http://basho.com | @basho On Wednesday, August 22, 2012 at 10:38 AM, Wido den Hollander wrote: > On 08/22/2012 04:27 PM, Greg Burd wrote: > > Hello, > > >

Re: patch for `ant build-apidocs` target on OSX

2012-08-22 Thread Greg Burd
Thanks, I'll give that a try. @gregburd, Basho Technologies | http://basho.com | @basho On Wednesday, August 22, 2012 at 10:31 AM, Chip Childers wrote: > On Wed, Aug 22, 2012 at 10:27 AM, Greg Burd (mailto:g...@basho.com)> wrote: > > Hello, > > > > I develop on OSX and I found a few small is

Re: patch for `ant build-apidocs` target on OSX

2012-08-22 Thread Wido den Hollander
On 08/22/2012 04:27 PM, Greg Burd wrote: Hello, I develop on OSX and I found a few small issues in the build-apidoc.sh script. `readlink -f` isn't supported and a `find` was missing the directory argument. How do these get tested/reviewed and into master? I've signed and filed my contributo

Re: patch for `ant build-apidocs` target on OSX

2012-08-22 Thread Chip Childers
On Wed, Aug 22, 2012 at 10:27 AM, Greg Burd wrote: > Hello, > > I develop on OSX and I found a few small issues in the build-apidoc.sh > script. `readlink -f` isn't supported and a `find` was missing the directory > argument. > > How do these get tested/reviewed and into master? I've signed an

patch for `ant build-apidocs` target on OSX

2012-08-22 Thread Greg Burd
Hello, I develop on OSX and I found a few small issues in the build-apidoc.sh script. `readlink -f` isn't supported and a `find` was missing the directory argument. How do these get tested/reviewed and into master? I've signed and filed my contributor agreement already. best, @gregburd, B