Re: Review Request: VPC create vm from ISO template

2012-09-26 Thread mice xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7278/#review11962 --- Ship it! Ship It! - mice xia On Sept. 26, 2012, 5:21 p.m., Marcus

Re: Review Request: VPC create vm from ISO template

2012-09-26 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7278/ --- (Updated Sept. 26, 2012, 5:21 p.m.) Review request for cloudstack and mice xia.

Re: Review Request: VPC create vm from ISO template

2012-09-26 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7278/ --- (Updated Sept. 26, 2012, 5:11 p.m.) Review request for cloudstack and mice xia.

Re: Review Request: VPC create vm from ISO template

2012-09-26 Thread mice xia
> On Sept. 26, 2012, 5:40 a.m., mice xia wrote: > > should we also consider isISO situation? like including condition (isIso > > && !vpcSupportedHTypes.contains(hypervisor)), there is a parameter > > 'hypervisor' passed from API layer. > > Marcus Sorensen wrote: > I suppose it depends on

Re: Review Request: VPC create vm from ISO template

2012-09-25 Thread Marcus Sorensen
> On Sept. 26, 2012, 5:40 a.m., mice xia wrote: > > should we also consider isISO situation? like including condition (isIso > > && !vpcSupportedHTypes.contains(hypervisor)), there is a parameter > > 'hypervisor' passed from API layer. > > Marcus Sorensen wrote: > I suppose it depends on

Re: Review Request: VPC create vm from ISO template

2012-09-25 Thread mice xia
> On Sept. 26, 2012, 5:40 a.m., mice xia wrote: > > should we also consider isISO situation? like including condition (isIso > > && !vpcSupportedHTypes.contains(hypervisor)), there is a parameter > > 'hypervisor' passed from API layer. > > Marcus Sorensen wrote: > I suppose it depends on

Re: Review Request: VPC create vm from ISO template

2012-09-25 Thread Marcus Sorensen
> On Sept. 26, 2012, 5:40 a.m., mice xia wrote: > > should we also consider isISO situation? like including condition (isIso > > && !vpcSupportedHTypes.contains(hypervisor)), there is a parameter > > 'hypervisor' passed from API layer. I suppose it depends on whether the intent was to test th

Re: Review Request: VPC create vm from ISO template

2012-09-25 Thread mice xia
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7278/#review11920 --- should we also consider isISO situation? like including condition (i

Review Request: VPC create vm from ISO template

2012-09-25 Thread Marcus Sorensen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7278/ --- Review request for cloudstack and mice xia. Description --- This should fix