Re: Review Request: Fix for CLOUDSTACK-648

2012-12-25 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8637/#review14892 --- Applied on master; >From 5aefd77f774723dd5729324043e62a413f580da8 Mon

Re: Review Request: Fix for CLOUDSTACK-648

2012-12-25 Thread Isaac Chiang
Hi Gavin: Done, thanks :) On Tue, Dec 25, 2012 at 9:06 PM, Gavin Lee wrote: >This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/8637/ > > On December 25th, 2012, 1:04 p.m., *Gavin Lee* wrote: > > Ship It! > > Hi, Isaac > Thank for this pat

Re: Review Request: Fix for CLOUDSTACK-648

2012-12-25 Thread Gavin Lee
> On Dec. 25, 2012, 1:04 p.m., Gavin Lee wrote: > > Ship It! Hi, Isaac Thank for this patch & sorry for my late reply. Please close as submitted. - Gavin --- This is an automatically generated e-mail. To reply, visit: https://reviews.ap

Re: Review Request: Fix for CLOUDSTACK-648

2012-12-25 Thread Gavin Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8637/#review14889 --- Ship it! Ship It! - Gavin Lee On Dec. 18, 2012, 2:16 a.m., Isaac

Re: Review Request: Fix for CLOUDSTACK-648

2012-12-25 Thread Gavin Lee
> On Dec. 17, 2012, 6:40 p.m., Rohit Yadav wrote: > > Pl. fix those evil trailing whitespaces and tabs (no tabs, only whitespaces > > please). > > Not sure if we should it this way. Probably the whole user and project > > management should be moved out of cloudstack as an adapter or business >

Re: Review Request: Fix for CLOUDSTACK-648

2012-12-17 Thread Rohit Yadav
> On Dec. 17, 2012, 6:40 p.m., Rohit Yadav wrote: > > Pl. fix those evil trailing whitespaces and tabs (no tabs, only whitespaces > > please). > > Not sure if we should it this way. Probably the whole user and project > > management should be moved out of cloudstack as an adapter or business >

Re: Review Request: Fix for CLOUDSTACK-648

2012-12-17 Thread Isaac Chiang
> On Dec. 17, 2012, 6:40 p.m., Rohit Yadav wrote: > > Pl. fix those evil trailing whitespaces and tabs (no tabs, only whitespaces > > please). > > Not sure if we should it this way. Probably the whole user and project > > management should be moved out of cloudstack as an adapter or business >

Re: Review Request: Fix for CLOUDSTACK-648

2012-12-17 Thread Isaac Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8637/ --- (Updated Dec. 18, 2012, 2:16 a.m.) Review request for cloudstack and Gavin Lee.

Re: Review Request: Fix for CLOUDSTACK-648

2012-12-17 Thread Rohit Yadav
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8637/#review14595 --- Pl. fix those evil trailing whitespaces and tabs (no tabs, only white

Review Request: Fix for CLOUDSTACK-648

2012-12-17 Thread Isaac Chiang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8637/ --- Review request for cloudstack and Gavin Lee. Description --- This patch is