Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

2013-02-25 Thread Nitin Mehta
> On Feb. 26, 2013, 5:09 a.m., Nitin Mehta wrote: > > Ship It! Pushed with commit 10236bee26f79391838c103972d0afa551e5efd4 - Nitin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9558/#review

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

2013-02-25 Thread Devdeep Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9558/#review17074 --- Ship it! Ship It! - Devdeep Singh On Feb. 25, 2013, 4:15 p.m., Sa

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

2013-02-25 Thread Abhinandan Prateek
I think ship it code should be committed too. After which the contributor should close the review request. On 26/02/13 10:39 AM, "Nitin Mehta" wrote: > >--- >This is an automatically generated e-mail. To reply, visit: >https://reviews.apach

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

2013-02-25 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9558/#review17072 --- Ship it! Ship It! - Nitin Mehta On Feb. 25, 2013, 4:15 p.m., Sanj

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

2013-02-25 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9558/ --- (Updated Feb. 25, 2013, 4:15 p.m.) Review request for cloudstack, Devdeep Singh,

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

2013-02-25 Thread Nitin Mehta
me...@citrix.com>>, "cloudstack-dev@incubator.apache.org<mailto:cloudstack-dev@incubator.apache.org>" mailto:cloudstack-dev@incubator.apache.org>>, Sanjay Tripathi mailto:sanjay.tripa...@citrix.com>> Subject: Re: Review Request: CLOUDSTACK-1374: Volume table is not getting up

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

2013-02-25 Thread Sanjay Tripathi
> On Feb. 25, 2013, 12:37 p.m., Nitin Mehta wrote: > > server/src/com/cloud/storage/download/DownloadMonitorImpl.java, line 742 > > > > > > What if the size is already set ? why do we need to set it again ? This is for

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

2013-02-25 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9558/#review17035 --- server/src/com/cloud/storage/download/DownloadMonitorImpl.java

Re: Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

2013-02-25 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9558/ --- (Updated Feb. 25, 2013, 12:31 p.m.) Review request for cloudstack, Devdeep Singh

Review Request: CLOUDSTACK-1374: Volume table is not getting updated with volume size.

2013-02-22 Thread Sanjay Tripathi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9558/ --- Review request for cloudstack, Devdeep Singh and Sateesh Chodapuneedi. Descripti