RE: Review Request: Support for local data disk feature. (CS-14277)

2012-09-11 Thread Nitin Mehta
local data disk feature. (CS-14277) This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/ Ship it! Ship It! - Nitin On September 11th, 2012, 9:50 a.m., Koushik Das wrote: Review request for cloudstack, Abhinandan Prateek and Nitin Mehta. By Koushik Das

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-09-11 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/#review11380 --- Ship it! Ship It! - Nitin Mehta On Sept. 11, 2012, 9:50 a.m., Kou

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-09-11 Thread anthony xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/#review11346 --- Ship it! Ship It! - anthony xu On Sept. 11, 2012, 9:50 a.m., Kous

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-09-11 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/ --- (Updated Sept. 11, 2012, 9:50 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-09-11 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/ --- (Updated Sept. 11, 2012, 9:50 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-09-10 Thread anthony xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/#review11267 --- patching failed, can you send out the patch against latest code? Tha

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-27 Thread edison su
> On Aug. 20, 2012, 8:49 p.m., edison su wrote: > > server/src/com/cloud/storage/allocator/FirstFitStoragePoolAllocator.java, > > line 87 > > > > > > Why don't use LocalStoragePoolAllocator? > > Koushik Das wrote: >

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-27 Thread Koushik Das
> On Aug. 20, 2012, 8:49 p.m., edison su wrote: > > server/src/com/cloud/storage/allocator/FirstFitStoragePoolAllocator.java, > > line 87 > > > > > > Why don't use LocalStoragePoolAllocator? > > Koushik Das wrote: >

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-27 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/ --- (Updated Aug. 27, 2012, 12:05 p.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-21 Thread edison su
> On Aug. 20, 2012, 8:49 p.m., edison su wrote: > > server/src/com/cloud/storage/allocator/FirstFitStoragePoolAllocator.java, > > line 87 > > > > > > Why don't use LocalStoragePoolAllocator? > > Koushik Das wrote: >

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-20 Thread Koushik Das
> On Aug. 20, 2012, 8:49 p.m., edison su wrote: > > server/src/com/cloud/storage/StorageManagerImpl.java, line 3040 > > > > > > why is volume migration between local storage pool disabled? Migration between local stor

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-20 Thread edison su
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/#review10544 --- server/src/com/cloud/storage/StorageManagerImpl.java

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-20 Thread Koushik Das
> On Aug. 12, 2012, 8:46 p.m., Nitin Mehta wrote: > > Its best to get another pair of eyes to review the change as well. > > I have one more question which was asked in another thread but let me reask > > - "if the end user chooses HA service offering and local storage disk > > offering would t

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-20 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/ --- (Updated Aug. 20, 2012, 11:54 a.m.) Review request for cloudstack, Abhinandan Pr

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-12 Thread Nitin Mehta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/#review10179 --- Its best to get another pair of eyes to review the change as well. I

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-10 Thread Koushik Das
> On Aug. 10, 2012, 8:58 a.m., Wido den Hollander wrote: > > It doesn't seem that complicated, but isn't this something we should > > develop in a feature branch? > > > > Currently there is also local storage support for KVM and it would be nice > > if this could be done for KVM as well. > >

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-10 Thread Wido den Hollander
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/#review10111 --- It doesn't seem that complicated, but isn't this something we should

Re: Review Request: Support for local data disk feature. (CS-14277)

2012-08-09 Thread Koushik Das
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6431/ --- (Updated Aug. 9, 2012, 5:45 p.m.) Review request for cloudstack, Abhinandan Prat