Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-15 Thread Sateesh Chodapuneedi
> On March 15, 2013, 1:46 p.m., Sateesh Chodapuneedi wrote: > > Ship It! Haven't merged this yet. - Sateesh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/#review17973 -

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-15 Thread Sateesh Chodapuneedi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/#review17973 --- Ship it! Ship It! - Sateesh Chodapuneedi On March 12, 2013, 7:15

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-15 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/#review17964 --- Ship it! - Rajesh Battala On March 12, 2013, 7:15 a.m., Anshul Gan

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-12 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/ --- (Updated March 12, 2013, 7:15 a.m.) Review request for cloudstack, Rajesh Battal

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-11 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/ --- (Updated March 11, 2013, 1:49 p.m.) Review request for cloudstack and Rajesh Bat

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-11 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/ --- (Updated March 11, 2013, 7:46 a.m.) Review request for cloudstack and Rajesh Bat

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-10 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/#review17677 --- Ship it! Ship It! - Rajesh Battala On March 8, 2013, 8:07 a.m., A

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-08 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/ --- (Updated March 8, 2013, 8:07 a.m.) Review request for cloudstack and Rajesh Batt

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-07 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/ --- (Updated March 7, 2013, 9:40 a.m.) Review request for cloudstack and Rajesh Batt

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-07 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/ --- (Updated March 7, 2013, 9:31 a.m.) Review request for cloudstack and Rajesh Batt

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-07 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/ --- (Updated March 7, 2013, 9:26 a.m.) Review request for cloudstack and Rajesh Batt

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-07 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/ --- (Updated March 7, 2013, 9:17 a.m.) Review request for cloudstack and Rajesh Batt

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-06 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/#review17515 --- Anshul there still whitespaces and lines please delete them and uplo

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-06 Thread Anshul Gangwar
> On March 6, 2013, 5:57 a.m., Rajesh Battala wrote: > > plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java, > > line 2 > > > > > > As SnmpConstants class is already available fro

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-06 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/ --- (Updated March 6, 2013, 11:01 a.m.) Review request for cloudstack and Rajesh Bat

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-05 Thread Anshul Gangwar
> On March 6, 2013, 5:19 a.m., Rajesh Battala wrote: > > plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/snmp/SnmpConstants2.java, > > line 1 > > > > > > why this class named ending with "2"? It is su

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-05 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/#review17456 --- plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/s

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-05 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/#review17458 --- plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/s

Re: Review Request: Feature SNMP Alerts support in CloudStack

2013-03-05 Thread Rajesh Battala
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9587/#review17450 --- plugins/alert-handlers/snmp-alerts/src/org/apache/cloudstack/alert/s