Re: UI tickets: Review request

2012-06-26 Thread Olga Smola
le; Jessica Wang > *Subject:* Fwd: UI tickets: Review request > > ** ** > > ** ** > > -- Forwarded message ---------- > From: *Olga Smola* > Date: Tue, Jun 26, 2012 at 11:27 AM > Subject: Re: UI tickets: Review request > To: Pranav Saxena > > > Pranav, > > you are right, I'

RE: UI tickets: Review request

2012-06-26 Thread Pranav Saxena
12 1:59 PM To: Pranav Saxena; Brian Federle; Jessica Wang Subject: Fwd: UI tickets: Review request -- Forwarded message -- From: Olga Smola mailto:olya.sm...@gmail.com>> Date: Tue, Jun 26, 2012 at 11:27 AM Subject: Re: UI tickets: Review request To: Pranav Saxena mailto:

RE: UI tickets: Review request

2012-06-26 Thread Pranav Saxena
you could merge it with the apache branch. Regards, Pranav From: Olga Smola [mailto:olya.sm...@gmail.com] Sent: Tuesday, June 26, 2012 1:05 PM To: Brian Federle Cc: Pranav Saxena; cloudstack-dev@incubator.apache.org; Jessica Wang Subject: Re: UI tickets: Review request Hi Pranav, Excuse me, I

Re: UI tickets: Review request

2012-06-26 Thread Olga Smola
Hi Pranav, Excuse me, I can't understand what you mean from here "...however since the backend API command hasn't been implemented for listing the specific OS types". Could you please clarify which API should be implemented? Because I've used already exists API commands "listOsCategories" and "lis

Re: UI tickets: Review request

2012-06-25 Thread Brian Federle
That is a good idea too, I agree. Also keep in mind that it will require a fair bit of UI testing too, since this would affect numerous dialog boxes and forms throughout the UI. -Brian On 6/25/12 1:04 PM, "Pranav Saxena" wrote: >Hi Olga , > >I reviewed your code for the following bug which you

RE: UI tickets: Review request

2012-06-25 Thread Pranav Saxena
Hi Olga , I reviewed your code for the following bug which you raised - http://bugs.cloudstack.org/browse/CS-15292 . This looks like a more modular improvement in displaying the OS types as split categories. Your patch looks good however since the backend API command hasn't been implemented for

RE: UI tickets: Review request - CS-15026 DeployVm dialog, Templates tab: have to make listTemplates/listIsos calls based on what is selected on the previous step (Template or ISO)

2012-06-20 Thread Jessica Wang
The patch of CS-15026 looks good to me. I just pushed it into to master branch. -Original Message- From: Brian Federle Sent: Wednesday, June 20, 2012 11:15 AM To: cloudstack-dev@incubator.apache.org Cc: Jessica Wang Subject: Re: UI tickets: Review request Hey Olga, I'll revie

Re: UI tickets: Review request

2012-06-20 Thread Brian Federle
CS-14110 was verified and pushed to master. http://bugs.cloudstack.org/browse/CS-14110 On 6/20/12 2:24 PM, "Brian Federle" wrote: >CS-15286 was verified and pushed to master. > >http://bugs.cloudstack.org/browse/CS-15286 > > >On 6/20/12 11:14 AM, "Brian Federle" wrote: > >>Hey Olga, I'll revie

Re: UI tickets: Review request

2012-06-20 Thread Brian Federle
CS-15286 was verified and pushed to master. http://bugs.cloudstack.org/browse/CS-15286 On 6/20/12 11:14 AM, "Brian Federle" wrote: >Hey Olga, I'll review the tickets below that are not commented on yet. > >Jessica, would you be able to check out CS-15026 when you have the chance? > >Thanks, >B

Re: UI tickets: Review request

2012-06-20 Thread Brian Federle
Hey Olga, I'll review the tickets below that are not commented on yet. Jessica, would you be able to check out CS-15026 when you have the chance? Thanks, Brian On 6/20/12 8:26 AM, "Olga Smola" wrote: >Hi, > >Could you please review my patches for the following tickets: > >http://bugs.cloudstac