I just fixed this to work on Mac. Sorry about that, didn't realize
that sed was different, and nobody said anything. Perhaps it's not
really being used, but again, this prepare-commit-msg hook just
prepopulates your commit message with standard fields for convenience.
On Thu, Oct 18, 2012 at 3:59
-chip
> --Alex
> -Original Message-
> From: Edison Su [mailto:edison...@citrix.com]
> Sent: Wednesday, November 07, 2012 2:25 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: RE: Rant: Request for better commit messages
>
> We'd better fire
Sent: Wednesday, November 07, 2012 2:25 PM
To: cloudstack-dev@incubator.apache.org
Subject: RE: Rant: Request for better commit messages
We'd better fire bugs on issues.apache.org/cloudstack, add a tag for each
maintenance release(e.g. the upcoming 4.0.1), then release manager assign the
bugs to each
: Wednesday, November 07, 2012 11:11 AM
> To: cloudstack-dev@incubator.apache.org
> Subject: Re: Rant: Request for better commit messages
>
> That's great, I'm fine with that if I need to create a bug for everything
> that I
> know needs to be fixed in the 4.0 bra
gt;>> This may be ambiguous, says some developer did not know if some commit
>>>> would apply for some branch? Another issue is to encourage everyone of
>> us
>>>> to use this convention.
>>>> If we could solve it, that would be great.
>>>>
nch? Another issue is to encourage everyone of
> us
> >> to use this convention.
> >> If we could solve it, that would be great.
> >>
> >>
> >> From: Marcus Sorensen [shadow...@gmail.com]
> >> Sent: Wedn
via commit
tags or explicitly over email, that should do right?
From: Marcus Sorensen [shadow...@gmail.com]
Sent: Wednesday, November 07, 2012 11:46 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: Rant: Request for better commit messages
Really I ju
r some branch? Another issue is to encourage everyone of us
>> to use this convention.
>> If we could solve it, that would be great.
>>
>>
>> From: Marcus Sorensen [shadow...@gmail.com]
>> Sent: Wednesday, November 07, 2012 8
e everyone of us
> to use this convention.
> If we could solve it, that would be great.
>
>
> From: Marcus Sorensen [shadow...@gmail.com]
> Sent: Wednesday, November 07, 2012 8:56 PM
> To: cloudstack-dev@incubator.apache.org
> Subject: R
.com]
Sent: Wednesday, November 07, 2012 8:56 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: Rant: Request for better commit messages
Should we add a line to this commit message, where people can mark whether
this patch should be considered for the next bugfix release? Or is that all
handled/track
Should we add a line to this commit message, where people can mark whether
this patch should be considered for the next bugfix release? Or is that all
handled/tracked through JIRA or some other means? I just thought it would
be nice for the guy maintaining a release to be able to eventually pull in
Ok, this is now in master, see 9ba7509c70fe82a8ce0b08826d424de452aef1d2
set it up by running the following from your incubator-cloudstack dir:
'ln -s ../../tools/git/prepare-commit-msg .git/hooks/prepare-commit-msg'
Developers can also optionally commit different prepare-commit-msg
scripts for e
If there's something Infra might be able to provide, you should start a
thread at infrastruct...@apache.org to check. They can be
quite accommodating. Especially around Git, etc. One of the things I
suggested to them was that it might be nice if CLOUDSTACK-BUGID in a commit
message automatically ap
Yeah, that's an option too. The reason I was thinking going the hook
route was because we could provide one file that will work for
everyone (auto populate the signed-off-by and perhaps other things).
Basically because it's scriptable. Then they can just copy it to
.git/hooks on their own. That's t
On 14-Oct-2012, at 9:18 PM, Marcus Sorensen wrote:
> I'm by no means a git guru, but in searching around it didn't seem like
> there was a way to enforce the application of hooks from the repo side.
> I'm not sure we'd want to anyway. I was just going to commit the file and
> then add instructio
I'm by no means a git guru, but in searching around it didn't seem like
there was a way to enforce the application of hooks from the repo side.
I'm not sure we'd want to anyway. I was just going to commit the file and
then add instructions on the wiki for people to add it in their local repo
config
On 12-Oct-2012, at 10:29 PM, Marcus Sorensen wrote:
> Sure thing. A few questions:
>
> the "CLOUDSTACK- prefix:" line, should that be changed to
> simply "Bug id:"?
I guess as there are already several commits that follow CLOUDSTACK-BUGID
convention, we should continue that.
Also, there are
Sure thing. A few questions:
the "CLOUDSTACK- prefix:" line, should that be changed to
simply "Bug id:"? I'm assuming that if the commit is a bug fix, the
fix will already be described in the summary and detail of the commit.
Or are we looking for something else here other than a description? I
c
I ported an old wiki from wiki.cloudstack to cwiki.a.o
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Git#Git-CommitMessages
Pl. check and edit as needed.
One more thing, I checked looks like ASF infra guys have upgraded their review
board.
The bug
(http://code.google.com/p/reviewboard
Might be cool if we could make/document git hooks for a standard message form.
On Thu, Oct 11, 2012 at 3:05 PM, Wido den Hollander wrote:
>
>
> On 10/10/2012 08:50 PM, Noah Slater wrote:
>>
>> Perhaps we could document this on the wiki, as part of a nascent coding
>> standards policy?
>
>
> I'd s
On Thu, Oct 11, 2012 at 5:05 PM, Wido den Hollander wrote:
>
>
> On 10/10/2012 08:50 PM, Noah Slater wrote:
>>
>> Perhaps we could document this on the wiki, as part of a nascent coding
>> standards policy?
>
>
> I'd say so. We already have a coding convention, it's just a small step to
> add a co
On 10/10/2012 08:50 PM, Noah Slater wrote:
Perhaps we could document this on the wiki, as part of a nascent coding
standards policy?
I'd say so. We already have a coding convention, it's just a small step
to add a commit convention.
I personally like 'clean' GIT repos with clear commit mes
Perhaps we could document this on the wiki, as part of a nascent coding
standards policy?
On Wed, Oct 10, 2012 at 8:01 AM, Rohit Yadav wrote:
> Hi folks,
>
> With due respect, I would like to request all the committers and
> contributors to write better commit message. [0]
>
> For example, a goo
23 matches
Mail list logo