[mailto:murali.re...@citrix.com]
Sent: Tuesday, July 10, 2012 11:09 PM
To: cloudstack-dev@incubator.apache.org
Subject: Re: Review Request: Nicira NVP integration for CloudStack
Hugo,
I reviewed the patch and its good to go into master. I will get the patch
integrated into master branch. Can you please do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5590/#review9042
---
Ship it!
Great work Hugo! I just wanted to confirm here that all look
Hugo,
I reviewed the patch and its good to go into master. I will get the patch
integrated into master branch. Can you please do below tasks to conclude
phase 1 effort.
- Since there in no flexibility to tag VIF's as Nicira integration would
want, we can leave the changes you done in the CitrixRe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5590/#review9036
---
Ship it!
Ship It!
- Murali Reddy
On July 8, 2012, 7:20 p.m., Hugo
i Reddy [mailto:nore...@reviews.apache.org] On Behalf Of Murali Reddy
Sent: Friday, July 06, 2012 1:37 AM
To: cloudstack; Murali Reddy; Hugo Trippaers
Subject: Re: Review Request: Nicira NVP integration for CloudStack
---
This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5590/
---
(Updated July 8, 2012, 7:20 p.m.)
Review request for cloudstack.
Changes
-
> On July 5, 2012, 11:36 p.m., Murali Reddy wrote:
> > Hugo, code in general looks good. Below are some minor comments. Is there
> > is trial version of NVP controller that can used for trying out integration
> > or for testing?
> >
> > - In CitrixResourceBase it seems to me that Nicira config
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5590/#review8903
---
Hugo, code in general looks good. Below are some minor comments. Is th
Hugo,
Thanks for submitting a detailed patch with API changes, functional test
steps etc. I maintain the "Network Element" modules of CloudStack will get
started on the review of the patch. I might need to pull in other module
owners of (CitrixResource, NetWorkGuru, NetworkManager) for review if
r
Hi,
I tried to apply the patch, but failed with apache git master HEAD
due to the file path changes recently committed.
Branch (and rev) is missing in that review page, but following worked:
git clone https://git-wip-us.apache.org/repos/asf/incubator-cloudstack.git
cd incubator-cloudstack
git ch
Heya all,
Based on the feedback on the pre-review I made quite a few changes.
Functionally it seems to be doing what I want it to do and the code integrates
a lot better with the existing code.
I've pushed the patch to reviewboard at https://reviews.apache.org/r/5590/
I hope this patch address
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5590/
---
(Updated June 26, 2012, 4:56 p.m.)
Review request for cloudstack.
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5590/
---
Review request for cloudstack.
Description
---
Patch to add Nicira NVP supp
13 matches
Mail list logo
