Re: [ACS41][Patch Request] agent.properties from RPM is blocking proper agent setup

2013-03-02 Thread Marcus Sorensen
I went back and looked at the wiki, and I think I misunderstood one of the sections. It shows examples of things to put into the commit, Reviewed-by:,Signed-off-by:,Reported-by:, and then below that, CLOUDSTACK-bug-id:, Maven:, Doc:, etc. It says the latter group should be prefixes, which I appare

Re: [ACS41][Patch Request] agent.properties from RPM is blocking proper agent setup

2013-03-02 Thread Chip Childers
On Sat, Mar 02, 2013 at 12:28:55PM -0700, Marcus Sorensen wrote: > The bug was created a few hours before the commit. I didn't even know > I'd end up fixing it. I thought we had standardized on a BUG-ID: > header in commits, way back in October or so when Rohit was asking for > better commit messag

Re: [ACS41][Patch Request] agent.properties from RPM is blocking proper agent setup

2013-03-02 Thread Marcus Sorensen
The bug was created a few hours before the commit. I didn't even know I'd end up fixing it. I thought we had standardized on a BUG-ID: header in commits, way back in October or so when Rohit was asking for better commit messages. We even created a pre-commit hook people could use to prepopulate the

Re: [ACS41][Patch Request] agent.properties from RPM is blocking proper agent setup

2013-03-02 Thread Chip Childers
On Fri, Mar 01, 2013 at 07:37:24PM -0700, Marcus Sorensen wrote: > Please cherry pick to 4.1, it allows agent setup to complete properly > when host is added. This might actually have something to do with all > of the 'no private.network.device in agent.properties' issues popping > up from the test

[ACS41][Patch Request] agent.properties from RPM is blocking proper agent setup

2013-03-01 Thread Marcus Sorensen
Please cherry pick to 4.1, it allows agent setup to complete properly when host is added. This might actually have something to do with all of the 'no private.network.device in agent.properties' issues popping up from the testers. commit e08281838a428a26f1993519de96fc45a26c0920 Author: Marcus Sor