Re: Review Request: MidoNet Networking Plugin [2/2]

> On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote: > > server/src/com/cloud/network/NetworkManagerImpl.java, line 1773 > > <https://reviews.apache.org/r/9898/diff/1/?file=270127#file270127line1773> > > > > NetworkElement should be always called after Networ

Re: Review Request: MidoNet Networking Plugin [2/2]

getProvider, etc. server/src/com/cloud/network/NetworkManagerImpl.java <https://reviews.apache.org/r/9898/#comment37808> NetworkElement should be always called after NetworkGuru, isn't it? - Hiroaki Kawai On March 13, 2013, 9:32 a

Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

- server/src/com/cloud/network/NetworkManager.java 8b6bf9a server/src/com/cloud/network/NetworkManagerImpl.java ba5ab5d server/src/com/cloud/vm/VirtualMachineManagerImpl.java 0aeef0e Diff: https://reviews.apache.org/r/9871/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: (CLOUDSTACK-1558) vCenter service cookie parsing is wrong

an be get by CookieSpec#formatCookies. This addresses bug CLOUDSTACK-1558. Diffs - vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java cbae5a9 Diff: https://reviews.apache.org/r/9786/diff/ Testing --- Thanks, Hiroaki Kawai

Review Request: (CLOUDSTACK-1558) vCenter service cookie parsing is wrong

This addresses bug CLOUDSTACK-1558. Diffs - vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareClient.java cbae5a9 Diff: https://reviews.apache.org/r/9786/diff/ Testing --- Thanks, Hiroaki Kawai

Review Request: [CLOUDSTACK-1535] kvm agent will silently ignore many exceptions

848de plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtXMLParser.java 3a61403 Diff: https://reviews.apache.org/r/9774/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: Remove invalid use of library internal class found in vmware-base

/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: Remove invalid use of library internal class found in vmware-base

/VmwareClient.java 344fbdd vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77 Diff: https://reviews.apache.org/r/9768/diff/ Testing --- Thanks, Hiroaki Kawai

Review Request: Remove invalid use of library internal class found in vmware-base

/src/com/cloud/hypervisor/vmware/util/VmwareContext.java 091ce77 Diff: https://reviews.apache.org/r/9768/diff/ Testing --- Thanks, Hiroaki Kawai

[jira] [Updated] (CLOUDSTACK-1489) cloudstack agent plugin classpath is missing

[ https://issues.apache.org/jira/browse/CLOUDSTACK-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-1489: -- Affects Version/s: (was: 4.2.0) (was: 4.1.0

[jira] [Updated] (CLOUDSTACK-1489) cloudstack agent plugin classpath is missing

[ https://issues.apache.org/jira/browse/CLOUDSTACK-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-1489: -- Component/s: KVM > cloudstack agent plugin classpath is miss

[jira] [Created] (CLOUDSTACK-1489) cloudstack agent plugin classpath is missing

Hiroaki Kawai created CLOUDSTACK-1489: - Summary: cloudstack agent plugin classpath is missing Key: CLOUDSTACK-1489 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-1489 Project: CloudStack

ポロシャツ

っpqっっpqqっpっっqっっq

[jira] [Updated] (CLOUDSTACK-589) Juniper SRX does not depends on f5 iControl jar

[ https://issues.apache.org/jira/browse/CLOUDSTACK-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-589: - Attachment: srx_pom.patch > Juniper SRX does not depends on f5 iControl

[jira] [Updated] (CLOUDSTACK-589) Juniper SRX does not depend on f5 iControl jar

[ https://issues.apache.org/jira/browse/CLOUDSTACK-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-589: - Summary: Juniper SRX does not depend on f5 iControl jar (was: Juniper SRX does not

[jira] [Created] (CLOUDSTACK-589) Juniper SRX does not depends on f5 iControl jar

Hiroaki Kawai created CLOUDSTACK-589: Summary: Juniper SRX does not depends on f5 iControl jar Key: CLOUDSTACK-589 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-589 Project: CloudStack

Review Request: Store NetworkServiceProvider connectivity service configuration in database.

rver/src/com/cloud/upgrade/dao/Upgrade40to41.java 5067f39 setup/db/create-schema.sql fff084e setup/db/db/schema-40to41.sql PRE-CREATION Diff: https://reviews.apache.org/r/8294/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: Default admin user account will not be created in clean setup

, Hiroaki Kawai

Review Request: Default admin user account will not be created in clean setup

execution failed. Diffs - server/src/com/cloud/server/ConfigurationServerImpl.java d2f0bb0 setup/db/create-schema.sql fff084e Diff: https://reviews.apache.org/r/8293/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: HttpClient needs releaseConnection method call

icira/NiciraNvpApi.java 26e7e0d server/src/com/cloud/cluster/ClusterServiceServletImpl.java 0c3a175 server/src/com/cloud/maint/UpgradeManagerImpl.java c1ce3f0 Diff: https://reviews.apache.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: HttpClient needs releaseConnection method call

ttps://reviews.apache.org/r/8186/#review13691 ------- On Nov. 22, 2012, 8:42 a.m., Hiroaki Kawai wrote: > > --- > This is an automatically generated e-mail

Review Request: HttpClient needs releaseConnection method call

e.org/r/8186/diff/ Testing --- Thanks, Hiroaki Kawai

Review Request: CentOS rpm build fix

/package.sh Thanks, Hiroaki Kawai

[jira] [Updated] (CLOUDSTACK-487) HttpClient in multithreaded environment

[ https://issues.apache.org/jira/browse/CLOUDSTACK-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-487: - Description: Running cloudstack with nicira nvp plugin, I got following error. It

Re: Review Request: CLOUDSTACK-487 HttpClient in multithreaded environment

/storage/template/HttpTemplateDownloader.java bd607b3 plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 2c002ab server/src/com/cloud/maint/UpgradeManagerImpl.java b4bc291 Diff: https://reviews.apache.org/r/8075/diff/ Testing --- Thanks, Hiroaki Kawai

[jira] [Updated] (CLOUDSTACK-487) HttpClient in multithreaded environment

[ https://issues.apache.org/jira/browse/CLOUDSTACK-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-487: - Description: Running cloudstack with nicira nvp plugin, I got following error. It

[jira] [Updated] (CLOUDSTACK-487) HttpClient in multithreaded environment

[ https://issues.apache.org/jira/browse/CLOUDSTACK-487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-487: - Description: Running cloudstack with nicira nvp plugin, I got following error. It

Review Request: CLOUDSTACK-487 HttpClient in multithreaded environment

bd607b3 plugins/network-elements/nicira-nvp/src/com/cloud/network/nicira/NiciraNvpApi.java 2c002ab server/src/com/cloud/maint/UpgradeManagerImpl.java b4bc291 Diff: https://reviews.apache.org/r/8075/diff/ Testing --- Thanks, Hiroaki Kawai

[jira] [Created] (CLOUDSTACK-487) HttpClient in multithreaded environment

Hiroaki Kawai created CLOUDSTACK-487: Summary: HttpClient in multithreaded environment Key: CLOUDSTACK-487 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-487 Project: CloudStack

[jira] [Updated] (CLOUDSTACK-423) During VM migration on KVM, VifDriver.unplug is not called.

[ https://issues.apache.org/jira/browse/CLOUDSTACK-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-423: - Description: VifDriver.unplug must be called in MigrateCommand which hooks VM

Review Request: CLOUDSTACK-423 : During VM migration on KVM, VifDriver.unplug is not called.

/hypervisor/kvm/resource/LibvirtComputingResource.java 1bc70fa Diff: https://reviews.apache.org/r/7761/diff/ Testing --- Thanks, Hiroaki Kawai

[jira] [Updated] (CLOUDSTACK-423) During VM migration on KVM, VifDriver.unplug is not called.

[ https://issues.apache.org/jira/browse/CLOUDSTACK-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hiroaki Kawai updated CLOUDSTACK-423: - Summary: During VM migration on KVM, VifDriver.unplug is not called. (was: During

[jira] [Created] (CLOUDSTACK-423) During VM migration with KVM, VifDriver.unplug is not called.

Hiroaki Kawai created CLOUDSTACK-423: Summary: During VM migration with KVM, VifDriver.unplug is not called. Key: CLOUDSTACK-423 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-423 Project

Review Request: kvm agent NIC unplug will always fail

much. Diffs - plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java 1bc70fa Diff: https://reviews.apache.org/r/7612/diff/ Testing --- Thanks, Hiroaki Kawai

Review Request: fix 4.0 build failure (invalid constructor argument)

error displayed in http://jenkins.cloudstack.org/job/build-4.0/91/ Diffs - server/src/com/cloud/network/rules/RulesManagerImpl.java 37cae90 Diff: https://reviews.apache.org/r/7337/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: STT isolation support for KVM

ble ovs libvirt.vif.driver now. I would discard this patch for now. - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7165/#review11960 ---------

Re: Review Request: Set correct version for database version check

rs must be x.x.x and artifacts should be appneded with "-". This patch will fix startup database check errors in management server. Diffs (updated) - wscript ff38ed2 Diff: https://reviews.apache.org/r/7013/diff/ Testing --- Thanks, Hiroaki Kawai

Review Request: STT isolation support for KVM

/setupLswitch.sh PRE-CREATION server/src/com/cloud/hypervisor/HypervisorGuruBase.java 242852f Diff: https://reviews.apache.org/r/7165/diff/ Testing --- Thanks, Hiroaki Kawai

Review Request: add logging for debugging.

orage/LibvirtStorageAdaptor.java d6236a0d6038bbf251450a424ea0089c01739e00 Diff: https://reviews.apache.org/r/7153/diff/ Testing --- Thanks, Hiroaki Kawai

Review Request: Add proper OS name to KVMGuestOsMapper for systemvm

/ Testing --- Thanks, Hiroaki Kawai

[jira] [Commented] (CLOUDSTACK-120) Failed to deploy Router with KVM hyperviosor [ Can't find the mapping of guest os: Debian GNU/Linux 5.0 (32-bit)]

[ https://issues.apache.org/jira/browse/CLOUDSTACK-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457707#comment-13457707 ] Hiroaki Kawai commented on CLOUDSTACK-120: -- This is not fixed in 4.0 br

[jira] [Commented] (CLOUDSTACK-78) Cloudstack Agent installation failed with jsvc package dependancy error

[ https://issues.apache.org/jira/browse/CLOUDSTACK-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453847#comment-13453847 ] Hiroaki Kawai commented on CLOUDSTACK-78: - Please try typing: yum install

Re: Review Request: typo in cloud-install-sys-tmplt

:-) - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7049/#review11373 --- On Sept. 12, 2012, 12:36 a.m., Hiro

Review Request: typo in cloud-install-sys-tmplt

a typo in shell script syntax. /usr/lib64/cloud/agent/scripts/storage/secondary/cloud-install-sys-tmplt: line 141: [: missing `]' Diffs - scripts/storage/secondary/cloud-install-sys-tmplt d744b56 Diff: https://reviews.apache.org/r/7049/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: Set correct version for database version check

This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7013/#review11343 ------- On Sept. 11, 2012, 10:08 a.m., Hiroaki Kawai wrote: > >

[jira] [Commented] (CLOUDSTACK-78) Cloudstack Agent installation failed with jsvc package dependancy error

[ https://issues.apache.org/jira/browse/CLOUDSTACK-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13453056#comment-13453056 ] Hiroaki Kawai commented on CLOUDSTACK-78: - What is the distribution you

Re: Review Request: agent rpm package requires more package on CentOS6

s running. - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7015/#review11320 --- On Sept. 11, 2012, 12:09 p.m., Hiroaki Ka

Review Request: agent rpm package requires more package on CentOS6

-errfile option to jsvc. Diffs - cloud.spec c31fe5b Diff: https://reviews.apache.org/r/7015/diff/ Testing --- Thanks, Hiroaki Kawai

Review Request: Set correct version for database version check

- Thanks, Hiroaki Kawai

Review Request: cloud.spec centos6 "Requires" package name fix.

-commons-lang is the package name for apache-commons-lang which is the name on fedora. Without this patch, rpm installation will fail. Diffs - cloud.spec c31fe5b Diff: https://reviews.apache.org/r/7009/diff/ Testing --- Thanks, Hiroaki Kawai

Re: [ASFCS40] Release Candidate Status

On 2012/09/07, at 23:02, Rohit Yadav wrote: > > On 07-Sep-2012, at 6:50 PM, Chip Childers wrote: > >> On Fri, Sep 7, 2012 at 12:33 AM, Rajesh Battala >> wrote: >>> >>> >>> -Original Message- >>> From: Chip Childers [mailto:chip.child...@sungard.com] >>> Sent: Friday, September 07,

Review Request: Fedora 17 openjdk 1.7 support

, openjdk 1.6 package was marked as deprecated, and only openjdk 1.7 is available for general. https://admin.fedoraproject.org/pkgdb/acls/name/java-1.6.0-openjdk Diffs - cloud.spec b22bd8c Diff: https://reviews.apache.org/r/6941/diff/ Testing --- mvn && mvn test Thanks, Hiroaki Kawai

Review Request: maven kvm hypervisor plugin build without -Dnonoss

://reviews.apache.org/r/6925/diff/ Testing --- mvn && mvn test Thanks, Hiroaki Kawai

Re: Review Request: maven without -Dnonoss build dependency fix

g/r/6923/diff/ Testing --- mvn && mvn test Thanks, Hiroaki Kawai

Review Request: maven without -Dnonoss build dependency fix

ffs - pom.xml 99b1177 Diff: https://reviews.apache.org/r/6923/diff/ Testing --- mvn && mvn test Thanks, Hiroaki Kawai

Re: How to run kvm agent on development environment by maven

Hi, I'd like to suggest that we run exec:java with -pl plugins/hypervisors/kvm . # Running AgentShell will require some host setups. On 2012/09/04, at 18:35, Wido den Hollander wrote: > On 09/04/2012 03:38 AM, Satoshi Kobayashi wrote: >> Hi Wido, >> >> Thank you for your reply. >> >> 2012/9/