Re: Review Request: CS-13537 Delete Domain Response doesn't let the User know the Failure for the operation and partial fix for CS-14681 Detail errortext in the API response

2012-06-23 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5522/ --- (Updated June 24, 2012, 6:33 a.m.) Review request for cloudstack. Changes

Re: Review Request: CS-13537 Delete Domain Response doesn't let the User know the Failure for the operation and partial fix for CS-14681 Detail errortext in the API response

2012-06-23 Thread Anshul Gangwar
> On June 22, 2012, 3:34 p.m., Venkata Siva Vijayendra Bhamidipati wrote: > > Hi Anshul, 1) When throwing exceptions that have IDs, please use the addProxyObject() call to fill in those IDs into the exceptions. They will transparently get translated into their corresponding UUIDs when the resp

Re: Review Request: License header update for the ovm folder.

2012-06-23 Thread Chip Childers
I can pull the latest from master on Monday morning, and have the new patches back to the list by the end of the day. Can you plan on reviewing / committing them early next week? - chip Sent from my iPhone. On Jun 23, 2012, at 9:50 PM, David Nalley wrote: > > --

Re: Review Request: License header update for the ovm folder.

2012-06-23 Thread David Nalley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5440/#review8510 --- Yet another one I didn't get to in time - [ke4qqq@mba incubator-clo

RE: Coding conventions, spaces and tabs

2012-06-23 Thread Deepak Garg
-Original Message- From: David Nalley [mailto:da...@gnsa.us] Sent: Saturday, June 23, 2012 1:27 AM To: cloudstack-dev@incubator.apache.org Subject: Re: Coding conventions, spaces and tabs On Fri, Jun 22, 2012 at 3:51 PM, Deepak Garg wrote: > +1 > > > In Eclipse it is easy to configure

Re: Coding conventions, spaces and tabs

2012-06-23 Thread Wido den Hollander
On 06/22/2012 08:03 PM, David Nalley wrote: On Fri, Jun 22, 2012 at 12:45 PM, David Nalley wrote: On Fri, Jun 22, 2012 at 12:37 PM, Wido den Hollander wrote: Hi, While working on CloudStack I noticed that a lot of files still use tabs instead of spaces. I've been working on the agent main