Re: Review Request: License header updates for awsapi-setup folder.

2012-06-22 Thread David Nalley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5438/#review8501 --- getting these errors error: patch failed: awsapi-setup/db/mysql/clou

Re: Review Request: License header updates for the scripts folder.

2012-06-22 Thread David Nalley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5488/#review8500 --- Ship it! Thanks for the patch Chip! - David Nalley On June 21, 201

Re: Review Request: License header updates for core folder.

2012-06-22 Thread David Nalley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5439/#review8499 --- Chip, This one also doesn't apply - pretty sure it's my fault though

Re: Review Request: Licensing update from Chip Childers for vmware-base

2012-06-22 Thread David Nalley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5430/#review8497 --- Ship it! Ship It! - David Nalley On June 20, 2012, 4:38 a.m., Davi

Re: FW: Easy task for folks looking to get involved

2012-06-22 Thread David Nalley
On Fri, Jun 22, 2012 at 6:40 PM, Jessica Tomechak wrote: > See inline below for my reply to David's question about purging the docs > directory in the repo. > > > -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Wednesday, June 20, 2012 1:39 PM > To: Chip Childers > C

Re: Query regarding where to store encryption keys

2012-06-22 Thread John Kinsella
Concur on both. I've been in an appsec mode recently and sending people to the OWASP site so that came to mind, but CVSS is better known. I mentioned CVE directly as "MITRE" might confuse people, but probably not an issue. Wiki's been updated. Any other feedback/thoughts are welcome… John On

RE: Coding conventions, spaces and tabs

2012-06-22 Thread Alex Huang
> -Original Message- > From: Frank Zhang [mailto:frank.zh...@citrix.com] > Sent: Friday, June 22, 2012 1:57 PM > To: cloudstack-dev@incubator.apache.org > Subject: RE: Coding conventions, spaces and tabs > > An annoying thing is Eclipse doesn't have a global setting for all instances, >

RE: Query regarding where to store encryption keys

2012-06-22 Thread Clement Chen
Hi John, It looks nice. Two comments: 1. Regarding risk rating, it seems to me that CVSS (http://www.first.org/cvss) has wider adoption than the "OWASP risk rating methodology". Every security vulnerability in the National Vulnerability Database (http://nvd.nist.gov/) has a CVSS score. 2. It s

Re: FW: FW: [PROPOSAL] Further refinement of CloudStack modules...

2012-06-22 Thread Jessica Tomechak
Please see inline replies below. -Original Message- > From: David Nalley [mailto:da...@gnsa.us] > Sent: Wednesday, June 13, 2012 7:30 AM > To: cloudstack-dev@incubator.apache.org > Cc: radhika...@gmail.com > Subject: Re: FW: [PROPOSAL] Further refinement of CloudStack modules... > > >> Hel

Re: FW: Easy task for folks looking to get involved

2012-06-22 Thread Jessica Tomechak
See inline below for my reply to David's question about purging the docs directory in the repo. -Original Message- From: David Nalley [mailto:da...@gnsa.us] Sent: Wednesday, June 20, 2012 1:39 PM To: Chip Childers Cc: cloudstack-dev@incubator.apache.org Subject: Re: Easy task for folks lo

Re: Coding conventions, spaces and tabs

2012-06-22 Thread Hugo Trippaers
Easy enough to setup Jenkins to catch this as well. I don't know about the reviewboard setup, but if it's linked to jenkins we can spot this before accepting the patch. Maybe also add the note about the git crlf settings to the developer wiki in an easy to find spot? Cheers, Hugo Sent from

buildbot success in ASF Buildbot on cloudstack-site-staging

2012-06-22 Thread buildbot
The Buildbot has detected a restored build on builder cloudstack-site-staging while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/cloudstack-site-staging/builds/4 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-cms-slave Build Reason: sch

Re: CloudStack API question

2012-06-22 Thread Jessica Tomechak
Thanks to Amit for raising these API questions. I have noted the answers in in the documentation bug http://bugs.cloudstack.org/browse/CS-12742, "API docs: Better describe parameters." I filed this bug myself last January. I'm sad to say the existing CloudStack tech writing team does not have enoug

RE: Coding conventions, spaces and tabs

2012-06-22 Thread Frank Zhang
An annoying thing is Eclipse doesn't have a global setting for all instances, its setting is per workspace. I wish I were wrong. As I have multiple workspaces for various branches, it's easy to forget to configure the workspace whenever I create a new one. > -Original Message- > From: De

RE: Storage Networks XenServer

2012-06-22 Thread Frank Zhang
Yes it's quite confusing. My best guess, just guess, is CloudStack used to have similar feature but somehow dropped it at some moment, however, the doc was not updated promptly. Anyway, the storage network in current code base means secondary storage. Could you file a bug on http://bugs.cloudstac

RE: Storage Networks XenServer

2012-06-22 Thread Frank Zhang
Let's say the host having two nics, one is staying on a high bandwidth network that can access primary storage(the nfs share), another is on a different network. Ideally a route specifying that access to primary storage should go thru high bandwidth network will make mount perform faster. But Cl

Re: Review Request: Fix to clean up Nexus VSM record in db when failure in addCluster command is encountered

2012-06-22 Thread Sheng Yang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5500/#review8494 --- Ship it! Applied, thanks! - Sheng Yang On June 22, 2012, 7:39 p.m.

RE: patch for marvin configGenerator.py

2012-06-22 Thread Edison Su
Applied, thanks! BTW, better to write your own test configuration by importing configGenerator, other than modify configGenerator itself, if the default configuration is not fulfill with your test plan. You are welcome to add more test cases/plans/configurations into Cloudstack. > -Origin

Re: Coding conventions, spaces and tabs

2012-06-22 Thread Sheng Yang
On Fri, Jun 22, 2012 at 9:45 AM, David Nalley wrote: > On Fri, Jun 22, 2012 at 12:37 PM, Wido den Hollander wrote: >> Hi, >> >> While working on CloudStack I noticed that a lot of files still use tabs >> instead of spaces. >> >> I've been working on the agent mainly and there it seems bad. >> >>

Re: Coding conventions, spaces and tabs

2012-06-22 Thread David Nalley
On Fri, Jun 22, 2012 at 3:51 PM, Deepak Garg wrote: > +1 > > > In Eclipse it is easy to configure the editor to replace 'tabs' with 'spaces' > and also to kill the trailing whitespaces: > > To remove the trailing whitespaces on save: > > Preferences -> Java -> Editor -> Save Actions -> Configure

RE: Coding conventions, spaces and tabs

2012-06-22 Thread Deepak Garg
+1 In Eclipse it is easy to configure the editor to replace 'tabs' with 'spaces' and also to kill the trailing whitespaces: To remove the trailing whitespaces on save: Preferences -> Java -> Editor -> Save Actions -> Configure Project Specific settings -> (choose project) -> Configure -> Choo

RE: Storage Networks XenServer

2012-06-22 Thread Geoff Higginbottom
Hi Frank If the storage network is for Secondary Storage, why does the admin guide contain the following "For the separate storage network to work correctly, it must be the only interface that can ping the primary storage device's IP address. For example, if eth0 is the management network NIC,

Re: Review Request: Fix to clean up Nexus VSM record in db when failure in addCluster command is encountered

2012-06-22 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5500/ --- (Updated June 22, 2012, 7:39 p.m.) Review request for cloudstack and Sheng Yang.

Re: Storage Networks XenServer

2012-06-22 Thread Chip Childers
Hi Frank... can you clarify this statement a little more for me please? On Fri, Jun 22, 2012 at 2:43 PM, Frank Zhang wrote: > As far as I know, CloudStack hasn't been capable of leveraging dedicated > nic on host for primary storage. Thanks a ton!

RE: Storage Networks XenServer

2012-06-22 Thread Frank Zhang
See my another reply. The storage network(I admit it's a bad term for this feature) is indeed for secondary storage now. > -Original Message- > From: Weiran Xia [mailto:weiran.x...@gmail.com] > Sent: Friday, June 22, 2012 4:57 AM > To: cloudstack-dev@incubator.apache.org > Subject: Re: St

RE: Storage Networks XenServer

2012-06-22 Thread Frank Zhang
I apologize so many puzzling terminologies here, to your surprise, the storage network in CloudStack is currently for secondary storage. http://wiki.cloudstack.org/display/DesignDocs/Storage+network+in+Acton has a short explanation. To people's intuition, I quite understand the storage network sh

patch for marvin configGenerator.py

2012-06-22 Thread Jason Bausewein
Thank you for applying my last patch. I started using the tools/marvin/marvin directory. I would like to add an command line option to choose between advanced or basic networking configuration. This would allow me or others to choose advanced networking without having to edit the python code.

Re: Coding conventions, spaces and tabs

2012-06-22 Thread Robert Schweikert
On 06/22/2012 02:03 PM, David Nalley wrote: On Fri, Jun 22, 2012 at 12:45 PM, David Nalley wrote: On Fri, Jun 22, 2012 at 12:37 PM, Wido den Hollander wrote: Hi, While working on CloudStack I noticed that a lot of files still use tabs instead of spaces. I've been working on the agent mainly

Re: Coding conventions, spaces and tabs

2012-06-22 Thread David Nalley
On Fri, Jun 22, 2012 at 12:45 PM, David Nalley wrote: > On Fri, Jun 22, 2012 at 12:37 PM, Wido den Hollander wrote: >> Hi, >> >> While working on CloudStack I noticed that a lot of files still use tabs >> instead of spaces. >> >> I've been working on the agent mainly and there it seems bad. >> >>

Re: CloudStack bugs, CS-14896

2012-06-22 Thread Brian Federle
Verified CS-12478, will merge to master. http://bugs.cloudstack.org/browse/CS-12478 On 6/19/12 2:49 PM, "Brian Federle" wrote: >Olga, > >I have verified and merged in your patches to ASF master, for the >following UI bugs: > >http://bugs.cloudstack.org/browse/CS-14010 > >http://bugs.cloudstack.

Re: Cloudstack Supporting Xenserver StorageLink storage pool

2012-06-22 Thread Diego Spinola Castro
Kevin, as far as i know , thin provisioning is only supported using StorageLink. I'm going to receive my equallogic box next week and i choose equallogic for thin provisioning feature. Any of you can setup a test environment ? Diego 2012/6/20 Kevin Kluge > All of the EqualLogic deployments

Re: patch for python test client configGenerator.py

2012-06-22 Thread Prasanna Santhanam
Yeah - it needs to be deleted. Could you please do that? Marvin is where all the bug fixes, patches and packaging changes go in in the future. Thanks Jason for the patch! - Original Message - From: Edison Su Sent: Friday, June 22, 2012 10:55 PM To: cloudstack-dev@incubator.apache.org

RE: Coding conventions, spaces and tabs

2012-06-22 Thread Edison Su
+1 > -Original Message- > From: Wido den Hollander [mailto:w...@widodh.nl] > Sent: Friday, June 22, 2012 9:38 AM > To: cloudstack-dev@incubator.apache.org > Subject: Coding conventions, spaces and tabs > > Hi, > > While working on CloudStack I noticed that a lot of files still use > tabs

RE: patch for python test client configGenerator.py

2012-06-22 Thread Edison Su
Applied, thanks! Prasanna, do we still need tools/testClient folder? Seems you already copy the code to tools/marvin/marvin. > -Original Message- > From: Jason Bausewein [mailto:jason.bausew...@tier3.com] > Sent: Friday, June 22, 2012 9:59 AM > To: cloudstack-dev@incubator.apache.org > Su

Re: Private IP allocation

2012-06-22 Thread Diego Spinola Castro
Worked! Tks Alena. 2012/6/22 Alena Prokharchyk > You need to mark them as free: > > > Update op_dc_address_alloc set nic_id=null, reservation_id=null, > taken=null where id in (list of ids of orphaned nics) > > > > -Alena. > > On 6/22/12 9:58 AM, "Diego Spinola Castro" > wrote: > > >Alena, i di

Re: Private IP allocation

2012-06-22 Thread Alena Prokharchyk
You need to mark them as free: Update op_dc_address_alloc set nic_id=null, reservation_id=null, taken=null where id in (list of ids of orphaned nics) -Alena. On 6/22/12 9:58 AM, "Diego Spinola Castro" wrote: >Alena, i did what you said. >Now i have a few orphan ips, what should i do with th

patch for python test client configGenerator.py

2012-06-22 Thread Jason Bausewein
I have a small patch for the configGenerator.py in the test client. I needed to change the case in the sim url so the SimulatorDiscover will detect the simulator hosts. Thanks, Jason diff --git a/tools/testClient/configGenerator.py b/tools/testClient/configGenerator.py index a5bf0ea..52373bf

Re: Private IP allocation

2012-06-22 Thread Diego Spinola Castro
Alena, i did what you said. Now i have a few orphan ips, what should i do with they? mysql> SELECT * FROM op_dc_ip_address_alloc a WHERE a.nic_id IS NOT NULL AND (SELECT COUNT(*) FROM op_dc_ip_address_alloc b WHERE a.nic_id = b.nic_id)>1 order by nic_id; +-+---++---

Re: Coding conventions, spaces and tabs

2012-06-22 Thread John Kinsella
+1 On Jun 22, 2012, at 9:45 AM, David Nalley wrote: > On Fri, Jun 22, 2012 at 12:37 PM, Wido den Hollander wrote: >> Hi, >> >> While working on CloudStack I noticed that a lot of files still use tabs >> instead of spaces. >> >> I've been working on the agent mainly and there it seems bad. >> >

Re: CloudStack API question

2012-06-22 Thread Alena Prokharchyk
On 6/22/12 5:50 AM, "Prasanna Santhanam" wrote: >Hi Amit, > >Posting this to the asf-dev list. There are more eyes here to correct me >if I am wrong. > >Answers Inline: > >> Where can I find more information on specific parameters passed to a >> CLoudStack API. The API reference guide only prov

RE: Coding conventions, spaces and tabs

2012-06-22 Thread Vijayendra Bhamidipati
-Original Message- From: David Nalley [mailto:da...@gnsa.us] Sent: Friday, June 22, 2012 9:45 AM To: cloudstack-dev@incubator.apache.org Subject: Re: Coding conventions, spaces and tabs On Fri, Jun 22, 2012 at 12:37 PM, Wido den Hollander wrote: > Hi, > > While working on CloudStack I

Re: Coding conventions, spaces and tabs

2012-06-22 Thread David Nalley
On Fri, Jun 22, 2012 at 12:37 PM, Wido den Hollander wrote: > Hi, > > While working on CloudStack I noticed that a lot of files still use tabs > instead of spaces. > > I've been working on the agent mainly and there it seems bad. > > The coding convention [0] says: > > "Must indent with space not

Re: add a ssh button to the VM tab

2012-06-22 Thread John Kinsella
On Jun 22, 2012, at 9:29 AM, David Nalley wrote: > On Fri, Jun 22, 2012 at 12:24 PM, Wido den Hollander wrote: >> Hi, >> >> >> On 06/22/2012 03:09 PM, LAMBERT Thomas wrote: >>> >>> Hi >>> >>> i would like to add a button in the VM tab, to open a SSH console into the >>> selected VM. I don't r

Coding conventions, spaces and tabs

2012-06-22 Thread Wido den Hollander
Hi, While working on CloudStack I noticed that a lot of files still use tabs instead of spaces. I've been working on the agent mainly and there it seems bad. The coding convention [0] says: "Must indent with space not tabs. Indentation = 4 spaces" Now, I'm sure this is legacy, but would any

Re: add a ssh button to the VM tab

2012-06-22 Thread David Nalley
On Fri, Jun 22, 2012 at 12:24 PM, Wido den Hollander wrote: > Hi, > > > On 06/22/2012 03:09 PM, LAMBERT Thomas wrote: >> >> Hi >> >> i would like to add a button in the VM tab, to open a SSH console into the >> selected VM. I don't really know where to begin, could someone give me a >> hint  or ad

Re: add a ssh button to the VM tab

2012-06-22 Thread Wido den Hollander
Hi, On 06/22/2012 03:09 PM, LAMBERT Thomas wrote: Hi i would like to add a button in the VM tab, to open a SSH console into the selected VM. I don't really know where to begin, could someone give me a hint or advice about this? Would you like to open a in-browser SSH console? That would be

Re: Review Request: CS-13537 Delete Domain Response doesn't let the User know the Failure for the operation and partial fix for CS-14681 Detail errortext in the API response

2012-06-22 Thread Venkata Siva Vijayendra Bhamidipati
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5522/#review8483 --- Hi Anshul, 1) When throwing exceptions that have IDs, please use the

Re: CloudStack API question

2012-06-22 Thread Prasanna Santhanam
Hi Amit, Posting this to the asf-dev list. There are more eyes here to correct me if I am wrong. Answers Inline: > Where can I find more information on specific parameters passed to a > CLoudStack API. The API reference guide only provides a one line > description > I think that the API refe

Re: Storage Networks XenServer

2012-06-22 Thread Weiran Xia
here i got a similar question, there seems be some confusion in terminology. >From http://wiki.cloudstack.org/display/DesignDocs/Storage+network+in+Acton it says a storage network is for speeding up template/snapshot copying process, and indeed during the zone creation process there is a step of c

JUnit Test Suites

2012-06-22 Thread Saksham Srivastava
Hi, Currently there are a few JUnit Test cases present in the code base.Many of them are broken. We do not need all the tests now.There is a need to identify and clean-up these tests so the obsolete tests can be removed from the code. Bugs for the failing tests have been created.More bugs can b

Review Request: CS-13537 Delete Domain Response doesn't let the User know the Failure for the operation and partial fix for CS-14681 Detail errortext in the API response

2012-06-22 Thread Anshul Gangwar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5522/ --- Review request for cloudstack. Description --- In DomainManagerImpl class i

Storage Networks XenServer

2012-06-22 Thread Geoff Higginbottom
Hi I have been trying to get a system up and running using XenServer 6.0.2 with multiple physical networks, with one nic dedicated to Storage. There seems to be a lot of contradictory info regarding the use of the storage network, and whether it is for Primary or Secondary storage. The latest

[PATCH] CS-13537 Delete Domain Response doesn't let the User know the Failure for the operation and partial fix for CS-14681 Detail errortext in the API response

2012-06-22 Thread Anshul Gangwar
From: Anshul Gangwar Signed-off-by: Anshul Gangwar --- server/src/com/cloud/user/DomainManagerImpl.java | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/server/src/com/cloud/user/DomainManagerImpl.java b/server/src/com/cloud/user/DomainManagerImpl.java in