Sente 1.0.0 (was: [ANN] Taoensso library updates / 2014 September

2014-09-06 Thread Sean Corfield
Peter, I just upgraded from Sente 0.15.1 to 1.0.0 and it looks like the values that come in ch-recv have changed format? I used to have the following: (go (loop [[op arg] ( wrote: > (All new releases are now on BreakVersioning, > https://github.com/ptaoussanis/encore/blob/master/BREAK-VERSIONI

Re: [ANN] Clojure 1.7.0-alpha2

2014-09-06 Thread Michael Gardner
Great stuff, and thanks for all the hard work. But if I may, I'd like to suggest that "completing" isn't a great name for that transducer helper function-- at least not in the core namespace. It's too generic: there's no way to guess what it does from the name, and IMO a function with such a ni

Re: Sente 1.0.0 (was: [ANN] Taoensso library updates / 2014 September

2014-09-06 Thread Hugo Duncan
s...@corfield.org writes: > Is that an intentional change? I ask because you claimed the release was > major but non-breaking - and this seems to be a breaking change...? Did you change `start-chsk-router-loop!` to `start-chsk-router!`? The former maintains the previous event handler signature

Re: [ANN] Taoensso library updates / 2014 September

2014-09-06 Thread Peter Taoussanis
Hi Sean, thank you for pinging about this. The upgrade to v1.0.0 *is* actually breaking *if* you've been reading from the client-side :ch-recv directly. Most folks use the provided router utils, so it slipped my mind to document that - I'm really sorry. Will update the README and CHANGELOG now.

Re: how do you name your protocols?

2014-09-06 Thread Bobby Eickhoff
What might be an advantage to using something like the I-prefix? At first glance, this appears to be unbeneficial hungarian notation. Aesthetically, this seems backwards (to me). I want interfaces and protocols to have the most readable names. I'm willing to concede on less readable names fo

Re: how do you name your protocols?

2014-09-06 Thread Jozef Wagner
Clojure API exposes types to the user (Agent, Ref, Var, ...), so it is benefical to see on the first glance whether the name is of a type or interface/protocol. If the API would be built solely on the protocols/interfaces, those prefixes would be of less use. Moreover, I think that names of types

Re: [ANN] Taoensso library updates / 2014 September

2014-09-06 Thread Sean Corfield
On Sep 6, 2014, at 5:01 AM, Peter Taoussanis wrote: > The upgrade to v1.0.0 *is* actually breaking *if* you've been reading from > the client-side :ch-recv directly. Most folks use the provided router utils, > so it slipped my mind to document that - I'm really sorry. No problem. I just wanted

Re: Sente 1.0.0 (was: [ANN] Taoensso library updates / 2014 September

2014-09-06 Thread Sean Corfield
On Sep 6, 2014, at 3:55 AM, Hugo Duncan wrote: > Did you change `start-chsk-router-loop!` to `start-chsk-router!`? I don't use those. I read directly from ch-recv due to some of the stuff I needed to do (when I first started using Sente). I may revisit this now... Sean Corfield -- (904) 302-SEA

Re: Sente 1.0.0 (was: [ANN] Taoensso library updates / 2014 September

2014-09-06 Thread Sean Corfield
Ah, I remember why now: Since the event loop is in a 'go' block and because I didn't want slow event handlers blocking everything, I wanted to dispatch my event handler in a (thread ...) call. Perhaps start-chsk-router! could take an optional argument to indicate the handler call should be spu

Re: [ANN] Taoensso library updates / 2014 September

2014-09-06 Thread Peter Taoussanis
> > No problem. I just wanted to check that it was an intentional change, and > not some unknown bug that had crept in. Sure, appreciate that. And one had (buggy CHANGELOG) - so good that you checked ;-) I just switched my app from Om/Sablono + Sente to Reagent + Sente and I'm > currently wo