Re: small code review..

2010-02-14 Thread Meikel Brandmeyer
Hi, On Sun, Feb 14, 2010 at 08:32:42AM -0800, Martin Hauner wrote: > > (cond > >   (empty? rolls)     0 > >   (strike? rolls)    (+ (score-strike rolls) (score-after-strike rolls)) > >   (spare?  rolls)    (+ (score-spare rolls)  (score-after-frame rolls)) > >   (more?   rolls)    (+ (score-frame

Re: small code review..

2010-02-14 Thread Martin Hauner
On 12 Feb., 01:34, Timothy Pratley wrote: > On 12 February 2010 03:19, Martin Hauner wrote: > > > I'm mostly interested if there is anything in my code one would/should > > never do that way. > > Looks excellent, you've aced it! Thanks :-) > I'd like to discuss switching...You wrote: > > (cond

Re: small code review..

2010-02-14 Thread Martin Hauner
Hi Brandon, On 11 Feb., 19:59, Brenton wrote: > Martin, > > It's very simple, I like it. > > There two things that stand out to me, both having to do with > readabiliby. > > Instead of using (def score) you should use (declare score). declare > exists for the purpose of making forward declaration

Re: small code review..

2010-02-11 Thread ataggart
On Feb 11, 4:34 pm, Timothy Pratley wrote: > On 12 February 2010 03:19, Martin Hauner wrote: > > > I'm mostly interested if there is anything in my code one would/should > > never do that way. > > Looks excellent, you've aced it! > > I'd like to discuss switching...You wrote: > > (cond >   (emp

Re: small code review..

2010-02-11 Thread Timothy Pratley
On 12 February 2010 03:19, Martin Hauner wrote: > I'm mostly interested if there is anything in my code one would/should > never do that way. Looks excellent, you've aced it! I'd like to discuss switching... You wrote: (cond (empty? rolls) 0 (strike? rolls)(+ (score-strike rolls) (sc

Re: small code review..

2010-02-11 Thread Brenton
Martin, It's very simple, I like it. There two things that stand out to me, both having to do with readabiliby. Instead of using (def score) you should use (declare score). declare exists for the purpose of making forward declarations. That one is black and white. You have to do it. The other I

small code review..

2010-02-11 Thread Martin Hauner
Hi, I'm doing my first steps in Clojure and I would like to get some feedback on my implementation of the Bowling Game Kata. The code is here http://softnoise.wordpress.com/2010/02/07/the-bowling-kata-in-clojure. I can post the code here if that's preferred. I'm mostly interested if there is anyt