Re: clojure.core.read-line broken - can we please fix it?

2009-03-09 Thread Perry Trolard
Just for the record, this problem with read-line was fixed at SVN r1321. (Thanks for packaging up the patch, Chouser.) Perry --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Clojure" group. To post to this group, se

Re: clojure.core.read-line broken - can we please fix it?

2009-02-20 Thread Rayne
I filed it as an issue a few days ago, until then I wrote my own read- line from the old read-line. On Feb 20, 4:32 pm, "Stephen C. Gilardi" wrote: > On Feb 20, 2009, at 12:58 PM, Perry Trolard wrote: > > > Hope I didn't imply by the above that I was suggesting a name change. > > > I know my pro

Re: clojure.core.read-line broken - can we please fix it?

2009-02-20 Thread Stephen C. Gilardi
On Feb 20, 2009, at 12:58 PM, Perry Trolard wrote: Hope I didn't imply by the above that I was suggesting a name change. I know my proposed version is ugly, but since BufferedReader & LineNumberingPR can't be unified, special-case-ing for the latter strikes me as an acceptable fix. But removin

Re: clojure.core.read-line broken

2009-02-20 Thread Perry Trolard
Hope I didn't imply by the above that I was suggesting a name change. I know my proposed version is ugly, but since BufferedReader & LineNumberingPR can't be unified, special-case-ing for the latter strikes me as an acceptable fix. But removing the type hint so that the function works out of the

Re: clojure.core.read-line broken

2009-02-18 Thread Perry Trolard
On Feb 18, 12:27 pm, "Stephen C. Gilardi" wrote: > This is from issue 47, svn 1229. It's unfortunate that a class can't   > be both a BufferedReader and a PushbackReader simultaneously. Those   > classes were implemented using class inheritance rather than via   > interfaces. In this case, the d

Re: clojure.core.read-line broken

2009-02-18 Thread Stephen C. Gilardi
On Feb 18, 2009, at 12:05 PM, Perry Trolard wrote: On the most recent svn (r1293), read-line throws a ClassCastException when called: user=> (read-line) java.lang.ClassCastException: clojure.lang.LineNumberingPushbackReader cannot be cast to java.io.BufferedReader (NO_SOURCE_FILE:0) Removing

clojure.core.read-line broken

2009-02-18 Thread Perry Trolard
On the most recent svn (r1293), read-line throws a ClassCastException when called: user=> (read-line) java.lang.ClassCastException: clojure.lang.LineNumberingPushbackReader cannot be cast to java.io.BufferedReader (NO_SOURCE_FILE:0) Removing the type hint solves the issue: user=> (source read-l