Re: clojure.contrib.sql - Support DataSource in with-connection

2009-01-21 Thread Juergen Gmeiner
On Jan 21, 4:12 am, "Stephen C. Gilardi" wrote: > On Jan 20, 2009, at 7:01 PM, Stephen C. Gilardi wrote: > > I've checked in an implementation for this. I confirmed that it > doesn't harm the jdbc url method of connecting, but I don't have a > DataSource setup to test the DataSource method. Juerg

Re: clojure.contrib.sql - Support DataSource in with-connection

2009-01-20 Thread Stephen C. Gilardi
On Jan 20, 2009, at 7:01 PM, Stephen C. Gilardi wrote: I'd like for clojure.contrib.sql to support DataSource. As an alternative implementation, what do you think of db-spec allowing a :datasource key. If :datasource is specified, with-connection could use its value to acquire the connecti

Re: clojure.contrib.sql - Support DataSource in with-connection

2009-01-20 Thread Stephen C. Gilardi
On Jan 20, 2009, at 6:16 PM, Juergen Gmeiner wrote: I've been using clojure for prototyping in JBoss and I found that clojure.contrib.sql does not currently support opening JDBC connections via a javax.sql.DataSource. So I propose the patch below. Hi Juergen, I'd like for clojure.contrib.sq

clojure.contrib.sql - Support DataSource in with-connection

2009-01-20 Thread Juergen Gmeiner
I've been using clojure for prototyping in JBoss and I found that clojure.contrib.sql does not currently support opening JDBC connections via a javax.sql.DataSource. So I propose the patch below. Cheers, Juergen diff --git a/src/clojure/contrib/sql.clj b/src/clojure/contrib/sql.clj index 75242