Re: My first clojure web app

2011-01-10 Thread Sean Allen
On Wed, Jan 5, 2011 at 9:21 PM, Timothy Pratley wrote: > Neat, looks pretty nice. > I love invitations to nit pick! > database.clj > (defn complete-todo [id] > (dosync (ref-set *todo* (vec (remove #(= (get % :id) id) @*todo*) > 1) ref-set is unnecessary you could re-factor this to use alter.

Re: My first clojure web app

2011-01-05 Thread Timothy Pratley
Neat, looks pretty nice. I love invitations to nit pick! database.clj (defn complete-todo [id] (dosync (ref-set *todo* (vec (remove #(= (get % :id) id) @*todo*) 1) ref-set is unnecessary you could re-factor this to use alter. The result is the same, but semantically set only applies when the