Re: Calling superclass methods from implemented methods

2008-12-09 Thread Rich Hickey
On Tue, Dec 9, 2008 at 4:28 PM, Matt Revelle <[EMAIL PROTECTED]> wrote: > > On Dec 9, 2008, at 10:03 AM, Rich Hickey wrote: > >> >> >> >> On Dec 9, 12:24 am, Matt Revelle <[EMAIL PROTECTED]> wrote: >>> The attached patch adds :super-methods option to generate-class as a >>> map, {local-name [name

Re: Calling superclass methods from implemented methods

2008-12-09 Thread Matt Revelle
On Dec 9, 2008, at 10:03 AM, Rich Hickey wrote: > > > > On Dec 9, 12:24 am, Matt Revelle <[EMAIL PROTECTED]> wrote: >> The attached patch adds :super-methods option to generate-class as a >> map, {local-name [name [param-types] return-type], ...}. The >> mechanics work as Rich suggested in an ea

Re: Calling superclass methods from implemented methods

2008-12-09 Thread Rich Hickey
On Dec 9, 12:24 am, Matt Revelle <[EMAIL PROTECTED]> wrote: > The attached patch adds :super-methods option to generate-class as a > map, {local-name [name [param-types] return-type], ...}. The > mechanics work as Rich suggested in an earlier message, a method is > created that has the same typ

Re: Calling superclass methods from implemented methods

2008-12-08 Thread Matt Revelle
The attached patch adds :super-methods option to generate-class as a map, {local-name [name [param-types] return-type], ...}. The mechanics work as Rich suggested in an earlier message, a method is created that has the same type signature as the exposed method - it loads the arguments, inv

Re: Calling superclass methods from implemented methods

2008-12-08 Thread Matt Revelle
The original plan was to use the super keyword to signal that invokespecial should be used. Now that you mention the lack of type relationship, that problem is obvious. I suppose adding a :supers is what I'll do. -Matt On Dec 8, 2008, at 10:59 AM, Rich Hickey wrote: > > > > On Dec 8, 9:

Re: Calling superclass methods from implemented methods

2008-12-08 Thread Rich Hickey
On Dec 8, 9:30 am, Matt Revelle <[EMAIL PROTECTED]> wrote: > I'm working on a patch to add support for calling the superclass' > implementation of a method when overriding a method in Clojure with > ns/:genclass. This looks like it requires a modification of the > InstanceMethodExpr class in cl

Re: Calling superclass methods from implemented methods

2008-12-08 Thread Geoffrey Teale
2008/12/8 Matt Revelle <[EMAIL PROTECTED]> > > I'm working on a patch to add support for calling the superclass' > implementation of a method when overriding a method in Clojure with > ns/:genclass. This looks like it requires a modification of the > InstanceMethodExpr class in clojure.lang.Compi