Re: FindBugs run on Clojure source code

2008-11-15 Thread Attila Szegedi
On 2008.11.15., at 15:25, Rich Hickey wrote: > Welcome Attila, > > I've run findbugs on Clojure before and cleaned up a few things. These > that you mentioned, however, stand as a good example of such an > analyzer not knowing enough, and I count as spurious, if well- > intended. > > As mentione

Re: FindBugs run on Clojure source code

2008-11-15 Thread Rich Hickey
On Nov 15, 4:53 am, Attila Szegedi <[EMAIL PROTECTED]> wrote: > Hi folks, > > I run FindBugs on Clojure source code, and there are few things it > uncovered. I'd be happy to fix these and submit patches (after I > submitted a contributor agreement), except if someone already a > contributor want

Re: FindBugs run on Clojure source code

2008-11-15 Thread Attila Szegedi
On 2008.11.15., at 14:23, Phil Jordan wrote: > > Hi Attila, > > I can't comment on the other issues, but: > > Attila Szegedi wrote: >> 2. Keyword and Ref define compareTo, but don't redefine equals (and >> hashCode) to be consistent with it. It ain't necessarily a problem if >> you know what you'

Re: FindBugs run on Clojure source code

2008-11-15 Thread Phil Jordan
Hi Attila, I can't comment on the other issues, but: Attila Szegedi wrote: > 2. Keyword and Ref define compareTo, but don't redefine equals (and > hashCode) to be consistent with it. It ain't necessarily a problem if > you know what you're doing, but since they're public it's usually a > g

FindBugs run on Clojure source code

2008-11-15 Thread Attila Szegedi
Hi folks, I run FindBugs on Clojure source code, and there are few things it uncovered. I'd be happy to fix these and submit patches (after I submitted a contributor agreement), except if someone already a contributor wants to tackle these instead (they're easy to fix for the most part).