Re: [core.async] New put api

2014-01-25 Thread Sean Corfield
On Jan 23, 2014, at 1:47 PM, Timothy Baldridge wrote: > Sadly, put! on a closed channel has never thrown an exception (regardless of > what the docstring says). LOL! OK, then I'm happy. > So to answer your question about closing with pending puts. > > 1) call put! on an open channel with no t

Re: [core.async] New put api

2014-01-23 Thread Timothy Baldridge
Sadly, put! on a closed channel has never thrown an exception (regardless of what the docstring says). I'll list the semantics, but note that the wording gets a bit clumsy due to the way threading works. So if I say "if the channel is closed when the put! occurs", the "occurs" is at the time that

Re: [core.async] New put api

2014-01-23 Thread Sean Corfield
Can you confirm: * Today, calling put! on a closed channel throws an exception (according to its docstring). * After this change, calling put! on a closed channel will return nil instead. The current docstring says that the function will be called "when complete" which I took to mean when the v

[core.async] New put api

2014-01-23 Thread Timothy Baldridge
I'm looking for some feedback on recent changes Rich and I have made to core.async: I merged the "put ret" branch into master of core.async. This commit introduces some changes to the core.async API that provides feedback during a put! operation. The changes to the public api are fairly simple: