Nice. Thanks for pushing that through a Jira and into 1.8 so quickly!
On Tuesday, October 27, 2015 at 1:32:46 PM UTC-5, Alex Miller wrote:
>
> The map-entry? predicate was just committed to master and will be in the
> next build.
>
> On Friday, October 16, 2015 at 1:29:21 PM UTC-5, Mike Rodrigue
The fix for this was applied to master today and will be in the next build.
On Tuesday, October 13, 2015 at 12:39:43 PM UTC-5, Alex Miller wrote:
>
> The reflection warning is from the pprint ticket - code changed from when
> the patch was created and applied. We will get that in the next beta.
CLJ-1809 was applied today and will be in the next build.
On Tuesday, October 13, 2015 at 12:29:17 PM UTC-5, Alex Miller wrote:
>
> CLJ-1809 will be addressed before 1.8 final.
--
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, se
The map-entry? predicate was just committed to master and will be in the
next build.
On Friday, October 16, 2015 at 1:29:21 PM UTC-5, Mike Rodriguez wrote:
>
> Yes a `map-entry?` predicate was sort of the direction I was leaning in
> that would help avoid issues like this around these changes.
>
Yes a `map-entry?` predicate was sort of the direction I was leaning in
that would help avoid issues like this around these changes.
On Friday, October 16, 2015 at 10:58:47 AM UTC-5, Alex Miller wrote:
>
> Perhaps having a "map-entry?" predicate that was smarter would be helpful.
>
> On Friday, O
Perhaps having a "map-entry?" predicate that was smarter would be helpful.
On Friday, October 16, 2015 at 9:39:09 AM UTC-5, Mike Rodriguez wrote:
>
> Yes, I am in support of the fact that size=2 vectors now can now have
> `key` and `val` called on them. This not working prior to Clojure 1.8 was
Yes, I am in support of the fact that size=2 vectors now can now have `key`
and `val` called on them. This not working prior to Clojure 1.8 was
occasionally the reason why I just used `first` and `second` instead of
`key` and `val` before since some function transformations could result in
siz
On Friday, October 16, 2015 at 3:32:43 AM UTC-5, Pierre-Yves Ritschard
wrote:
>
> Hi Mike,
>
> The code at here seems to contradict you:
>
> https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/APersistentVector.java#L448-L460,
>
>
> as does "(key [:a :b])" in the REPL.
>
> Th
Hi Mike,
The code at here seems to contradict you:
https://github.com/clojure/clojure/blob/master/src/jvm/clojure/lang/APersistentVector.java#L448-L460,
as does "(key [:a :b])" in the REPL.
The only limitation is that vectors need to be of size two to act as
IMapEntries (otherwise an IllegalOpera
It would be great to have a ticket and some examples beyond the riddley one
where this was an issue.
Thanks for trying the beta and giving feedback!
--
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googleg
It would be great to have a ticket and some examples beyond the riddley one
where this was an issue.
Thanks for trying the beta and giving feedback!
--
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googleg
I migrated a significant Clojure codebase to 1.8.0-beta1, and I had to
solve issues caused by this IMapEntry/APersistentVector change in several
places (including the pull request mentioned above). Also wondering about
the rationale behind this. It's not a huge deal, but it does make some code
Someone else looked at the issue on
https://github.com/ztellman/riddley/issues/18
This issue makes the current version of riddley, and therefore potemkin, not
work on Clojure 1.8 beta1
There is a pull request to fix it at https://github.com/ztellman/riddley/pull/19
However I am wondering if it
Agreed :)
On 14 October 2015 at 23:08, Alex Miller wrote:
> This is a bug in the original code that is being caught by the stricter
> check on throws (at
> https://github.com/hugoduncan/clj-ssh/blob/develop/src/clj_ssh/ssh.clj#L301)
> - name there should be the final arg to ex-info, not to throw
This is a bug in the original code that is being caught by the stricter
check on throws
(at
https://github.com/hugoduncan/clj-ssh/blob/develop/src/clj_ssh/ssh.clj#L301)
- name there should be the final arg to ex-info, not to throw.
So I'm going to call that a good regression. :)
On Wednesday,
I don't have a good way to measure runtime like that I'm afraid.
On 14 October 2015 at 22:39, Ghadi Shayban wrote:
> Marc,
> Any changes up or down in run-time performance (post-startup)?
>
> On Wednesday, October 14, 2015 at 5:11:20 PM UTC-4, Marc O'Morain wrote:
>>
>> I just ran the CircleCI c
Marc,
Any changes up or down in run-time performance (post-startup)?
On Wednesday, October 14, 2015 at 5:11:20 PM UTC-4, Marc O'Morain wrote:
>
> I just ran the CircleCI code-base under 1.8 beta 1 to see if there were
> any gains in compile time (which is in the region of 90 seconds for our
> ma
I just ran the CircleCI code-base under 1.8 beta 1 to see if there were any
gains in compile time (which is in the region of 90 seconds for our main
app). The clj-ssh issue was the only third-party lib that didn't work.
Here is our compile time on Clojure 1.7 and 1.8:
Clojure 1.7:
real 1m30.622s
FYI - Trying to upgrade CircleCI I get a syntax error in clj-ssh (passing
too many argument to throw):
https://github.com/hugoduncan/clj-ssh/issues/39
I've logged the issue with them.
On 13 October 2015 at 15:01, Alex Miller wrote:
> Clojure 1.8.0-beta1 is now available.
>
> Try it via
>
>
Just a heads up, I tried upliftign to Clojure 1.8.0-beta1 today and had a
failure that is originating from potemkin "0.4.1". I think the issue may
be in its dependent project riddley "0.1.10".
I logged an issue there at https://github.com/ztellman/riddley/issues/18.
I haven't tracked down the c
The reflection warning is from the pprint ticket - code changed from when the
patch was created and applied. We will get that in the next beta.
--
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.
CLJ-1809 will be addressed before 1.8 final.
--
You received this message because you are subscribed to the Google
Groups "Clojure" group.
To post to this group, send email to clojure@googlegroups.com
Note that posts from new members are moderated - please be patient with your
first post.
To uns
Since upgrading our maven-based project, I'm seeing a new warning:
Reflection warning, clojure/pprint/pretty_writer.clj:419:12 - call to
method write can't be resolved (target class is unknown).
Once I connect with cider, I check *warn-on-reflection* and it is false.
On Tue, Oct 13, 2015 at 11:44
Just a heads up that http://dev.clojure.org/jira/browse/CLJ-1809 is still a
problem. A lot of Clojure code fails to compile now. I hope this will be
fixed before 1.8 final is out.
On Tuesday, October 13, 2015 at 4:01:06 PM UTC+2, Alex Miller wrote:
>
> Clojure 1.8.0-beta1 is now available.
>
> T
Clojure 1.8.0-beta1 is now available.
Try it via
- Download:
https://repo1.maven.org/maven2/org/clojure/clojure/1.8.0-beta1
- Leiningen: [org.clojure/clojure "1.8.0-beta1"]
Below is a list of the other changes included in beta1. See the full change
log here: https://github.com/clojure
25 matches
Mail list logo