This fix does a couple of things
1) AffineTransformOp.createCompatibleDestImage() and
AffineTransformOp.createCompatibleDestRaster() now specify that they will throw
RasterFormatException if the transformed size is too large. They were already
getting an exception.
Note that inside the JDK only
On Fri, 22 Aug 2025 17:39:10 GMT, Phil Race wrote:
> Some text describing the Beans.instantiate lookup process existed only on the
> method that used the now removed AppletInitializer.
> Since there are two other Beans.instantiate methods, we need to move that
> text to the remai
behavioral changes
> - One for the createInterleavedRaster() update where the unchecked case
> could end up causing a NegativeArraySizeException. This seems like a merited
> change.
> - One for an unlikely case where if an app specified 0 app to
> createPackedRaster, divide by z
Updates the specification of Raster.createPackedRaster(..) methods and also the
implementation of these to explicitly check the specified conditions rather
than relying on them being passed up from some other API.
Also one each of the createInterleavedRaster(..) and createBandedRaster(..)
metho
behavioral changes
> - One for the createInterleavedRaster() update where the unchecked case
> could end up causing a NegativeArraySizeException. This seems like a merited
> change.
> - One for an unlikely case where if an app specified 0 app to
> createPackedRaster, divide by z
On Thu, 25 Sep 2025 03:12:17 GMT, Sergey Bylokhov wrote:
>> Additional checks were recently added to ICC_Profile (see
>> [JDK-8347377](https://bugs.openjdk.org/browse/JDK-8347377)). As a result,
>> objects previously stored as valid profiles may now throw an
>> IllegalArgumentException during
On Mon, 1 Sep 2025 10:24:58 GMT, Artem Semenov wrote:
>> The defect has been detected and confirmed in the function
>> OGLBlitToSurfaceViaTexture() located in the file
>> src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c with
>> static code analysis. This defect can potentially
On Sat, 20 Sep 2025 23:55:39 GMT, Sergey Bylokhov wrote:
> This test verifies rendering consistency across three APIs: String,
> TextLayout, and GlyphVector. The same text is rendered using each API, and
> the results are expected to match.
>
> The test logic differs slightly between the two c
On Wed, 24 Sep 2025 22:50:28 GMT, Sergey Bylokhov wrote:
> > I don't think it is a JDK product bug. It is something in Apple's scaling
> > that we can't do anything about.
>
> I meant on windows, why it does not work as is, so we need to set scale to 1,
> the tests seems do not use some compli
On Wed, 24 Sep 2025 22:38:29 GMT, Sergey Bylokhov wrote:
>> What's the command you are using to run the tests ?
>> make test something .. ?
>
>>Is that somehow propagated to jtreg concurrency too ?
>
> Yes, jtreg executed via make will use the same concurrency.
>
>>Why is this test special
On Fri, 19 Sep 2025 18:20:43 GMT, Sergey Bylokhov wrote:
> The default timeout factor for tests was changed by
> [JDK-8260555](https://bugs.openjdk.org/browse/JDK-8260555). Since then, the
> HeadlessMalfunctionTest may occasionally fail on some systems when run in
> parallel with other tests.
> This mostly went OK except that I found one of the tests fails on macOS with
> metal.
> I've had to add a new problem listing for that.
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
8040230
-
Changes:
On Thu, 25 Sep 2025 11:23:18 GMT, Ravi-Patel8 wrote:
>> Bug Ref: https://bugs.openjdk.org/browse/JDK-8368606
>>
>> As part of [JDK-8344057](https://bugs.openjdk.org/browse/JDK-8344057)
>> ("Remove doPrivileged calls from unix platform sources in the java.desktop
>> module"), changes were made
On Fri, 26 Sep 2025 07:53:44 GMT, Prasanta Sadhukhan
wrote:
>> Ravi-Patel8 has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Updated Comments
>>
>>Signed-off-by: Ravi.Patel8
>> - Add catch block to log exception details for tr
On Mon, 25 Aug 2025 20:09:15 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8366002
>> - 8366002
>
> src/java.desktop/share/classes/java/beans/Beans.j
is also deprecated for removal, so it seems
> prudent to add it to both so that when the next to be removed method is gone,
> this problem doesn't recur.
>
> This is a doc. only change. The CSR is ready for review.
Phil Race has updated the pull request incrementally with two
On Fri, 26 Sep 2025 19:19:32 GMT, Phil Race wrote:
>> Some text describing the Beans.instantiate lookup process existed only on
>> the method that used the now removed AppletInitializer.
>> Since there are two other Beans.instantiate methods, we need to move that
>&g
On Thu, 25 Sep 2025 23:22:26 GMT, Daniel Gredler wrote:
>> This PR fixes one more issue preventing
>> `test/jdk/java/awt/print/PrinterJob/PrintTextTest.java` from being removed
>> from the problem list on macOS. The issue is the placement of line 8
>> ("GlyphVector with position adjustments")
On Fri, 26 Sep 2025 16:24:23 GMT, Daniel Gredler wrote:
> > You can use str.isEmpty() here.
>
> I was actually going for consistency with all of the other optimizations of
> this type, which all use a length check. I can change it to `isEmpty` if you
> feel strongly about it, though.
I think
On Fri, 26 Sep 2025 11:23:03 GMT, Daniel Gredler wrote:
> Until [JDK-4138921](https://bugs.openjdk.org/browse/JDK-4138921),
> `TextLayout` did not accept empty strings in the constructor. This limitation
> has been removed. However, there is a guard condition in
> `OutlineTextRenderer` which c
On Sat, 20 Sep 2025 21:23:06 GMT, Sergey Bylokhov wrote:
>>> I don't think it is high profile enough to need a release note.
>>
>> OK, sounds good.
>>
>>> I was hoping I could push that problem listing (it is an internal thing)
>>> right at the same time you pushed
>>
>> Ah, I'm sorry -- I di
On Thu, 25 Sep 2025 12:49:31 GMT, Daniel Gredler wrote:
> This PR fixes one more issue preventing
> `test/jdk/java/awt/print/PrinterJob/PrintTextTest.java` from being removed
> from the problem list on macOS. The issue is the placement of line 8
> ("GlyphVector with position adjustments") duri
On Wed, 24 Sep 2025 22:47:43 GMT, Sergey Bylokhov wrote:
> Does this mean that using the graphics object after calling .end is not
> specified as noop? The comments above is from the non public API.
I directed you to the following spec on end()
* Ends the print job and does any necessary clean
On Fri, 19 Sep 2025 18:20:43 GMT, Sergey Bylokhov wrote:
> The default timeout factor for tests was changed by
> [JDK-8260555](https://bugs.openjdk.org/browse/JDK-8260555). Since then, the
> HeadlessMalfunctionTest may occasionally fail on some systems when run in
> parallel with other tests.
On Wed, 24 Sep 2025 20:45:47 GMT, Sergey Bylokhov wrote:
> Does this new statement in the spec covered by any tests?
The test pushed in the previous PR covers it.
> How will it behave if getGraphics is called before end, but the Graphics
> object is used after end has been called?
Same as b
On Fri, 19 Sep 2025 21:53:30 GMT, Phil Race wrote:
> Moving to open a number of graphics related tests, originally written to test
> the OpenGL pipeline.
> These versions are "better behaved" than the versions that were in closed -
> mostly meaning they now
> do thing
On Wed, 24 Sep 2025 21:17:05 GMT, Sergey Bylokhov wrote:
>> test/jdk/java/awt/Headless/HeadlessMalfunctionTest.java line 41:
>>
>>> 39: * HeadlessMalfunctionAgent
>>> 40: * HeadlessMalfunctionAgent$1
>>> 41: * @run driver/timeout=240 HeadlessMalfunctionTest
>>
>> On
On Wed, 24 Sep 2025 21:54:44 GMT, Phil Race wrote:
>> Just tested it on the system:
>>
>>
>> Build performance summary:
>> * Build jobs: 48
>> * Memory limit: 95498 MB
>>
>>
>>
>> command: driver Headless
On Tue, 23 Sep 2025 21:00:18 GMT, Phil Race wrote:
> A few days ago it was noticed that there was a printing test (in closed) that
> didn't have a test tag and on closer examination that was unfortunate because
> it tested that PrintJob.getGraphics() returns null after Prin
On Fri, 19 Sep 2025 22:01:32 GMT, Phil Race wrote:
> This test would fail with Xrender. But it did odd things like sleep in the
> paint method.
> When I fixed that it started to pass every time.
> It also had a problem listing for macOS supposedly for edge pixels.
> I didn't
On Mon, 22 Sep 2025 19:46:37 GMT, Sergey Bylokhov wrote:
> > > why on WIndows/Linux we set "-Dsun.java2d.uiScale=1" option and on mac we
> > > do not?
> >
> >
> > I'd have used uiScale=1 everywhere, but I actually observed a few rounding
> > errors on retina if I used uiScale = 1 . Letting ui
On Sun, 21 Sep 2025 12:03:26 GMT, Prasanta Sadhukhan
wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8221451
>
> test/jdk/sun/java2d/X11SurfaceData/SharedMemoryPixmapsTest/SharedM
> This test would fail with Xrender. But it did odd things like sleep in the
> paint method.
> When I fixed that it started to pass every time.
> It also had a problem listing for macOS supposedly for edge pixels.
> I didn't see that myself but I changed it to not sample the e
On Sun, 21 Sep 2025 11:58:16 GMT, Prasanta Sadhukhan
wrote:
>> This test would fail with Xrender. But it did odd things like sleep in the
>> paint method.
>> When I fixed that it started to pass every time.
>> It also had a problem listing for macOS supposedly for edge pixels.
>> I didn't see t
On Tue, 23 Sep 2025 04:09:46 GMT, Prasanta Sadhukhan
wrote:
>> Moving to open a number of graphics related tests, originally written to
>> test the OpenGL pipeline.
>> These versions are "better behaved" than the versions that were in closed -
>> mostly meaning they now
>> do things on the rig
On Sun, 21 Sep 2025 11:43:28 GMT, Prasanta Sadhukhan
wrote:
>> Test used to timeout even though it seems the test passed..Increased the
>> timeout to a safe value as sometimes it shows elapsed time to timeout >
>> 300secs in macOS in CI and also ensured the wait-time for child process to
>> e
On Mon, 22 Sep 2025 16:20:04 GMT, Sergey Bylokhov wrote:
> why on WIndows/Linux we set "-Dsun.java2d.uiScale=1" option and on mac we do
> not?
I'd have used uiScale=1 everywhere, but I actually observed a few rounding
errors on retina if I used uiScale = 1 .
Letting uiScale be whatever is the
On Sun, 21 Sep 2025 23:20:48 GMT, Sergey Bylokhov wrote:
> > It seemed to be macOS bug on osx12 and it pass locally on osx15.6 everytime
> > now even without timeout increase so I dont think bug exists anymore...It
> > seems in slower CI systems it takes few minutes+ which is why we needed to
Moving to open a number of graphics related tests, originally written to test
the OpenGL pipeline.
These versions are "better behaved" than the versions that were in closed -
mostly meaning they now
do things on the right thread and paint properly on demand.
As a result they now pass - at least o
On Thu, 11 Sep 2025 03:13:13 GMT, Damon Nguyen wrote:
>> In the scenario where AWT's UNLOCK API encounters a pendingException, the
>> env pointer throws the pendingException (as seen in `awt.h`). However, in
>> `Java_sun_awt_X11GraphicsDevice_pGetBounds`, after `AWT_UNLOCK`, the bounds
>> var
On Fri, 5 Sep 2025 21:50:04 GMT, Sergey Bylokhov wrote:
> The Toolkit/Headless/WrappedToolkitTest/WrappedToolkitTest.sh test:
> - Checks the "XToolkit" environment property, which was removed a long time
> ago
> - Checks the "awt.toolkit" java property, which was also removed a long time
> ag
On Thu, 11 Sep 2025 05:00:38 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8314731 : Adds support for the alt attribute in the image type input
>> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
>>
>> This is tracked in JBS as
>> - [JDK
This test would fail with Xrender. But it did odd things like sleep in the
paint method.
When I fixed that it started to pass every time.
It also had a problem listing for macOS supposedly for edge pixels.
I didn't see that myself but I changed it to not sample the edges.
-
Commit me
On Thu, 18 Sep 2025 13:37:52 GMT, Matthias Baesken wrote:
> I have started a verification job with tier1-5.
If that passes, then it is very likely OK.
-
PR Comment: https://git.openjdk.org/jdk/pull/27358#issuecomment-3310536470
On Fri, 19 Sep 2025 02:55:34 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/java/awt/FullScreen/UninitializedDisplayModeChangeTest/DisplayModeChanger.java
>> line 69:
>>
>>> 67: f.dispose();
>>> 68: }
>>> 69: gd.setDisplay
On Thu, 18 Sep 2025 23:59:05 GMT, Harshitha Onkar wrote:
> On macOS mouse sensitivity setting play a role in click count increment. By
> increasing the double-click speed under
> (Settings > Mouse Sensitivity > Double click speed), the click count no
> longer shows as 1,2.
>
> src="https://gi
On Wed, 3 Sep 2025 17:37:00 GMT, Phil Race wrote:
>> `TextLayout` should deal more gracefully with zero length strings. Currently
>> the exception listed below is the one that is thrown.
>>
>> `new TextLayout("", f, new FontRenderContext(null, false, false));`
On Wed, 17 Sep 2025 17:26:44 GMT, Daniel Gredler wrote:
>> You have removed the only override, and the method does nothing with
>> anything except the provided string.
>> So it seems to me this could be a static utility method, like
>> isIgnorableWhitespace.
>> I'm not suggesting moving it, jus
On Tue, 16 Sep 2025 23:51:06 GMT, Sergey Bylokhov wrote:
> Additional checks were recently added to ICC_Profile (see
> [JDK-8347377](https://bugs.openjdk.org/browse/JDK-8347377)). As a result,
> objects previously stored as valid profiles may now throw an
> IllegalArgumentException during seri
On Wed, 17 Sep 2025 11:18:46 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/JFileChooser/8194044/FileSystemRootTest.java line 39:
>>
>>> 37: public class FileSystemRootTest {
>>> 38: public static void main(String[] args) throws Exception {
>>> 39: if (System.getProperty("os.name").equ
On Wed, 17 Sep 2025 07:09:22 GMT, Prasanta Sadhukhan
wrote:
> Test was deproblemlisted in https://github.com/openjdk/jdk/pull/27136 without
> any modifications as it was passing in testing.
> Since it again failed, added the execution in EDT to be more thread-safe.
>
> Fix is tested against se
On Wed, 17 Sep 2025 14:47:49 GMT, Daniel Gredler wrote:
>> src/java.desktop/share/classes/sun/print/RasterPrinterJob.java line 2479:
>>
>>> 2477: * don't have to worry about platform or font specific handling
>>> of them.
>>> 2478: */
>>> 2479: public String removeControlChars(Str
On Wed, 3 Sep 2025 20:11:24 GMT, Daniel Gredler wrote:
>> `TextLayout` should deal more gracefully with zero length strings. Currently
>> the exception listed below is the one that is thrown.
>>
>> `new TextLayout("", f, new FontRenderContext(null, false, false));`
>>
>>> Exception in thread "
On Wed, 10 Sep 2025 00:23:47 GMT, Sergey Bylokhov wrote:
> think we should recheck whether new methods like this one need to be
> synchronized. Some time ago, the synchronized keyword was removed from the
> delay method because synchronization could cause the delay to last longer
> than intend
On Mon, 8 Sep 2025 09:44:30 GMT, Srinivas Mandalika
wrote:
> Test Name: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java
> Updated the test instructions for better clarity, formatting and removed its
> entry from the ProblemList.txt.
test/jdk/java/awt/Modal/PrintDialogsTest/PrintDialogsTe
On Mon, 15 Sep 2025 11:00:56 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the insets calculation, similar calculation observed in
>> **SynthGraphicsUtils.java**. Reused the **SwingUtilities3.java** modified
>> code
>>
>> Please review and let me know your sugg
On Wed, 10 Sep 2025 03:41:23 GMT, Prasanta Sadhukhan
wrote:
> Although the test doesn't fail in recent run, test is updated to use
> CountDownLatch with proper delay and frame being made to render to screen
> centre.
> Several iterations of the test is ok, test job in JBS
Changes look reason
On Sun, 14 Sep 2025 07:05:44 GMT, Prasanta Sadhukhan
wrote:
>> Test tests navigation on virtual file created on Virtual File System which
>> is not supported in macos so restricting it for osx run.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit s
On Thu, 11 Sep 2025 07:06:20 GMT, Jeremy Wood wrote:
>> Previously:
>>
>> If DesktopProperty#updateAllUIs threw an exception, we would never reset the
>> update-pending property to false. This means any subsequent call to
>> `updateUI()` would not attempt to call `updateAllUIs()`
>>
>> With t
On Mon, 15 Sep 2025 06:24:15 GMT, Tejesh R wrote:
> Test is failing frequently on mach5 machines. I have fixed it with
> stabilizations and moved the frame to center of the screen. After the fix
> several runs were made on mach5 and no failures were seen.
Marked as reviewed by prr (Reviewer).
On Sun, 14 Sep 2025 07:02:12 GMT, Prasanta Sadhukhan
wrote:
> @prsadhuk Do we consider renaming the JBS title since this is open-sourced
> and java test now?
I think we should rename them both to "Test
java/awt/Focus/FocusActiveFocusTest.java fails"
-
PR Comment: https://git.ope
On Thu, 11 Sep 2025 10:02:59 GMT, Prasanta Sadhukhan
wrote:
> Test is made more robust by executing in EDT and cleanup done by frame
> dispose. Testing result is green.
Changes requested by prr (Reviewer).
test/jdk/java/awt/Focus/ActivateFocusTest.java line 57:
> 55: boolean test
On Fri, 12 Sep 2025 05:44:53 GMT, Prasanta Sadhukhan
wrote:
> mac printer dialog blocks underlying window even on native platform so this
> is not applicable to the test so restricting to run on osx
How does this test behave on Windows and Linux ?
I think I'd like to be sure this isn't a produ
On Mon, 15 Sep 2025 09:56:06 GMT, Alexander Zvegintsev
wrote:
> Removing 2 test from PL as they are no longer failing.
>
> Multiple CI test runs show no failures.
Do you know what fixed them ?
I wondered if for 8202004 if GDK_SCALE is now ignored but it seems to be
honoured on my Ubuntu 24.04
On Fri, 12 Sep 2025 01:37:06 GMT, Prasanta Sadhukhan
wrote:
>> Test used to fail earlier with above message.
>> Execution of the test didn't cause any failure in recent run of this test
>> for several iterations as seen in job listed in JBS so deproblemlisting
>
> Prasanta Sadhukhan has updated
On Wed, 10 Sep 2025 02:11:48 GMT, Prasanta Sadhukhan
wrote:
>> Test used to fail earlier with above message.
>> Execution of the test didn't cause any failure in recent run of this test
>> for several iterations as seen in job listed in JBS so deproblemlisting
>
> Prasanta Sadhukhan has updated
On Wed, 10 Sep 2025 18:20:13 GMT, Phil Race wrote:
> This test takes an insane amount of time on some systems. I just saw it take
> 1,042 seconds to PASS on an x64 Mac.
> It doesn't help that there are 3 @run commands.
> But also it loops over L&Fs, fonts, etc, testing man
On Thu, 11 Sep 2025 04:37:19 GMT, Prasanta Sadhukhan
wrote:
> It seems bold and italic testing is removed..
Yes. That is the idea.
-
PR Comment: https://git.openjdk.org/jdk/pull/27200#issuecomment-3277584561
This test takes an insane amount of time on some systems. I just saw it take
1,042 seconds to PASS on an x64 Mac.
It doesn't help that there are 3 @run commands.
But also it loops over L&Fs, fonts, etc, testing many component types and
created 4.600 top level frames and 2,300 popups
I don't thi
On Tue, 9 Sep 2025 18:00:50 GMT, Harshitha Onkar wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename applet test
>
> test/jdk/java/awt/Focus/FrameInitialFocusTest/FrameInitialFocusTest.java line
> 66:
>
On Fri, 5 Sep 2025 21:46:22 GMT, Damon Nguyen wrote:
>> src/java.desktop/unix/native/libawt_xawt/awt/awt_GraphicsEnv.c line 1289:
>>
>>> 1287: AWT_UNLOCK ();
>>> 1288:
>>> 1289: if ((*env)->ExceptionCheck(env)) {
>>
>> Is the problem that we are here because bounds == n
On Mon, 8 Sep 2025 17:51:45 GMT, Harshitha Onkar wrote:
> Do we consider renaming the test in this or a separate PR since Applets usage
> is removed?
>
> Actually there are 2 Applet based tests in
> java/awt/Focus/AppletInitialFocusTest folder. These tests can be deleted if
> they are decided
On Fri, 5 Sep 2025 01:43:30 GMT, Damon Nguyen wrote:
> In the scenario where AWT's UNLOCK API encounters a pendingException, the env
> pointer throws the pendingException (as seen in `awt.h`). However, in
> `Java_sun_awt_X11GraphicsDevice_pGetBounds`, after `AWT_UNLOCK`, the bounds
> var is se
On Tue, 26 Aug 2025 17:32:36 GMT, Volker Simonis wrote:
>> ### TL;DR
>>
>> This is a fix for what I think is a regression since the introduction of
>> HarfBuzz in JDK 9. The problem is that the algorithm which converts the
>> glyph vector produced by the layout engine into a corresponding char
On Thu, 4 Sep 2025 00:13:15 GMT, Chen Liang wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add finally block
>
> src/java.desktop/share/classes/java/awt/Robot.java line 977:
>
>> 975: public synchronized void
On Thu, 14 Aug 2025 17:27:09 GMT, Phil Race wrote:
> This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of
> the implementation is in a delegate
> com/sun/media/sound/JavaSoundAudioClipDelegate.java
>
> Then a disposer can be used to free the audio resour
On Wed, 3 Sep 2025 04:37:21 GMT, Tejesh R wrote:
>> No it was not an error. This is content moved from another file. Files are
>> an artificial division. It is the same content.
>
> Ok, so when we create a new file and move the contents from old file as part
> of refactoring we retain the copyr
On Thu, 4 Sep 2025 17:42:20 GMT, GennadiyKrivoshein wrote:
>> The fix for the https://bugs.openjdk.org/browse/JDK-8251928.
>>
>> **Description**.
>> This PR contains changes to be able to print with DPI higher than 72 on
>> macOS, set default CPrinterJob DPI is 300 like in the PSPrinterJob.
>>
On Thu, 4 Sep 2025 17:39:19 GMT, GennadiyKrivoshein wrote:
> This is the expected behavior, the same as on other OS. I checked the
> GraphicsConfiguration on Windows 11, Ubuntu 22.04 and macOS 10.15 with DPI
> 300 and A4 format. The device boundaries on macOS are 1 pixel different. The
> conso
On Tue, 2 Sep 2025 11:26:30 GMT, GennadiyKrivoshein wrote:
>> The fix for the https://bugs.openjdk.org/browse/JDK-8251928.
>>
>> **Description**.
>> This PR contains changes to be able to print with DPI higher than 72 on
>> macOS, set default CPrinterJob DPI is 300 like in the PSPrinterJob.
>>
On Tue, 26 Aug 2025 17:40:12 GMT, Daniel Gredler wrote:
> `TextLayout` should deal more gracefully with zero length strings. Currently
> the exception listed below is the one that is thrown.
>
> `new TextLayout("", f, new FontRenderContext(null, false, false));`
>
>> Exception in thread "main"
On Wed, 3 Sep 2025 13:57:41 GMT, Daniel Gredler wrote:
>> src/java.desktop/share/classes/java/awt/font/TextLayout.java line 516:
>>
>>> 514:
>>> 515: int start = text.getBeginIndex();
>>> 516: int limit = text.getEndIndex();
>>
>> Why do we call text.first() twice, on line 516
On Tue, 2 Sep 2025 08:35:37 GMT, Tejesh R wrote:
>> This refactors com/sun/media/sound/JavaSoundAudioClip.java so that most of
>> the implementation is in a delegate
>> com/sun/media/sound/JavaSoundAudioClipDelegate.java
>>
>> Then a disposer can be used to free the audio resources held by the
On Fri, 18 Jul 2025 13:19:10 GMT, Christian Heilmann wrote:
>> This PR fixes a bug that caused no or the wrong set of pages to be printed
>> when using page ranges on macOS.
>>
>> The main fix is to change the 'location' value of the returned NSRange from
>> the knowsPageRange method to 1 in t
On Fri, 29 Aug 2025 19:21:21 GMT, Alexey Ivanov wrote:
>> the java2d code uses the style that the "{" is on new line if the line was
>> wrapped. That was forced by Jim, and I still follow that.
>
> Okay. How much common is it for the newly added code? I haven't come across
> it frequently recen
On Fri, 29 Aug 2025 19:19:22 GMT, Sergey Bylokhov wrote:
>> We have a few places in the cmm code where the fast-code-path assumes that
>> standard buffered images with type such as TYPE_INT_ARGB_PRE use our private
>> raster implementation such as IntegerComponentRaster, which is not
>> necess
On Fri, 29 Aug 2025 08:11:19 GMT, Prasanta Sadhukhan
wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed indentation
>
> src/java.desktop/share/native/libsplashscreen/splashscreen_gif.c line 286:
>
>> 284:
On Fri, 29 Aug 2025 13:06:45 GMT, SendaoYan wrote:
>> Hi all,
>>
>> I think test javax/print/PrintServiceLookup/CountPrintServices.java should
>> throw jtreg.SkippedException when there is no lpstat, rather that report
>> test failure.
>>
>> Only javax/print/PrintServiceLookup/CountPrintServi
On Thu, 28 Aug 2025 13:19:02 GMT, Artem Semenov wrote:
>> The defect has been detected and confirmed in the function
>> OGLBlitToSurfaceViaTexture() located in the file
>> src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c with
>> static code analysis. This defect can potentiall
On Fri, 29 Aug 2025 16:15:43 GMT, Phil Race wrote:
>> src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c line 412:
>>
>>> 410: // in case pixel stride is not a multiple of scanline stride the
>>> copy
>>> 411: // has to be done lin
On Fri, 29 Aug 2025 08:02:30 GMT, Prasanta Sadhukhan
wrote:
>> Artem Semenov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixed indentation
>
> src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c line 412:
>
>> 410:
On Tue, 15 Jul 2025 08:27:07 GMT, Dmitry Kulikov wrote:
>> Dmitry Kulikov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update copyright years
>
> Yes, all 3 points are correct. Probably the native URL handler is installed
> during th
On Tue, 26 Aug 2025 17:40:12 GMT, Daniel Gredler wrote:
> REVIEWER NOTE: Please check the empty-string TextLayout behavior documented
> in TextLayoutConstructorTest carefully; a badly-behaving empty TextLayout is
> probably worse than a TextLayout which doesn't allow empty strings...
I assume
On Tue, 26 Aug 2025 17:40:12 GMT, Daniel Gredler wrote:
> `TextLayout` should deal more gracefully with zero length strings. Currently
> the exception listed below is the one that is thrown.
>
> `new TextLayout("", f, new FontRenderContext(null, false, false));`
>
>> Exception in thread "main"
On Thu, 28 Aug 2025 14:24:19 GMT, SendaoYan wrote:
> Hi all,
>
> I think test javax/print/PrintServiceLookup/CountPrintServices.java should
> throw jtreg.SkippedException when there is no lpstat, rather that report test
> failure.
>
> Only javax/print/PrintServiceLookup/CountPrintServices.jav
On Thu, 28 Aug 2025 18:34:00 GMT, Alexey Ivanov wrote:
> * Add `@requires os.family == "linux"` to prevent GTK L&F tests from running
> on other OS but Linux.
> * Let any exceptions from `UIManager.setLookAndFeel` propagate.
> * Remove `@author` tag.
> * Expand imports in `test/jdk/com/sun/java/
On Thu, 28 Aug 2025 16:43:18 GMT, Rui Li wrote:
> Yeah sorry. Closing this one and moving it to 25u.
This is an internal clean up bug. I don't see how it helps apps so I don't see
why it would be a back port candidate to any release.
-
PR Comment: https://git.openjdk.org/jdk/pull/
On Wed, 27 Aug 2025 18:40:07 GMT, Chen Liang wrote:
> Is there a reason these fields are not static? Non-static final fields like
> these are constant only in the class and not constant when used by other
> classes, and require an instance to access, but I don't find these
> differences convin
On Mon, 25 Aug 2025 20:18:49 GMT, Phil Race wrote:
> The disposer for MemoryCacheImageInputStream isn't needed. All it does is
> clear an ArrayList of byte[]
> GC can take care of that.
This pull request has now been integrated.
Changeset: c7553451
Author:Phil Race
URL
On Mon, 25 Aug 2025 20:41:25 GMT, Sergey Bylokhov wrote:
> may be there are some hints in the history that suggest why it was initially
> added? or it might simply have been an overlooked misuse of the disposer?
I think it was mostly a mis-use - partly because it could also flush() the
stream
1 - 100 of 2221 matches
Mail list logo
