On Wed, 11 Dec 2024 20:55:41 GMT, Magnus Ihse Bursie wrote:
>> @magicus Sorry for the ping, but I'm a bit confused. Do you know what bug
>> report site Phil is referring to when he says to submit a bug to AWT
>> instead? Is it just the JBS? (There's a little bit of a problem if it is, it
>> is
Hi all,
This PR fix file src/java.desktop/unix/native/libawt/awt/awt_LoadLibrary.c
reported compile warning "ignoring return value of function" by clang17, which
add check the return value of `realpath` function. Risk is low.
Additional testing:
- [ ] jtreg tests(include tier1/2/3) on linux-x6
On Tue, 10 Dec 2024 18:31:18 GMT, Nizar Benalla wrote:
> Hi all,
>
> This pull request contains a backport of commit
> 9bd70ec806ac0134926f32e222f4075e3d407422 from the
> [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit being backported was authored by Nizar Benalla on 10
On Sat, 7 Dec 2024 04:41:01 GMT, Saagar Jha wrote:
> 8345876: Update nativeAddAtIndex comment to match the code
This pull request has now been integrated.
Changeset: 72c59de6
Author:Saagar Jha
URL:
https://git.openjdk.org/jdk/commit/72c59de615b216c1729de4f4251652488f6f74ef
Stats:
javax/swing/text/StyledEditorKit/4506788/bug4506788.java fails in ubuntu22.04
seems to fail in OCI system citing "Test failed"
suggesting caret is not at expected place after text is typed, but I could not
find any CI jobs having it failed.
Anyway simplified the test and added stability fixes whi
> Candidat box can moving with caret on windows version. Someone must wrote
> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes.
> Why it doesn't work, is the key problem.
>
> 1, I wrote a example for linux:
> https://github.com/quantum6/X11InputMethod
>
> I tried all
On Wed, 11 Dec 2024 09:13:06 GMT, Saagar Jha wrote:
>> 8345876: Update nativeAddAtIndex comment to match the code
>
> Saagar Jha has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains one commit:
>
> Update nativeAddAtIndex comment to m
On Mon, 9 Dec 2024 12:16:26 GMT, Magnus Ihse Bursie wrote:
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u >
On Tue, 10 Dec 2024 09:31:21 GMT, Prasanta Sadhukhan
wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Revert changes to binary files
>
> not sure why client label is added, no java.desktop/accessibility files
On Mon, 9 Dec 2024 12:30:19 GMT, Magnus Ihse Bursie wrote:
> Some files have been modified in 2024, but the copyright year has not been
> properly updated. This should be fixed.
>
> I have located these modified files using:
>
> git log --since="Jan 1" --name-only --pretty=format: | sort -u >
On Wed, 11 Dec 2024 20:48:51 GMT, Alisen Chung wrote:
>> Soft hyphens should never render, regardless of the rendering path used
>> internally.
>>
>> This PR does not expand the categorization of "complex" characters in
>> `FontUtilities` in order to force the use of `TextLayout` rendering cod
On Wed, 11 Dec 2024 06:20:07 GMT, Julian Waters wrote:
>> Then you'll have to create a macro for disabling the unused warnings
>> (however, I'm not sure how well that would be received). Or fix the bug if
>> it is actually unused. Or wait until we go to 17.
>
> @magicus Sorry for the ping, but
On Tue, 10 Dec 2024 20:09:09 GMT, Daniel Gredler wrote:
> Soft hyphens should never render, regardless of the rendering path used
> internally.
>
> This PR does not expand the categorization of "complex" characters in
> `FontUtilities` in order to force the use of `TextLayout` rendering code
The Hashtable `javax.swing.text.html.parser.Entity#entityTypes` is modified
only within `` block.
We can replace it with immutable map to avoid Hashtable synchronization
overhead.
-
Commit messages:
- [PATCH] Unnecessary Hashtable usage in javax.swing.text.html.parser.Entity
Chang
> When robot.autoWaitForIdle is set to true, all mouse and key-related methods
> when invoked on the EDT will throw java.lang.IllegalThreadStateException
> which is not in the Robot specification.
>
> This PR updates the specification by adding warnings to avoid calling lengthy
> and delay-type
> When robot.autoWaitForIdle is set to true, all mouse and key-related methods
> when invoked on the EDT will throw java.lang.IllegalThreadStateException
> which is not in the Robot specification.
>
> This PR updates the specification by adding warnings to avoid calling lengthy
> and delay-type
On Fri, 1 Nov 2024 13:32:07 GMT, Andrey Turbanov wrote:
> The Hashtable `javax.swing.text.html.parser.Element#contentTypes` is
> initialized only within `` block.
> We can replace it with immutable map to avoid Hashtable `synchronized`
> overhead.
This pull request has now been integrated.
Ch
On Fri, 1 Nov 2024 13:32:07 GMT, Andrey Turbanov wrote:
> The Hashtable `javax.swing.text.html.parser.Element#contentTypes` is
> initialized only within `` block.
> We can replace it with immutable map to avoid Hashtable `synchronized`
> overhead.
Marked as reviewed by azvegint (Reviewer).
--
Hi Phil,
Both JDK-8342869 and JDK-8342870 [1][2] which correspond to the PRs have
subcomponent set to javax.accessibility, which is correct.
Do you mean that these bugs need to be assigned to someone from
clientlibs? In Oracle?
Do you mean Julian needs to submit new bugs and leave them unas
On Wed, 11 Dec 2024 09:13:06 GMT, Saagar Jha wrote:
>> 8345876: Update nativeAddAtIndex comment to match the code
>
> Saagar Jha has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelated changes brought in
> by the merge/reba
On Wed, 11 Dec 2024 09:13:48 GMT, Saagar Jha wrote:
> Oops I guess I wasn't supposed to rebase on top of master. Sorry :(
You must never use `git rebase` for a branch being reviewed. All your commits
get new hashes as the result of the rebase operation, therefore all the
comments become orphan
On Wed, 11 Dec 2024 09:13:06 GMT, Saagar Jha wrote:
>> 8345876: Update nativeAddAtIndex comment to match the code
>
> Saagar Jha has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains one commit:
>
> Update nativeAddAtIndex comment to m
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
On Mon, 9 Dec 2024 15:42:57 GMT, Magnus Ihse Bursie wrote:
>> Some files have been modified in 2024, but the copyright year has not been
>> properly updated. This should be fixed.
>>
>> I have located these modified files using:
>>
>> git log --since="Jan 1" --name-only --pretty=format: | sor
> 8345876: Update nativeAddAtIndex comment to match the code
Saagar Jha has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains one additional commit since the
On Wed, 11 Dec 2024 09:13:06 GMT, Saagar Jha wrote:
>> 8345876: Update nativeAddAtIndex comment to match the code
>
> Saagar Jha has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains one commit:
>
> Update nativeAddAtIndex comment to m
On Fri, 1 Nov 2024 13:32:07 GMT, Andrey Turbanov wrote:
> The Hashtable `javax.swing.text.html.parser.Element#contentTypes` is
> initialized only within `` block.
> We can replace it with immutable map to avoid Hashtable `synchronized`
> overhead.
Can I get a second review, please?
--
27 matches
Mail list logo
