On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote:
> `CTFontCopyAvailableTables` can return null, which causes subsequent call to
> `CFArrayGetCount` to crash with SEGFAULT, just added a null-check.
I didn't find anything in documentation too, but it does return null, I checked
with a de
On Wed, 18 May 2022 08:20:47 GMT, Srinivas Mandalika
wrote:
>> Create an automated test for
>> [JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286)
>>
>> AccessibleJTable.setAccessibleSelction should select rows/cols when cell
>> selection.
>> When cell selection is not enabled, th
On Wed, 18 May 2022 08:38:49 GMT, Srinivas Mandalika
wrote:
>> Create an automated test for
>> [JDK-4422362](https://bugs.openjdk.java.net/browse/JDK-4422362)
>>
>> The BoundedRangeModel components (JScrollBar, JSlider, JProgressBar) return
>> BoundedRangeModel.getMaximum() from getMaximumAcce
On Wed, 18 May 2022 08:37:03 GMT, Srinivas Mandalika
wrote:
>> Create an automated test for
>> [JDK-4422535](https://bugs.openjdk.java.net/browse/JDK-4422535)
>> AccessibleValue implementation only accept Integers
>> The AccessibleValue implementations of the following components:
>>
>> java.a
On Fri, 29 Apr 2022 14:11:41 GMT, Srinivas Mandalika
wrote:
>> Create an automated test for
>> [JDK-4702233](https://bugs.openjdk.java.net/browse/JDK-4702233)
>>
>> Several new AccessibleRole and AccessibleRelation constants are needed in
>> those classes in the java.accessibility package. Th
On Wed, 1 Jun 2022 06:46:40 GMT, Ajit Ghaisas wrote:
> > > Is it only a test stabilization fix? or were you able to uncover any
> > > performance issue (either with OpenGL or with Metal pipeline) with this
> > > change? Can you please provide before/after numbers?
> >
> >
> > Initially it was
On Fri, 27 May 2022 18:58:12 GMT, Alexey Ushakov wrote:
> Improved RenderPerfTest:
> - removed RenderPerfLCD.java (we have LCD tests in RenderPerfTest.java)
> - corrected and simplified test logic
> - added timeout on low performant rendering
> - used several markers to recover from missi
On Wed, 25 May 2022 23:40:59 GMT, Harshitha Onkar wrote:
> With the proposed fix, JList's focus ring color follows accent color changes.
> Previously the focus ring for JList was not prominently visible and did not
> follow accent color changes.
>
> While investing a similar issue related to J
On Wed, 25 May 2022 23:40:59 GMT, Harshitha Onkar wrote:
> With the proposed fix, JList's focus ring color follows accent color changes.
> Previously the focus ring for JList was not prominently visible and did not
> follow accent color changes.
>
> While investing a similar issue related to J
On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote:
> `CTFontCopyAvailableTables` can return null, which causes subsequent call to
> `CFArrayGetCount` to crash with SEGFAULT, just added a null-check.
All supported font formats on macOS have such tables, so it must be something
else.
I don
On Wed, 1 Jun 2022 06:00:34 GMT, Tejesh R wrote:
>> Added test for checking setMargin() of JRadioButton.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Updated based on review comments
Changes requested by aivanov (Reviewer).
On Wed, 1 Jun 2022 16:29:49 GMT, Alexey Ivanov wrote:
> Shall the test be located in
> `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
> `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
>
> Usually, there's been a folder with bugid (`/4380543/`) for each test. Do we
On Wed, 1 Jun 2022 10:08:37 GMT, Tejesh R wrote:
>> With the proposed fix, JList's focus ring color follows accent color
>> changes. Previously the focus ring for JList was not prominently visible and
>> did not follow accent color changes.
>>
>> While investing a similar issue related to JTab
On Wed, 1 Jun 2022 05:32:27 GMT, Tejesh R wrote:
> > > I wonder why the test is Windows-specific if it allows changing Look and
> > > Feels.
> > > The only Look and Feel which ignores the background is Nimbus, other L&Fs
> > > on Windows at least paint the yellow and green background. As such,
On Wed, 1 Jun 2022 05:30:23 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Wed, 1 Jun 2022 16:35:01 GMT, Harshitha Onkar wrote:
> > Shall the test be located in
> > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
> > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > Usually, there's been a folder with bugid (`/4380543/`) for each test
On Tue, 24 May 2022 16:54:55 GMT, Alisen Chung wrote:
> Removed stacktrace from WClipboard
Marked as reviewed by prr (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8871
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan
wrote:
> Test was failing intermiitently in iMac M1 system owing to minimalistic color
> difference of 1
>
> x 13 y 0 refRGB ffee customRGB ffef
> x 0 y 0 refRGB ffefefef customRGB ffefeeef
>
>
> so added color tolerance check.
>
On Mon, 30 May 2022 07:15:15 GMT, Prasanta Sadhukhan
wrote:
>> Yes for standalone testing for which I also removed dependancy on jtreg
>> Platform class
>
> Any reviewers please?
I prefer .toLoweCase().startsWith("mac") since the OS is called "macOS" not
"macOS X" but that's just me ..
-
On Fri, 27 May 2022 20:48:30 GMT, Alexey Ivanov wrote:
>> **WTrayIconPeer**: removed duplicate call to `popupParent.dispose()` that
>> might cause NPE (it looks `popupParent` cannot be `null`); organised imports.
>>
>> **SystemTray**: removed redundant initialisers; replaced sized array with
>
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan
wrote:
> Test was failing intermiitently in iMac M1 system owing to minimalistic color
> difference of 1
>
> x 13 y 0 refRGB ffee customRGB ffef
> x 0 y 0 refRGB ffefefef customRGB ffefeeef
>
>
> so added color tolerance check.
>
On Sat, 28 May 2022 08:41:35 GMT, Prasanta Sadhukhan
wrote:
>> Test was failing in linux citing `java.lang.RuntimeException: Expected Total
>> TitledBorder to be freed : 10 Freed 9 `
>> As per the fix done in JDK-8204963
>> http://hg.openjdk.java.net/jdk/jdk/rev/cd7d2f9154fd
>> there was no pl
On Wed, 1 Jun 2022 17:37:42 GMT, Alexey Ivanov wrote:
> > > Shall the test be located in
> > > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
> > > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > > Usually, there's been a folder with bugid (`/4380543/`) for eac
On Tue, 31 May 2022 23:39:09 GMT, Nikita Gubarkov wrote:
> `CTFontCopyAvailableTables` can return null, which causes subsequent call to
> `CFArrayGetCount` to crash with SEGFAULT, just added a null-check.
https://user-images.githubusercontent.com/9004656/171468848-58612bb1-6432-4c76-a13c-054e7f
On Wed, 1 Jun 2022 18:33:06 GMT, Phil Race wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed print statements.
>
> src/java.desktop/share/classes/javax/swing/text/html/HTMLDocument.java line
> 27:
>
>> 25:
On Tue, 31 May 2022 22:08:23 GMT, Damon Nguyen wrote:
>> Updated Parser class doc by appending to the doc regarding lack of support
>> for HTML script tags. Adding this information to the "parse" function did
>> not seem as consistent for formatting as adding it to the Parser class doc.
>
> Dam
> With the proposed fix, JList's focus ring color follows accent color changes.
> Previously the focus ring for JList was not prominently visible and did not
> follow accent color changes.
>
> While investing a similar issue related to JTable
> (https://github.com/openjdk/jdk/pull/7768#discussi
On Wed, 1 Jun 2022 16:54:43 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/JTable/CellFocusRingTest.java line 85:
>>
>>> 83: }
>>> 84:
>>> 85: if (UIManager.getDefaults().get("CellFocus.color") != null
>>
>> if (UIManager.getDefaults().get("CellFocus.color") != null
>>
Commit command buffer after MTL_OP_MASK_OP operation
-
Commit messages:
- 8287600: AA Ovals not rendered under metal
Changes: https://git.openjdk.java.net/jdk/pull/8981/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=8981&range=00
Issue: https://bugs.openjdk.java.net/
On Sat, 28 May 2022 03:41:29 GMT, Prasanta Sadhukhan
wrote:
>> Malgun_Gothic(https://en.wikipedia.org/wiki/Malgun_Gothic) had replaced
>> Gulim korean font so it needs to be updated to show korean fonts
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional com
On Wed, 27 Apr 2022 04:40:29 GMT, Phil Race wrote:
>> Andrey Turbanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8284672: Collapse identical catch branches in java.desktop
>> fix formatting
>
> src/java.desktop/share/classes/com/s
> Let's take advantage of Java 7 language feature - "Catching Multiple
> Exception Types".
> It simplifies code. Reduces duplication.
> Found by IntelliJ IDEA inspection Identical 'catch' branches in 'try'
> statement
Andrey Turbanov has updated the pull request incrementally with one additional
On Tue, 24 May 2022 11:16:16 GMT, Alexey Ivanov wrote:
>> It also has a functional implication, in the old code the "size" on a
>> Vector is called outside of the lock. So the resulted array after
>> "icons.toArray" can be bigger than the number of icons. This is similar to
>> this:
>> https:
On Fri, 27 May 2022 18:02:51 GMT, Alexander Zuev wrote:
>> Detect the situation where we do need to perform interpolation during
>> ImageIcon
>> painting and set a hint to the rendering to perform bicubic approximation so
>> image details are preserved during transition.
>
> Alexander Zuev has u
On Fri, 27 May 2022 18:12:59 GMT, Alexander Zuev wrote:
> On 1 iterations the difference is measurable in tens of milliseconds
> between test runs. On 10 iterations test execution with BICUBIC
> approximation is noticeable (like test run takes more than a second longer).
Not an ideal b
On Wed, 1 Jun 2022 23:13:57 GMT, Sergey Bylokhov wrote:
>> I remember IDEs used to suggest using correctly sized arrays in the calls to
>> `toArray`. Now they suggest using zero-sized array.
>>
>> My idea was to resolve the warning raised by the IDE to reduce the number of
>> yellow highlights
On Thu, 2 Jun 2022 00:32:29 GMT, Sergey Bylokhov wrote:
>> The IDE warning was changed based on the article above. Did you have a
>> chance to reproduce a possible race caused by data change after the size()
>> was called?
>
> I can reproduce it by this code example:
>
> class Scratch {
>
>
On Wed, 18 May 2022 08:20:47 GMT, Srinivas Mandalika
wrote:
>> Create an automated test for
>> [JDK-4495286](https://bugs.openjdk.java.net/browse/JDK-4495286)
>>
>> AccessibleJTable.setAccessibleSelction should select rows/cols when cell
>> selection.
>> When cell selection is not enabled, th
On Wed, 1 Jun 2022 05:30:23 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Thu, 2 Jun 2022 00:48:33 GMT, Sergey Bylokhov wrote:
> I think this feature was implemented someday for some L&Fs and then deleted.
> please double-check the history of releated bugs/files.
Hmm, I thought this is a produce fix since it has a CSR in the description. The
test for metal is fin
On Wed, 1 Jun 2022 05:30:23 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Wed, 1 Jun 2022 19:40:34 GMT, Harshitha Onkar wrote:
>> With the proposed fix, JList's focus ring color follows accent color
>> changes. Previously the focus ring for JList was not prominently visible and
>> did not follow accent color changes.
>>
>> While investing a similar issue related
On Wed, 1 Jun 2022 05:30:23 GMT, Tejesh R wrote:
>> The tooltip displays accelerated string along with the toooltip string. The
>> feature is implemented and applicable for Metal Look and Feel only. Hence
>> the test is updated for Metal Look and Feel by hard wiring it in the code.
>> Updated
On Thu, 26 May 2022 07:49:30 GMT, Prasanta Sadhukhan
wrote:
> Even if we remove TitledBorder code from the test and only keep JFrame, then
> also I see
So it means that the last visible but already disposed frame is sitting in the
memory/leaked and this test catch that, isn't it?
---
On Fri, 29 Apr 2022 14:11:41 GMT, Srinivas Mandalika
wrote:
>> Create an automated test for
>> [JDK-4702233](https://bugs.openjdk.java.net/browse/JDK-4702233)
>>
>> Several new AccessibleRole and AccessibleRelation constants are needed in
>> those classes in the java.accessibility package. Th
On Thu, 2 Jun 2022 00:51:22 GMT, Sergey Bylokhov wrote:
> > I think this feature was implemented someday for some L&Fs and then
> > deleted. please double-check the history of releated bugs/files.
>
> Hmm, I thought this is a produce fix since it has a CSR in the description.
> The test for me
On Thu, 28 Apr 2022 11:59:45 GMT, Prasanta Sadhukhan
wrote:
> Test was failing in linux citing `java.lang.RuntimeException: Expected Total
> TitledBorder to be freed : 10 Freed 9 `
> As per the fix done in JDK-8204963
> http://hg.openjdk.java.net/jdk/jdk/rev/cd7d2f9154fd
> there was no platfor
On Tue, 24 May 2022 08:28:57 GMT, Prasanta Sadhukhan
wrote:
> Test was failing intermiitently in iMac M1 system owing to minimalistic color
> difference of 1
>
> x 13 y 0 refRGB ffee customRGB ffef
> x 0 y 0 refRGB ffefefef customRGB ffefeeef
>
>
> so added color tolerance check.
>
On Wed, 1 Jun 2022 20:50:47 GMT, Phil Race wrote:
> Also can you attach the source of your test to JBS !
I have attached.
-
PR: https://git.openjdk.java.net/jdk/pull/7643
On Sat, 28 May 2022 08:41:35 GMT, Prasanta Sadhukhan
wrote:
>> Test was failing in linux citing `java.lang.RuntimeException: Expected Total
>> TitledBorder to be freed : 10 Freed 9 `
>> As per the fix done in JDK-8204963
>> http://hg.openjdk.java.net/jdk/jdk/rev/cd7d2f9154fd
>> there was no pl
On Thu, 2 Jun 2022 01:02:43 GMT, Harshitha Onkar wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unused parameter isTooltipAdded
>
> test/jdk/javax/swing/JToolTip/bug5047379.java line 28:
>
>> 26:@summary
On Wed, 1 Jun 2022 17:17:34 GMT, Phil Race wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unused parameter isTooltipAdded
>
> test/jdk/javax/swing/JToolTip/bug5047379.java line 137:
>
>> 135: text +=
> The tooltip displays accelerated string along with the toooltip string. The
> feature is implemented and applicable for Metal Look and Feel only. Hence the
> test is updated for Metal Look and Feel by hard wiring it in the code.
> Updated the test from manual to automatic.
Tejesh R has update
On Wed, 1 Jun 2022 18:00:44 GMT, Phil Race wrote:
> > > > Shall the test be located in
> > > > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead of
> > > > `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > > > Usually, there's been a folder with bugid (`/4380543/`) for
> The tooltip displays accelerated string along with the toooltip string. The
> feature is implemented and applicable for Metal Look and Feel only. Hence the
> test is updated for Metal Look and Feel by hard wiring it in the code.
> Updated the test from manual to automatic.
Tejesh R has update
On Thu, 2 Jun 2022 04:48:09 GMT, Tejesh R wrote:
> > > > > Shall the test be located in
> > > > > `test/jdk/javax/swing/JRadioButton/4380543/bug4380543.java` instead
> > > > > of `test/jdk/javax/swing/JRadioButton/bug4380543.java` ?
> > > > > Usually, there's been a folder with bugid (`/4380543
On Wed, 1 Jun 2022 17:09:37 GMT, Alexey Ivanov wrote:
> > > > I wonder why the test is Windows-specific if it allows changing Look
> > > > and Feels.
> > > > The only Look and Feel which ignores the background is Nimbus, other
> > > > L&Fs on Windows at least paint the yellow and green backgrou
> The tooltip displays accelerated string along with the toooltip string. The
> feature is implemented and applicable for Metal Look and Feel only. Hence the
> test is updated for Metal Look and Feel by hard wiring it in the code.
> Updated the test from manual to automatic.
Tejesh R has refres
58 matches
Mail list logo
